Skip to contentSkip to conversation

Fix multiple checkpatch issues

PATCH New Amitoj Kaur Chawla 1 participant 4 messages Oct 8, 2015

Subsystems (2)
Staging Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Amitoj Kaur Chawla

author
#0 lore raw

v2 cover Fix multiple checkpatch issues

This patchset fixes multiple issues found using checkpatch.pl

Amitoj Kaur Chawla (3):
staging: sm750fb: Remove space after cast
staging: sm750fb: Remove space before closing brace
staging: sm750fb: Remove space after opening brace

 drivers/staging/sm750fb/ddk750_chip.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH v2 1/3 staging: sm750fb: Remove space after cast

Remove unnecessary space after cast. Problem found using checkpatch.pl
CHECK: No space is necessary after a cast

Signed-off-by Amitoj Kaur Chawla <[email protected]>

---
Changes in v2
-None

 drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +2 -2
index 0734044..fe0e25a 100644
@@ -133,7 +133,7 @@ static void setMemoryClock(unsigned int frequency)
 			frequency = MHz(336);
 
 		/* Calculate the divisor */
-		divisor = (unsigned int) roundedDiv(getChipClock(), frequency);
+		divisor = (unsigned int)roundedDiv(getChipClock(), frequency);
 
 		/* Set the corresponding divisor in the register. */
 		ulReg = PEEK32(CURRENT_GATE);

@@ -180,7 +180,7 @@ static void setMasterClock(unsigned int frequency)
 			frequency = MHz(190);
 
 		/* Calculate the divisor */
-		divisor = (unsigned int) roundedDiv(getChipClock(), frequency);
+		divisor = (unsigned int)roundedDiv(getChipClock(), frequency);
 
 		/* Set the corresponding divisor in the register. */
 		ulReg = PEEK32(CURRENT_GATE);
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH v2 2/3 staging: sm750fb: Remove space before closing brace

In reply to Amitoj Kaur Chawla

Remove space before closing brace '}'. Problem found using checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'

Signed-off-by Amitoj Kaur Chawla <[email protected]>

---
Changes in v2:
-None

 drivers/staging/sm750fb/ddk750_chip.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/sm750fb/ddk750_chip.c +0 -1
index fe0e25a..deee227 100644
@@ -234,7 +234,6 @@ unsigned int ddk750_getVMSize(void)
 		break;
 	}
 	return data;
-
 }
 
 int ddk750_initHw(initchip_param_t *pInitParam)
Signature · 1 line
1.9.1
author
#3 lore raw

PATCH v2 3/3 staging: sm750fb: Remove space after opening brace

In reply to Amitoj Kaur Chawla

Remove space after opening brace '{'. Problem found using checkpatch.pl
CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by Amitoj Kaur Chawla <[email protected]>

---
Changes in v2:
-Updated kernel tree to remove error

 drivers/staging/sm750fb/ddk750_chip.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/sm750fb/ddk750_chip.c +0 -1
index deee227..a15bcd1 100644
@@ -238,7 +238,6 @@ unsigned int ddk750_getVMSize(void)
 
 int ddk750_initHw(initchip_param_t *pInitParam)
 {
-
 	unsigned int ulReg;
 
 	if (pInitParam->powerMode != 0)
Signature · 1 line
1.9.1