Skip to contentSkip to conversation

Fix host-user-contamination QA warning for webmin

PATCH New Anders Darander 1 participant 2 messages Oct 13, 2015

lore
Share & tools
lore
#0 lore raw

cover Fix host-user-contamination QA warning for webmin

Remove QA warnings for host-user-contamination for webmin.

The following changes since commit f4533380c8a5c1d229f692222ee0c2ef9d187ef8:

dracut: install modules to /usr/lib (2015-09-23 16:10:57 +0200)

are available in the git repository at:

git://github.com/darander/meta-openembedded host-user-cont
https://github.com/darander/meta-openembedded/tree/host-user-cont

Anders Darander (1):
webmin: fix QA host-user-contaminated

 meta-webserver/recipes-webadmin/webmin/webmin_1.750.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.6.1
#1 lore raw

PATCH 1/1 webmin: fix QA host-user-contaminated

Due to the way most files were installed, using cp ..., during packaging we got spammed with messages like:

WARNING: QA Issue: webmin: /webmin-module-fail2ban/usr/lib/webmin/webmin/fail2ban/lang/no is owned by gid 100, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
WARNING: QA Issue: webmin: /webmin-module-system-status/usr/lib/webmin/webmin/system-status/lang/no is owned by gid 100, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]

Do the install in a similar way as is done in bin_package.bbclass. By doing that, we're not getting any QA-errors from host-user-contaminated.

---
 meta-webserver/recipes-webadmin/webmin/webmin_1.750.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta-webserver/recipes-webadmin/webmin/webmin_1.750.bb +4 -1
index b6fbb0a..ca09ecf 100644
@@ -80,7 +80,10 @@ do_install() {
     install -d ${D}${localstatedir}/webmin
 
     install -d ${D}${libexecdir}/webmin
-    cp -pPR ${S}/* ${D}${libexecdir}/webmin
+    cd ${S} || exit 1
+    tar --no-same-owner --exclude='./patches' --exclude='./.pc' -cpf - . \
+        | tar --no-same-owner -xpf - -C ${D}${libexecdir}/webmin
+
     rm -f ${D}${libexecdir}/webmin/webmin-init
     rm -f ${D}${libexecdir}/webmin/ajaxterm/ajaxterm/configure.initd.gentoo
     rm -rf ${D}${libexecdir}/webmin/patches
Signature · 1 line
2.6.1