Skip to contentSkip to conversation

Fix multilib connectivity issues

PATCH New Jussi Kukkonen 1 participant 2 messages Oct 27, 2015

lore
Share & tools
lore

Jussi Kukkonen

author
#0 lore raw

cover Fix multilib connectivity issues

The following patch moves a connman setup script to the correct place and happens to avoid YOCTO #8550 making wired setup work in multilib qemu image again.

It does not fix the multilib bugs that were found during the investigation:
* YOCTO #8586 multilib build includes 32bit connman without reason
* YOCTO #8570 problems with gdk-pixbuf and pango loading on multilib

The following changes since commit 505a82673ac2487df5ea343a6422c2fc47018831:

build-appliance-image: Update to jethro head revision (2015-10-21 23:13:11 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib jku/connman-wired
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/connman-wired

Jussi Kukkonen (1):
connman: Move wired-setup to ${datadir}

 meta/recipes-connectivity/connman/connman-conf.bb | 6 +++---
 meta/recipes-connectivity/connman/connman.inc     | 4 ++--
 meta/recipes-connectivity/connman/connman/connman | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 1/1 connman: Move wired-setup to ${datadir}

wired-setup script should not be in ${libdir} as it's not arch dependent.

This also fixes (or works around) a practical issue where a multilib build installs the wrong version of connman-conf and then connman can't find the script.

[YOCTO #8550]

Signed-off-by Jussi Kukkonen <[email protected]>
---
 meta/recipes-connectivity/connman/connman-conf.bb | 6 +++---
 meta/recipes-connectivity/connman/connman.inc     | 4 ++--
 meta/recipes-connectivity/connman/connman/connman | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)
meta/recipes-connectivity/connman/connman-conf.bb +3 -3
index bd4c28d..9254ed7 100644
@@ -13,14 +13,14 @@ S = "${WORKDIR}"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-FILES_${PN} = "${localstatedir}/* ${libdir}/*"
+FILES_${PN} = "${localstatedir}/* ${datadir}/*"
 
 do_install() {
     #Configure Wired network interface in case of qemu* machines
     if test -e ${WORKDIR}/wired.config && test -e ${WORKDIR}/wired-setup; then
         install -d ${D}${localstatedir}/lib/connman
         install -m 0644 ${WORKDIR}/wired.config ${D}${localstatedir}/lib/connman
-        install -d ${D}${libdir}/connman
-        install -m 0755 ${WORKDIR}/wired-setup ${D}${libdir}/connman
+        install -d ${D}${datadir}/connman
+        install -m 0755 ${WORKDIR}/wired-setup ${D}${datadir}/connman
     fi
 }
meta/recipes-connectivity/connman/connman.inc +2 -2
index ab7f86d..afdb3f2 100644
@@ -68,7 +68,7 @@ python __anonymous () {
 
 SYSTEMD_SERVICE_${PN} = "connman.service"
 SYSTEMD_SERVICE_${PN}-vpn = "connman-vpn.service"
-SYSTEMD_WIRED_SETUP = "ExecStartPre=-${libdir}/connman/wired-setup"
+SYSTEMD_WIRED_SETUP = "ExecStartPre=-${datadir}/connman/wired-setup"
 
 do_compile_append() {
 	sed -i "s#ExecStart=#${SYSTEMD_WIRED_SETUP}\nExecStart=#" ${B}/src/connman.service

@@ -78,7 +78,7 @@ do_install_append() {
 	if ${@bb.utils.contains('DISTRO_FEATURES','sysvinit','true','false',d)}; then
 		install -d ${D}${sysconfdir}/init.d
 		install -m 0755 ${WORKDIR}/connman ${D}${sysconfdir}/init.d/connman
-		sed -i s%@LIBDIR@%${libdir}% ${D}${sysconfdir}/init.d/connman
+		sed -i s%@DATADIR@%${datadir}% ${D}${sysconfdir}/init.d/connman
 	fi
 
 	install -d ${D}${bindir}
meta/recipes-connectivity/connman/connman/connman +2 -2
index bf7a94a..c64fa0d 100644
@@ -49,8 +49,8 @@ do_start() {
 		fi
 	    fi
 	fi
-	if [ -f @LIBDIR@/connman/wired-setup ] ; then
-		. @LIBDIR@/connman/wired-setup
+	if [ -f @DATADIR@/connman/wired-setup ] ; then
+		. @DATADIR@/connman/wired-setup
 	fi
 	$DAEMON $EXTRA_PARAM
 }
Signature · 1 line
2.1.4