Skip to contentSkip to conversation

Fix for intermittent license collection warning

PATCH New Paul Eggleton 1 participant 2 messages Nov 10, 2015

lore
Share & tools
lore
#0 lore raw

cover Fix for intermittent license collection warning

This fix should also be backported to jethro.

The following changes since commit e44ed8c18e395b9c055aefee113b90708e8a8a2f:

build-appliance-image: Update to jethro head revision (2015-11-03 14:02:57 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib paule/licensefix
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/licensefix

Paul Eggleton (1):
classes/license: fix intermittent license collection warning

 meta/classes/license.bbclass | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 classes/license: fix intermittent license collection warning

Fixes the following warning sometimes appearing during image builds:

WARNING: The license listed ABC was not in the licenses collected for recipe xyz

The files being looked for here, which runs during do_rootfs, are written out by the do_populate_lic task for each recipe. However, there was no explicit dependency between do_rootfs and all of the do_populate_lic tasks to ensure they had run - only an implicit link via do_build, so it is possible that sometimes they had not depending on how the tasks were scheduled. Add an explicit set of dependencies to fix this.

---
 meta/classes/license.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/license.bbclass +1 -0
index c616a20..8ad4614 100644
@@ -474,6 +474,7 @@ do_populate_lic[sstate-inputdirs] = "${LICSSTATEDIR}"
 do_populate_lic[sstate-outputdirs] = "${LICENSE_DIRECTORY}/"
 
 ROOTFS_POSTPROCESS_COMMAND_prepend = "write_package_manifest; license_create_manifest; "
+do_rootfs[recrdeptask] += "do_populate_lic"
 
 do_populate_lic_setscene[dirs] = "${LICSSTATEDIR}/${PN}"
 do_populate_lic_setscene[cleandirs] = "${LICSSTATEDIR}"
Signature · 1 line
2.1.0