Skip to contentSkip to conversation

async: export current_is_async()

PATCH In review Lukas Wunner 3 participants 4 messages Nov 19, 2015

lore
Share & tools
lore

Lukas Wunner

author
#0 lore raw

cover async: export current_is_async()

Hi Tejun,

when you introduced current_is_async() with 84b233adcca3, was it a deliberate decision not to export it? All other non-static functions in async.c are exported as well.

I'm asking because I would like to use it in i915.ko.

Thanks,

Lukas

Lukas Wunner (1):
async: export current_is_async()

 kernel/async.c | 1 +
 1 file changed, 1 insertion(+)
Signature · 6 lines
2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#1 lore raw

PATCH 1/1 async: export current_is_async()

Introduced by 84b233adcca3 ("workqueue: implement current_is_async()").

Cc Tejun Heo <[email protected]>
Signed-off-by Lukas Wunner <[email protected]>
---
 kernel/async.c | 1 +
 1 file changed, 1 insertion(+)
kernel/async.c +1 -0
index 4c3773c..d2edd6e 100644
@@ -326,3 +326,4 @@ bool current_is_async(void)
 
 	return worker && worker->current_func == async_run_entry_fn;
 }
+EXPORT_SYMBOL_GPL(current_is_async);
Signature · 6 lines
2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
In reply to Lukas Wunner

Hello, Lukas.

Quoted 7 lines · Lukas Wunner

Hi Tejun,

when you introduced current_is_async() with 84b233adcca3, was it a deliberate decision not to export it? All other non-static functions in async.c are exported as well.

I'm asking because I would like to use it in i915.ko.

There just was no module user at the time. Please feel free to export it.

Thanks.

Signature · 5 lines
tejun
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 5 lines · Tejun Heo

Hello, Lukas.

Quoted 2 lines · Lukas Wunner

Hi Tejun,

Quoted 8 lines
Quoted 5 lines

when you introduced current_is_async() with 84b233adcca3, was it a deliberate decision not to export it? All other non-static functions in async.c are exported as well.

I'm asking because I would like to use it in i915.ko.

There just was no module user at the time. Please feel free to export it.

I take that as an ack to pull Lukas' export patch in through drm-intel trees.

Thanks, Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx