Staging: panel: Fix checkpatch warnings

PATCH New Ksenija Stanojevic 1 participant 3 messages Jan 3, 2016 Staging

lore

Share & tools

lore

Ksenija Stanojevic

author

2016-01-03 19:27 UTC #0 lore raw

v2 cover Staging: panel: Fix checkpatch warnings

Fix checkpatch.pl warnings in panel.c

Signed-off-by Ksenija Stanojevic <[email protected]>

Ksenija Stanojevic (2):
Staging: panel: Fix line over 80 characters
Staging: panel: Remove space

 drivers/staging/panel/panel.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Signature · 1 line

1.9.1

Ksenija Stanojevic

author

2016-01-03 19:31 UTC #1 lore raw

PATCH v2 1/2 Staging: panel: Fix line over 80 characters

Move statement into line below the comment to follow 80 characters per line rule.
Found by checkpatch.pl

Signed-off-by Ksenija Stanojevic <[email protected]>

---
Changes in v2:
- don't split comment in multiline

 drivers/staging/panel/panel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/staging/panel/panel.c +2 -1

index 79ac192..3525919 100644
@@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
 		lcd_send_serial(0x5F);	/* R/W=W, RS=1 */
 		lcd_send_serial(' ' & 0x0F);
 		lcd_send_serial((' ' >> 4) & 0x0F);
-		usleep_range(40, 100);	/* the shortest data takes at least 40 us */
+		/* the shortest data takes at least 40 us */
+		usleep_range(40, 100);
 	}
 	spin_unlock_irq(&pprt_lock);

Signature · 1 line

1.9.1

Ksenija Stanojevic

author

2016-01-03 19:32 UTC #2 lore raw

PATCH v2 2/2 Staging: panel: Remove space

In reply to Ksenija Stanojevic

No space is necessary after a cast, therefore remove it. Found by checkpatch.pl

Signed-off-by Ksenija Stanojevic <[email protected]>

---
Changes in v2:
- nothing

 drivers/staging/panel/panel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/panel/panel.c +2 -2

index 3525919..04d86f3 100644
@@ -1789,7 +1789,7 @@ static void phys_scan_contacts(void)
 	gndmask = PNL_PINPUT(r_str(pprt)) & scan_mask_i;
 
 	/* grounded inputs are signals 40-44 */
-	phys_read |= (pmask_t) gndmask << 40;
+	phys_read |= (pmask_t)gndmask << 40;
 
 	if (bitmask != gndmask) {
 		/*

@@ -1805,7 +1805,7 @@ static void phys_scan_contacts(void)
 
 			w_dtr(pprt, oldval & ~bitval);	/* enable this output */
 			bitmask = PNL_PINPUT(r_str(pprt)) & ~gndmask;
-			phys_read |= (pmask_t) bitmask << (5 * bit);
+			phys_read |= (pmask_t)bitmask << (5 * bit);
 		}
 		w_dtr(pprt, oldval);	/* disable all outputs */
 	}

Signature · 1 line

1.9.1