meta: cleanup PACKAGECONFIG ??= ""
cover meta: cleanup PACKAGECONFIG ??= ""
The following changes since commit 8084c185c43cb7e7f5e29d31939dfd308f8a0f93:
udev: Add 2 patches to support 4.4 kernel (2016-01-20 09:20:06 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/clean
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/clean
Robert Yang (1):
meta: cleanup PACKAGECONFIG ??= ""
meta/recipes-bsp/grub/grub2.inc | 1 - meta/recipes-core/dbus/dbus-glib.inc | 1 - meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb | 1 - meta/recipes-devtools/gdb/gdb_7.10.1.bb | 1 - meta/recipes-devtools/mtools/mtools_3.9.9.bb | 1 - meta/recipes-devtools/mtools/mtools_4.0.18.bb | 1 - meta/recipes-devtools/opkg/opkg_0.3.1.bb | 2 -- .../python/python-imaging_1.1.7.bb | 1 - meta/recipes-devtools/ruby/ruby_2.2.2.bb | 1 - meta/recipes-extended/mc/mc_4.8.15.bb | 1 - meta/recipes-extended/minicom/minicom_2.7.bb | 1 - meta/recipes-extended/screen/screen_4.3.1.bb | 1 - meta/recipes-extended/sudo/sudo.inc | 1 - meta/recipes-extended/tar/tar_1.28.bb | 1 - meta/recipes-extended/wget/wget.inc | 1 - meta/recipes-gnome/gnome/gconf_3.2.6.bb | 1 - meta/recipes-graphics/directfb/directfb.inc | 1 - meta/recipes-graphics/piglit/piglit_git.bb | 1 - meta/recipes-graphics/wayland/libinput_1.1.4.bb | 1 - meta/recipes-graphics/xorg-lib/libice_1.0.9.bb | 1 - .../recipes-graphics/xorg-lib/libx11-diet_1.6.3.bb | 1 - meta/recipes-graphics/xorg-lib/libxdmcp_1.1.2.bb | 1 - meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 1 - .../xorg-proto/xorg-proto-common.inc | 1 - meta/recipes-kernel/systemtap/systemtap_git.bb | 1 - meta/recipes-multimedia/webp/libwebp_0.5.0.bb | 1 - meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc | 1 - meta/recipes-support/aspell/aspell_0.60.6.1.bb | 1 - meta/recipes-support/beecrypt/beecrypt_4.2.1.bb | 1 - meta/recipes-support/boost/boost.inc | 1 - meta/recipes-support/gmp/gmp.inc | 1 - .../gnome-desktop-testing_2014.1.bb | 1 - meta/recipes-support/gnupg/gnupg_1.4.7.bb | 1 - meta/recipes-support/gnupg/gnupg_2.1.10.bb | 1 - meta/recipes-support/libevent/libevent_2.0.22.bb | 1 - meta/recipes-support/libunwind/libunwind.inc | 1 - 36 files changed, 37 deletions(-)
Signature · 1 line
1.7.9.5
PATCH 1/1 meta: cleanup PACKAGECONFIG ??= ""
The base.bbclass can handle PACKAGECONFIG well when it is not set, so PACKAGECONFIG ??= "" isn't useful here, but there are a lot of them, which may mislead the newbie that it is a must.
--- meta/recipes-bsp/grub/grub2.inc | 1 - meta/recipes-core/dbus/dbus-glib.inc | 1 - meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb | 1 - meta/recipes-devtools/gdb/gdb_7.10.1.bb | 1 - meta/recipes-devtools/mtools/mtools_3.9.9.bb | 1 - meta/recipes-devtools/mtools/mtools_4.0.18.bb | 1 - meta/recipes-devtools/opkg/opkg_0.3.1.bb | 2 -- .../python/python-imaging_1.1.7.bb | 1 - meta/recipes-devtools/ruby/ruby_2.2.2.bb | 1 - meta/recipes-extended/mc/mc_4.8.15.bb | 1 - meta/recipes-extended/minicom/minicom_2.7.bb | 1 - meta/recipes-extended/screen/screen_4.3.1.bb | 1 - meta/recipes-extended/sudo/sudo.inc | 1 - meta/recipes-extended/tar/tar_1.28.bb | 1 - meta/recipes-extended/wget/wget.inc | 1 - meta/recipes-gnome/gnome/gconf_3.2.6.bb | 1 - meta/recipes-graphics/directfb/directfb.inc | 1 - meta/recipes-graphics/piglit/piglit_git.bb | 1 - meta/recipes-graphics/wayland/libinput_1.1.4.bb | 1 - meta/recipes-graphics/xorg-lib/libice_1.0.9.bb | 1 - .../recipes-graphics/xorg-lib/libx11-diet_1.6.3.bb | 1 - meta/recipes-graphics/xorg-lib/libxdmcp_1.1.2.bb | 1 - meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 1 - .../xorg-proto/xorg-proto-common.inc | 1 - meta/recipes-kernel/systemtap/systemtap_git.bb | 1 - meta/recipes-multimedia/webp/libwebp_0.5.0.bb | 1 - meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc | 1 - meta/recipes-support/aspell/aspell_0.60.6.1.bb | 1 - meta/recipes-support/beecrypt/beecrypt_4.2.1.bb | 1 - meta/recipes-support/boost/boost.inc | 1 - meta/recipes-support/gmp/gmp.inc | 1 - .../gnome-desktop-testing_2014.1.bb | 1 - meta/recipes-support/gnupg/gnupg_1.4.7.bb | 1 - meta/recipes-support/gnupg/gnupg_2.1.10.bb | 1 - meta/recipes-support/libevent/libevent_2.0.22.bb | 1 - meta/recipes-support/libunwind/libunwind.inc | 1 - 36 files changed, 37 deletions(-)
meta/recipes-bsp/grub/grub2.inc +0 -1
@@ -39,7 +39,6 @@ COMPATIBLE_HOST = '(x86_64.*|i.86.*)-(linux|freebsd.*)' inherit autotools gettext texinfo -PACKAGECONFIG ??= "" PACKAGECONFIG[grub-mount] = "--enable-grub-mount,--disable-grub-mount,fuse" PACKAGECONFIG[device-mapper] = "--enable-device-mapper,--disable-device-mapper,lvm2"
meta/recipes-core/dbus/dbus-glib.inc +0 -1
@@ -19,7 +19,6 @@ inherit autotools pkgconfig gettext #default disable regression tests, some unit test code in non testing code #PACKAGECONFIG_pn-${PN} = "tests" enable regression tests local.conf -PACKAGECONFIG ??= "" PACKAGECONFIG[tests] = "--enable-tests,,," EXTRA_OECONF = "--with-introspect-xml=${STAGING_DATADIR_NATIVE}/dbus/dbus-bus-introspect.xml \
meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb +0 -1
@@ -18,7 +18,6 @@ EXTRA_OECONF += "--libdir=${base_libdir} --sbindir=${base_sbindir} \ EXTRA_OECONF_darwin = "--libdir=${base_libdir} --sbindir=${base_sbindir} --enable-bsd-shlibs" -PACKAGECONFIG ??= "" PACKAGECONFIG[fuse] = '--enable-fuse2fs,--disable-fuse2fs,fuse' do_configure_prepend () {
meta/recipes-devtools/gdb/gdb_7.10.1.bb +0 -1
@@ -3,7 +3,6 @@ require gdb-${PV}.inc inherit python-dir -PACKAGECONFIG ??= "" PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python,python python-codecs" PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
meta/recipes-devtools/mtools/mtools_3.9.9.bb +0 -1
@@ -46,7 +46,6 @@ EXTRA_OECONF = "--without-x" BBCLASSEXTEND = "native nativesdk" -PACKAGECONFIG ??= "" PACKAGECONFIG[libbsd] = "ac_cv_lib_bsd_main=yes,ac_cv_lib_bsd_main=no,libbsd" do_install_prepend () {
meta/recipes-devtools/mtools/mtools_4.0.18.bb +0 -1
@@ -37,7 +37,6 @@ EXTRA_OECONF = "--without-x" BBCLASSEXTEND = "native nativesdk" -PACKAGECONFIG ??= "" PACKAGECONFIG[libbsd] = "ac_cv_lib_bsd_main=yes,ac_cv_lib_bsd_main=no,libbsd" do_install_prepend () {
meta/recipes-devtools/opkg/opkg_0.3.1.bb +0 -2
@@ -29,8 +29,6 @@ SYSTEMD_SERVICE_${PN} = "opkg-configure.service" target_localstatedir := "${localstatedir}" OPKGLIBDIR = "${target_localstatedir}/lib" -PACKAGECONFIG ??= "" - PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error,gnupg" PACKAGECONFIG[curl] = "--enable-curl,--disable-curl,curl" PACKAGECONFIG[ssl-curl] = "--enable-ssl-curl,--disable-ssl-curl,curl openssl"
meta/recipes-devtools/python/python-imaging_1.1.7.bb +0 -1
@@ -17,7 +17,6 @@ S = "${WORKDIR}/${SRCNAME}-${PV}" # There isn't enable/disable option, and lcms is in meta-oe, at least make it explicit when enabled # setup.py already has FIXME: add mechanism to explicitly *disable* the use of a library -PACKAGECONFIG ??= "" PACKAGECONFIG[lcms] = ",,lcms" inherit distutils
meta/recipes-devtools/ruby/ruby_2.2.2.bb +0 -1
@@ -8,7 +8,6 @@ SRC_URI[sha256sum] = "5ffc0f317e429e6b29d4a98ac521c3ce65481bfd22a8cf845fa02a7b11 # 0001-socket-extconf-hardcode-wide-getaddr-info-test-outco.patch UNKNOWN_CONFIGURE_WHITELIST += "--enable-wide-getaddrinfo" -PACKAGECONFIG ??= "" PACKAGECONFIG += "${@bb.utils.contains('DISTRO_FEATURES', 'ipv6', 'ipv6', '', d)}" PACKAGECONFIG[valgrind] = "--with-valgrind=yes, --with-valgrind=no, valgrind"
meta/recipes-extended/mc/mc_4.8.15.bb +0 -1
@@ -16,7 +16,6 @@ inherit autotools gettext pkgconfig # # Both Samba (smb) and sftp require package delivered from meta-openembedded # -PACKAGECONFIG ??= "" PACKAGECONFIG[smb] = "--enable-vfs-smb,--disable-vfs-smb,samba," PACKAGECONFIG[sftp] = "--enable-vfs-sftp,--disable-vfs-sftp,libssh2,"
meta/recipes-extended/minicom/minicom_2.7.bb +0 -1
@@ -17,7 +17,6 @@ SRC_URI[sha256sum] = "9ac3a663b82f4f5df64114b4792b9926b536c85f59de0f2d2b321c7626 UPSTREAM_CHECK_URI = "https://alioth.debian.org/frs/?group_id=30018" -PACKAGECONFIG ??= "" PACKAGECONFIG[lockdev] = "--enable-lockdev,--disable-lockdev,lockdev" inherit autotools gettext pkgconfig
meta/recipes-extended/screen/screen_4.3.1.bb +0 -1
@@ -32,7 +32,6 @@ SRC_URI[sha256sum] = "fa4049f8aee283de62e283d427f2cfd35d6c369b40f7f45f947dbfd915 inherit autotools texinfo -PACKAGECONFIG ??= "" PACKAGECONFIG[utempter] = "ac_cv_header_utempter_h=yes,ac_cv_header_utempter_h=no,libutempter," EXTRA_OECONF = "--with-pty-mode=0620 --with-pty-group=5 \
meta/recipes-extended/sudo/sudo.inc +0 -1
@@ -16,7 +16,6 @@ LIC_FILES_CHKSUM = "file://doc/LICENSE;md5=c16e542408abda013d672be8eb88d174 \ inherit autotools -PACKAGECONFIG ??= "" PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib" CONFFILES_${PN} = "${sysconfdir}/sudoers"
meta/recipes-extended/tar/tar_1.28.bb +0 -1
@@ -1,6 +1,5 @@ require tar.inc -PACKAGECONFIG ??= "" PACKAGECONFIG[acl] = "--with-posix-acls, --without-posix-acls, acl," LICENSE = "GPLv3"
meta/recipes-extended/wget/wget.inc +0 -1
@@ -20,5 +20,4 @@ RRECOMMENDS_${PN} += "ca-certificates" BBCLASSEXTEND += "nativesdk" -PACKAGECONFIG ??= "" PACKAGECONFIG[libuuid] = "--with-libuuid, --without-libuuid,util-linux"
meta/recipes-gnome/gnome/gconf_3.2.6.bb +0 -1
@@ -23,7 +23,6 @@ EXTRA_OECONF = "--enable-shared --disable-static --enable-debug=yes \ --disable-introspection --disable-orbit --with-openldap=no --disable-gtk" # Disable PolicyKit by default -PACKAGECONFIG ??= "" # We really don't want PolicyKit for native or uclibc PACKAGECONFIG_class-native = "" PACKAGECONFIG_libc-uclibc = ""
meta/recipes-graphics/directfb/directfb.inc +0 -1
@@ -29,7 +29,6 @@ BINCONFIG = "${bindir}/directfb-config" inherit autotools binconfig-disabled pkgconfig -PACKAGECONFIG ??= "" PACKAGECONFIG[jpeg2000] = "--enable-jpeg2000,--disable-jpeg2000,jasper" PACKAGECONFIG[drmkms] = "--enable-drmkms,--disable-drmkms,libdrm" PACKAGECONFIG[tiff] = "--enable-tiff,--disable-tiff,tiff"
meta/recipes-graphics/piglit/piglit_git.bb +0 -1
@@ -18,7 +18,6 @@ inherit cmake pythonnative distro_features_check # depends on virtual/libx11 REQUIRED_DISTRO_FEATURES = "x11" -PACKAGECONFIG ??= "" PACKAGECONFIG[freeglut] = "-DPIGLIT_USE_GLUT=1,-DPIGLIT_USE_GLUT=0,freeglut," do_configure_prepend() {
meta/recipes-graphics/wayland/libinput_1.1.4.bb +0 -1
@@ -15,7 +15,6 @@ SRC_URI[sha256sum] = "302cb76209b9c57a5a318e178f9bc446eede8ea79386103b5291cbfaa5 inherit autotools pkgconfig -PACKAGECONFIG ??= "" PACKAGECONFIG[libunwind] = "--with-libunwind,--without-libunwind,libunwind" PACKAGECONFIG[gui] = "--enable-event-gui,--disable-event-gui,cairo gtk+3"
meta/recipes-graphics/xorg-lib/libice_1.0.9.bb +0 -1
@@ -23,5 +23,4 @@ BBCLASSEXTEND = "native" SRC_URI[md5sum] = "addfb1e897ca8079531669c7c7711726" SRC_URI[sha256sum] = "8f7032f2c1c64352b5423f6b48a8ebdc339cc63064af34d66a6c9aa79759e202" -PACKAGECONFIG ??= "" PACKAGECONFIG[arc4] = "ac_cv_lib_bsd_arc4random_buf=yes,ac_cv_lib_bsd_arc4random_buf=no,libbsd"
meta/recipes-graphics/xorg-lib/libx11-diet_1.6.3.bb +0 -1
@@ -16,4 +16,3 @@ SRC_URI[sha256sum] = "cf31a7c39f2f52e8ebd0db95640384e63451f9b014eed2bb7f5de03e8a EXTRA_OECONF += "--disable-xlocale" -PACKAGECONFIG ??= ""
meta/recipes-graphics/xorg-lib/libxdmcp_1.1.2.bb +0 -1
@@ -25,5 +25,4 @@ BBCLASSEXTEND = "native nativesdk" SRC_URI[md5sum] = "18aa5c1279b01f9d18e3299969665b2e" SRC_URI[sha256sum] = "81fe09867918fff258296e1e1e159f0dc639cb30d201c53519f25ab73af4e4e2" -PACKAGECONFIG ??= "" PACKAGECONFIG[arc4] = "ac_cv_lib_bsd_arc4random_buf=yes,ac_cv_lib_bsd_arc4random_buf=no,libbsd"
meta/recipes-graphics/xorg-lib/xorg-lib-common.inc +0 -1
@@ -15,7 +15,6 @@ inherit autotools distro_features_check pkgconfig EXTRA_OECONF = "--disable-specs --without-groff --without-ps2pdf --without-fop" -PACKAGECONFIG ??= "" PACKAGECONFIG[xmlto] = "--with-xmlto, --without-xmlto, xmlto-native docbook-xml-dtd4-native docbook-xsl-stylesheets-native" UNKNOWN_CONFIGURE_WHITELIST += "--enable-malloc0returnsnull --disable-malloc0returnsnull \
meta/recipes-graphics/xorg-proto/xorg-proto-common.inc +0 -1
@@ -18,7 +18,6 @@ EXTRA_OECONF = "--without-fop" UNKNOWN_CONFIGURE_WHITELIST += "--without-fop --without-xmlto --with-xmlto" -PACKAGECONFIG ??= "" PACKAGECONFIG[xmlto] = "--with-xmlto, --without-xmlto, xmlto-native docbook-xml-dtd4-native docbook-xsl-stylesheets-native" # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
meta/recipes-kernel/systemtap/systemtap_git.bb +0 -1
@@ -20,7 +20,6 @@ STAP_DOCS ?= "--disable-docs --disable-publican --disable-refdocs" EXTRA_OECONF += "${STAP_DOCS} " -PACKAGECONFIG ??= "" PACKAGECONFIG[libvirt] = "--enable-libvirt,--disable-libvirt,libvirt" inherit autotools gettext pkgconfig
meta/recipes-multimedia/webp/libwebp_0.5.0.bb +0 -1
@@ -29,7 +29,6 @@ EXTRA_OECONF = " \ inherit autotools lib_package -PACKAGECONFIG ??= "" # libwebpdecoder is a subset of libwebp, don't build it unless requested PACKAGECONFIG[decoder] = "--enable-libwebpdecoder,--disable-libwebpdecoder"
meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc +0 -1
@@ -30,7 +30,6 @@ EXTRA_OECONF = "--enable-xim \ --enable-combining --disable-perl \ --with-x=${STAGING_DIR_HOST}${prefix}" -PACKAGECONFIG ??= "" PACKAGECONFIG[startup] = "--enable-startup-notification,--disable-startup-notification,startup-notification," do_configure_prepend () {
meta/recipes-support/aspell/aspell_0.60.6.1.bb +0 -1
@@ -10,7 +10,6 @@ SRC_URI = "${GNU_MIRROR}/aspell/aspell-${PV}.tar.gz" SRC_URI[md5sum] = "e66a9c9af6a60dc46134fdacf6ce97d7" SRC_URI[sha256sum] = "f52583a83a63633701c5f71db3dc40aab87b7f76b29723aeb27941eff42df6e1" -PACKAGECONFIG ??= "" PACKAGECONFIG[curses] = "--enable-curses,--disable-curses,ncurses" PACKAGES += "libaspell libpspell aspell-utils"
meta/recipes-support/beecrypt/beecrypt_4.2.1.bb +0 -1
@@ -33,7 +33,6 @@ do_install_append() { EXTRA_OECONF = "--without-python --enable-shared --enable-static --disable-openmp --with-java=no" -PACKAGECONFIG ??= "" PACKAGECONFIG[cplusplus] = "--with-cplusplus,--without-cplusplus,icu" FILES_${PN} = "${sysconfdir} ${libdir}/*.so.* ${libdir}/${BPN}/*.so.*"
meta/recipes-support/boost/boost.inc +0 -1
@@ -24,7 +24,6 @@ BOOST_LIBS = "\ " # optional boost-python library -PACKAGECONFIG ??= "" PACKAGECONFIG[python] = ",,python python3" BOOST_LIBS += "${@bb.utils.contains('PACKAGECONFIG', 'python', 'python python3', '', d)}" inherit python-dir
meta/recipes-support/gmp/gmp.inc +0 -1
@@ -12,5 +12,4 @@ ARM_INSTRUCTION_SET = "arm" BBCLASSEXTEND = "native nativesdk" -PACKAGECONFIG ??= "" PACKAGECONFIG[readline] = "--with-readline=yes,--with-readline=no,readline"
meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing_2014.1.bb +0 -1
@@ -18,5 +18,4 @@ inherit autotools pkgconfig PR = "r1" -PACKAGECONFIG ??= "" PACKAGECONFIG[journald] = "--with-systemd-journal,--without-systemd-journal,systemd,systemd"
meta/recipes-support/gnupg/gnupg_1.4.7.bb +0 -1
@@ -99,6 +99,5 @@ FILES_gpgv = "${bindir}/gpgv" # Exclude debug files from the main packages FILES_${PN} = "${bindir}/* ${datadir}/${BPN} ${libexecdir}/${BPN}/*" -PACKAGECONFIG ??= "" PACKAGECONFIG[curl] = "--with-libcurl=${STAGING_LIBDIR},--without-libcurl,curl" PACKAGECONFIG[libusb] = "--with-libusb=${STAGING_LIBDIR},--without-libusb,libusb-compat"
meta/recipes-support/gnupg/gnupg_2.1.10.bb +0 -1
@@ -41,5 +41,4 @@ do_install_append() { RDEPENDS_${PN} = "gnutls" -PACKAGECONFIG ??= "" PACKAGECONFIG[sqlite3] = "--enable-sqlite, --disable-sqlite, sqlite3"
meta/recipes-support/libevent/libevent_2.0.22.bb +0 -1
@@ -18,7 +18,6 @@ UPSTREAM_CHECK_URI = "http://libevent.org/" S = "${WORKDIR}/${BPN}-${PV}-stable" -PACKAGECONFIG ??= "" PACKAGECONFIG[openssl] = "--enable-openssl,--disable-openssl,openssl" inherit autotools
meta/recipes-support/libunwind/libunwind.inc +0 -1
@@ -9,7 +9,6 @@ SRC_URI = "${SAVANNAH_NONGNU_MIRROR}/${BPN}/${BPN}-${PV}.tar.gz" inherit autotools -PACKAGECONFIG ??= "" PACKAGECONFIG[lzma] = "--enable-minidebuginfo,--disable-minidebuginfo,xz" EXTRA_OECONF_arm = "--enable-debug-frame"
Signature · 1 line
1.7.9.5
Quoted 4 lines · Robert Yang
The base.bbclass can handle PACKAGECONFIG well when it is not set, so PACKAGECONFIG ??= "" isn't useful here, but there are a lot of them, which may mislead the newbie that it is a must.
I actually like the clarity of PACKAGECONFIG??="". Does anyone else have an opinion either way?
Ross
Quoted 10 lines · Ross
Quoted 4 lines · Robert Yang
The base.bbclass can handle PACKAGECONFIG well when it is not set, so PACKAGECONFIG ??= "" isn't useful here, but there are a lot of them, which may mislead the newbie that it is a must.
I actually like the clarity of PACKAGECONFIG??="". Does anyone else have an opinion either way?
I'd prefer to keep it too.
Quoted 8 lines
Ross
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core