Skip to contentSkip to conversation

toaster: speed up and harden lsof usage

PATCH In review brian avery 2 participants 4 messages Feb 10, 2016 – Feb 26, 2016

lore
Share & tools
lore
#0 lore raw

cover toaster: speed up and harden lsof usage

This adds a -t to the lsof command so that it:
1) runs faster
2) doesn't give a warning on esoteric file system mounts (a docker experiment in my case)

If it does give a warning then the script assumes restarting bitbake failed and no build happens. -b

The following changes since commit 246b02e281f84ffe1c9156ce24b728eb6f3742c1:

ptest-runner: Explicitly set EXTRA_OEMAKE as required (2016-02-10 16:06:25 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib bavery/toaster/betterlsof
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=bavery/toaster/betterlsof

brian avery (1):
add a -t to the lsof command so that it is faster and it won't fail on
esoteric filesystem mounts since it is just looking at processes.

 bin/toaster | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.9.1

#1 lore raw

PATCH 1/1 add a -t to the lsof command so that it is faster and it won't fail on esoteric filesystem mounts since it is just looking at processes.

---
 bin/toaster | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
bin/toaster +1 -1
index 72eae64..89318f0 100755
@@ -128,7 +128,7 @@ stop_bitbake() {
     BBSERVER=0.0.0.0:-1 bitbake -m
     unset BBSERVER
     # force stop any misbehaving bitbake server
-    lsof bitbake.lock | awk '{print $2}' | grep "[0-9]\+" | xargs -n1 -r kill
+    lsof -t bitbake.lock | awk '{print $2}' | grep "[0-9]\+" | xargs -n1 -r kill
 }
 
 verify_prereq() {
Signature · 1 line
1.9.1
#2 lore raw
In reply to brian avery
Quoted 5 lines · brian avery

This adds a -t to the lsof command so that it:
1) runs faster
2) doesn't give a warning on esoteric file system mounts (a docker experiment in my case)

Hello Brian.

I attempted to merge this today and it failed. You can either rebase and submit it yourself (looks fine to me) or send for review and I'll submit it.

Elliot

Quoted 32 lines

If it does give a warning then the script assumes restarting bitbake failed and no build happens.
-b

The following changes since commit
246b02e281f84ffe1c9156ce24b728eb6f3742c1:

ptest-runner: Explicitly set EXTRA_OEMAKE as required (2016-02-10
16:06:25 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib bavery/toaster/betterlsof

http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=bavery/toaster/betterlsof

brian avery (1):
add a -t to the lsof command so that it is faster and it won't fail on
esoteric filesystem mounts since it is just looking at processes.

 bin/toaster | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.9.1
--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Signature · 3 lines
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
#3 lore raw

Thanks, I'll rebase and resubmit.
-b

Quoted 55 lines · Elliot
Quoted 5 lines · brian avery

This adds a -t to the lsof command so that it:
1) runs faster
2) doesn't give a warning on esoteric file system mounts (a docker experiment in my case)

Hello Brian.

I attempted to merge this today and it failed. You can either rebase and submit it yourself (looks fine to me) or send for review and I'll submit it.

Elliot

Quoted 25 lines

If it does give a warning then the script assumes restarting bitbake failed and no build happens.
-b

The following changes since commit
246b02e281f84ffe1c9156ce24b728eb6f3742c1:

ptest-runner: Explicitly set EXTRA_OEMAKE as required (2016-02-10
16:06:25 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib bavery/toaster/betterlsof

http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=bavery/toaster/betterlsof

brian avery (1):
add a -t to the lsof command so that it is faster and it won't fail on
esoteric filesystem mounts since it is just looking at processes.

 bin/toaster | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines

--
1.9.1
--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

--
Elliot Smith
Software Engineer
Intel Open Source Technology Centre