Staging: Use ether_addr_equal_64bits() insted of ether_addr_equal().

PATCH In review Sandhya Bankar 2 participants 3 messages Feb 28, 2016

Share & tools

Sandhya Bankar

author

2016-02-28 20:08 UTC #0 lore raw

cover Staging: Use ether_addr_equal_64bits() insted of ether_addr_equal().

Use ether_addr_equal_64bits() insted of ether_addr_equal().
ether_addr_equal_64bits() is more efficient than ether_addr_equal(), and can be used when each argument is an array within a structure.

Sandhya Bankar (2):
[PATCH 1/2] Staging: slicoss: Use ether_addr_equal_64bits() insted of ether_addr_equal(). [PATCH 2/2] Staging: rtl8192e: Use ether_addr_equal_64bits() instead of ether_addr_equal().

 drivers/staging/rtl8192e/rtllib_softmac.c | 5 +++--
 drivers/staging/slicoss/slicoss.c         | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

Signature · 1 line

1.8.3.4

Julia Lawall

2016-02-28 20:18 UTC #1 lore raw

Quoted 2 lines · Sandhya Bankar

Use ether_addr_equal_64bits() insted of ether_addr_equal().
ether_addr_equal_64bits() is more efficient than ether_addr_equal(), and can be used when each argument is an array within a structure.

This seems to have come to me more slowly than the patches :)

However, it would be good to have the explanation in the patches, because that is the only thing that will be committed. The cover letter just exists in the mailing list.

You chould check in each case that the mentioned field is not at the end of the structure, ie that it has at least two bytes within the structure after it.

However, what I recall from the mailing list discussions on this issue was that the condition for the call being valid was considered to be quite fragile, and so using this function was not considered to be worth it unless performance was really critical.

julia

Quoted 19 lines

 drivers/staging/rtl8192e/rtllib_softmac.c | 5 +++--
 drivers/staging/slicoss/slicoss.c         | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

Signature · 8 lines

1.8.3.4

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1456660509.git.bankarsandhya512%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

sandhya bankar

author

2016-02-28 20:42 UTC #2 lore raw

Thanks for the information.!!
I will provide detail explanation of the patch in message body as well as cover letter in upcoming patches.

Thanks
Sandhya

Quoted 49 lines · Julia Lawall

Quoted 2 lines · Sandhya Bankar
Use ether_addr_equal_64bits() insted of ether_addr_equal(). ether_addr_equal_64bits() is more efficient than ether_addr_equal(), and
can be used when each argument is an array within a structure.
This seems to have come to me more slowly than the patches :)
However, it would be good to have the explanation in the patches, because that is the only thing that will be committed. The cover letter just exists in the mailing list.
You chould check in each case that the mentioned field is not at the end of the structure, ie that it has at least two bytes within the structure after it.
However, what I recall from the mailing list discussions on this issue was that the condition for the call being valid was considered to be quite fragile, and so using this function was not considered to be worth it unless performance was really critical.
julia
Quoted 3 lines
Sandhya Bankar (2):
[PATCH 1/2] Staging: slicoss: Use ether_addr_equal_64bits() insted of
ether_addr_equal().
Quoted 1 line
[PATCH 2/2] Staging: rtl8192e: Use ether_addr_equal_64bits() instead
of ether_addr_equal().
Quoted 10 lines
 drivers/staging/rtl8192e/rtllib_softmac.c | 5 +++--
 drivers/staging/slicoss/slicoss.c         | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)
--
1.8.3.4
--
You received this message because you are subscribed to the Google
Groups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 2 lines
To post to this group, send email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/cover.1456660509.git.bankarsandhya512%40gmail.com
.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.