quilt: fix ptest faildiff.test failed
cover quilt: fix ptest faildiff.test failed
The following changes since commit 7d409ffb1e0a26b196e5ab7e69fec87f7467d5f6:
pTest-tcl fail fixed (2016-03-02 23:28:51 -0500)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib dengke/pTest-quilt-fail-fixed
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=dengke/pTest-quilt-fail-fixed
Dengke Du (1):
quilt: fix ptest faildiff.test failed
meta/recipes-devtools/quilt/quilt/run-ptest | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.9.1
PATCH 1/1 quilt: fix ptest faildiff.test failed
When run the quilt ptest on the target, the faildiff.test failed, because the user is root. The faildiff.test had the following:
$ chmod -r test.txt $ quilt refresh when we drop the read permission of the file test.txt, we can't "quilt refresh" as normal user, so we got the following: >~ .*diff: test\.txt: Permission denied > Diff failed on file 'test.txt', aborting But when the user is root, we can access the file, so we get the following: > Nothing in patch patches/test.diff So I change the file "meta/recipes-devtools/quilt/quilt/run-ptest", when it meet the faildiff.test it skipped. I will report this bug to quilt upstream.
--- meta/recipes-devtools/quilt/quilt/run-ptest | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/quilt/quilt/run-ptest +1 -1
@@ -1,5 +1,5 @@ #!/bin/sh ln -sf /bin/ed /usr/bin/ed -for i in `ls test/*.test |awk -F. '{print $1}' |awk -F/ '{print $2}'`; do make check-$i; if [ $? -eq 0 ]; then echo PASS: $i.test; else echo FAIL: $i.test; fi; done +for i in `ls test/*.test |awk -F. '{print $1}' |awk -F/ '{print $2}'`; do if [ "$i" == "faildiff" ]; then echo SKIPPED: $i.test; else make check-$i; if [ $? -eq 0 ]; then echo PASS: $i.test; else echo FAIL: $i.test; fi; fi; done rm -f /usr/bin/ed
Signature · 1 line
1.9.1
Quoted 4 lines · Dengke Du
So I change the file "meta/recipes-devtools/quilt/quilt/run-ptest", when it meet the faildiff.test it skipped. I will report this bug to quilt upstream.
We're seeing a number of tests that expect to run as a non-root user. Maybe ptest-runner should create a ptest user and run the test suites as that user instead?
Ross
OK, it's a good idea!
//dengke
Quoted 11 lines · Ross
On 8 March 2016 at 12:11, Dengke Du <[email protected] <mailto:[email protected]>> wrote:
So I change the file "meta/recipes-devtools/quilt/quilt/run-ptest", when it meet the faildiff.test it skipped. I will report this bug to quilt upstream.
We're seeing a number of tests that expect to run as a non-root user. Maybe ptest-runner should create a ptest user and run the test suites as that user instead?
Ross