Skip to contentSkip to conversation

staging: wilc1000: Fix line over 80 characters

PATCH Superseded Anchal Jain 3 participants 7 messages Mar 12, 2016 – Mar 13, 2016 Staging

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Anchal Jain

author
#0 lore raw

cover staging: wilc1000: Fix line over 80 characters

staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters

Anchal Jain (4):
staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters

 drivers/staging/wilc1000/linux_mon.c | 39 ++++++++++++++++++++++++------------
 1 file changed, 26 insertions(+), 13 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/4 staging: wilc1000: Fix line over 80 characters

Break comment lines so that they do not exceed
80 characters. Problem found using checkpatch.

Signed-off-by Anchal Jain <[email protected]>
---
 drivers/staging/wilc1000/linux_mon.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/staging/wilc1000/linux_mon.c +7 -3
index 7d9e5de..44996e2 100644
@@ -60,8 +60,10 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 	/* Get WILC header */
 	memcpy(&header, (buff - HOST_HDR_OFFSET), HOST_HDR_OFFSET);
 
-	/* The packet offset field conain info about what type of managment frame */
-	/* we are dealing with and ack status */
+	/* The packet offset field conain info
+	 * about what type of managment frame
+	 * we are dealing with and ack status
+	 */
 	pkt_offset = GET_PKT_OFFSET(header);
 
 	if (pkt_offset & IS_MANAGMEMENT_CALLBACK) {

@@ -128,7 +130,9 @@ static void mgmt_tx_complete(void *priv, int status)
 {
 	struct tx_complete_mon_data *pv_data = priv;
 
-	/* incase of fully hosting mode, the freeing will be done in response to the cfg packet */
+	/* incase of fully hosting mode, the freeing
+	 * will be done in response to the cfg packet
+	 */
 	kfree(pv_data->buff);
 
 	kfree(pv_data);
Signature · 1 line
1.9.1
#2 lore raw
Quoted 13 lines · Anchal Jain

Break comment lines so that they do not exceed
80 characters. Problem found using checkpatch.

Signed-off-by Anchal Jain <[email protected]>
---
 drivers/staging/wilc1000/linux_mon.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/staging/wilc1000/linux_mon.c +0 -0
index 7d9e5de..44996e2 100644

drivers/staging/wilc1000/linux_mon.c void WILC_WFI_monitor_rx(u8 *buff, u32 size) · line 65

Quoted 8 lines
drivers/staging/wilc1000/linux_mon.c +3 -2
@@ -60,8 +60,10 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 	/* Get WILC header */
 	memcpy(&header, (buff - HOST_HDR_OFFSET), HOST_HDR_OFFSET);
 
-	/* The packet offset field conain info about what type of managment frame */
-	/* we are dealing with and ack status */
+	/* The packet offset field conain info
+	 * about what type of managment frame
+	 * we are dealing with and ack status

There is no need to make the lines so short. Also, if you are redoing the multiline comment, it may as well also go to the right format, with /* on a line by itself at the start.

julia

Quoted 25 lines
drivers/staging/wilc1000/linux_mon.c +4 -1
+	 */
 	pkt_offset = GET_PKT_OFFSET(header);
 
 	if (pkt_offset & IS_MANAGMEMENT_CALLBACK) {

@@ -128,7 +130,9 @@ static void mgmt_tx_complete(void *priv, int status)
 {
 	struct tx_complete_mon_data *pv_data = priv;
 
-	/* incase of fully hosting mode, the freeing will be done in response to the cfg packet */
+	/* incase of fully hosting mode, the freeing
+	 * will be done in response to the cfg packet
+	 */
 	kfree(pv_data->buff);
 
 	kfree(pv_data);
Signature · 8 lines
1.9.1

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/34df57c2a9e66d8279f7c3b948896da328c382ea.1457800084.git.anchalj109%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
author
#3 lore raw

PATCH 2/4 staging: wilc1000: Fix line over 80 characters

In reply to Anchal Jain

Break lines so that they do not exceed
80 characters. Problem found using checkpatch.

Signed-off-by Anchal Jain <[email protected]>
---
 drivers/staging/wilc1000/linux_mon.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/staging/wilc1000/linux_mon.c +12 -6
index 44996e2..55f626a 100644
@@ -69,7 +69,8 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 	if (pkt_offset & IS_MANAGMEMENT_CALLBACK) {
 		/* hostapd callback mgmt frame */
 
-		skb = dev_alloc_skb(size + sizeof(struct wilc_wfi_radiotap_cb_hdr));
+		skb = dev_alloc_skb(size + sizeof(
+			struct wilc_wfi_radiotap_cb_hdr));
 		if (!skb)
 			return;
 

@@ -80,7 +81,8 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 
 		cb_hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
 
-		cb_hdr->hdr.it_len = cpu_to_le16(sizeof(struct wilc_wfi_radiotap_cb_hdr));
+		cb_hdr->hdr.it_len = cpu_to_le16(sizeof(
+					struct wilc_wfi_radiotap_cb_hdr));
 
 		cb_hdr->hdr.it_present = cpu_to_le32(
 				(1 << IEEE80211_RADIOTAP_RATE) |

@@ -96,7 +98,8 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 		}
 
 	} else {
-		skb = dev_alloc_skb(size + sizeof(struct wilc_wfi_radiotap_hdr));
+		skb = dev_alloc_skb(size + sizeof(
+					struct wilc_wfi_radiotap_hdr));
 
 		if (!skb)
 			return;

@@ -105,7 +108,8 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 		hdr = (struct wilc_wfi_radiotap_hdr *)skb_push(skb, sizeof(*hdr));
 		memset(hdr, 0, sizeof(struct wilc_wfi_radiotap_hdr));
 		hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
-		hdr->hdr.it_len = cpu_to_le16(sizeof(struct wilc_wfi_radiotap_hdr));
+		hdr->hdr.it_len = cpu_to_le16(sizeof(
+					struct wilc_wfi_radiotap_hdr));
 		hdr->hdr.it_present = cpu_to_le32
 				(1 << IEEE80211_RADIOTAP_RATE);                   /* | */
 		hdr->rate = 5; /* txrate->bitrate / 5; */

@@ -197,7 +201,8 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb,
 	skb_pull(skb, rtap_len);
 
 	if (skb->data[0] == 0xc0 && (!(memcmp(broadcast, &skb->data[4], 6)))) {
-		skb2 = dev_alloc_skb(skb->len + sizeof(struct wilc_wfi_radiotap_cb_hdr));
+		skb2 = dev_alloc_skb(skb->len + sizeof(
+					struct wilc_wfi_radiotap_cb_hdr));
 
 		memcpy(skb_put(skb2, skb->len), skb->data, skb->len);
 

@@ -206,7 +211,8 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb,
 
 		cb_hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
 
-		cb_hdr->hdr.it_len = cpu_to_le16(sizeof(struct wilc_wfi_radiotap_cb_hdr));
+		cb_hdr->hdr.it_len = cpu_to_le16(sizeof(
+					struct wilc_wfi_radiotap_cb_hdr));
 
 		cb_hdr->hdr.it_present = cpu_to_le32(
 				(1 << IEEE80211_RADIOTAP_RATE) |
Signature · 1 line
1.9.1
author
#4 lore raw

PATCH 3/4 staging: wilc1000: Fix line over 80 characters

In reply to Anchal Jain

Break lines so that they do not exceed
80 characters. Problem found using checkpatch.

Signed-off-by Anchal Jain <[email protected]>
---
 drivers/staging/wilc1000/linux_mon.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/staging/wilc1000/linux_mon.c +6 -3
index 55f626a..420f923 100644
@@ -76,7 +76,8 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 
 		memcpy(skb_put(skb, size), buff, size);
 
-		cb_hdr = (struct wilc_wfi_radiotap_cb_hdr *)skb_push(skb, sizeof(*cb_hdr));
+		cb_hdr = (struct wilc_wfi_radiotap_cb_hdr *)
+				skb_push(skb, sizeof(*cb_hdr));
 		memset(cb_hdr, 0, sizeof(struct wilc_wfi_radiotap_cb_hdr));
 
 		cb_hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */

@@ -105,7 +106,8 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 			return;
 
 		memcpy(skb_put(skb, size), buff, size);
-		hdr = (struct wilc_wfi_radiotap_hdr *)skb_push(skb, sizeof(*hdr));
+		hdr = (struct wilc_wfi_radiotap_hdr *)
+			skb_push(skb, sizeof(*hdr));
 		memset(hdr, 0, sizeof(struct wilc_wfi_radiotap_hdr));
 		hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
 		hdr->hdr.it_len = cpu_to_le16(sizeof(

@@ -206,7 +208,8 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb,
 
 		memcpy(skb_put(skb2, skb->len), skb->data, skb->len);
 
-		cb_hdr = (struct wilc_wfi_radiotap_cb_hdr *)skb_push(skb2, sizeof(*cb_hdr));
+		cb_hdr = (struct wilc_wfi_radiotap_cb_hdr *)
+				skb_push(skb2, sizeof(*cb_hdr));
 		memset(cb_hdr, 0, sizeof(struct wilc_wfi_radiotap_cb_hdr));
 
 		cb_hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
Signature · 1 line
1.9.1
author
#5 lore raw

PATCH 4/4 staging: wilc1000: Fix line over 80 characters

In reply to Anchal Jain

Remove unwanted space between comment and
code so that they do not exceed 80
characters.Problem found using checkpatch.

Signed-off-by Anchal Jain <[email protected]>
---
 drivers/staging/wilc1000/linux_mon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/linux_mon.c +1 -1
index 420f923..4e72f66 100644
@@ -113,7 +113,7 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 		hdr->hdr.it_len = cpu_to_le16(sizeof(
 					struct wilc_wfi_radiotap_hdr));
 		hdr->hdr.it_present = cpu_to_le32
-				(1 << IEEE80211_RADIOTAP_RATE);                   /* | */
+				(1 << IEEE80211_RADIOTAP_RATE); /* | */
 		hdr->rate = 5; /* txrate->bitrate / 5; */
 	}
Signature · 1 line
1.9.1
maintainer
#6 lore raw
In reply to Anchal Jain
Quoted 11 lines · Anchal Jain

staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters

Anchal Jain (4):
staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters
staging: wilc1000: Fix line over 80 characters

You can't send 4 patches all with the same commit message, yet doing different things, I can't accept that, sorry. Please fix up and make them unique.

greg k-h