staging: dgnc: variable rename to avoid camelcase

PATCH New Juliana Rodrigues 1 participant 3 messages Mar 13, 2016 Staging

Share & tools

Juliana Rodrigues

author

2016-03-13 04:58 UTC #0 lore raw

v2 cover staging: dgnc: variable rename to avoid camelcase

This patchset aims to fix dgnc_Major_TransparentPrint_Registered CamelCase issue on checkpatch.pl by renaming it in dgnc_driver.h and its calls in dgnc_tty.c.

Changes on v2:
- Removed file names from subject line
- Make commit message more clear
- Commit message is now below 80 characters

Juliana Rodrigues (2):
staging: dgnc: renamed variable to avoid camelcase
staging: dgnc: fixed variable call

 drivers/staging/dgnc/dgnc_driver.h | 2 +-
 drivers/staging/dgnc/dgnc_tty.c    | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

Signature · 1 line

2.7.2

Juliana Rodrigues

author

2016-03-13 05:01 UTC #1 lore raw

PATCH v2 1/2 staging: dgnc: renamed variable to avoid camelcase

This patch fixes a CamelCase issue on checkpatch.pl by renaming dgnc_Major_TransparentPrint_Registered to dgnc_major_transparent_print_registered on dgnc_driver.h.

CHECK: Avoid CamelCase: <dgnc_Major_TransparentPrint_Registered>
+ bool dgnc_Major_TransparentPrint_Registered;

Signed-off-by Juliana Rodrigues <[email protected]>

---
 drivers/staging/dgnc/dgnc_driver.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/dgnc/dgnc_driver.h +1 -1

index 98ff648..6d91abd 100644
@@ -211,7 +211,7 @@ struct dgnc_board {
 	char		PrintName[200];
 
 	bool		dgnc_major_serial_registered;
-	bool		dgnc_Major_TransparentPrint_Registered;
+	bool		dgnc_major_transparent_print_registered;
 
 	uint		dgnc_Serial_Major;
 	uint		dgnc_TransparentPrint_Major;

Signature · 1 line

2.7.2

Juliana Rodrigues

author

2016-03-13 05:02 UTC #2 lore raw

PATCH v2 2/2 staging: dgnc: fixed variable call

In reply to Juliana Rodrigues

This patch fixes dgnc_major_transparent_print_registered in dgnc_tty.c that was previously camelcased.

Signed-off-by Juliana Rodrigues <[email protected]>

---
 drivers/staging/dgnc/dgnc_tty.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

drivers/staging/dgnc/dgnc_tty.c +4 -4

index c723fab..da2c7ed 100644
@@ -273,7 +273,7 @@ int dgnc_tty_register(struct dgnc_board *brd)
 	 */
 	tty_set_operations(&brd->PrintDriver, &dgnc_tty_ops);
 
-	if (!brd->dgnc_Major_TransparentPrint_Registered) {
+	if (!brd->dgnc_major_transparent_print_registered) {
 		/* Register Transparent Print devices */
 		rc = tty_register_driver(&brd->PrintDriver);
 		if (rc < 0) {

@@ -282,7 +282,7 @@ int dgnc_tty_register(struct dgnc_board *brd)
 				rc);
 			return rc;
 		}
-		brd->dgnc_Major_TransparentPrint_Registered = true;
+		brd->dgnc_major_transparent_print_registered = true;
 	}
 
 	dgnc_BoardsByMajor[brd->SerialDriver.major] = brd;

@@ -420,7 +420,7 @@ void dgnc_tty_uninit(struct dgnc_board *brd)
 		brd->dgnc_major_serial_registered = false;
 	}
 
-	if (brd->dgnc_Major_TransparentPrint_Registered) {
+	if (brd->dgnc_major_transparent_print_registered) {
 		dgnc_BoardsByMajor[brd->PrintDriver.major] = NULL;
 		brd->dgnc_TransparentPrint_Major = 0;
 		for (i = 0; i < brd->nasync; i++) {

@@ -430,7 +430,7 @@ void dgnc_tty_uninit(struct dgnc_board *brd)
 			tty_unregister_device(&brd->PrintDriver, i);
 		}
 		tty_unregister_driver(&brd->PrintDriver);
-		brd->dgnc_Major_TransparentPrint_Registered = false;
+		brd->dgnc_major_transparent_print_registered = false;
 	}
 
 	kfree(brd->SerialDriver.ttys);

Signature · 1 line

2.7.2