Skip to contentSkip to conversation

Staging : Fix multiple coding style issues.

PATCH New Sandhya Bankar 1 participant 4 messages Mar 13, 2016 Staging

lore
Share & tools
lore

Sandhya Bankar

author
#0 lore raw

cover Staging : Fix multiple coding style issues.

Fix multiple coding style issues. These issues are reported by checkpatch.pl script.

Sandhya Bankar (3):
Staging: gs_fpgaboot: Fix alignment to match open parenthesis.
Staging: gs_fpgaboot: Remove unnecessary blank lines.
Staging: gs_fpgaboot: Add space around '+'.

 drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
Signature · 1 line
1.8.3.4
author
#1 lore raw

PATCH 1/3 Staging: gs_fpgaboot: Fix alignment to match open parenthesis.

Fix alignment to match open parenthesis.

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/gs_fpgaboot/gs_fpgaboot.c +2 -2
index 7b7c978..de1a9a6 100644
@@ -201,7 +201,7 @@ static int gs_download_image(struct fpgaimage *fimage, enum wbus bus_bytes)
 #endif /* DEBUG_FPGA */
 	if (!xl_supported_prog_bus_width(bus_bytes)) {
 		pr_err("unsupported program bus width %d\n",
-				bus_bytes);
+		       bus_bytes);
 		return -1;
 	}
 

@@ -277,7 +277,7 @@ static int gs_set_download_method(struct fpgaimage *fimage)
 static int init_driver(void)
 {
 	firmware_pdev = platform_device_register_simple("fpgaboot", -1,
-							 NULL, 0);
+							NULL, 0);
 	return PTR_ERR_OR_ZERO(firmware_pdev);
 }
Signature · 1 line
1.8.3.4
author
#2 lore raw

PATCH 2/3 Staging: gs_fpgaboot: Remove unnecessary blank lines.

In reply to Sandhya Bankar

Remove unnecessary blank lines.

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/gs_fpgaboot/gs_fpgaboot.c +0 -2
index de1a9a6..1af0745 100644
@@ -93,7 +93,6 @@ static int readlength_bitstream(char *bitdata, int *lendata, int *offset)
 	return 0;
 }
 
-
 /*
  * read first 13 bytes to check bitstream magic number
  */

@@ -331,7 +330,6 @@ err_out1:
 	kfree(fimage);
 
 	return -1;
-
 }
 
 static int __init gs_fpgaboot_init(void)
Signature · 1 line
1.8.3.4
author
#3 lore raw

PATCH 3/3 Staging: gs_fpgaboot: Add space around '+'.

In reply to Sandhya Bankar

Add space around '+'.

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gs_fpgaboot/gs_fpgaboot.c +1 -1
index 1af0745..a221f26 100644
@@ -221,7 +221,7 @@ static int gs_download_image(struct fpgaimage *fimage, enum wbus bus_bytes)
 	pr_info("device init done\n");
 
 	for (i = 0; i < size; i += bus_bytes)
-		xl_shift_bytes_out(bus_bytes, bitdata+i);
+		xl_shift_bytes_out(bus_bytes, bitdata + i);
 
 	pr_info("program done\n");
Signature · 1 line
1.8.3.4