Skip to contentSkip to conversation

General cleanage of systemd unitdir vars

PATCH In review Pau Espin Pedrol 1 participant 44 messages Mar 13, 2016 – Jun 18, 2016

lore
Share & tools
lore
#0 lore raw

cover General cleanage of systemd unitdir vars

* These series of patches aim at improving the usage of some systemd related variables in several recipes from oe-core. Main aim is to change those recipes to use 'systemd_system_unitdir' instead of the old 'systemd_unitdir/system' variable, which will be marked as deprecated instead of being removed as is may still be used in other oe layers. To mark it as deprecated, a comment is added in bitbake.conf, but better ideas regarding this are welcome.

* Few recipes have also been changed to use the 'systemd_user_unitdir' variable for their systemd user services.

The following changes since commit 4be0e15f74cff85edca9de55248939fb438f30ae:

oeqa/selftest/recipetool: Fix test_recipetool_create_simple (2016-03-13 18:15:41 +0000)

are available in the git repository at:

git://github.com/pespin/openembedded-core systemd-var-fixes
https://github.com/pespin/openembedded-core/tree/systemd-var-fixes

Pau Espin Pedrol (42):
rootfs-postcommands: Fix usage of systemd unitdir vars
acpid: Fix usage of systemd unitdir vars
apmd: Fix usage of systemd unitdir vars
avahi: Fix usage of systemd unitdir vars
bind: Fix usage of systemd unitdir vars
connman: Fix usage of systemd unitdir vars
dhcp: Fix usage of systemd unitdir vars
neard: Fix usage of systemd unitdir vars
nfs-utils: Fix usage of systemd unitdir vars
openssh: Fix usage of systemd unitdir vars
portmap: Fix usage of systemd unitdir vars
ppp: Fix usage of systemd unitdir vars
wpa-supplicant: Fix usage of systemd unitdir vars
busybox: Fix usage of systemd unitdir vars
dropbear: Fix usage of systemd unitdir vars
glibc-package: Fix usage of systemd unitdir vars
systemd-compat-units: Fix usage of systemd unitdir vars
systemd-serialgetty: Fix usage of systemd unitdir vars
systemd: Fix usage of systemd unitdir vars
util-linux: Fix usage of systemd unitdir vars
volatile-binds: Fix usage of systemd unitdir vars
distcc: Fix usage of systemd unitdir vars
run-postints: Fix usage of systemd unitdir vars
tcf-agent: Fix usage of systemd unitdir vars
at: Fix usage of systemd unitdir vars
cronie: Fix usage of systemd unitdir vars
lighttpd: Fix usage of systemd unitdir vars
rpcbind: Fix usage of systemd unitdir vars
sysstat: Fix usage of systemd unitdir vars
xinetd: Fix usage of systemd unitdir vars
xserver-nodm-init: Fix usage of systemd unitdir vars
oprofileui-server: Fix usage of systemd unitdir vars
consolekit: Fix usage of systemd unitdir vars
alsa-utils: Fix usage of systemd unitdir vars
ofono: Fix usage of systemd unitdir vars
bluez5: Fix usage of systemd unitdir vars
avahi-ui: Fix usage of systemd unitdir vars
opkg: Fix usage of systemd unitdir vars
dpkg: Fix usage of systemd unitdir vars
systemd.bbclass: Remove user services too if systemd is not enabled
systemd: Remove usage of systemd_unitdir
bitbake.conf: Mark systemd_unitdir as deprecated to avoid future use

 meta/classes/rootfs-postcommands.bbclass           |  4 +-
 meta/classes/systemd.bbclass                       | 19 ++++--
 meta/conf/bitbake.conf                             |  3 +
 meta/recipes-bsp/acpid/acpid.inc                   |  6 +-
 meta/recipes-bsp/apmd/apmd_3.2.2-15.bb             |  6 +-
 meta/recipes-connectivity/avahi/avahi-ui_0.6.32.bb |  8 +--
 meta/recipes-connectivity/avahi/avahi.inc          |  2 +-
 meta/recipes-connectivity/bind/bind_9.10.3-P3.bb   |  6 +-
 meta/recipes-connectivity/bluez5/bluez5.inc        |  4 +-
 meta/recipes-connectivity/connman/connman.inc      |  6 +-
 meta/recipes-connectivity/dhcp/dhcp.inc            | 16 ++---
 meta/recipes-connectivity/neard/neard_0.15.bb      |  2 +-
 .../nfs-utils/nfs-utils_1.3.3.bb                   | 20 +++---
 meta/recipes-connectivity/ofono/ofono.inc          |  4 +-
 meta/recipes-connectivity/openssh/openssh_7.1p2.bb | 12 ++--
 meta/recipes-connectivity/portmap/portmap_6.0.bb   |  6 +-
 meta/recipes-connectivity/ppp/ppp_2.4.7.bb         |  8 +--
 .../wpa-supplicant/wpa-supplicant_2.5.bb           |  4 +-
 meta/recipes-core/busybox/busybox.inc              | 12 ++--
 meta/recipes-core/dropbear/dropbear.inc            | 10 +--
 meta/recipes-core/glibc/glibc-package.inc          |  6 +-
 meta/recipes-core/systemd/systemd-compat-units.bb  |  2 +-
 meta/recipes-core/systemd/systemd-serialgetty.bb   | 16 ++---
 meta/recipes-core/systemd/systemd_229.bb           | 72 +++++++++++-----------
 meta/recipes-core/util-linux/util-linux.inc        |  2 +-
 meta/recipes-core/volatile-binds/volatile-binds.bb |  6 +-
 meta/recipes-devtools/distcc/distcc_3.1.bb         |  8 +--
 meta/recipes-devtools/dpkg/dpkg.inc                |  7 +--
 meta/recipes-devtools/opkg/opkg_0.3.1.bb           |  9 ++-
 .../run-postinsts/run-postinsts_1.0.bb             |  6 +-
 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb   |  6 +-
 meta/recipes-extended/at/at_3.1.18.bb              |  6 +-
 meta/recipes-extended/cronie/cronie_1.5.0.bb       |  6 +-
 meta/recipes-extended/lighttpd/lighttpd_1.4.39.bb  |  6 +-
 meta/recipes-extended/rpcbind/rpcbind_0.2.3.bb     | 10 +--
 meta/recipes-extended/sysstat/sysstat.inc          |  6 +-
 meta/recipes-extended/xinetd/xinetd_2.3.15.bb      |  6 +-
 .../x11-common/xserver-nodm-init.bb                |  8 +--
 .../oprofile/oprofileui-server_git.bb              |  6 +-
 meta/recipes-multimedia/alsa/alsa-utils_1.1.0.bb   |  2 +-
 .../recipes-support/consolekit/consolekit_0.4.6.bb |  4 +-
 41 files changed, 182 insertions(+), 176 deletions(-)

--
2.7.1

#1 lore raw

PATCH 1/42 rootfs-postcommands: Fix usage of systemd unitdir vars

---
 meta/classes/rootfs-postcommands.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/classes/rootfs-postcommands.bbclass +2 -2
index e184667..d65e639 100644
@@ -153,8 +153,8 @@ postinst_enable_logging () {
 # Modify systemd default target
 #
 set_systemd_default_target () {
-	if [ -d ${IMAGE_ROOTFS}${sysconfdir}/systemd/system -a -e ${IMAGE_ROOTFS}${systemd_unitdir}/system/${SYSTEMD_DEFAULT_TARGET} ]; then
-		ln -sf ${systemd_unitdir}/system/${SYSTEMD_DEFAULT_TARGET} ${IMAGE_ROOTFS}${sysconfdir}/systemd/system/default.target
+	if [ -d ${IMAGE_ROOTFS}${sysconfdir}/systemd/system -a -e ${IMAGE_ROOTFS}${systemd_system_unitdir}/${SYSTEMD_DEFAULT_TARGET} ]; then
+		ln -sf ${systemd_system_unitdir}/${SYSTEMD_DEFAULT_TARGET} ${IMAGE_ROOTFS}${sysconfdir}/systemd/system/default.target
 	fi
 }
 
Signature · 1 line
2.7.1
#2 lore raw

PATCH 2/42 acpid: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-bsp/acpid/acpid.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-bsp/acpid/acpid.inc +3 -3
index 12ec19b..181f448 100644
@@ -24,7 +24,7 @@ do_install_append () {
 	install -d ${D}${sysconfdir}/acpi
 	install -d ${D}${sysconfdir}/acpi/events
 
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/acpid.service ${D}${systemd_unitdir}/system
-	sed -i -e 's,@SBINDIR@,${sbindir},g' ${D}${systemd_unitdir}/system/acpid.service
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/acpid.service ${D}${systemd_system_unitdir}
+	sed -i -e 's,@SBINDIR@,${sbindir},g' ${D}${systemd_system_unitdir}/acpid.service
 }
Signature · 1 line
2.7.1
#3 lore raw

PATCH 3/42 apmd: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-bsp/apmd/apmd_3.2.2-15.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-bsp/apmd/apmd_3.2.2-15.bb +3 -3
index 4ff6ad0..e66a553 100644
@@ -72,10 +72,10 @@ do_install() {
 	sed -e 's,/usr/sbin,${sbindir},g; s,/etc,${sysconfdir},g;' ${WORKDIR}/init > ${D}${sysconfdir}/init.d/apmd
 	chmod 755 ${D}${sysconfdir}/init.d/apmd
 
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/apmd.service ${D}${systemd_unitdir}/system/
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/apmd.service ${D}${systemd_system_unitdir}/
 	sed -i -e 's,@SYSCONFDIR@,${sysconfdir},g' \
-		-e 's,@SBINDIR@,${sbindir},g' ${D}${systemd_unitdir}/system/apmd.service
+		-e 's,@SBINDIR@,${sbindir},g' ${D}${systemd_system_unitdir}/apmd.service
 }
 
 PACKAGES =+ "libapm apm"
Signature · 1 line
2.7.1
#4 lore raw

PATCH 4/42 avahi: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/avahi/avahi.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/avahi/avahi.inc +1 -1
index 81aad79..aaccb75 100644
@@ -56,7 +56,7 @@ EXTRA_OECONF = "--with-avahi-priv-access-group=adm \
 
 # The distro choice determines what init scripts are installed
 EXTRA_OECONF_SYSVINIT = "${@bb.utils.contains('DISTRO_FEATURES','sysvinit','--with-distro=debian','--with-distro=none',d)}"
-EXTRA_OECONF_SYSTEMD = "${@bb.utils.contains('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=${systemd_unitdir}/system/','--without-systemdsystemunitdir',d)}"
+EXTRA_OECONF_SYSTEMD = "${@bb.utils.contains('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=${systemd_system_unitdir}/','--without-systemdsystemunitdir',d)}"
 
 AVAHI_GTK ?= "--disable-gtk --disable-gtk3"
 
Signature · 1 line
2.7.1
#5 lore raw

PATCH 5/42 bind: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/bind/bind_9.10.3-P3.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-connectivity/bind/bind_9.10.3-P3.bb +3 -3
index da414c0..d6309f6 100644
@@ -83,11 +83,11 @@ do_install_append() {
 	install -d ${D}${localstatedir}/cache/bind
 	install -d ${D}${sbindir}
 	install -m 755 ${WORKDIR}/generate-rndc-key.sh ${D}${sbindir}
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/named.service ${D}${systemd_unitdir}/system
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/named.service ${D}${systemd_system_unitdir}
 	sed -i -e 's,@BASE_BINDIR@,${base_bindir},g' \
 	       -e 's,@SBINDIR@,${sbindir},g' \
-	       ${D}${systemd_unitdir}/system/named.service
+	       ${D}${systemd_system_unitdir}/named.service
 
 	install -d ${D}${sysconfdir}/default
 	install -m 0644 ${WORKDIR}/bind9 ${D}${sysconfdir}/default
Signature · 1 line
2.7.1
#6 lore raw

PATCH 6/42 connman: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/connman/connman.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-connectivity/connman/connman.inc +3 -3
index c375251..539df7e 100644
@@ -43,7 +43,7 @@ PACKAGECONFIG ??= "wispr \
 # local.conf or distro config
 # PACKAGECONFIG_append_pn-connman = " openvpn vpnc l2tp pptp"
 
-PACKAGECONFIG[systemd] = "--with-systemdunitdir=${systemd_unitdir}/system/ --with-tmpfilesdir=${sysconfdir}/tmpfiles.d/,--with-systemdunitdir='' --with-tmpfilesdir=''"
+PACKAGECONFIG[systemd] = "--with-systemdunitdir=${systemd_system_unitdir}/ --with-tmpfilesdir=${sysconfdir}/tmpfiles.d/,--with-systemdunitdir='' --with-tmpfilesdir=''"
 PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant, wpa-supplicant"
 PACKAGECONFIG[bluez] = "--enable-bluetooth, --disable-bluetooth, ${BLUEZ}, ${BLUEZ}"
 PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono, ofono"
@@ -169,13 +169,13 @@ VPN technogies are implemented using plug-ins."
 FILES_${PN}-vpn += "${sbindir}/connman-vpnd \
                     ${sysconfdir}/dbus-1/system.d/connman-vpn-dbus.conf \
                     ${datadir}/dbus-1/system-services/net.connman.vpn.service \
-                    ${systemd_unitdir}/system/connman-vpn.service"
+                    ${systemd_system_unitdir}/connman-vpn.service"
 
 SUMMARY_${PN}-wait-online = "A program that will return once ConnMan has connected to a network"
 DESCRIPTION_${PN}-wait-online = "A service that can be enabled so that \
 the system waits until a network connection is established."
 FILES_${PN}-wait-online += "${sbindir}/connmand-wait-online \
-                            ${systemd_unitdir}/system/connman-wait-online.service"
+                            ${systemd_system_unitdir}/connman-wait-online.service"
 
 SUMMARY_${PN}-plugin-vpn-openvpn = "An OpenVPN plugin for ConnMan VPN"
 DESCRIPTION_${PN}-plugin-vpn-openvpn = "The ConnMan OpenVPN plugin uses openvpn client \
Signature · 1 line
2.7.1
#7 lore raw

PATCH 7/42 dhcp: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/dhcp/dhcp.inc | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
meta/recipes-connectivity/dhcp/dhcp.inc +8 -8
index 9c4233b..c57eb03 100644
@@ -62,14 +62,14 @@ do_install_append () {
 	install -m 0755 ${S}/client/scripts/linux ${D}${base_sbindir}/dhclient-script
 
 	# Install systemd unit files
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/dhcpd.service ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/dhcpd6.service ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/dhcrelay.service ${D}${systemd_unitdir}/system
-	sed -i -e 's,@SBINDIR@,${sbindir},g' ${D}${systemd_unitdir}/system/dhcpd*.service ${D}${systemd_unitdir}/system/dhcrelay.service
-	sed -i -e 's,@SYSCONFDIR@,${sysconfdir},g' ${D}${systemd_unitdir}/system/dhcpd*.service
-	sed -i -e 's,@base_bindir@,${base_bindir},g' ${D}${systemd_unitdir}/system/dhcpd*.service
-	sed -i -e 's,@localstatedir@,${localstatedir},g' ${D}${systemd_unitdir}/system/dhcpd*.service
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/dhcpd.service ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/dhcpd6.service ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/dhcrelay.service ${D}${systemd_system_unitdir}
+	sed -i -e 's,@SBINDIR@,${sbindir},g' ${D}${systemd_system_unitdir}/dhcpd*.service ${D}${systemd_system_unitdir}/dhcrelay.service
+	sed -i -e 's,@SYSCONFDIR@,${sysconfdir},g' ${D}${systemd_system_unitdir}/dhcpd*.service
+	sed -i -e 's,@base_bindir@,${base_bindir},g' ${D}${systemd_system_unitdir}/dhcpd*.service
+	sed -i -e 's,@localstatedir@,${localstatedir},g' ${D}${systemd_system_unitdir}/dhcpd*.service
 }
 
 PACKAGES += "dhcp-server dhcp-server-config dhcp-client dhcp-relay dhcp-omshell"
Signature · 1 line
2.7.1
#8 lore raw

PATCH 8/42 neard: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/neard/neard_0.15.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/neard/neard_0.15.bb +1 -1
index 93bddb3..be593fb 100644
@@ -21,7 +21,7 @@ inherit autotools pkgconfig systemd update-rc.d bluetooth
 
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)}"
 
-PACKAGECONFIG[systemd] = "--enable-systemd --with-systemdsystemunitdir=${systemd_unitdir}/system/ --with-systemduserunitdir=${systemd_unitdir}/user/,--disable-systemd"
+PACKAGECONFIG[systemd] = "--enable-systemd --with-systemdsystemunitdir=${systemd_system_unitdir}/ --with-systemduserunitdir=${systemd_user_unitdir}/,--disable-systemd"
 
 EXTRA_OECONF += "--enable-tools"
 
Signature · 1 line
2.7.1
#9 lore raw

PATCH 9/42 nfs-utils: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 .../nfs-utils/nfs-utils_1.3.3.bb                     | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb +10 -10
index a6268f3..c89fe3d 100644
@@ -86,11 +86,11 @@ FILES_${PN}-client = "${base_sbindir}/*mount.nfs* ${sbindir}/*statd \
 		      ${sysconfdir}/nfs-utils.conf \
 		      ${sysconfdir}/nfsmount.conf \
 		      ${sysconfdir}/init.d/nfscommon \
-		      ${systemd_unitdir}/system/nfs-statd.service"
+		      ${systemd_system_unitdir}/nfs-statd.service"
 FILES_${PN}-stats = "${sbindir}/mountstats ${sbindir}/nfsiostat"
 RDEPENDS_${PN}-stats = "python"
 
-FILES_${PN} += "${systemd_unitdir}"
+FILES_${PN} += "${systemd_system_unitdir}"
 
 do_configure_prepend() {
         sed -i -e 's,sbindir = /sbin,sbindir = ${base_sbindir},g' \
@@ -114,19 +114,19 @@ do_install_append () {
 	install -m 0755 ${WORKDIR}/nfs-utils.conf ${D}${sysconfdir}
 	install -m 0755 ${S}/utils/mount/nfsmount.conf ${D}${sysconfdir}
 
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/nfs-server.service ${D}${systemd_unitdir}/system/
-	install -m 0644 ${WORKDIR}/nfs-mountd.service ${D}${systemd_unitdir}/system/
-	install -m 0644 ${WORKDIR}/nfs-statd.service ${D}${systemd_unitdir}/system/
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/nfs-server.service ${D}${systemd_system_unitdir}/
+	install -m 0644 ${WORKDIR}/nfs-mountd.service ${D}${systemd_system_unitdir}/
+	install -m 0644 ${WORKDIR}/nfs-statd.service ${D}${systemd_system_unitdir}/
 	sed -i -e 's,@SBINDIR@,${sbindir},g' \
 		-e 's,@SYSCONFDIR@,${sysconfdir},g' \
-		${D}${systemd_unitdir}/system/*.service
+		${D}${systemd_system_unitdir}/*.service
 	if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
 	    install -d ${D}${sysconfdir}/modules-load.d
 	    echo "nfsd" > ${D}${sysconfdir}/modules-load.d/nfsd.conf
-	    install -m 0644 ${WORKDIR}/proc-fs-nfsd.mount ${D}${systemd_unitdir}/system/
-	    install -d ${D}${systemd_unitdir}/system/sysinit.target.wants/
-	    ln -sf ../proc-fs-nfsd.mount ${D}${systemd_unitdir}/system/sysinit.target.wants/proc-fs-nfsd.mount
+	    install -m 0644 ${WORKDIR}/proc-fs-nfsd.mount ${D}${systemd_system_unitdir}/
+	    install -d ${D}${systemd_system_unitdir}/sysinit.target.wants/
+	    ln -sf ../proc-fs-nfsd.mount ${D}${systemd_system_unitdir}/sysinit.target.wants/proc-fs-nfsd.mount
 	fi
 
 	# kernel code as of 3.8 hard-codes this path as a default
Signature · 1 line
2.7.1
#10 lore raw

PATCH 10/42 openssh: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/openssh/openssh_7.1p2.bb | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta/recipes-connectivity/openssh/openssh_7.1p2.bb +6 -6
index 3b5e28a..103f751 100644
@@ -114,14 +114,14 @@ do_install_append () {
 	echo "HostKey /var/run/ssh/ssh_host_dsa_key" >> ${D}${sysconfdir}/ssh/sshd_config_readonly
 	echo "HostKey /var/run/ssh/ssh_host_ecdsa_key" >> ${D}${sysconfdir}/ssh/sshd_config_readonly
 
-	install -d ${D}${systemd_unitdir}/system
-	install -c -m 0644 ${WORKDIR}/sshd.socket ${D}${systemd_unitdir}/system
-	install -c -m 0644 ${WORKDIR}/[email protected] ${D}${systemd_unitdir}/system
-	install -c -m 0644 ${WORKDIR}/sshdgenkeys.service ${D}${systemd_unitdir}/system
+	install -d ${D}${systemd_system_unitdir}
+	install -c -m 0644 ${WORKDIR}/sshd.socket ${D}${systemd_system_unitdir}
+	install -c -m 0644 ${WORKDIR}/[email protected] ${D}${systemd_system_unitdir}
+	install -c -m 0644 ${WORKDIR}/sshdgenkeys.service ${D}${systemd_system_unitdir}
 	sed -i -e 's,@BASE_BINDIR@,${base_bindir},g' \
 		-e 's,@SBINDIR@,${sbindir},g' \
 		-e 's,@BINDIR@,${bindir},g' \
-		${D}${systemd_unitdir}/system/sshd.socket ${D}${systemd_unitdir}/system/*.service
+		${D}${systemd_system_unitdir}/sshd.socket ${D}${systemd_system_unitdir}/*.service
 }
 
 do_install_ptest () {
@@ -134,7 +134,7 @@ ALLOW_EMPTY_${PN} = "1"
 PACKAGES =+ "${PN}-keygen ${PN}-scp ${PN}-ssh ${PN}-sshd ${PN}-sftp ${PN}-misc ${PN}-sftp-server"
 FILES_${PN}-scp = "${bindir}/scp.${BPN}"
 FILES_${PN}-ssh = "${bindir}/ssh.${BPN} ${sysconfdir}/ssh/ssh_config"
-FILES_${PN}-sshd = "${sbindir}/sshd ${sysconfdir}/init.d/sshd ${systemd_unitdir}/system"
+FILES_${PN}-sshd = "${sbindir}/sshd ${sysconfdir}/init.d/sshd ${systemd_system_unitdir}"
 FILES_${PN}-sshd += "${sysconfdir}/ssh/moduli ${sysconfdir}/ssh/sshd_config ${sysconfdir}/ssh/sshd_config_readonly ${sysconfdir}/default/volatiles/99_sshd ${sysconfdir}/pam.d/sshd"
 FILES_${PN}-sftp = "${bindir}/sftp"
 FILES_${PN}-sftp-server = "${libexecdir}/sftp-server"
Signature · 1 line
2.7.1
#11 lore raw

PATCH 11/42 portmap: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/portmap/portmap_6.0.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-connectivity/portmap/portmap_6.0.bb +3 -3
index 999b4a9..e1d3f1e 100644
@@ -29,7 +29,7 @@ do_install() {
     install -m 0755 ${WORKDIR}/portmap.init ${D}${sysconfdir}/init.d/portmap
     oe_runmake install DESTDIR=${D}
 
-    install -d ${D}${systemd_unitdir}/system
-    install -m 0644 ${WORKDIR}/portmap.service ${D}${systemd_unitdir}/system
-    sed -i -e 's,@BASE_SBINDIR@,${base_sbindir},g' ${D}${systemd_unitdir}/system/portmap.service
+    install -d ${D}${systemd_system_unitdir}
+    install -m 0644 ${WORKDIR}/portmap.service ${D}${systemd_system_unitdir}
+    sed -i -e 's,@BASE_SBINDIR@,${base_sbindir},g' ${D}${systemd_system_unitdir}/portmap.service
 }
Signature · 1 line
2.7.1
#12 lore raw

PATCH 12/42 ppp: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/ppp/ppp_2.4.7.bb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
meta/recipes-connectivity/ppp/ppp_2.4.7.bb +4 -4
index 4437b5c..5dab247 100644
@@ -70,17 +70,17 @@ do_install_append () {
 	install -m 0755 ${WORKDIR}/pap ${D}${sysconfdir}/chatscripts
 	install -m 0755 ${WORKDIR}/ppp_on_boot ${D}${sysconfdir}/ppp/ppp_on_boot
 	install -m 0755 ${WORKDIR}/provider ${D}${sysconfdir}/ppp/peers/provider
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/[email protected] ${D}${systemd_unitdir}/system
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/[email protected] ${D}${systemd_system_unitdir}
 	sed -i -e 's,@SBINDIR@,${sbindir},g' \
-	       ${D}${systemd_unitdir}/system/[email protected]
+	       ${D}${systemd_system_unitdir}/[email protected]
 	rm -rf ${D}/${mandir}/man8/man8
 	chmod u+s ${D}${sbindir}/pppd
 }
 
 CONFFILES_${PN} = "${sysconfdir}/ppp/pap-secrets ${sysconfdir}/ppp/chap-secrets ${sysconfdir}/ppp/options"
 PACKAGES =+ "${PN}-oa ${PN}-oe ${PN}-radius ${PN}-winbind ${PN}-minconn ${PN}-password ${PN}-l2tp ${PN}-tools"
-FILES_${PN}        = "${sysconfdir} ${bindir} ${sbindir}/chat ${sbindir}/pppd ${systemd_unitdir}/system/[email protected]"
+FILES_${PN}        = "${sysconfdir} ${bindir} ${sbindir}/chat ${sbindir}/pppd ${systemd_system_unitdir}/[email protected]"
 FILES_${PN}-oa       = "${libdir}/pppd/${PV}/pppoatm.so"
 FILES_${PN}-oe       = "${sbindir}/pppoe-discovery ${libdir}/pppd/${PV}/rp-pppoe.so"
 FILES_${PN}-radius   = "${libdir}/pppd/${PV}/radius.so ${libdir}/pppd/${PV}/radattr.so ${libdir}/pppd/${PV}/radrealms.so"
Signature · 1 line
2.7.1
#13 lore raw

PATCH 13/42 wpa-supplicant: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.5.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.5.bb +2 -2
index 935c8af..16ad53b 100644
@@ -91,8 +91,8 @@ do_install () {
 	install -m 644 ${S}/wpa_supplicant/dbus/*.service ${D}/${datadir}/dbus-1/system-services
 
 	if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
-		install -d ${D}/${systemd_unitdir}/system
-		install -m 644 ${S}/wpa_supplicant/systemd/*.service ${D}/${systemd_unitdir}/system
+		install -d ${D}/${systemd_system_unitdir}
+		install -m 644 ${S}/wpa_supplicant/systemd/*.service ${D}/${systemd_system_unitdir}
 	fi
 
 	install -d ${D}/etc/default/volatiles
Signature · 1 line
2.7.1
#14 lore raw

PATCH 14/42 busybox: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-core/busybox/busybox.inc | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta/recipes-core/busybox/busybox.inc +6 -6
index 5e91a26..bd8c6aa 100644
@@ -24,7 +24,7 @@ EXTRA_OEMAKE = "CC='${CC}' LD='${CCLD}' V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${
 PACKAGES =+ "${PN}-httpd ${PN}-udhcpd ${PN}-udhcpc ${PN}-syslog ${PN}-mdev ${PN}-hwclock"
 
 FILES_${PN}-httpd = "${sysconfdir}/init.d/busybox-httpd /srv/www"
-FILES_${PN}-syslog = "${sysconfdir}/init.d/syslog* ${sysconfdir}/syslog-startup.conf* ${sysconfdir}/syslog.conf* ${systemd_unitdir}/system/syslog.service ${sysconfdir}/default/busybox-syslog"
+FILES_${PN}-syslog = "${sysconfdir}/init.d/syslog* ${sysconfdir}/syslog-startup.conf* ${sysconfdir}/syslog.conf* ${systemd_system_unitdir}/syslog.service ${sysconfdir}/default/busybox-syslog"
 FILES_${PN}-mdev = "${sysconfdir}/init.d/mdev ${sysconfdir}/mdev.conf ${sysconfdir}/mdev/*"
 FILES_${PN}-udhcpd = "${sysconfdir}/init.d/busybox-udhcpd"
 FILES_${PN}-udhcpc = "${sysconfdir}/udhcpc.d ${datadir}/udhcpc"
@@ -294,19 +294,19 @@ do_install () {
 
     if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
         if grep -q "CONFIG_SYSLOGD=y" ${B}/.config; then
-            install -d ${D}${systemd_unitdir}/system
+            install -d ${D}${systemd_system_unitdir}
             sed 's,@base_sbindir@,${base_sbindir},g' < ${WORKDIR}/busybox-syslog.service.in \
-		> ${D}${systemd_unitdir}/system/busybox-syslog.service
+		> ${D}${systemd_system_unitdir}/busybox-syslog.service
             if [ -f ${WORKDIR}/busybox-syslog.default ] ; then
 		install -d ${D}${sysconfdir}/default
 		install -m 0644 ${WORKDIR}/busybox-syslog.default ${D}${sysconfdir}/default/busybox-syslog
             fi
-            ln -sf /dev/null ${D}${systemd_unitdir}/system/syslog.service
+            ln -sf /dev/null ${D}${systemd_system_unitdir}/syslog.service
         fi
         if grep -q "CONFIG_KLOGD=y" ${B}/.config; then
-            install -d ${D}${systemd_unitdir}/system
+            install -d ${D}${systemd_system_unitdir}
             sed 's,@base_sbindir@,${base_sbindir},g' < ${WORKDIR}/busybox-klogd.service.in \
-		> ${D}${systemd_unitdir}/system/busybox-klogd.service
+		> ${D}${systemd_system_unitdir}/busybox-klogd.service
         fi
     fi
 
Signature · 1 line
2.7.1
#15 lore raw

PATCH 15/42 dropbear: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-core/dropbear/dropbear.inc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
meta/recipes-core/dropbear/dropbear.inc +5 -5
index 1dce2a5..a34125c 100644
@@ -76,14 +76,14 @@ do_install() {
 	fi
 
 	# deal with systemd unit files
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/dropbearkey.service ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/[email protected] ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/dropbear.socket ${D}${systemd_unitdir}/system
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/dropbearkey.service ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/[email protected] ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/dropbear.socket ${D}${systemd_system_unitdir}
 	sed -i -e 's,@BASE_BINDIR@,${base_bindir},g' \
 		-e 's,@BINDIR@,${bindir},g' \
 		-e 's,@SBINDIR@,${sbindir},g' \
-		${D}${systemd_unitdir}/system/dropbear.socket ${D}${systemd_unitdir}/system/*.service
+		${D}${systemd_system_unitdir}/dropbear.socket ${D}${systemd_system_unitdir}/*.service
 }
 
 inherit update-alternatives
Signature · 1 line
2.7.1
#16 lore raw

PATCH 16/42 glibc-package: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-core/glibc/glibc-package.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-core/glibc/glibc-package.inc +3 -3
index bad6424..e2644a9 100644
@@ -49,7 +49,7 @@ FILES_libsotruss = "${libdir}/audit/sotruss-lib.so"
 FILES_SOLIBSDEV = "${libdir}/lib*${SOLIBSDEV}"
 FILES_${PN}-dev += "${bindir}/rpcgen ${libdir}/*_nonshared.a ${base_libdir}/*_nonshared.a ${base_libdir}/*.o ${datadir}/aclocal"
 FILES_${PN}-staticdev += "${libdir}/*.a ${base_libdir}/*.a"
-FILES_nscd = "${sbindir}/nscd* ${sysconfdir}/init.d/nscd ${systemd_unitdir}/system/nscd* ${sysconfdir}/tmpfiles.d/nscd.conf \
+FILES_nscd = "${sbindir}/nscd* ${sysconfdir}/init.d/nscd ${systemd_system_unitdir}/nscd* ${sysconfdir}/tmpfiles.d/nscd.conf \
               ${sysconfdir}/nscd.conf ${sysconfdir}/default/volatiles/98_nscd ${localstatedir}/db/nscd"
 FILES_${PN}-mtrace = "${bindir}/mtrace"
 FILES_tzcode = "${bindir}/tzselect ${sbindir}/zic ${sbindir}/zdump"
@@ -117,8 +117,8 @@ do_install_append () {
 	install -m 0755 ${S}/nscd/nscd.conf ${D}${sysconfdir}/nscd.conf
 	sed -i "s%daemon%start-stop-daemon --start --exec%g" ${D}${sysconfdir}/init.d/nscd
 
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${S}/nscd/nscd.service ${D}${systemd_unitdir}/system/
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${S}/nscd/nscd.service ${D}${systemd_system_unitdir}/
 
 	if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}; then
 		install -d ${D}${sysconfdir}/tmpfiles.d
Signature · 1 line
2.7.1
#17 lore raw

PATCH 17/42 systemd-compat-units: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-core/systemd/systemd-compat-units.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/systemd/systemd-compat-units.bb +1 -1
index 0b8ff09..9ff3237 100644
@@ -34,7 +34,7 @@ pkg_postinst_${PN} () {
 	fi
 
 	for i in ${SYSTEMD_DISABLED_SYSV_SERVICES} ; do
-		if [ \( -e $i -o $i.sh \) -a ! \( -e $D${sysconfdir}/systemd/system/$i.service -o  -e $D${systemd_unitdir}/system/$i.service \) ] ; then
+		if [ \( -e $i -o $i.sh \) -a ! \( -e $D${sysconfdir}/systemd/system/$i.service -o  -e $D${systemd_system_unitdir}/$i.service \) ] ; then
 			echo -n "$i: " ; systemctl ${OPTS} mask $i.service
 		fi
 	done ; echo
Signature · 1 line
2.7.1
#18 lore raw

PATCH 18/42 systemd-serialgetty: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-core/systemd/systemd-serialgetty.bb | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
meta/recipes-core/systemd/systemd-serialgetty.bb +8 -8
index 768b130..b57f0f3 100644
@@ -13,10 +13,10 @@ S = "${WORKDIR}"
 do_install() {
 	if [ ! -z "${SERIAL_CONSOLES}" ] ; then
 		default_baudrate=`echo "${SERIAL_CONSOLES}" | sed 's/\;.*//'`
-		install -d ${D}${systemd_unitdir}/system/
+		install -d ${D}${systemd_system_unitdir}/
 		install -d ${D}${sysconfdir}/systemd/system/getty.target.wants/
-		install -m 0644 ${WORKDIR}/[email protected] ${D}${systemd_unitdir}/system/
-		sed -i -e s/\@BAUDRATE\@/$default_baudrate/g ${D}${systemd_unitdir}/system/[email protected]
+		install -m 0644 ${WORKDIR}/[email protected] ${D}${systemd_system_unitdir}/
+		sed -i -e s/\@BAUDRATE\@/$default_baudrate/g ${D}${systemd_system_unitdir}/[email protected]
 
 		tmp="${SERIAL_CONSOLES}"
 		for entry in $tmp ; do
@@ -24,14 +24,14 @@ do_install() {
 			ttydev=`echo $entry | sed -e 's/^[0-9]*\;//' -e 's/\;.*//'`
 			if [ "$baudrate" = "$default_baudrate" ] ; then
 				# enable the service
-				ln -sf ${systemd_unitdir}/system/[email protected] \
+				ln -sf ${systemd_system_unitdir}/[email protected] \
 					${D}${sysconfdir}/systemd/system/getty.target.wants/serial-getty@$ttydev.service
 			else
 				# install custom service file for the non-default baudrate
-				install -m 0644 ${WORKDIR}/[email protected] ${D}${systemd_unitdir}/system/[email protected]
-				sed -i -e s/\@BAUDRATE\@/$baudrate/g ${D}${systemd_unitdir}/system/[email protected]
+				install -m 0644 ${WORKDIR}/[email protected] ${D}${systemd_system_unitdir}/[email protected]
+				sed -i -e s/\@BAUDRATE\@/$baudrate/g ${D}${systemd_system_unitdir}/[email protected]
 				# enable the service
-				ln -sf ${systemd_unitdir}/system/[email protected] \
+				ln -sf ${systemd_system_unitdir}/[email protected] \
 					${D}${sysconfdir}/systemd/system/getty.target.wants/serial-getty$baudrate@$ttydev.service
 			fi
 		done
@@ -41,7 +41,7 @@ do_install() {
 RDEPENDS_${PN} = "systemd"
 
 # This is a machine specific file
-FILES_${PN} = "${systemd_unitdir}/system/*.service ${sysconfdir}"
+FILES_${PN} = "${systemd_system_unitdir}/*.service ${sysconfdir}"
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
 # As this package is tied to systemd, only build it when we're also building systemd.
Signature · 1 line
2.7.1
#19 lore raw

PATCH 19/42 systemd: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-core/systemd/systemd_229.bb | 68 ++++++++++++++++----------------
 1 file changed, 34 insertions(+), 34 deletions(-)
meta/recipes-core/systemd/systemd_229.bb +34 -34
index ae88c89..fcb22a3 100644
@@ -203,7 +203,7 @@ do_install() {
 	autotools_do_install
 	install -d ${D}/${base_sbindir}
 	# Provided by a separate recipe
-	rm ${D}${systemd_unitdir}/system/serial-getty* -f
+	rm ${D}${systemd_system_unitdir}/serial-getty* -f
 
 	# Provide support for initramfs
 	[ ! -e ${D}/init ] && ln -s ${rootlibexecdir}/systemd/systemd ${D}/init
@@ -231,19 +231,19 @@ do_install() {
         # Delete journal README, as log can be symlinked inside volatile.
         rm -f ${D}/${localstatedir}/log/README
 
-	install -d ${D}${systemd_unitdir}/system/graphical.target.wants
-	install -d ${D}${systemd_unitdir}/system/multi-user.target.wants
-	install -d ${D}${systemd_unitdir}/system/poweroff.target.wants
-	install -d ${D}${systemd_unitdir}/system/reboot.target.wants
-	install -d ${D}${systemd_unitdir}/system/rescue.target.wants
+	install -d ${D}${systemd_system_unitdir}/graphical.target.wants
+	install -d ${D}${systemd_system_unitdir}/multi-user.target.wants
+	install -d ${D}${systemd_system_unitdir}/poweroff.target.wants
+	install -d ${D}${systemd_system_unitdir}/reboot.target.wants
+	install -d ${D}${systemd_system_unitdir}/rescue.target.wants
 
 	# Create symlinks for systemd-update-utmp-runlevel.service
 	if ${@bb.utils.contains('PACKAGECONFIG', 'utmp', 'true', 'false', d)}; then
-		ln -sf ../systemd-update-utmp-runlevel.service ${D}${systemd_unitdir}/system/graphical.target.wants/systemd-update-utmp-runlevel.service
-		ln -sf ../systemd-update-utmp-runlevel.service ${D}${systemd_unitdir}/system/multi-user.target.wants/systemd-update-utmp-runlevel.service
-		ln -sf ../systemd-update-utmp-runlevel.service ${D}${systemd_unitdir}/system/poweroff.target.wants/systemd-update-utmp-runlevel.service
-		ln -sf ../systemd-update-utmp-runlevel.service ${D}${systemd_unitdir}/system/reboot.target.wants/systemd-update-utmp-runlevel.service
-		ln -sf ../systemd-update-utmp-runlevel.service ${D}${systemd_unitdir}/system/rescue.target.wants/systemd-update-utmp-runlevel.service
+		ln -sf ../systemd-update-utmp-runlevel.service ${D}${systemd_system_unitdir}/graphical.target.wants/systemd-update-utmp-runlevel.service
+		ln -sf ../systemd-update-utmp-runlevel.service ${D}${systemd_system_unitdir}/multi-user.target.wants/systemd-update-utmp-runlevel.service
+		ln -sf ../systemd-update-utmp-runlevel.service ${D}${systemd_system_unitdir}/poweroff.target.wants/systemd-update-utmp-runlevel.service
+		ln -sf ../systemd-update-utmp-runlevel.service ${D}${systemd_system_unitdir}/reboot.target.wants/systemd-update-utmp-runlevel.service
+		ln -sf ../systemd-update-utmp-runlevel.service ${D}${systemd_system_unitdir}/rescue.target.wants/systemd-update-utmp-runlevel.service
 	fi
 
 	# Enable journal to forward message to syslog daemon
@@ -318,8 +318,8 @@ FILES_${PN}-ptest += "${libdir}/udev/rules.d"
 FILES_${PN}-gui = "${bindir}/systemadm"
 
 FILES_${PN}-vconsole-setup = "${rootlibexecdir}/systemd/systemd-vconsole-setup \
-                              ${systemd_unitdir}/system/systemd-vconsole-setup.service \
-                              ${systemd_unitdir}/system/sysinit.target.wants/systemd-vconsole-setup.service"
+                              ${systemd_system_unitdir}/systemd-vconsole-setup.service \
+                              ${systemd_system_unitdir}/sysinit.target.wants/systemd-vconsole-setup.service"
 
 RDEPENDS_${PN}-kernel-install += "bash"
 FILES_${PN}-kernel-install = "${bindir}/kernel-install \
@@ -336,8 +336,8 @@ FILES_${PN}-zsh-completion = "${datadir}/zsh/site-functions"
 FILES_${PN}-binfmt = "${sysconfdir}/binfmt.d/ \
                       ${exec_prefix}/lib/binfmt.d \
                       ${rootlibexecdir}/systemd/systemd-binfmt \
-                      ${systemd_unitdir}/system/proc-sys-fs-binfmt_misc.* \
-                      ${systemd_unitdir}/system/systemd-binfmt.service"
+                      ${systemd_system_unitdir}/proc-sys-fs-binfmt_misc.* \
+                      ${systemd_system_unitdir}/systemd-binfmt.service"
 RRECOMMENDS_${PN}-binfmt = "kernel-module-binfmt-misc"
 
 RRECOMMENDS_${PN}-vconsole-setup = "kbd kbd-consolefonts kbd-keymaps"
@@ -355,34 +355,34 @@ FILES_${PN}-extra-utils = "\
                         ${bindir}/systemd-stdio-bridge \
                         ${base_bindir}/systemd-ask-password \
                         ${base_bindir}/systemd-tty-ask-password-agent \
-                        ${systemd_unitdir}/system/systemd-ask-password-console.path \
-                        ${systemd_unitdir}/system/systemd-ask-password-console.service \
-                        ${systemd_unitdir}/system/systemd-ask-password-wall.path \
-                        ${systemd_unitdir}/system/systemd-ask-password-wall.service \
-                        ${systemd_unitdir}/system/sysinit.target.wants/systemd-ask-password-console.path \
-                        ${systemd_unitdir}/system/sysinit.target.wants/systemd-ask-password-wall.path \
-                        ${systemd_unitdir}/system/multi-user.target.wants/systemd-ask-password-wall.path \
+                        ${systemd_system_unitdir}/systemd-ask-password-console.path \
+                        ${systemd_system_unitdir}/systemd-ask-password-console.service \
+                        ${systemd_system_unitdir}/systemd-ask-password-wall.path \
+                        ${systemd_system_unitdir}/systemd-ask-password-wall.service \
+                        ${systemd_system_unitdir}/sysinit.target.wants/systemd-ask-password-console.path \
+                        ${systemd_system_unitdir}/sysinit.target.wants/systemd-ask-password-wall.path \
+                        ${systemd_system_unitdir}/multi-user.target.wants/systemd-ask-password-wall.path \
                         ${rootlibexecdir}/systemd/systemd-resolve-host \
                         ${rootlibexecdir}/systemd/systemd-ac-power \
                         ${rootlibexecdir}/systemd/systemd-activate \
                         ${bindir}/systemd-nspawn \
                         ${exec_prefix}/lib/tmpfiles.d/systemd-nspawn.conf \
-                        ${systemd_unitdir}/system/[email protected] \
+                        ${systemd_system_unitdir}/[email protected] \
                         ${rootlibexecdir}/systemd/systemd-bus-proxyd \
-                        ${systemd_unitdir}/system/systemd-bus-proxyd.service \
-                        ${systemd_unitdir}/system/systemd-bus-proxyd.socket \
+                        ${systemd_system_unitdir}/systemd-bus-proxyd.service \
+                        ${systemd_system_unitdir}/systemd-bus-proxyd.socket \
                         ${rootlibexecdir}/systemd/systemd-socket-proxyd \
                         ${rootlibexecdir}/systemd/systemd-reply-password \
                         ${rootlibexecdir}/systemd/systemd-sleep \
                         ${rootlibexecdir}/systemd/system-sleep \
-                        ${systemd_unitdir}/system/systemd-hibernate.service \
-                        ${systemd_unitdir}/system/systemd-hybrid-sleep.service \
-                        ${systemd_unitdir}/system/systemd-suspend.service \
-                        ${systemd_unitdir}/system/sleep.target \
+                        ${systemd_system_unitdir}/systemd-hibernate.service \
+                        ${systemd_system_unitdir}/systemd-hybrid-sleep.service \
+                        ${systemd_system_unitdir}/systemd-suspend.service \
+                        ${systemd_system_unitdir}/sleep.target \
                         ${rootlibexecdir}/systemd/systemd-initctl \
-                        ${systemd_unitdir}/system/systemd-initctl.service \
-                        ${systemd_unitdir}/system/systemd-initctl.socket \
-                        ${systemd_unitdir}/system/sockets.target.wants/systemd-initctl.socket \
+                        ${systemd_system_unitdir}/systemd-initctl.service \
+                        ${systemd_system_unitdir}/systemd-initctl.socket \
+                        ${systemd_system_unitdir}/sockets.target.wants/systemd-initctl.socket \
                         ${rootlibexecdir}/systemd/system-generators/systemd-gpt-auto-generator \
                         ${rootlibexecdir}/systemd/systemd-cgroups-agent \
 "
@@ -472,8 +472,8 @@ FILES_udev += "${base_sbindir}/udevd \
                ${rootlibexecdir}/udev/rules.d/*.rules \
                ${sysconfdir}/udev \
                ${sysconfdir}/init.d/systemd-udevd \
-               ${systemd_unitdir}/system/*udev* \
-               ${systemd_unitdir}/system/*.wants/*udev* \
+               ${systemd_system_unitdir}/*udev* \
+               ${systemd_system_unitdir}/*.wants/*udev* \
                ${base_bindir}/udevadm \
                ${datadir}/bash-completion/completions/udevadm \
               "
Signature · 1 line
2.7.1
#20 lore raw

PATCH 20/42 util-linux: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-core/util-linux/util-linux.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/util-linux/util-linux.inc +1 -1
index 08ca040..f3c5685 100644
@@ -54,7 +54,7 @@ PACKAGECONFIG_class-target ?= "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'p
 PACKAGECONFIG[pam] = "--enable-su --enable-runuser,--disable-su --disable-runuser, libpam,"
 
 # Respect the systemd feature for uuidd
-PACKAGECONFIG[systemd] = "--with-systemd --with-systemdsystemunitdir=${systemd_unitdir}/system/, --without-systemd --without-systemdsystemunitdir,systemd"
+PACKAGECONFIG[systemd] = "--with-systemd --with-systemdsystemunitdir=${systemd_system_unitdir}/, --without-systemd --without-systemdsystemunitdir,systemd"
 
 # Build setpriv requires libcap-ng
 PACKAGECONFIG[libcap-ng] = "--enable-setpriv,--disable-setpriv,libcap-ng,"
Signature · 1 line
2.7.1
#21 lore raw

PATCH 21/42 volatile-binds: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-core/volatile-binds/volatile-binds.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-core/volatile-binds/volatile-binds.bb +3 -3
index fee7275..e5fec95 100644
@@ -32,7 +32,7 @@ def volatile_systemd_services(d):
 
 SYSTEMD_SERVICE_${PN} = "${@volatile_systemd_services(d)}"
 
-FILES_${PN} += "${systemd_unitdir}/system/*.service"
+FILES_${PN} += "${systemd_system_unitdir}/*.service"
 
 do_compile () {
     while read spec mountpoint; do
@@ -63,9 +63,9 @@ do_install () {
     install -d ${D}${base_sbindir}
     install -m 0755 mount-copybind ${D}${base_sbindir}/
 
-    install -d ${D}${systemd_unitdir}/system
+    install -d ${D}${systemd_system_unitdir}
     for service in ${SYSTEMD_SERVICE_volatile-binds}; do
-        install -m 0644 $service ${D}${systemd_unitdir}/system/
+        install -m 0644 $service ${D}${systemd_system_unitdir}/
     done
 }
 do_install[dirs] = "${WORKDIR}"
Signature · 1 line
2.7.1
#22 lore raw

PATCH 22/42 distcc: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-devtools/distcc/distcc_3.1.bb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
meta/recipes-devtools/distcc/distcc_3.1.bb +4 -4
index f8879c8..e7b9e26 100644
@@ -48,9 +48,9 @@ do_install_append() {
     install -d ${D}${sysconfdir}/default
     install -m 0755 ${WORKDIR}/distcc ${D}${sysconfdir}/init.d/
     install -m 0755 ${WORKDIR}/default ${D}${sysconfdir}/default/distcc
-    install -d ${D}${systemd_unitdir}/system/
-    install -m 0644 ${WORKDIR}/distcc.service ${D}${systemd_unitdir}/system
-    sed -i -e 's,@BINDIR@,${bindir},g' ${D}${systemd_unitdir}/system/distcc.service
+    install -d ${D}${systemd_system_unitdir}/
+    install -m 0644 ${WORKDIR}/distcc.service ${D}${systemd_system_unitdir}
+    sed -i -e 's,@BINDIR@,${bindir},g' ${D}${systemd_system_unitdir}/distcc.service
     ${DESKTOPINSTALL}
 }
 DESKTOPINSTALL = ""
@@ -65,7 +65,7 @@ FILES_${PN} = " ${sysconfdir} \
     ${bindir}/lsdistcc \
 		${bindir}/distccd \
 		${bindir}/distccmon-text \
-		${systemd_unitdir}/system/distcc.service"
+		${systemd_system_unitdir}/distcc.service"
 FILES_distcc-distmon-gnome = "  ${bindir}/distccmon-gnome \
 				${datadir}/distcc"
 
Signature · 1 line
2.7.1
#23 lore raw

PATCH 23/42 run-postints: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-devtools/run-postinsts/run-postinsts_1.0.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-devtools/run-postinsts/run-postinsts_1.0.bb +3 -3
index 11c94e5..4860d9c 100644
@@ -33,13 +33,13 @@ do_install() {
 	install -d ${D}${sysconfdir}/init.d/
 	install -m 0755 ${WORKDIR}/run-postinsts.init ${D}${sysconfdir}/init.d/run-postinsts
 
-	install -d ${D}${systemd_unitdir}/system/
-	install -m 0644 ${WORKDIR}/run-postinsts.service ${D}${systemd_unitdir}/system/
+	install -d ${D}${systemd_system_unitdir}/
+	install -m 0644 ${WORKDIR}/run-postinsts.service ${D}${systemd_system_unitdir}/
 
 	sed -i -e 's:#SYSCONFDIR#:${sysconfdir}:g' \
                -e 's:#SBINDIR#:${sbindir}:g' \
                -e 's:#BASE_BINDIR#:${base_bindir}:g' \
                -e 's:#LOCALSTATEDIR#:${localstatedir}:g' \
                ${D}${sbindir}/run-postinsts \
-               ${D}${systemd_unitdir}/system/run-postinsts.service
+               ${D}${systemd_system_unitdir}/run-postinsts.service
 }
Signature · 1 line
2.7.1
#24 lore raw

PATCH 24/42 tcf-agent: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-devtools/tcf-agent/tcf-agent_git.bb +3 -3
index ab2fcd7..5438d62 100644
@@ -45,8 +45,8 @@ do_install() {
 	oe_runmake install INSTALLROOT=${D}
 	install -d ${D}${sysconfdir}/init.d/
 	install -m 0755 ${WORKDIR}/tcf-agent.init ${D}${sysconfdir}/init.d/tcf-agent
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/tcf-agent.service ${D}${systemd_unitdir}/system
-	sed -i -e 's,@SBINDIR@,${sbindir},g' ${D}${systemd_unitdir}/system/tcf-agent.service
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/tcf-agent.service ${D}${systemd_system_unitdir}
+	sed -i -e 's,@SBINDIR@,${sbindir},g' ${D}${systemd_system_unitdir}/tcf-agent.service
 }
 
Signature · 1 line
2.7.1
#25 lore raw

PATCH 25/42 at: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-extended/at/at_3.1.18.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-extended/at/at_3.1.18.bb +3 -3
index e83ea32..d7f99c5 100644
@@ -59,9 +59,9 @@ do_install () {
 	install -m 0755    ${WORKDIR}/atd.init		${D}${sysconfdir}/init.d/atd
 
 	# install systemd unit files
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/atd.service ${D}${systemd_unitdir}/system
-	sed -i -e 's,@SBINDIR@,${sbindir},g' ${D}${systemd_unitdir}/system/atd.service
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/atd.service ${D}${systemd_system_unitdir}
+	sed -i -e 's,@SBINDIR@,${sbindir},g' ${D}${systemd_system_unitdir}/atd.service
 
 	if [ "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}" = "pam" ]; then
 		install -D -m 0644 ${WORKDIR}/${BP}/pam.conf ${D}${sysconfdir}/pam.d/atd
Signature · 1 line
2.7.1
#26 lore raw

PATCH 26/42 cronie: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-extended/cronie/cronie_1.5.0.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-extended/cronie/cronie_1.5.0.bb +3 -3
index 697501a..54eabf3 100644
@@ -48,11 +48,11 @@ do_install_append () {
 	install -m 0755 ${WORKDIR}/crond.init ${D}${sysconfdir}/init.d/crond
 
 	# install systemd unit files
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/crond.service ${D}${systemd_unitdir}/system
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/crond.service ${D}${systemd_system_unitdir}
 	sed -i -e 's,@BASE_BINDIR@,${base_bindir},g' \
 	       -e 's,@SBINDIR@,${sbindir},g' \
-	       ${D}${systemd_unitdir}/system/crond.service
+	       ${D}${systemd_system_unitdir}/crond.service
 
 	# below are necessary for a complete cron environment
 	install -d ${D}${localstatedir}/spool/cron
Signature · 1 line
2.7.1
#27 lore raw

PATCH 27/42 lighttpd: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-extended/lighttpd/lighttpd_1.4.39.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-extended/lighttpd/lighttpd_1.4.39.bb +3 -3
index a407d03..ca88b75 100644
@@ -54,12 +54,12 @@ do_install_append() {
 	install -m 0644 ${WORKDIR}/lighttpd.conf ${D}${sysconfdir}
 	install -m 0644 ${WORKDIR}/index.html.lighttpd ${D}/www/pages/index.html
 
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/lighttpd.service ${D}${systemd_unitdir}/system
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/lighttpd.service ${D}${systemd_system_unitdir}
 	sed -i -e 's,@SBINDIR@,${sbindir},g' \
 		-e 's,@SYSCONFDIR@,${sysconfdir},g' \
 		-e 's,@BASE_BINDIR@,${base_bindir},g' \
-		${D}${systemd_unitdir}/system/lighttpd.service
+		${D}${systemd_system_unitdir}/lighttpd.service
 	#For FHS compliance, create symbolic links to /var/log and /var/tmp for logs and temporary data
 	ln -sf ${localstatedir}/log ${D}/www/logs
 	ln -sf ${localstatedir}/tmp ${D}/www/var
Signature · 1 line
2.7.1
#28 lore raw

PATCH 28/42 rpcbind: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-extended/rpcbind/rpcbind_0.2.3.bb | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
meta/recipes-extended/rpcbind/rpcbind_0.2.3.bb +5 -5
index c19a197..0afec6d 100644
@@ -47,7 +47,7 @@ USERADD_PARAM_${PN} = "--system --no-create-home --home-dir / \
                        --shell /bin/false --user-group rpc"
 
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)}"
-PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_unitdir}/system/, \
+PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir}/, \
                           --without-systemdsystemunitdir, \
                           systemd \
 "
@@ -64,10 +64,10 @@ do_install_append () {
 	chmod 0755 ${D}${sysconfdir}/init.d/rpcbind
 
 	install -m 0755 ${WORKDIR}/rpcbind.conf ${D}${sysconfdir}
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/rpcbind.socket ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/rpcbind.service ${D}${systemd_unitdir}/system
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/rpcbind.socket ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/rpcbind.service ${D}${systemd_system_unitdir}
 	sed -i -e 's,@SBINDIR@,${sbindir},g' \
 		-e 's,@SYSCONFDIR@,${sysconfdir},g' \
-		${D}${systemd_unitdir}/system/rpcbind.service
+		${D}${systemd_system_unitdir}/rpcbind.service
 }
Signature · 1 line
2.7.1
#29 lore raw

PATCH 29/42 sysstat: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-extended/sysstat/sysstat.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-extended/sysstat/sysstat.inc +3 -3
index c353291..9e0e0cb 100644
@@ -36,9 +36,9 @@ do_install() {
 	install -d ${D}/etc/default/volatiles
 	install -m 0644 ${WORKDIR}/99_sysstat ${D}/etc/default/volatiles
 
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/sysstat.service ${D}${systemd_unitdir}/system
-	sed -i -e 's#@LIBDIR@#${libdir}#g' ${D}${systemd_unitdir}/system/sysstat.service
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/sysstat.service ${D}${systemd_system_unitdir}
+	sed -i -e 's#@LIBDIR@#${libdir}#g' ${D}${systemd_system_unitdir}/sysstat.service
 }
 
 pkg_postinst_${PN} () {
Signature · 1 line
2.7.1
#30 lore raw

PATCH 30/42 xinetd: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-extended/xinetd/xinetd_2.3.15.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-extended/xinetd/xinetd_2.3.15.bb +3 -3
index 6bfaabe..98d66d3 100644
@@ -67,11 +67,11 @@ do_install() {
 	install -m 664 ${S}/contrib/xinetd.d/* ${D}${sysconfdir}/xinetd.d
 
 	# Install systemd unit files
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/xinetd.service ${D}${systemd_unitdir}/system
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/xinetd.service ${D}${systemd_system_unitdir}
 	sed -i -e 's,@BASE_BINDIR@,${base_bindir},g' \
 	       -e 's,@SBINDIR@,${sbindir},g' \
-	       ${D}${systemd_unitdir}/system/xinetd.service
+	       ${D}${systemd_system_unitdir}/xinetd.service
 }
 
 CONFFILES_${PN} = "${sysconfdir}/xinetd.conf"
Signature · 1 line
2.7.1
#31 lore raw

PATCH 31/42 xserver-nodm-init: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-graphics/x11-common/xserver-nodm-init.bb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
meta/recipes-graphics/x11-common/xserver-nodm-init.bb +4 -4
index b68d40e..650ebe0 100644
@@ -25,14 +25,14 @@ do_install() {
     if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
         install -d ${D}${sysconfdir}/default
         install xserver-nodm.conf ${D}${sysconfdir}/default/xserver-nodm
-        install -d ${D}${systemd_unitdir}/system
-        install -m 0644 ${WORKDIR}/xserver-nodm.service ${D}${systemd_unitdir}/system
+        install -d ${D}${systemd_system_unitdir}
+        install -m 0644 ${WORKDIR}/xserver-nodm.service ${D}${systemd_system_unitdir}
         if [ "${ROOTLESS_X}" = "1" ] ; then
             sed -i 's!^HOME=.*!HOME=/home/xuser!' ${D}${sysconfdir}/default/xserver-nodm
-            sed -i 's!^User=.*!User=xuser!' ${D}${systemd_unitdir}/system/xserver-nodm.service
+            sed -i 's!^User=.*!User=xuser!' ${D}${systemd_system_unitdir}/xserver-nodm.service
         else
             sed -i 's!^HOME=.*!HOME=${ROOT_HOME}!' ${D}${sysconfdir}/default/xserver-nodm
-            sed -i '/^User=/d' ${D}${systemd_unitdir}/system/xserver-nodm.service
+            sed -i '/^User=/d' ${D}${systemd_system_unitdir}/xserver-nodm.service
         fi
     fi
 
Signature · 1 line
2.7.1
#32 lore raw

PATCH 32/42 oprofileui-server: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-kernel/oprofile/oprofileui-server_git.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-kernel/oprofile/oprofileui-server_git.bb +3 -3
index cc3477b..e1a153b 100644
@@ -19,10 +19,10 @@ do_install_append() {
 	install -d ${D}${sysconfdir}/init.d
 	install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/oprofileui-server
 
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/oprofileui-server.service ${D}${systemd_unitdir}/system/
+	install -d ${D}${systemd_system_unitdir}
+	install -m 0644 ${WORKDIR}/oprofileui-server.service ${D}${systemd_system_unitdir}/
 	sed -i -e 's,@SYSCONFDIR@,${sysconfdir},g' \
-		-e 's,@BINDIR@,${bindir},g' ${D}${systemd_unitdir}/system/oprofileui-server.service
+		-e 's,@BINDIR@,${bindir},g' ${D}${systemd_system_unitdir}/oprofileui-server.service
 }
 
 inherit update-rc.d systemd
Signature · 1 line
2.7.1
#33 lore raw

PATCH 33/42 consolekit: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-support/consolekit/consolekit_0.4.6.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-support/consolekit/consolekit_0.4.6.bb +2 -2
index 2974e36..1ae054c 100644
@@ -28,10 +28,10 @@ PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}
 
 PACKAGECONFIG[pam] = "--enable-pam-module --with-pam-module-dir=${base_libdir}/security,--disable-pam-module,libpam"
 PACKAGECONFIG[policykit] = "--with-polkit,--without-polkit,polkit"
-PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_unitdir}/system/,--with-systemdsystemunitdir="
+PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir}/,--with-systemdsystemunitdir="
 
 FILES_${PN} += "${localstatedir}/log/ConsoleKit ${exec_prefix}/lib/ConsoleKit \
-                ${libdir}/ConsoleKit  ${systemd_unitdir} ${base_libdir} \
+                ${libdir}/ConsoleKit  ${systemd_system_unitdir} ${base_libdir} \
                 ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
 
 PACKAGES =+ "pam-plugin-ck-connector"
Signature · 1 line
2.7.1
#34 lore raw

PATCH 34/42 alsa-utils: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-multimedia/alsa/alsa-utils_1.1.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/alsa/alsa-utils_1.1.0.bb +1 -1
index af40488..49068f5 100644
@@ -62,7 +62,7 @@ FILES_alsa-utils-midi        = "${bindir}/aplaymidi ${bindir}/arecordmidi ${bind
 FILES_alsa-utils-aconnect    = "${bindir}/aconnect"
 FILES_alsa-utils-aseqnet     = "${bindir}/aseqnet"
 FILES_alsa-utils-iecset      = "${bindir}/iecset"
-FILES_alsa-utils-alsactl     = "${sbindir}/alsactl */udev/rules.d */*/udev/rules.d ${systemd_unitdir} ${localstatedir}/lib/alsa ${datadir}/alsa/init/"
+FILES_alsa-utils-alsactl     = "${sbindir}/alsactl */udev/rules.d */*/udev/rules.d ${systemd_system_unitdir} ${localstatedir}/lib/alsa ${datadir}/alsa/init/"
 FILES_alsa-utils-aseqdump    = "${bindir}/aseqdump"
 FILES_alsa-utils-alsaloop    = "${bindir}/alsaloop"
 FILES_alsa-utils-alsaucm     = "${bindir}/alsaucm"
Signature · 1 line
2.7.1
#35 lore raw

PATCH 35/42 ofono: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/ofono/ofono.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-connectivity/ofono/ofono.inc +2 -2
index c415a39..5e40c6c 100644
@@ -16,7 +16,7 @@ PACKAGECONFIG ??= "\
     ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
     "
-PACKAGECONFIG[systemd] = "--with-systemdunitdir=${systemd_unitdir}/system/,--with-systemdunitdir="
+PACKAGECONFIG[systemd] = "--with-systemdunitdir=${systemd_system_unitdir}/,--with-systemdunitdir="
 PACKAGECONFIG[bluez] = "--enable-bluetooth, --disable-bluetooth, ${BLUEZ}"
 
 EXTRA_OECONF += "--enable-test"
@@ -32,6 +32,6 @@ PACKAGES =+ "${PN}-tests"
 
 RDEPENDS_${PN} += "dbus"
 
-FILES_${PN} += "${base_libdir}/udev ${systemd_unitdir}"
+FILES_${PN} += "${base_libdir}/udev ${systemd_system_unitdir}"
 FILES_${PN}-tests = "${libdir}/${BPN}/test"
 RDEPENDS_${PN}-tests = "python python-pygobject python-dbus"
Signature · 1 line
2.7.1
#36 lore raw

PATCH 36/42 bluez5: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/bluez5/bluez5.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-connectivity/bluez5/bluez5.inc +2 -2
index ff2bdcb..504c320 100644
@@ -69,14 +69,14 @@ ALLOW_EMPTY_libasound-module-bluez = "1"
 PACKAGES =+ "libasound-module-bluez ${PN}-testtools ${PN}-obex ${PN}-noinst-tools"
 
 FILES_libasound-module-bluez = "${libdir}/alsa-lib/lib*.so ${datadir}/alsa"
-FILES_${PN} += "${libdir}/bluetooth/plugins/*.so ${base_libdir}/udev/ ${nonarch_base_libdir}/udev/ ${systemd_unitdir}/ ${datadir}/dbus-1"
+FILES_${PN} += "${libdir}/bluetooth/plugins/*.so ${base_libdir}/udev/ ${nonarch_base_libdir}/udev/ ${systemd_system_unitdir}/ ${datadir}/dbus-1"
 FILES_${PN}-dev += "\
   ${libdir}/bluetooth/plugins/*.la \
   ${libdir}/alsa-lib/*.la \
 "
 
 FILES_${PN}-obex = "${libexecdir}/bluetooth/obexd \
-                    ${exec_prefix}/lib/systemd/user/obex.service \
+                    ${systemd_user_unitdir}/obex.service \
                     ${datadir}/dbus-1/services/org.bluez.obex.service \
                    "
 SYSTEMD_SERVICE_${PN}-obex = "obex.service"
Signature · 1 line
2.7.1
#37 lore raw

PATCH 37/42 avahi-ui: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol
---
 meta/recipes-connectivity/avahi/avahi-ui_0.6.32.bb | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
meta/recipes-connectivity/avahi/avahi-ui_0.6.32.bb +3 -5
index 3966b4c..0ab1e38 100644
@@ -41,11 +41,9 @@ RDEPENDS_python-avahi = "python-core python-dbus"
 do_install_append () {
 	rm ${D}${sysconfdir} -rf
 	rm ${D}${base_libdir} -rf
-	rm ${D}${systemd_unitdir} -rf
-	# The ${systemd_unitdir} is /lib/systemd, so we need rmdir /lib,
-	# but not ${base_libdir} here. And the /lib may not exist
-	# whithout systemd.
-	[ ! -d ${D}/lib ] || rmdir ${D}/lib --ignore-fail-on-non-empty
+	rm ${D}${systemd_system_unitdir} -rf
+	rm ${D}${nonarch_base_libdir}/systemd -rf
+	[ ! -d ${D}${nonarch_base_libdir} ] || rmdir ${D}${nonarch_base_libdir} --ignore-fail-on-non-empty
 	rm ${D}${bindir}/avahi-b*
 	rm ${D}${bindir}/avahi-p*
 	rm ${D}${bindir}/avahi-r*
Signature · 1 line
2.7.1
#38 lore raw

PATCH 38/42 opkg: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol

* SYSTEMD_UNITDIR var is not present in the file, it can be safely removed

---
 meta/recipes-devtools/opkg/opkg_0.3.1.bb | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
meta/recipes-devtools/opkg/opkg_0.3.1.bb +4 -5
index 577f495..f1bc8ae 100644
@@ -48,13 +48,12 @@ do_install_append () {
 	install -d ${D}${OPKGLIBDIR}/opkg
 
 	if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)};then
-		install -d ${D}${systemd_unitdir}/system
-		install -m 0644 ${WORKDIR}/opkg-configure.service ${D}${systemd_unitdir}/system/
+		install -d ${D}${systemd_system_unitdir}
+		install -m 0644 ${WORKDIR}/opkg-configure.service ${D}${systemd_system_unitdir}/
 		sed -i -e 's,@BASE_BINDIR@,${base_bindir},g' \
 			-e 's,@SYSCONFDIR@,${sysconfdir},g' \
 			-e 's,@BINDIR@,${bindir},g' \
-			-e 's,@SYSTEMD_UNITDIR@,${systemd_unitdir},g' \
-			${D}${systemd_unitdir}/system/opkg-configure.service
+			${D}${systemd_system_unitdir}/opkg-configure.service
 	fi
 }
 
@@ -68,7 +67,7 @@ RPROVIDES_${PN} = "opkg-collateral"
 PACKAGES =+ "libopkg"
 
 FILES_libopkg = "${libdir}/*.so.* ${OPKGLIBDIR}/opkg/"
-FILES_${PN} += "${systemd_unitdir}/system/"
+FILES_${PN} += "${systemd_system_unitdir}/"
 
 BBCLASSEXTEND = "native nativesdk"
 
Signature · 1 line
2.7.1
#39 lore raw

PATCH 39/42 dpkg: Fix usage of systemd unitdir vars

In reply to Pau Espin Pedrol

* SYSTEMD_UNITDIR var is not present in the file, it can be safely removed

---
 meta/recipes-devtools/dpkg/dpkg.inc | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
meta/recipes-devtools/dpkg/dpkg.inc +3 -4
index 3d9e7e3..1f7f5d1 100644
@@ -52,13 +52,12 @@ do_install_append () {
 	fi
 
 	if ${@bb.utils.contains('DISTRO_FEATURES','sysvinit','false','true',d)};then
-		install -d ${D}${systemd_unitdir}/system
-		install -m 0644 ${WORKDIR}/dpkg-configure.service ${D}${systemd_unitdir}/system/
+		install -d ${D}${systemd_system_unitdir}
+		install -m 0644 ${WORKDIR}/dpkg-configure.service ${D}${systemd_system_unitdir}/
 		sed -i -e 's,@BASE_BINDIR@,${base_bindir},g' \
 			-e 's,@SYSCONFDIR@,${sysconfdir},g' \
 			-e 's,@BINDIR@,${bindir},g' \
-			-e 's,@SYSTEMD_UNITDIR@,${systemd_unitdir},g' \
-			${D}${systemd_unitdir}/system/dpkg-configure.service
+			${D}${systemd_system_unitdir}/dpkg-configure.service
 	fi
 }
 
Signature · 1 line
2.7.1
#40 lore raw

PATCH 40/42 systemd.bbclass: Remove user services too if systemd is not enabled

In reply to Pau Espin Pedrol

* Also change naming related to unitdir, as it's quite misleading because in here we are removing more stuff (parent directory) than just unitdir.

---
 meta/classes/systemd.bbclass | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)
meta/classes/systemd.bbclass +13 -6
index db7873f..9574cbd 100644
@@ -179,17 +179,24 @@ python systemd_populate_packages() {
 
 PACKAGESPLITFUNCS_prepend = "systemd_populate_packages "
 
-python rm_systemd_unitdir (){
+python rm_systemd_dir (){
     import shutil
     if not bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
-        systemd_unitdir = oe.path.join(d.getVar("D", True), d.getVar('systemd_unitdir', True))
-        if os.path.exists(systemd_unitdir):
-            shutil.rmtree(systemd_unitdir)
-        systemd_libdir = os.path.dirname(systemd_unitdir)
+        systemd_system_dir = oe.path.join(d.getVar("D", True), d.getVar('nonarch_base_libdir', True), 'systemd')
+        if os.path.exists(systemd_system_dir):
+            shutil.rmtree(systemd_system_dir)
+        systemd_libdir = os.path.dirname(systemd_system_dir)
+        if (os.path.exists(systemd_libdir) and not os.listdir(systemd_libdir)):
+            os.rmdir(systemd_libdir)
+
+        systemd_user_dir = oe.path.join(d.getVar("D", True), d.getVar('nonarch_libdir', True), 'systemd')
+        if os.path.exists(systemd_user_dir):
+            shutil.rmtree(systemd_user_dir)
+        systemd_libdir = os.path.dirname(systemd_user_dir)
         if (os.path.exists(systemd_libdir) and not os.listdir(systemd_libdir)):
             os.rmdir(systemd_libdir)
 }
-do_install[postfuncs] += "rm_systemd_unitdir "
+do_install[postfuncs] += "rm_systemd_dir "
 
 python rm_sysvinit_initddir (){
     import shutil
Signature · 1 line
2.7.1
#41 lore raw

PATCH 41/42 systemd: Remove usage of systemd_unitdir

In reply to Pau Espin Pedrol
---
 meta/recipes-core/systemd/systemd_229.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-core/systemd/systemd_229.bb +2 -2
index fcb22a3..f422d15 100644
@@ -260,7 +260,7 @@ do_install() {
 		echo 'L! ${sysconfdir}/resolv.conf - - - - ../run/resolv.conf' >>${D}${exec_prefix}/lib/tmpfiles.d/etc.conf
 		echo 'f /run/resolv.conf 0644 root root' >>${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf
 	fi
-	install -Dm 0755 ${S}/src/systemctl/systemd-sysv-install.SKELETON ${D}${systemd_unitdir}/systemd-sysv-install
+	install -Dm 0755 ${S}/src/systemctl/systemd-sysv-install.SKELETON ${D}${nonarch_base_libdir}/systemd/systemd-sysv-install
 }
 
 do_install_ptest () {
@@ -411,7 +411,7 @@ FILES_${PN} = " ${base_bindir}/* \
                 ${sysconfdir}/init.d/README \
                 ${sysconfdir}/resolv.conf \
                 ${rootlibexecdir}/systemd/* \
-                ${systemd_unitdir}/* \
+                ${nonarch_base_libdir}/systemd/* \
                 ${base_libdir}/security/*.so \
                 ${libdir}/libnss_* \
                 /cgroup \
Signature · 1 line
2.7.1
#42 lore raw

PATCH 42/42 bitbake.conf: Mark systemd_unitdir as deprecated to avoid future use

In reply to Pau Espin Pedrol

* This var is not used anymore in oe-core, but it may still be used in some other layers. Let's leave it there for some more time to avoid crashes.

---
 meta/conf/bitbake.conf | 3 +++
 1 file changed, 3 insertions(+)
meta/conf/bitbake.conf +3 -0
index 7ed5ffb..7eeac94 100644
@@ -32,7 +32,10 @@ export datadir = "${prefix}/share"
 export infodir = "${datadir}/info"
 export mandir = "${datadir}/man"
 export docdir = "${datadir}/doc"
+
+# systemd_unitdir is DEPRECATED, don't use it:
 export systemd_unitdir = "${nonarch_base_libdir}/systemd"
+
 export systemd_system_unitdir = "${nonarch_base_libdir}/systemd/system"
 export nonarch_libdir = "${exec_prefix}/lib"
 export systemd_user_unitdir = "${nonarch_libdir}/systemd/user"
Signature · 1 line
2.7.1
#43 lore raw
In reply to Pau Espin Pedrol

Hi,

I sent this series of patches around 3 months ago and got no aswer at all, so just wondering if is it gonna ever be reviewed/merged.

I know maintainers are currently kind of overwhelmed with the big amount of patches received every day, but I'd like to know if it makes sense for me to spend more time on this.

Pau Espin Pedrol

2016-03-13 20:12 GMT+01:00 Pau Espin Pedrol <[email protected]>:

Quoted 119 lines

* These series of patches aim at improving the usage of some systemd related variables
in several recipes from oe-core. Main aim is to change those recipes to
use
'systemd_system_unitdir' instead of the old 'systemd_unitdir/system'
variable,
which will be marked as deprecated instead of being removed as is may
still be
used in other oe layers. To mark it as deprecated, a comment is added in
bitbake.conf,
but better ideas regarding this are welcome.

* Few recipes have also been changed to use the 'systemd_user_unitdir' variable for
their systemd user services.

The following changes since commit
4be0e15f74cff85edca9de55248939fb438f30ae:

oeqa/selftest/recipetool: Fix test_recipetool_create_simple (2016-03-13
18:15:41 +0000)

are available in the git repository at:

git://github.com/pespin/openembedded-core systemd-var-fixes
https://github.com/pespin/openembedded-core/tree/systemd-var-fixes

Pau Espin Pedrol (42):
rootfs-postcommands: Fix usage of systemd unitdir vars
acpid: Fix usage of systemd unitdir vars
apmd: Fix usage of systemd unitdir vars
avahi: Fix usage of systemd unitdir vars
bind: Fix usage of systemd unitdir vars
connman: Fix usage of systemd unitdir vars
dhcp: Fix usage of systemd unitdir vars
neard: Fix usage of systemd unitdir vars
nfs-utils: Fix usage of systemd unitdir vars
openssh: Fix usage of systemd unitdir vars
portmap: Fix usage of systemd unitdir vars
ppp: Fix usage of systemd unitdir vars
wpa-supplicant: Fix usage of systemd unitdir vars
busybox: Fix usage of systemd unitdir vars
dropbear: Fix usage of systemd unitdir vars
glibc-package: Fix usage of systemd unitdir vars
systemd-compat-units: Fix usage of systemd unitdir vars
systemd-serialgetty: Fix usage of systemd unitdir vars
systemd: Fix usage of systemd unitdir vars
util-linux: Fix usage of systemd unitdir vars
volatile-binds: Fix usage of systemd unitdir vars
distcc: Fix usage of systemd unitdir vars
run-postints: Fix usage of systemd unitdir vars
tcf-agent: Fix usage of systemd unitdir vars
at: Fix usage of systemd unitdir vars
cronie: Fix usage of systemd unitdir vars
lighttpd: Fix usage of systemd unitdir vars
rpcbind: Fix usage of systemd unitdir vars
sysstat: Fix usage of systemd unitdir vars
xinetd: Fix usage of systemd unitdir vars
xserver-nodm-init: Fix usage of systemd unitdir vars
oprofileui-server: Fix usage of systemd unitdir vars
consolekit: Fix usage of systemd unitdir vars
alsa-utils: Fix usage of systemd unitdir vars
ofono: Fix usage of systemd unitdir vars
bluez5: Fix usage of systemd unitdir vars
avahi-ui: Fix usage of systemd unitdir vars
opkg: Fix usage of systemd unitdir vars
dpkg: Fix usage of systemd unitdir vars
systemd.bbclass: Remove user services too if systemd is not enabled
systemd: Remove usage of systemd_unitdir
bitbake.conf: Mark systemd_unitdir as deprecated to avoid future use

 meta/classes/rootfs-postcommands.bbclass           |  4 +-
 meta/classes/systemd.bbclass                       | 19 ++++--
 meta/conf/bitbake.conf                             |  3 +
 meta/recipes-bsp/acpid/acpid.inc                   |  6 +-
 meta/recipes-bsp/apmd/apmd_3.2.2-15.bb             |  6 +-
 meta/recipes-connectivity/avahi/avahi-ui_0.6.32.bb |  8 +--
 meta/recipes-connectivity/avahi/avahi.inc          |  2 +-
 meta/recipes-connectivity/bind/bind_9.10.3-P3.bb   |  6 +-
 meta/recipes-connectivity/bluez5/bluez5.inc        |  4 +-
 meta/recipes-connectivity/connman/connman.inc      |  6 +-
 meta/recipes-connectivity/dhcp/dhcp.inc            | 16 ++---
 meta/recipes-connectivity/neard/neard_0.15.bb      |  2 +-
 .../nfs-utils/nfs-utils_1.3.3.bb                   | 20 +++---
 meta/recipes-connectivity/ofono/ofono.inc          |  4 +-
 meta/recipes-connectivity/openssh/openssh_7.1p2.bb | 12 ++--
 meta/recipes-connectivity/portmap/portmap_6.0.bb   |  6 +-
 meta/recipes-connectivity/ppp/ppp_2.4.7.bb         |  8 +--
 .../wpa-supplicant/wpa-supplicant_2.5.bb           |  4 +-
 meta/recipes-core/busybox/busybox.inc              | 12 ++--
 meta/recipes-core/dropbear/dropbear.inc            | 10 +--
 meta/recipes-core/glibc/glibc-package.inc          |  6 +-
 meta/recipes-core/systemd/systemd-compat-units.bb  |  2 +-
 meta/recipes-core/systemd/systemd-serialgetty.bb   | 16 ++---
 meta/recipes-core/systemd/systemd_229.bb           | 72
+++++++++++-----------
 meta/recipes-core/util-linux/util-linux.inc        |  2 +-
 meta/recipes-core/volatile-binds/volatile-binds.bb |  6 +-
 meta/recipes-devtools/distcc/distcc_3.1.bb         |  8 +--
 meta/recipes-devtools/dpkg/dpkg.inc                |  7 +--
 meta/recipes-devtools/opkg/opkg_0.3.1.bb           |  9 ++-
 .../run-postinsts/run-postinsts_1.0.bb             |  6 +-
 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb   |  6 +-
 meta/recipes-extended/at/at_3.1.18.bb              |  6 +-
 meta/recipes-extended/cronie/cronie_1.5.0.bb       |  6 +-
 meta/recipes-extended/lighttpd/lighttpd_1.4.39.bb  |  6 +-
 meta/recipes-extended/rpcbind/rpcbind_0.2.3.bb     | 10 +--
 meta/recipes-extended/sysstat/sysstat.inc          |  6 +-
 meta/recipes-extended/xinetd/xinetd_2.3.15.bb      |  6 +-
 .../x11-common/xserver-nodm-init.bb                |  8 +--
 .../oprofile/oprofileui-server_git.bb              |  6 +-
 meta/recipes-multimedia/alsa/alsa-utils_1.1.0.bb   |  2 +-
 .../recipes-support/consolekit/consolekit_0.4.6.bb |  4 +-
 41 files changed, 182 insertions(+), 176 deletions(-)

--
2.7.1