Skip to contentSkip to conversation

Staging: lustre: Remove return statement from void function.

PATCH New Sandhya Bankar 1 participant 3 messages Mar 21, 2016 Staging

lore
Share & tools
lore
#0 lore raw

cover Staging: lustre: Remove return statement from void function.

Remove return statement from void function,as in void function return statements are not generally useful.

Sandhya Bankar (2):
Staging: lustre: socklnd_lib: Remove return statement from void function.
Staging: lustre: socklnd: Remove return statement from void function.

 drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c     | 1 -
 drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 3 ---
 2 files changed, 4 deletions(-)
Signature · 1 line
1.8.3.4
#1 lore raw

PATCH 1/2 Staging: lustre: socklnd_lib: Remove return statement from void function.

Remove return statement from void function.

---
 drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c +0 -3
index 3e1f24e..acebc6f 100644
@@ -675,7 +675,6 @@ ksocknal_lib_set_callback(struct socket *sock,  ksock_conn_t *conn)
 	sock->sk->sk_user_data = conn;
 	sock->sk->sk_data_ready = ksocknal_data_ready;
 	sock->sk->sk_write_space = ksocknal_write_space;
-	return;
 }
 
 void
@@ -695,8 +694,6 @@ ksocknal_lib_reset_callback(struct socket *sock, ksock_conn_t *conn)
 	 * sk_user_data is NULL.
 	 */
 	sock->sk->sk_user_data = NULL;
-
-	return ;
 }
 
 int
Signature · 1 line
1.8.3.4
#2 lore raw

PATCH 2/2 Staging: lustre: socklnd: Remove return statement from void function.

In reply to Sandhya Bankar

Remove return statement from void function.

---
 drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c +0 -1
index cca7b2f..406c0e7 100644
@@ -2582,7 +2582,6 @@ ksocknal_debug_peerhash(lnet_ni_t *ni)
 	}
 
 	read_unlock(&ksocknal_data.ksnd_global_lock);
-	return;
 }
 
 void
Signature · 1 line
1.8.3.4