Skip to contentSkip to conversation

Fixes for len(TMPDIR) == 410

PATCH In review Robert Yang 3 participants 5 messages Apr 6, 2016

lore
Share & tools
lore
#0 lore raw

cover Fixes for len(TMPDIR) == 410

The following changes since commit b2dc5a68e74dafedf7960ef77ad3d73912ed7960:

bdwgc: use github repo for source location (2016-04-05 11:48:09 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/long
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/long

Robert Yang (2):
sanity.bbclass: fix a hardcode in check_path_length()
wget: fix build when len(TMPDIR) == 410

 meta/classes/sanity.bbclass         | 2 +-
 meta/recipes-extended/wget/wget.inc | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
2.8.0
#1 lore raw

PATCH 1/2 sanity.bbclass: fix a hardcode in check_path_length()

* Fixed:
410 -> limit

---
 meta/classes/sanity.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/sanity.bbclass +1 -1
index 662f764..ac23517 100644
@@ -334,7 +334,7 @@ def check_create_long_filename(filepath, pathname):
 
 def check_path_length(filepath, pathname, limit):
     if len(filepath) > limit:
-        return "The length of %s is longer than 410, this would cause unexpected errors, please use a shorter path.\n" % pathname
+        return "The length of %s is longer than %s, this would cause unexpected errors, please use a shorter path.\n" % (pathname, limit)
     return ""
 
 def get_filesystem_id(path):
Signature · 1 line
2.8.0
#2 lore raw

PATCH 2/2 wget: fix build when len(TMPDIR) == 410

In reply to Robert Yang

Fixed:
aclocal: error: cannot open [snip] |: Argument list too long

Set acpaths to fix the problem.

---
 meta/recipes-extended/wget/wget.inc | 5 +++++
 1 file changed, 5 insertions(+)
meta/recipes-extended/wget/wget.inc +5 -0
index 049b898..dc381a6 100644
@@ -22,3 +22,8 @@ BBCLASSEXTEND += "nativesdk"
 
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[libuuid] = "--with-libuuid, --without-libuuid,util-linux"
+
+# Let aclocal use the relative path for the m4 file rather than
+# absolute, otherwise there might be an "Argument list too long" error
+# when it is built in a long/deep directory.
+acpaths = "-I ./m4"
Signature · 1 line
2.8.0
#3 lore raw
In reply to Robert Yang
Quoted 9 lines · Robert Yang

The following changes since commit b2dc5a68e74dafedf7960ef77ad3d73912ed7960:

bdwgc: use github repo for source location (2016-04-05 11:48:09 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/long
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/long

Quoted 8 lines

Robert Yang (2):
sanity.bbclass: fix a hardcode in check_path_length()
wget: fix build when len(TMPDIR) == 410

  meta/classes/sanity.bbclass         | 2 +-
  meta/recipes-extended/wget/wget.inc | 5 +++++
  2 files changed, 6 insertions(+), 1 deletion(-)

How are these patches related and what is magic about a path length of 410? Are you sure that it might not be 569 on my system for example?

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#4 lore raw
Quoted 17 lines · Gary Thomas
Quoted 16 lines · Robert Yang

The following changes since commit
b2dc5a68e74dafedf7960ef77ad3d73912ed7960:

bdwgc: use github repo for source location (2016-04-05 11:48:09
+0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/long
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/
log/?h=rbt/long

Robert Yang (2):
sanity.bbclass: fix a hardcode in check_path_length()
wget: fix build when len(TMPDIR) == 410

Quoted 8 lines
Quoted 4 lines
  meta/classes/sanity.bbclass         | 2 +-
  meta/recipes-extended/wget/wget.inc | 5 +++++
  2 files changed, 6 insertions(+), 1 deletion(-)

How are these patches related and what is magic about a path length of 410?
Are you sure that it might not be 569 on my system for example?

410 is the maximum we've ever managed to make work for the core recipes. We're basically trying to ensure we don't get worse. In an ideal world there wouldn't be any restrictions but that would take significant resource investment for questionable return.

Cheers,

Richard