fs-perms.txt: fix ROOT_HOME's permission
cover fs-perms.txt: fix ROOT_HOME's permission
The following changes since commit 5ebea1114d54120d5ff5d8a6cd148110d0fda23f:
build-appliance-image: Update to master head revision (2016-04-06 23:54:57 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/home
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
Robert Yang (1):
fs-perms.txt: fix ROOT_HOME's permission
meta/files/fs-perms.txt | 1 + 1 file changed, 1 insertion(+)
Signature · 1 line
2.8.0
PATCH 1/1 fs-perms.txt: fix ROOT_HOME's permission
It should be 0700 rather than 0755.
--- meta/files/fs-perms.txt | 1 + 1 file changed, 1 insertion(+)
meta/files/fs-perms.txt +1 -0
@@ -51,6 +51,7 @@ ${localstatedir}/lock link /run/lock ${localstatedir}/tmp link volatile/tmp /home 0755 root root false - - - +${ROOT_HOME} 0700 root root false - - - /srv 0755 root root false - - - ${prefix}/src 0755 root root false - - - ${localstatedir}/local 0755 root root false - - -
Signature · 1 line
2.8.0
Quoted 13 lines · Robert Yang
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>--- meta/files/fs-perms.txt | 1 + 1 file changed, 1 insertion(+)meta/files/fs-perms.txt +0
-0
meta/files/fs-perms.txt ${localstatedir}/lock link /run/lock · line 54
Quoted 4 lines
meta/files/fs-perms.txt +1
-0@@ -51,6 +51,7 @@ ${localstatedir}/lock link /run/lock ${localstatedir}/tmp link volatile/tmp /home 0755 root root false - - - +${ROOT_HOME} 0700 root root false - - -
I'd like to see this in the section labelled "Special permissions from base-files" around line 58. I think that makes it more clear that this is a special permission setting.
Quoted 11 lines
meta/files/fs-perms.txt +0
-1/srv 0755 root root false - - - ${prefix}/src 0755 root root false - - - ${localstatedir}/local 0755 root root false - - - --2.8.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 16 lines · Dan McGregor
Quoted 15 lines · Robert Yang
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>--- meta/files/fs-perms.txt | 1 + 1 file changed, 1 insertion(+)meta/files/fs-perms.txt +0
-0@@ -51,6 +51,7 @@ ${localstatedir}/lock link /run/lock ${localstatedir}/tmp link volatile/tmp
Quoted 6 lines
meta/files/fs-perms.txt ${localstatedir}/lock link /run/lock · line 54
Quoted 2 lines
meta/files/fs-perms.txt +1
-0/home 0755 root root false - - - +${ROOT_HOME} 0700 root root false - - -I'd like to see this in the section labelled "Special permissions from base-files" around line 58. I think that makes it more clear that this is a special permission setting.
Thanks, updated in the repo:
git://git.openembedded.org/openembedded-core-contrib rbt/home
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
commit ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32b
Author: Robert Yang <[email protected]> Date: Tue Apr 5 22:34:25 2016 -0700
fs-perms.txt: fix ROOT_HOME's permission
It should be 0700 rather than 0755.
meta/files/fs-perms.txt +1 -0
@@ -59,6 +59,7 @@ ${localstatedir}/local 0755 root root false - - - # Set 1777 /tmp 01777 root root false - - - ${localstatedir}/volatile/tmp 01777 root root false - - - +${ROOT_HOME} 0700 root root false - - - # Set 755-lsb /srv 0755 root root false - - -
// Robert
Quoted 14 lines
Quoted 13 lines
meta/files/fs-perms.txt +0
-1/srv 0755 root root false - - - ${prefix}/src 0755 root root false - - - ${localstatedir}/local 0755 root root false - - - --2.8.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 55 lines · Robert Yang
Quoted 18 lines · Dan McGregor
Quoted 16 lines · Robert Yang
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>--- meta/files/fs-perms.txt | 1 + 1 file changed, 1 insertion(+)meta/files/fs-perms.txt +0
-0@@ -51,6 +51,7 @@ ${localstatedir}/lock link /run/lock ${localstatedir}/tmp link volatile/tmpQuoted 7 lines
meta/files/fs-perms.txt ${localstatedir}/lock link /run/lock · line 54
Quoted 2 lines
meta/files/fs-perms.txt +1
-0/home 0755 root root false - - - +${ROOT_HOME} 0700 root root false - - -I'd like to see this in the section labelled "Special permissions from base-files" around line 58. I think that makes it more clear that this is a special permission setting.
Thanks, updated in the repo:
git://git.openembedded.org/openembedded-core-contribrbt/homehttp://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
commit
ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32bAuthor: Robert Yang <[email protected]> Date: Tue Apr 5 22:34:25 2016 -0700fs-perms.txt: fix ROOT_HOME's permission
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>meta/files/fs-perms.txt +0
-0@@ -59,6 +59,7 @@ ${localstatedir}/local 0755 root rootfalse - - -
# Set 1777
Quoted 4 lines
/tmp 01777 root root false - - -
${localstatedir}/volatile/tmp 01777 root root false - - -
+${ROOT_HOME} 0700 root root false - - -Thanks, this is the right track, but this implies that ${ROOT_HOME} should be mode 1777, how about:
+
+# Set 700
+${ROOT_HOME} 0700 root root false - - -
Quoted 23 lines
# Set 755-lsb
/srv 0755 root root false - - -// Robert
Quoted 15 lines
Quoted 13 lines
meta/files/fs-perms.txt +0
-1/srv 0755 root root false - - - ${prefix}/src 0755 root root false - - - ${localstatedir}/local 0755 root root false - - - --2.8.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 64 lines · Dan McGregor
Quoted 55 lines · Robert Yang
Quoted 18 lines · Dan McGregor
Quoted 16 lines · Robert Yang
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>--- meta/files/fs-perms.txt | 1 + 1 file changed, 1 insertion(+)meta/files/fs-perms.txt +0
-0@@ -51,6 +51,7 @@ ${localstatedir}/lock link /run/lock ${localstatedir}/tmp link volatile/tmpQuoted 7 lines
meta/files/fs-perms.txt ${localstatedir}/lock link /run/lock · line 54
Quoted 2 lines
meta/files/fs-perms.txt +1
-0/home 0755 root root false - - - +${ROOT_HOME} 0700 root root false - - -I'd like to see this in the section labelled "Special permissions from base-files" around line 58. I think that makes it more clear that this is a special permission setting.
Thanks, updated in the repo:
git://git.openembedded.org/openembedded-core-contribrbt/homehttp://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
commit
ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32bAuthor: Robert Yang <[email protected]> Date: Tue Apr 5 22:34:25 2016 -0700fs-perms.txt: fix ROOT_HOME's permission
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>meta/files/fs-perms.txt +0
-0@@ -59,6 +59,7 @@ ${localstatedir}/local 0755 root rootfalse - - -
# Set 1777Quoted 4 lines
/tmp 01777 root root false - - - ${localstatedir}/volatile/tmp 01777 root root false - - -+${ROOT_HOME} 0700 root root false - - -
Thanks, this is the right track, but this implies that ${ROOT_HOME} should be mode 1777, how about:
Review
Quoted 3 lines
(quoted diff) +3
-0+ +# Set 700 +${ROOT_HOME} 0700 root root false - - -
Thanks, updated in the repo:
git://git.openembedded.org/openembedded-core-contrib rbt/home
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
commit 5d0c64fd55edc957d8fb6340c9842bf8498a485d
Author: Robert Yang <[email protected]> Date: Tue Apr 5 22:34:25 2016 -0700
fs-perms.txt: fix ROOT_HOME's permission
It should be 0700 rather than 0755.
meta/files/fs-perms.txt +3 -0
@@ -60,6 +60,9 @@ ${localstatedir}/local 0755 root root false - - - /tmp 01777 root root false - - - ${localstatedir}/volatile/tmp 01777 root root false - - - +# Set 0700 +${ROOT_HOME} 0700 root root false - - - + # Set 755-lsb /srv 0755 root root false - - -
// Robert
Quoted 25 lines
Quoted 24 lines
# Set 755-lsb
/srv 0755 root root false - - -// Robert
Quoted 15 lines
Quoted 13 lines
meta/files/fs-perms.txt +0
-1/srv 0755 root root false - - - ${prefix}/src 0755 root root false - - - ${localstatedir}/local 0755 root root false - - - --2.8.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 108 lines · Robert Yang
Quoted 72 lines · Dan McGregor
Quoted 62 lines · Robert Yang
Quoted 20 lines · Dan McGregor
Quoted 17 lines · Robert Yang
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>--- meta/files/fs-perms.txt | 1 + 1 file changed, 1 insertion(+)meta/files/fs-perms.txt +0
-0@@ -51,6 +51,7 @@ ${localstatedir}/lock link /run/lock ${localstatedir}/tmp link volatile/tmpQuoted 8 lines
meta/files/fs-perms.txt ${localstatedir}/lock link /run/lock · line 54
Quoted 2 lines
meta/files/fs-perms.txt +1
-0/home 0755 root root false - - - +${ROOT_HOME} 0700 root root false - - -I'd like to see this in the section labelled "Special permissions from base-files" around line 58. I think that makes it more clear that this is a special permission setting.
Thanks, updated in the repo:
git://git.openembedded.org/openembedded-core-contribrbt/homehttp://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
commit
ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32bAuthor: Robert Yang <[email protected]> Date: Tue Apr 5 22:34:25 2016 -0700fs-perms.txt: fix ROOT_HOME's permission
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>meta/files/fs-perms.txt +0
-0@@ -59,6 +59,7 @@ ${localstatedir}/local 0755 rootroot
false - - -
# Set 1777Quoted 4 lines
/tmp 01777 root root false - - - ${localstatedir}/volatile/tmp 01777 root root false - - -+${ROOT_HOME} 0700 root root false - - -
Thanks, this is the right track, but this implies that ${ROOT_HOME} should be mode 1777, how about:
Review
Quoted 3 lines
(quoted diff) +3
-0+ +# Set 700 +${ROOT_HOME} 0700 root root false - - -Thanks, updated in the repo:
git://git.openembedded.org/openembedded-core-contribrbt/homehttp://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
commit
5d0c64fd55edc957d8fb6340c9842bf8498a485dAuthor: Robert Yang <[email protected]> Date: Tue Apr 5 22:34:25 2016 -0700fs-perms.txt: fix ROOT_HOME's permission
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>meta/files/fs-perms.txt +0
-0@@ -60,6 +60,9 @@ ${localstatedir}/local 0755 root rootfalse - - -
/tmp 01777 root root false - - - ${localstatedir}/volatile/tmp 01777 root root false - - -
meta/files/fs-perms.txt ${localstatedir}/local 0755 root root false - - -
Quoted 6 lines
meta/files/fs-perms.txt +3
-0+# Set 0700 +${ROOT_HOME} 0700 root root false - - - + # Set 755-lsb /srv 0755 root root false - - -
Looks good to me.
Quoted 30 lines
// Robert
Quoted 26 lines
Quoted 25 lines
# Set 755-lsb
/srv 0755 root root false - - -// Robert
Quoted 16 lines
Quoted 13 lines
meta/files/fs-perms.txt +0
-1/srv 0755 root root false - - - ${prefix}/src 0755 root root false - - - ${localstatedir}/local 0755 root root false - - - --2.8.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Richard,
I believe you merged the wrong version of this patch.
Dan
Quoted 144 lines · Robert Yang
Quoted 72 lines · Dan McGregor
Quoted 62 lines · Robert Yang
Quoted 20 lines · Dan McGregor
Quoted 17 lines · Robert Yang
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>--- meta/files/fs-perms.txt | 1 + 1 file changed, 1 insertion(+)meta/files/fs-perms.txt +0
-0@@ -51,6 +51,7 @@ ${localstatedir}/lock link /run/lock ${localstatedir}/tmp link volatile/tmpQuoted 8 lines
meta/files/fs-perms.txt ${localstatedir}/lock link /run/lock · line 54
Quoted 2 lines
meta/files/fs-perms.txt +1
-0/home 0755 root root false - - - +${ROOT_HOME} 0700 root root false - - -I'd like to see this in the section labelled "Special permissions from base-files" around line 58. I think that makes it more clear that this is a special permission setting.
Thanks, updated in the repo:
git://git.openembedded.org/openembedded-core-contribrbt/homehttp://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
commit
ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32bAuthor: Robert Yang <[email protected]> Date: Tue Apr 5 22:34:25 2016 -0700fs-perms.txt: fix ROOT_HOME's permission
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>meta/files/fs-perms.txt +0
-0@@ -59,6 +59,7 @@ ${localstatedir}/local 0755 rootroot
false - - -
# Set 1777Quoted 4 lines
/tmp 01777 root root false - - - ${localstatedir}/volatile/tmp 01777 root root false - - -+${ROOT_HOME} 0700 root root false - - -
Thanks, this is the right track, but this implies that ${ROOT_HOME} should be mode 1777, how about:
Review
Quoted 3 lines
(quoted diff) +3
-0+ +# Set 700 +${ROOT_HOME} 0700 root root false - - -Thanks, updated in the repo:
git://git.openembedded.org/openembedded-core-contribrbt/homehttp://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
commit
5d0c64fd55edc957d8fb6340c9842bf8498a485dAuthor: Robert Yang <[email protected]> Date: Tue Apr 5 22:34:25 2016 -0700fs-perms.txt: fix ROOT_HOME's permission
It should be 0700 rather than 0755.
Reported-by Charles Chan <[email protected]>Signed-off-by Robert Yang <[email protected]>meta/files/fs-perms.txt +0
-0@@ -60,6 +60,9 @@ ${localstatedir}/local 0755 root rootfalse - - -
/tmp 01777 root root false - - - ${localstatedir}/volatile/tmp 01777 root root false - - -meta/files/fs-perms.txt +3
-0+# Set 0700 +${ROOT_HOME} 0700 root root false - - - + # Set 755-lsb /srv 0755 root root false - - -// Robert
Quoted 26 lines
Quoted 25 lines
# Set 755-lsb
/srv 0755 root root false - - -// Robert
Quoted 16 lines
Quoted 13 lines
meta/files/fs-perms.txt +0
-1/srv 0755 root root false - - - ${prefix}/src 0755 root root false - - - ${localstatedir}/local 0755 root root false - - - --2.8.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 2 lines · Dan McGregor
I believe you merged the wrong version of this patch.
I've updated mut with a revert/add of the revised patch.
Ross