Skip to contentSkip to conversation

Fix more potential build failures

PATCH In review Jussi Kukkonen 3 participants 6 messages Apr 22, 2016 – Apr 25, 2016

lore
Share & tools
lore
#0 lore raw

cover Fix more potential build failures

Decided to run a build/cleansstate/wipe-sysroot/re-build cycle for all recipes in world: Only found the intltool failures Ross already sent patches for and these two.

Jussi

The following changes since commit 6c1c01392d91f512e2949ad1d57a75a8077478ba:

build-appliance-image: Update to krogoth head revision (2016-04-19 21:26:33 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib jku/more-build-fixes
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/more-build-fixes

Jussi Kukkonen (2):
babeltrace: Let autotools.bbclass run autoreconf
gcc-sanitizers: Depend on target gcc

 meta/recipes-devtools/gcc/gcc-sanitizers.inc  | 2 +-
 meta/recipes-kernel/lttng/babeltrace_1.3.1.bb | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/2 babeltrace: Let autotools.bbclass run autoreconf

When bootstrap calls autoreconf, it won't have AC_LOCAL set properly so shared scripts may not be found: glib-2.0.m4 in this case.

Remove custom bootstrap code so autotools class handles this.

---
 meta/recipes-kernel/lttng/babeltrace_1.3.1.bb | 4 ----
 1 file changed, 4 deletions(-)
meta/recipes-kernel/lttng/babeltrace_1.3.1.bb +0 -4
index 1766026..6f4cb85 100644
@@ -18,7 +18,3 @@ SRC_URI = "git://git.efficios.com/babeltrace.git;branch=stable-1.3 \
 "
 
 S = "${WORKDIR}/git"
-
-do_configure_prepend () {
-	( cd ${S}; ${S}/bootstrap )
-}
Signature · 1 line
2.1.4
#2 lore raw

PATCH 2/2 gcc-sanitizers: Depend on target gcc

Without this the target gcc might not be in the sysroot leading to configure failure.

---
 meta/recipes-devtools/gcc/gcc-sanitizers.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-sanitizers.inc +1 -1
index 6091a0b..df4e297 100644
@@ -50,7 +50,7 @@ do_install () {
 
 INHIBIT_DEFAULT_DEPS = "1"
 ALLOW_EMPTY_${PN} = "1"
-DEPENDS = "gcc-runtime"
+DEPENDS = "gcc-runtime virtual/${TARGET_PREFIX}gcc"
 
 BBCLASSEXTEND = "nativesdk"
 
Signature · 1 line
2.1.4
#3 lore raw

Re: [PATCH 2/2] gcc-sanitizers: Depend on target gcc

Quoted 5 lines · Jussi Kukkonen

Without this the target gcc might not be in the sysroot leading to configure failure.

you might want to correct the comment to say cross gcc. Thats whats added to DEPENDS here and not target gcc.

Quoted 27 lines

---
meta/recipes-devtools/gcc/gcc-sanitizers.inc | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-sanitizers.inc +0 -0
index 6091a0b..df4e297 100644
@@ -50,7 +50,7 @@ do_install () {
 

INHIBIT_DEFAULT_DEPS = "1"
ALLOW_EMPTY_${PN} = "1"

meta/recipes-devtools/gcc/gcc-sanitizers.inc +1 -1
-DEPENDS = "gcc-runtime"
+DEPENDS = "gcc-runtime virtual/${TARGET_PREFIX}gcc"

BBCLASSEXTEND = "nativesdk"

--
2.1.4

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw

Re: [PATCH 2/2] gcc-sanitizers: Depend on target gcc

Quoted 7 lines · Khem Raj
Quoted 4 lines · Jussi Kukkonen

Without this the target gcc might not be in the sysroot leading to configure failure.

you might want to correct the comment to say cross gcc. Thats whats added to DEPENDS here and not target gcc.

Thanks. I've force pushed the above change in the repo:

git://git.yoctoproject.org/poky-contrib jku/more-build-fixes
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/more-build-fixes

Jussi

#5 lore raw

Re: [PATCH 2/2] gcc-sanitizers: Depend on target gcc

In reply to Jussi Kukkonen

Review

Quoted 10 lines · Jussi Kukkonen

Without this the target gcc might not be in the sysroot leading to configure failure.

---
 meta/recipes-devtools/gcc/gcc-sanitizers.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-devtools/gcc/gcc-sanitizers.inc

Quoted 13 lines

index 6091a0b..df4e297 100644

meta/recipes-devtools/gcc/gcc-sanitizers.inc +1 -2
@@ -50,7 +50,7 @@ do_install () {
 
 INHIBIT_DEFAULT_DEPS = "1"
 ALLOW_EMPTY_${PN} = "1"
-DEPENDS = "gcc-runtime"
+DEPENDS = "gcc-runtime virtual/${TARGET_PREFIX}gcc"
 
 BBCLASSEXTEND = "nativesdk"
 
--
Quoted 2 lines

2.1.4

I agree with Khem. Otherwise looks good to me.

Quoted 5 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core