Remove unnecessary pci_set_drvdata() and platform_set_drvdata().
Subsystems (3)
cover Remove unnecessary pci_set_drvdata() and platform_set_drvdata().
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver datato NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL.
Sandhya Bankar (3):
usb: pci: Remove unnecessary pci_set_drvdata().
usb: dwc3-keystone: Remove unnecessary platform_set_drvdata().
usb: gr_udec: Remove unnecessary platform_set_drvdata().
drivers/usb/dwc2/pci.c | 1 - drivers/usb/dwc3/dwc3-keystone.c | 1 - drivers/usb/gadget/udc/gr_udc.c | 1 - 3 files changed, 3 deletions(-)
Signature · 1 line
1.8.3.4
PATCH 1/3 usb: pci: Remove unnecessary pci_set_drvdata().
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL.
--- drivers/usb/dwc2/pci.c | 1 - 1 file changed, 1 deletion(-)
drivers/usb/dwc2/pci.c +0 -1
@@ -69,7 +69,6 @@ static void dwc2_pci_remove(struct pci_dev *pci)platform_device_unregister (glue->dwc2);usb_phy_generic_unregister (glue->phy);kfree (glue); -pci_set_drvdata (pci,NULL ); } static int dwc2_pci_probe(struct pci_dev *pci,
Signature · 1 line
1.8.3.4
Greg KH
maintainerRe: [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata().
Quoted 2 lines · Sandhya Bankar
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL.
Please fix your changelog text to be wrapped at 72 columns like it is supposed to be.
thanks,
greg k-h
PATCH 2/3 usb: dwc3-keystone: Remove unnecessary platform_set_drvdata().
In reply to Sandhya BankarUnnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL
--- drivers/usb/dwc3/dwc3-keystone.c | 1 - 1 file changed, 1 deletion(-)
drivers/usb/dwc3/dwc3-keystone.c +0 -1
@@ -164,7 +164,6 @@ static int kdwc3_remove(struct platform_device *pdev)kdwc3_disable_irqs (kdwc);device_for_each_child (&pdev->dev,NULL , kdwc3_remove_core);clk_disable_unprepare (kdwc->clk); -platform_set_drvdata (pdev,NULL );return 0 ; }
Signature · 1 line
1.8.3.4
PATCH 3/3 usb: gr_udc: Remove unnecessary platform_set_drvdata().
In reply to Sandhya BankarUnnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL.
--- drivers/usb/gadget/udc/gr_udc.c | 1 - 1 file changed, 1 deletion(-)
drivers/usb/gadget/udc/gr_udc.c +0 -1
@@ -2117,7 +2117,6 @@ static int gr_remove(struct platform_device *pdev)gr_dfs_delete (dev);dma_pool_destroy (dev->desc_pool); -platform_set_drvdata (pdev,NULL );gr_free_request (&dev->epi[0 ].ep, &dev->ep0reqi->req);gr_free_request (&dev->epo[0 ].ep, &dev->ep0reqo->req);
Signature · 1 line
1.8.3.4