recipetool/create.py: fix LICENSE value
cover recipetool/create.py: fix LICENSE value
The following changes since commit 7b4b67da33beff736dc0286ea24e3860480f9650:
directfb: fix client->gfx_state initialisation (2016-06-15 18:13:09 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib ChenQi/recipetool-license
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/recipetool-license
Chen Qi (1):
recipetool/create.py: fix LICENSE value
scripts/lib/recipetool/create.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.9.1
PATCH 1/1 recipetool/create.py: fix LICENSE value
When there multiple license in a repo, the LICENSE value be created as something like "LGPLv2.1 GPLv2", which causes the following warning.
LICENSE value "LGPLv2.1 GPLv2" has an invalid format - license names must be separated by the following characters to indicate the license selection: &|()
Fix it by using '&' to join multiple licenses.
--- scripts/lib/recipetool/create.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/lib/recipetool/create.py +1 -1
@@ -504,7 +504,7 @@ def create_recipe(args): licenses = [pkg_license] else: lines_before.append('# NOTE: Original package metadata indicates license is: %s' % pkg_license) - lines_before.append('LICENSE = "%s"' % ' '.join(licenses)) + lines_before.append('LICENSE = "%s"' % ' & '.join(licenses)) lines_before.append('LIC_FILES_CHKSUM = "%s"' % ' \\\n '.join(lic_files_chksum)) lines_before.append('')
Signature · 1 line
1.9.1
Quoted 9 lines · Chen Qi
When there multiple license in a repo, the LICENSE value be created as something like "LGPLv2.1 GPLv2", which causes the following warning.
LICENSE value "LGPLv2.1 GPLv2" has an invalid format - license names must be separated by the following characters to indicate the license
selection: &|()Fix it by using '&' to join multiple licenses.
This behaviour is intentional, as recipetool isn't smart enough to read the licensing terms and decide if there are multiple licenses in aggregate (&) or a choice of licenses (|). The solution is to list all the licenses that have been found, let bitbake throw a warning, and the person creating a recipe comprehend the licensing situation and add the relevant operations.
Ross
Quoted 11 lines · Ross
On 16 June 2016 at 10:30, Chen Qi <[email protected] <mailto:[email protected]>> wrote:
When there multiple license in a repo, the LICENSE value be created as something like "LGPLv2.1 GPLv2", which causes the following warning.
LICENSE value "LGPLv2.1 GPLv2" has an invalid format - license names must
be separated by the following characters to indicate the license
selection: &|()
Quoted 6 lines
Fix it by using '&' to join multiple licenses.
This behaviour is intentional, as recipetool isn't smart enough to read the licensing terms and decide if there are multiple licenses in aggregate (&) or a choice of licenses (|). The solution is to list all the licenses that have been found, let bitbake throw a warning, and the person creating a recipe comprehend the licensing situation and add the relevant operations.
Ross
Thanks for your detailed explanation.
Best Regards,
Chen Qi