Skip to contentSkip to conversation

NO_GNU_HASH warning fixes

PATCH In review Yi Zhao 3 participants 7 messages Aug 19, 2016 – Aug 22, 2016

lore
Share & tools
lore

Yi Zhao

author
#0 lore raw

cover NO_GNU_HASH warning fixes

The following changes since commit 02a390b79bdc089eb583e443ee04f60bffd409eb:

tnftp: tnftp20130505 -> tnftp20151004 (2016-08-16 21:26:15 -0400)

are available in the git repository at:

git://git.openembedded.org/meta-openembedded-contrib yzhao/networking-hashfix
http://cgit.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h=yzhao/networking-hashfix

Yi Zhao (3):
ifenslave: fix QA warning for GNU_HASH
ipvsadm: fix QA warning for GNU_HASH
iscsitarget: fix QA warning for GNU_HASH

 .../iscsitarget/iscsitarget_1.4.20.3+svn502.bb        |  3 ++-
 .../recipes-support/ifenslave/ifenslave_1.1.0.bb      |  2 +-
 .../ipvsadm/ipvsadm/makefile-add-ldflags.patch        | 19 +++++++++++++++++++
 .../recipes-support/ipvsadm/ipvsadm_1.26.bb           |  1 +
 4 files changed, 23 insertions(+), 2 deletions(-)
 create mode 100644 meta-networking/recipes-support/ipvsadm/ipvsadm/makefile-add-ldflags.patch
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/3 ifenslave: fix QA warning for GNU_HASH

Set LDFLAGS explicitly for do_compile

Signed-off-by Yi Zhao <[email protected]>
---
 meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb +1 -1
index acc0864..385bc80 100644
@@ -10,7 +10,7 @@ SRC_URI[md5sum] = "56126cd1013cefe0ce6f81613e677bdd"
 SRC_URI[sha256sum] = "7917bf34de80a2492eb225adf9168c83a4854ac8a008ed0fd5b3fd147ccd3041"
 
 do_compile() {
-    ${CC} ifenslave.c -o ifenslave
+    ${CC} ${LDFLAGS} ifenslave.c -o ifenslave
 }
 do_install() {
     install -d "${D}${sbindir}"
Signature · 1 line
2.7.4
#2 lore raw

Re: [meta-networking][PATCH 1/3] ifenslave: fix QA warning for GNU_HASH

Quoted 13 lines · Yi Zhao

Set LDFLAGS explicitly for do_compile

Signed-off-by Yi Zhao <[email protected]>

---
 meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb +0 -0
index acc0864..385bc80 100644
@@ -10,7 +10,7 @@ SRC_URI[md5sum] = "56126cd1013cefe0ce6f81613e677bdd"
Quoted 6 lines

 SRC_URI[sha256sum] = "7917bf34de80a2492eb225adf9168c83a4854ac8a008ed0fd5b3fd147ccd3041"
 do_compile() {
-    ${CC} ifenslave.c -o ifenslave
+    ${CC} ${LDFLAGS} ifenslave.c -o ifenslave

While you're fixing the gcc invocation here, wouldn't it make sense to add CFLAGS as well? (Maybe in a separate patch).

Cheers,
Andre'

#3 lore raw

Re: [meta-networking][PATCH 1/3] ifenslave: fix QA warning for GNU_HASH

Quoted 20 lines · André Draszik
Quoted 16 lines · Yi Zhao

Set LDFLAGS explicitly for do_compile

Signed-off-by Yi Zhao <[email protected]>
---
 meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb +0 -0
index acc0864..385bc80 100644
@@ -10,7 +10,7 @@ SRC_URI[md5sum] = "56126cd1013cefe0ce6f81613e677bdd"
 SRC_URI[sha256sum] =

"7917bf34de80a2492eb225adf9168c83a4854ac8a008ed0fd5b3fd147ccd3041"

Quoted 7 lines

meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb SRC_URI[md5sum] = "56126cd1013cefe0ce6f81613e677bdd" · line 13

Quoted 3 lines

do_compile() {

meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb +1 -1
-    ${CC} ifenslave.c -o ifenslave
+    ${CC} ${LDFLAGS} ifenslave.c -o ifenslave

While you're fixing the gcc invocation here, wouldn't it make sense to add CFLAGS as well? (Maybe in a separate patch).

yeah or into two distinct steps of compile and link.

Quoted 9 lines

Cheers,
Andre'

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#4 lore raw

Re: [meta-networking][PATCH 1/3] ifenslave: fix QA warning for GNU_HASH

In reply to André Draszik
Quoted 17 lines · André Draszik
Quoted 16 lines · Yi Zhao

Set LDFLAGS explicitly for do_compile

Signed-off-by Yi Zhao <[email protected]>
---
  meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb +0 -0
index acc0864..385bc80 100644
@@ -10,7 +10,7 @@ SRC_URI[md5sum] = "56126cd1013cefe0ce6f81613e677bdd"
  SRC_URI[sha256sum] =

"7917bf34de80a2492eb225adf9168c83a4854ac8a008ed0fd5b3fd147ccd3041"

Quoted 5 lines

meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb SRC_URI[md5sum] = "56126cd1013cefe0ce6f81613e677bdd" · line 13

Quoted 3 lines
  do_compile() {
meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb +1 -1
-    ${CC} ifenslave.c -o ifenslave
+    ${CC} ${LDFLAGS} ifenslave.c -o ifenslave

While you're fixing the gcc invocation here, wouldn't it make sense to add CFLAGS as well? (Maybe in a separate patch).

Thanks, I will send the patch later.

Yi

Quoted 4 lines

Cheers,
Andre'

author
#5 lore raw

PATCH 2/3 ipvsadm: fix QA warning for GNU_HASH

In reply to Yi Zhao

Add LDFLAGS variable to Makefile so that extra linker flags can be sent via this variable.

Signed-off-by Yi Zhao <[email protected]>
---
 .../ipvsadm/ipvsadm/makefile-add-ldflags.patch        | 19 +++++++++++++++++++
 .../recipes-support/ipvsadm/ipvsadm_1.26.bb           |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 meta-networking/recipes-support/ipvsadm/ipvsadm/makefile-add-ldflags.patch
meta-networking/recipes-support/ipvsadm/ipvsadm/makefile-add-ldflags.patch new file +19 -0
new file mode 100644
index 0000000..1bf1eed
@@ -0,0 +1,19 @@
+Add LDFLAGS variable to Makefile, make sure the extra linker flags can be passed.
+
+Upstream-Status: Pending
+
+Signed-off-by: Yi Zhao <[email protected]>
+
+diff --git a/Makefile b/Makefile
+index 461c021..8bc9cde 100644
+--- a/Makefile
++++ b/Makefile
+@@ -86,7 +86,7 @@ libs:
+ 		make -C libipvs
+ 
+ ipvsadm:	$(OBJS) libs
+-		$(CC) $(CFLAGS) -o $@ $(OBJS) $(STATIC_LIBS) $(LIBS)
++		$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(OBJS) $(STATIC_LIBS) $(LIBS)
+ 
+ install:        all
+ 		if [ ! -d $(SBIN) ]; then $(MKDIR) -p $(SBIN); fi
meta-networking/recipes-support/ipvsadm/ipvsadm_1.26.bb +1 -0
index 7302e9d..8d1b3f0 100644
@@ -19,6 +19,7 @@ SRC_URI = "http://www.linuxvirtualserver.org/software/kernel-2.6/${BP}.tar.gz \
         file://0001-Modify-the-Makefile-for-cross-compile.patch \
         file://0002-Replace-nl_handle-to-nl_sock.patch \
         file://0003-ipvsadm-remove-dependency-on-bash.patch \
+        file://makefile-add-ldflags.patch \
 "
 
 SRC_URI[md5sum] = "eac3ba3f62cd4dea2da353aeddd353a8"
Signature · 1 line
2.7.4
author
#6 lore raw

PATCH 3/3 iscsitarget: fix QA warning for GNU_HASH

In reply to Yi Zhao

Split kernel module and user space build. Ensure the LDFLAGS is passed when build user space code.

Signed-off-by Yi Zhao <[email protected]>
---
 .../recipes-extended/iscsitarget/iscsitarget_1.4.20.3+svn502.bb        | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+svn502.bb +2 -1
index 4c5eed6..c60277d 100644
@@ -26,7 +26,8 @@ do_configure[noexec] = "1"
 do_make_scripts[depends] += "virtual/kernel:do_shared_workdir"
 
 do_compile() {
-    oe_runmake KSRC=${STAGING_KERNEL_DIR} LDFLAGS='' V=1
+    oe_runmake KSRC=${STAGING_KERNEL_DIR} LDFLAGS='' V=1 kernel
+    oe_runmake KSRC=${STAGING_KERNEL_DIR} usr
 }
 
 do_install() {
Signature · 1 line
2.7.4