Skip to contentSkip to conversation

Staging: Remove exceptional & on function name.

PATCH New Sandhya Bankar 1 participant 3 messages Sep 18, 2016 Staging

lore
Share & tools
lore
#0 lore raw

v2 cover Staging: Remove exceptional & on function name.

A function name is already a pointer, and does not need &. This changes are made by below coccinelle script:

// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>

Changes in v2:
* Correcting the commit message.
* Correcting the file permission issue.

Sandhya Bankar (2):
Staging: lustre: file: Remove exceptional & on function name.
Staging: lustre: namei: Remove exceptional & on function name.

 drivers/staging/lustre/lustre/llite/file.c  |    2 +-
 drivers/staging/lustre/lustre/llite/namei.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
#1 lore raw

PATCH v2 1/2 Staging: lustre: namei: Remove exceptional & on function name.

A function name is already a pointer, and does not need &. This changes are made by below coccinelle script:

// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>

---
Changes in v2:
* Correcting the commit message.
* Correcting the file permission issue

 drivers/staging/lustre/lustre/llite/namei.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/lustre/lustre/llite/namei.c +1 -1
index b7d448f..aa10e7c 100644
@@ -551,7 +551,7 @@ static struct dentry *ll_lookup_it(struct inode *parent, struct dentry *dentry,
 		it->it_create_mode &= ~current_umask();
 
 	rc = md_intent_lock(ll_i2mdexp(parent), op_data, it, &req,
-			    &ll_md_blocking_ast, 0);
+			    ll_md_blocking_ast, 0);
 	ll_finish_md_op_data(op_data);
 	if (rc < 0) {
 		retval = ERR_PTR(rc);
Signature · 1 line
1.7.1
#2 lore raw

PATCH v2 2/2 Staging: lustre: file: Remove exceptional & on function name.

In reply to Sandhya Bankar

A function name is already a pointer, and does not need &. This changes are made by below coccinelle script:

// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>

---
Changes in v2:
* Correcting the commit message.
* Correcting the file permission issue.

 drivers/staging/lustre/lustre/llite/file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/lustre/lustre/llite/file.c +1 -1
index bfac6dd..4965d15 100644
@@ -829,7 +829,7 @@ ll_lease_open(struct inode *inode, struct file *file, fmode_t fmode,
 	it.it_flags = fmode | open_flags;
 	it.it_flags |= MDS_OPEN_LOCK | MDS_OPEN_BY_FID | MDS_OPEN_LEASE;
 	rc = md_intent_lock(sbi->ll_md_exp, op_data, &it, &req,
-			    &ll_md_blocking_lease_ast,
+			    ll_md_blocking_lease_ast,
 	/* LDLM_FL_NO_LRU: To not put the lease lock into LRU list, otherwise
 	 * it can be cancelled which may mislead applications that the lease is
 	 * broken;
Signature · 1 line
1.7.1