Skip to contentSkip to conversation

staging: rtl8192e: Fix checkpatch issues

PATCH New Namrata A Shettar 1 participant 5 messages Sep 19, 2016 Staging

lore
Share & tools
lore

Namrata A Shettar

author
#0 lore raw

cover staging: rtl8192e: Fix checkpatch issues

Fix multiple checkpatch issues.

Namrata A Shettar (4):
staging: rtl8192e: Add space around '+'
staging: rtl8192e: Remove unneccessary blank lines
staging: rtl8192e: Add space around binary operator '+'
staging: rtl8192e: Insert blank line after function declaration

 drivers/staging/rtl8192e/dot11d.c | 12 +++++-------
 drivers/staging/rtl8192e/dot11d.h |  5 +++--
 2 files changed, 8 insertions(+), 9 deletions(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/4 staging: rtl8192e: Add space around '+'

Add space around '+' to resolve checkpatch issue.

Signed-off-by Namrata A Shettar <[email protected]>
---
 drivers/staging/rtl8192e/dot11d.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8192e/dot11d.c +5 -5
index 4d8fb41..24fc615 100644
@@ -51,7 +51,7 @@ void dot11d_init(struct rtllib_device *ieee)
 	pDot11dInfo->State = DOT11D_STATE_NONE;
 	pDot11dInfo->CountryIeLen = 0;
 	memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER+1);
-	memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER+1);
+	memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER + 1);
 	RESET_CIE_WATCHDOG(ieee);
 
 }

@@ -105,8 +105,8 @@ void Dot11d_Reset(struct rtllib_device *ieee)
 	struct rt_dot11d_info *pDot11dInfo = GET_DOT11D_INFO(ieee);
 	u32 i;
 
-	memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER+1);
-	memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER+1);
+	memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER + 1);
+	memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER + 1);
 	for (i = 1; i <= 11; i++)
 		(pDot11dInfo->channel_map)[i] = 1;
 	for (i = 12; i <= 14; i++)

@@ -123,8 +123,8 @@ void Dot11d_UpdateCountryIe(struct rtllib_device *dev, u8 *pTaddr,
 	u8 i, j, NumTriples, MaxChnlNum;
 	struct chnl_txpow_triple *pTriple;
 
-	memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER+1);
-	memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER+1);
+	memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER + 1);
+	memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER + 1);
 	MaxChnlNum = 0;
 	NumTriples = (CoutryIeLen - 3) / 3;
 	pTriple = (struct chnl_txpow_triple *)(pCoutryIe + 3);
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH 2/4 staging: rtl8192e: Remove unnecessary blank lines

In reply to Namrata A Shettar

Remove unneccessary blank lines to resolve checkpatch issue.

Signed-off-by Namrata A Shettar <[email protected]>
---
 drivers/staging/rtl8192e/dot11d.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rtl8192e/dot11d.c +0 -2
index 24fc615..25725b1 100644
@@ -53,7 +53,6 @@ void dot11d_init(struct rtllib_device *ieee)
 	memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER+1);
 	memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER + 1);
 	RESET_CIE_WATCHDOG(ieee);
-
 }
 EXPORT_SYMBOL(dot11d_init);
 

@@ -99,7 +98,6 @@ void Dot11d_Channelmap(u8 channel_plan, struct rtllib_device *ieee)
 }
 EXPORT_SYMBOL(Dot11d_Channelmap);
 
-
 void Dot11d_Reset(struct rtllib_device *ieee)
 {
 	struct rt_dot11d_info *pDot11dInfo = GET_DOT11D_INFO(ieee);
Signature · 1 line
2.7.4
author
#3 lore raw

PATCH 3/4 staging: rtl8192e: Add space around binary operator '+'

In reply to Namrata A Shettar

Add space around binary operator '+' to resolve checkpatch issue.

Signed-off-by Namrata A Shettar <[email protected]>
---
 drivers/staging/rtl8192e/dot11d.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/dot11d.h +2 -2
index 735a199..bdb5392 100644
@@ -47,8 +47,8 @@ struct rt_dot11d_info {
 	u8  CountryIeSrcAddr[6];
 	u8  CountryIeWatchdog;
 
-	u8  channel_map[MAX_CHANNEL_NUMBER+1];
-	u8  MaxTxPwrDbmList[MAX_CHANNEL_NUMBER+1];
+	u8  channel_map[MAX_CHANNEL_NUMBER + 1];
+	u8  MaxTxPwrDbmList[MAX_CHANNEL_NUMBER + 1];
 
 	enum dot11d_state State;
 };
Signature · 1 line
2.7.4
author
#4 lore raw

PATCH 4/4 staging: rtl8192e: Insert blank line after function declaration

In reply to Namrata A Shettar

Insert blank line after function declaration to resolve checkpatch issue.

Signed-off-by Namrata A Shettar <[email protected]>
---
 drivers/staging/rtl8192e/dot11d.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/rtl8192e/dot11d.h +1 -0
index bdb5392..aac395f 100644
@@ -78,6 +78,7 @@ static inline void RESET_CIE_WATCHDOG(struct rtllib_device *__pIeeeDev)
 {
 	GET_CIE_WATCHDOG(__pIeeeDev) = 0;
 }
+
 #define UPDATE_CIE_WATCHDOG(__pIeeeDev) (++GET_CIE_WATCHDOG(__pIeeeDev))
 
 void dot11d_init(struct rtllib_device *dev);
Signature · 1 line
2.7.4