Skip to contentSkip to conversation

usb: dwc2: Add AHB burst configuration

PATCH New John Youn 1 participant 2 messages Nov 17, 2016 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

John Youn

author
#0 lore raw

v3 cover usb: dwc2: Add AHB burst configuration

This series adds a binding for AHB burst, reads it in, and configures the controller for the specified burst type.

Tested on HAPS platform with DWC_hsotg IP version 3.30a.

v3:
* Split out binding documentation
* Squash bcm2835 comment with binding implementation
* Add warning for bcm2835

v2:
* Don't remove the bcm2835 ahbcfg param and document why.

John Youn (4):
Documentation: devictree: dwc2: Add AHB burst binding
usb: dwc2: Read in the AHB burst property
usb: dwc2: Use the ahb_burst param
usb: dwc2: pci: Add AHB burst property for HAPS

 Documentation/devicetree/bindings/usb/dwc2.txt |  2 +
 drivers/usb/dwc2/core.h                        |  9 +++
 drivers/usb/dwc2/gadget.c                      |  2 +-
 drivers/usb/dwc2/hcd.c                         |  8 +--
 drivers/usb/dwc2/params.c                      | 79 ++++++++++++++++++++++----
 drivers/usb/dwc2/pci.c                         |  1 +
 6 files changed, 85 insertions(+), 16 deletions(-)
Signature · 6 lines
2.10.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): cover.1479415762.git.johnyoun-HKixBCOQz3hWk0Htik3J/[email protected]

author
#2 lore raw

PATCH v3 1/4 Documentation: devictree: dwc2: Add AHB burst binding

Add the "snps,ahb-burst" property which controls the burst type to perform on the AHB bus as a master in internal DMA mode.

Some platforms may see better or worse performance based on this value. The HAPS platform is one example where all INCRx have worse performance than INCR.

Other platforms (such as the Canyonlands board) report that the default value causes system hangs.

---
 Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/usb/dwc2.txt +2 -0
index 6c7c2bce..9e7b4b4 100644
@@ -26,6 +26,8 @@ Optional properties:
 Refer to phy/phy-bindings.txt for generic phy consumer properties
 - dr_mode: shall be one of "host", "peripheral" and "otg"
   Refer to usb/generic.txt
+- snps,ahb-burst: specifies the ahb burst length. Valid arguments are:
+  "SINGLE", "INCR", "INCR4", "INCR8", "INCR16". Defaults to "INCR4".
 - g-rx-fifo-size: size of rx fifo size in gadget mode.
 - g-np-tx-fifo-size: size of non-periodic tx fifo size in gadget mode.
 - g-tx-fifo-size: size of periodic tx fifo per endpoint (except ep0) in gadget mode.
Signature · 6 lines
2.10.0

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html