kernel-devsrc: remove symlink source
cover kernel-devsrc: remove symlink source
The following changes since commit af280990bff4a484fd8a18e3442b56a0a39b7611:
Revert "classes/populate_sdk_ext: require uninative" (2016-11-28 14:49:37 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/kernel
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/kernel
Robert Yang (1):
kernel-devsrc: remove symlink source
meta/recipes-kernel/linux/kernel-devsrc.bb | 7 +++++++ 1 file changed, 7 insertions(+)
Signature · 1 line
2.9.0
PATCH 1/1 kernel-devsrc: remove symlink source
Fixed:
$ rpm -qplv tmp/deploy/rpm/qemuppc/kernel-devsrc-1.0-r0.qemuppc.rpm | grep kernel/source /usr/src/kernel/source -> /buildarea/lyang1/test_yocto/tmp/work/qemuppc-poky-linux/kernel-devsrc/1.0-r0/image/usr/src/kernel
It is generated by kernel's "make clean _mrproper_scripts", the kernel-devsrc includeds full sources, this symlink is not needed, and the path is invalid on target, so remove it.
--- meta/recipes-kernel/linux/kernel-devsrc.bb | 7 +++++++ 1 file changed, 7 insertions(+)
meta/recipes-kernel/linux/kernel-devsrc.bb +7 -0
@@ -53,6 +53,13 @@ do_install() { # architecture (since scripts and helpers are native format). KBUILD_OUTPUT="$kerneldir" oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean _mrproper_scripts + # make clean generates an absolute path symlink called "source" + # in $kerneldir points to $kerneldir, which doesn't make any + # sense, so remove it. + if [ -L $kerneldir/source ]; then + bbnote "Removing $kerneldir/source" + rm -f $kerneldir/source + fi # As of Linux kernel version 3.0.1, the clean target removes # arch/powerpc/lib/crtsavres.o which is present in
Signature · 1 line
2.9.0
Quoted 26 lines · Robert Yang
Fixed:
$ rpm -qplv tmp/deploy/rpm/qemuppc/kernel-devsrc-1.0-r0.qemuppc.rpm | grep kernel/source /usr/src/kernel/source -> /buildarea/lyang1/test_yocto/ tmp/work/qemuppc-poky-linux/kernel-devsrc/1.0-r0/image/usr/src/kernelIt is generated by kernel's "make clean
_mrproper_scripts", the kernel-devsrc includeds full sources, this symlink is not needed, and the path is invalid on target, so remove it.Signed-off-by Robert Yang <[email protected]>--- meta/recipes-kernel/linux/kernel-devsrc.bb | 7 +++++++ 1 file changed, 7 insertions(+)meta/recipes-kernel/linux/kernel-devsrc.bb +0
-0@@ -53,6 +53,13 @@ do_install() { # architecture (since scripts and helpers are native format). KBUILD_OUTPUT="$kerneldir" oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}"clean
_mrproper_scripts
meta/recipes-kernel/linux/kernel-devsrc.bb do_install() { · line 60
Quoted 5 lines
meta/recipes-kernel/linux/kernel-devsrc.bb +5
-0+ # make clean generates an absolute path symlink called "source" + # in $kerneldir points to $kerneldir, which doesn't make any + # sense, so remove it. + if [ -L $kerneldir/source ]; then + bbnote "Removing $kerneldir/source"
This message needs to be clarified. When that comes out, I'd read it and think
"it is removing my kernel source".
Maybe:
bbnote "Removing $kerneldir/source symlink"
is better.
Bruce
Quoted 14 lines
meta/recipes-kernel/linux/kernel-devsrc.bb +2
-1+ rm -f $kerneldir/source + fi # As of Linux kernel version 3.0.1, the clean target removes # arch/powerpc/lib/crtsavres.o which is present in --2.9.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
Quoted 40 lines · Bruce Ashfield
On Tue, Nov 29, 2016 at 4:16 AM, Robert Yang <[email protected] <mailto:[email protected]>> wrote:
Fixed:
$ rpm -qplv tmp/deploy/rpm/qemuppc/kernel-devsrc-1.0-r0.qemuppc.rpm | grep kernel/source
/usr/src/kernel/source-> /buildarea/lyang1/test_yocto/tmp/work/qemuppc-poky-linux/kernel-devsrc/1.0-r0/image/usr/src/kernelIt is generated by kernel's "make clean
_mrproper_scripts", the kernel-devsrc includeds full sources, this symlink is not needed, and the path is invalid on target, so remove it.Signed-off-by Robert Yang <[email protected]<mailto:[email protected]>>
---
meta/recipes-kernel/linux/kernel-devsrc.bb <http://kernel-devsrc.bb> | 7
+++++++
1 file changed, 7 insertions(+)diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb
<http://kernel-devsrc.bb> b/meta/recipes-kernel/linux/kernel-devsrc.bb
<http://kernel-devsrc.bb>
index 9fd2e08..b182936 100644
--- a/meta/recipes-kernel/linux/kernel-devsrc.bb <http://kernel-devsrc.bb>
+++ b/meta/recipes-kernel/linux/kernel-devsrc.bb <http://kernel-devsrc.bb>
@@ -53,6 +53,13 @@do_install(){
# architecture (since scripts and helpers are native format). KBUILD_OUTPUT="$kerneldir"
oe_runmake-C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean
_mrproper_scripts
+ # make clean generates an absolute path symlink called "source"
+ # in $kerneldir points to $kerneldir, which doesn't make any
+ # sense, so remove it.
+ if [ -L $kerneldir/source ]; then
+ bbnote "Removing $kerneldir/source"
Quoted 8 lines
This message needs to be clarified. When that comes out, I'd read it and think "it is removing my kernel source".
Maybe:
bbnote "Removing $kerneldir/source symlink"
is better.
Thanks, updated in the repo:
meta/recipes-kernel/linux/kernel-devsrc.bb +0 -0
@@ -53,6 +53,13 @@ do_install() { # architecture (since scripts and helpers are native format). KBUILD_OUTPUT="$kerneldir" oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean
_mrproper_scripts
+ # make clean generates an absolute path symlink called "source" + # in $kerneldir points to $kerneldir, which doesn't make any + # sense, so remove it. + if [ -L $kerneldir/source ]; then
+ bbnote "Removing $kerneldir/source symlink"
+ rm -f $kerneldir/source
+ fi
# As of Linux kernel version 3.0.1, the clean target removes # arch/powerpc/lib/crtsavres.o which is present in
// Robert
Quoted 26 lines
Bruce
+ rm -f $kerneldir/source
+ fi# As of Linux kernel version 3.0.1, the clean target removes #
arch/powerpc/lib/crtsavres.owhich is present in
--
2.9.0--
_______________________________________________
Openembedded-core mailing list [email protected] <mailto:[email protected]>
http://lists.openembedded.org/mailman/listinfo/openembedded-core
<http://lists.openembedded.org/mailman/listinfo/openembedded-core>--
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
Ping.
// Robert
Quoted 15 lines · Robert Yang
The following changes since commit
af280990bff4a484fd8a18e3442b56a0a39b7611:Revert "classes/populate_sdk_ext: require uninative" (2016-11-28 14:49:37 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contribrbt/kernel
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/kernelRobert Yang (1):
kernel-devsrc: remove symlink sourcemeta/recipes-kernel/linux/kernel-devsrc.bb | 7 +++++++ 1 file changed, 7 insertions(+)