Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.
PATCH 1/1 Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.
Fixed checkpatch warning "line over 80 characters" in wlan-ng/hfa384x_usb.c file.
--- drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/wlan-ng/hfa384x_usb.c +2 -1
@@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb) {struct wlandevice *wlandev = urb->context;struct hfa384x *hw; -union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer; +union hfa384x_usbin *usbin =NULL ;struct sk_buff *skb =NULL ;int result;int urb_status;
@@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb) ABORT } action; + usbin = (union hfa384x_usbin *)urb->transfer_buffer;if (!wlandev || !wlandev->netdev || wlandev->hwremoved) goto exit;
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 13 lines · Yan Laijun
Fixed checkpatch warning "line over 80 characters" in
wlan-ng/hfa384x_usb.cfile.Signed-off-by Yan Laijun <[email protected]>--- drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/wlan-ng/hfa384x_usb.c +0
-0
drivers/staging/wlan-ng/hfa384x_usb.c static void hfa384x_usbin_callback(struct urb *urb) · line 3040
Quoted 5 lines
drivers/staging/wlan-ng/hfa384x_usb.c +1
-1@@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb) {struct wlandevice *wlandev = urb->context;struct hfa384x *hw; -union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer; +union hfa384x_usbin *usbin =NULL ;
Why set this to NULL if you then assign it to something else a few lines later?
thanks,
greg k-h
Remove initialization of usbin on its decarlation.
Yan Laijun (1):
Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.
drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
1.9.1
PATCH v2 1/1 staging: wlan-ng: Fixed too long code line warnings.
Fixed checkpatch warning "line over 80 characters" in wlan-ng/hfa384x_usb.c file.
---
Changes in v2:
- Remove initialization of usbin on its decarlation.
--- drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/wlan-ng/hfa384x_usb.c +2 -1
@@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb) {struct wlandevice *wlandev = urb->context;struct hfa384x *hw; -union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer; +union hfa384x_usbin *usbin;struct sk_buff *skb =NULL ;int result;int urb_status;
@@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb) ABORT } action; + usbin = (union hfa384x_usbin *)urb->transfer_buffer;if (!wlandev || !wlandev->netdev || wlandev->hwremoved) goto exit;
Signature · 1 line
1.9.1
Re: [PATCH v2] staging: wlan-ng: Fixed too long code line warnings.
Quoted 26 lines · Yan Laijun
Fixed checkpatch warning "line over 80 characters" in
wlan-ng/hfa384x_usb.cfile.Signed-off-by Yan Laijun <[email protected]>---
Changes in v2:
- Remove initialization of usbin on its decarlation.--- drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/wlan-ng/hfa384x_usb.c +1
-1@@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb) {struct wlandevice *wlandev = urb->context;struct hfa384x *hw; -union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer; +union hfa384x_usbin *usbin;struct sk_buff *skb =NULL ;int result;int urb_status;
drivers/staging/wlan-ng/hfa384x_usb.c static void hfa384x_usbin_callback(struct urb *urb) · line 3055
Quoted 7 lines
drivers/staging/wlan-ng/hfa384x_usb.c +1
-0@@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb) ABORT } action; + usbin = (union hfa384x_usbin *)urb->transfer_buffer;if (!wlandev || !wlandev->netdev || wlandev->hwremoved) goto exit;
If you separate declaration and assignment of usbin, maybe it makes sense to move the assignment down to where usbin is used for the first time.
Regards,
Markus