Resolve gdb-cross-canadian dependency on imp

Add imp to python3-importlib. Make gdb-cross-canadian depend on nativesdk-python3-importlib when python is enabled.

The following changes since commit c8d96b10ee3bc2eae0fd269d2564286fd0bc82ed:

rm_work: Ensure we don't remove sigbasedata files (2016-11-16 10:34:34 +0000)

are available in the git repository at:

git://github.com/gmccollister/openembedded-core morty-gdb-cross-canadian
https://github.com/gmccollister/openembedded-core/tree/morty-gdb-cross-canadian

George McCollister (2):
python-3.5-manifest: Add imp to importlib
gdb-cross-canadian: Depend on nativesdk-python3-importlib

 meta/recipes-devtools/gdb/gdb-cross-canadian.inc     | 3 ++-
 meta/recipes-devtools/python/python-3.5-manifest.inc | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

2.9.3

The imp python module is the forerunner of importlib. Include imp in the importlib subpackage instead of the misc subpackage so that it can be depended on without bringing in a bunch of unrelated, unused modules.

---
 meta/recipes-devtools/python/python-3.5-manifest.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index 3046114..6c690db 100644
@@ -115,7 +115,7 @@ FILES_${PN}-image="${libdir}/python3.5/colorsys.* ${libdir}/python3.5/imghdr.* $
 
 SUMMARY_${PN}-importlib="Python import implementation library"
 RDEPENDS_${PN}-importlib="${PN}-core ${PN}-lang"
-FILES_${PN}-importlib="${libdir}/python3.5/importlib "
+FILES_${PN}-importlib="${libdir}/python3.5/importlib ${libdir}/python3.5/imp.* "
 
 SUMMARY_${PN}-io="Python low-level I/O"
 RDEPENDS_${PN}-io="${PN}-core ${PN}-math"

2.9.3

Add missing dependency on nativesdk-python3-importlib so the imp Python module is installed.

Before this patch, running gdb from the sdk would give the following error:

Python Exception <class 'ImportError'> No module named 'imp':

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

index e53081d..3ff1989 100644
@@ -14,7 +14,8 @@ GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 PACKAGECONFIG ??= "python readline"
 PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,nativesdk-python3, \
                          nativesdk-python3-core nativesdk-python3-lang nativesdk-python3-re \
-                         nativesdk-python3-codecs nativesdk-python3-netclient"
+                         nativesdk-python3-codecs nativesdk-python3-netclient \
+                         nativesdk-python3-importlib"
 PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,nativesdk-readline"
 
 SSTATE_DUPWHITELIST += "${STAGING_DATADIR}/gdb"

2.9.3

Any chance we can get this applied to morty?

You should add [morty] tag to subject and CC the maintainer ( [email protected]) to improve chances of this happening. I'm sure Armin would also appreciate explicit confirmation that the patches apply to morty branch.

Before that some review though (sorry I missed this in Dec) ... it looks like the "Add imp to importlib" commit only modified manifest.inc: this is a generated file and your changes will be overwritten next time someone runs the generator. You should modify scripts/contrib/python/ generate-manifest-3.5.py and run that to generate the new manifest.inc file.

It would be nice if we did not store noth the source and the generated files in git but that's how it's currently setup...

Jussi

[morty] was in the subject but I didn't CC the maintainer. Now I know who the maintainer is.

Yes, I messed that up. Someone else fixed it in master here:
http://git.openembedded.org/openembedded-core/commit/scripts/contrib/python/generate-manifest-3.5.py?id=bfe1d948ab034017622110c8365be7026e139fbf

I'll resend my two patches with the patch that fixes generate-manifest-3.5.py for morty.