Skip to contentSkip to conversation

Use weak assignment for SERIAL_CONSOLES in qemu configuration files

PATCH In review Chen Qi 2 participants 4 messages Dec 9, 2016 – Dec 12, 2016

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

cover Use weak assignment for SERIAL_CONSOLES in qemu configuration files

The following changes since commit ad00a31fbe93e073a2d83616efcd08c5a7ef37c9:

gdb-cross-canadian: Depend on nativesdk-python3-importlib (2016-12-08 10:26:15 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib ChenQi/qemu-console
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/qemu-console

Chen Qi (1):
Use weak assignment for SERIAL_CONSOLES in qemu configuration files

 meta/conf/machine/qemuarm.conf    | 2 +-
 meta/conf/machine/qemuarm64.conf  | 2 +-
 meta/conf/machine/qemumips.conf   | 2 +-
 meta/conf/machine/qemumips64.conf | 2 +-
 meta/conf/machine/qemuppc.conf    | 2 +-
 meta/conf/machine/qemux86-64.conf | 2 +-
 meta/conf/machine/qemux86.conf    | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 Use weak assignment for SERIAL_CONSOLES in qemu configuration files

Use weak assignment for SERIAL_CONSOLES in qemu configuration files so that the value could serve as a default value and could be easily overridden in configuration files like local.conf.

When using the default value for SERAIL_CONSOLES in qemux86-64,we would have annoying messages on console complaining about respawning getty on ttyS1. Although the value is set by purpose, at least we need to provide an easy way to override it.

Signed-off-by Chen Qi <[email protected]>
---
 meta/conf/machine/qemuarm.conf    | 2 +-
 meta/conf/machine/qemuarm64.conf  | 2 +-
 meta/conf/machine/qemumips.conf   | 2 +-
 meta/conf/machine/qemumips64.conf | 2 +-
 meta/conf/machine/qemuppc.conf    | 2 +-
 meta/conf/machine/qemux86-64.conf | 2 +-
 meta/conf/machine/qemux86.conf    | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
meta/conf/machine/qemuarm.conf +1 -1
index 17402ef..f9d6dd7 100644
@@ -8,7 +8,7 @@ require conf/machine/include/tune-arm926ejs.inc
 
 KERNEL_IMAGETYPE = "zImage"
 
-SERIAL_CONSOLES = "115200;ttyAMA0 115200;ttyAMA1"
+SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;ttyAMA1"
 
 # For runqemu
 QB_SYSTEM_NAME = "qemu-system-arm"
meta/conf/machine/qemuarm64.conf +1 -1
index df2010c..e70538a 100644
@@ -7,7 +7,7 @@ require conf/machine/include/qemu.inc
 
 KERNEL_IMAGETYPE = "Image"
 
-SERIAL_CONSOLES = "38400;ttyAMA0 38400;hvc0"
+SERIAL_CONSOLES ?= "38400;ttyAMA0 38400;hvc0"
 
 # For runqemu
 QB_SYSTEM_NAME = "qemu-system-aarch64"
meta/conf/machine/qemumips.conf +1 -1
index 3182ea1..986315a 100644
@@ -9,6 +9,6 @@ require conf/machine/include/qemuboot-mips.inc
 KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
-SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
+SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
 
 MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
meta/conf/machine/qemumips64.conf +1 -1
index 9529f4c..3f91cbe 100644
@@ -9,6 +9,6 @@ require conf/machine/include/qemuboot-mips.inc
 KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
-SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
+SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
 
 MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
meta/conf/machine/qemuppc.conf +1 -1
index 8703c20..9d174bc 100644
@@ -9,7 +9,7 @@ TARGET_CC_KERNEL_ARCH = "-mno-spe"
 
 KERNEL_IMAGETYPE = "vmlinux"
 
-SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
+SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
 
 # For runqemu
 QB_SYSTEM_NAME = "qemu-system-ppc"
meta/conf/machine/qemux86-64.conf +1 -1
index 3117ca1..150d745 100644
@@ -14,7 +14,7 @@ require conf/machine/include/qemuboot-x86.inc
 
 KERNEL_IMAGETYPE = "bzImage"
 
-SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
+SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
 
 XSERVER = "xserver-xorg \
            ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'mesa-driver-swrast xserver-xorg-extension-glx', '', d)} \
meta/conf/machine/qemux86.conf +1 -1
index 7785999..8997f6b 100644
@@ -13,7 +13,7 @@ require conf/machine/include/qemuboot-x86.inc
 
 KERNEL_IMAGETYPE = "bzImage"
 
-SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
+SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
 
 XSERVER = "xserver-xorg \
            ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'mesa-driver-swrast xserver-xorg-extension-glx', '', d)} \
Signature · 1 line
1.9.1
#2 lore raw
Quoted 5 lines · Chen Qi

Use weak assignment for SERIAL_CONSOLES in qemu configuration files so that the value could serve as a default value and could be easily overridden in configuration files like local.conf.

When using the default value for SERAIL_CONSOLES in qemux86-64,we would have

                                   ^^^^^^

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
author
#3 lore raw
Quoted 6 lines · Robert P. J. Day
Quoted 4 lines · Chen Qi

Use weak assignment for SERIAL_CONSOLES in qemu configuration files so that the value could serve as a default value and could be easily overridden in configuration files like local.conf.

Quoted 6 lines
Quoted 1 line

When using the default value for SERAIL_CONSOLES in qemux86-64,we would have

                                    ^^^^^^

rday

Thanks for spotting this.

I've fixed the typo and updated the remote repo.

git://git.openembedded.org/openembedded-core-contrib ChenQi/qemu-console
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/qemu-console

Best Regards,

Chen Qi