Openrisc 4.10 fixes

PATCH In review Stafford Horne 3 participants 9 messages Dec 31, 2016 – Jan 2, 2017 Openrisc architecture

lore

Share & tools

lore

Stafford Horne

author maintainer

2016-12-31 11:52 UTC #0 lore raw

cover Openrisc 4.10 fixes

Hello,

These are a few small changes for openrisc I would like to include in 4.10. The main change is a fix for building with alldefconfig to properly setup then _text symbol. Others are trivial.

If no complaints I will push to 4.10 for inclusion and start working on 4.11 changes.

Let me know if these are too minor to even post for review.

Stafford Horne (3):
openrisc: Add _text symbol to fix ksym build error
openrisc: Add .gitignore
MAINTAINERS: Add the openrisc official repository

 MAINTAINERS                        | 1 +
 arch/openrisc/kernel/.gitignore    | 1 +
 arch/openrisc/kernel/vmlinux.lds.S | 2 ++
 3 files changed, 4 insertions(+)
 create mode 100644 arch/openrisc/kernel/.gitignore

Signature · 1 line

2.9.3

Stafford Horne

author maintainer

2016-12-31 11:52 UTC #1 lore raw

PATCH 1/3 openrisc: Add _text symbol to fix ksym build error

The build robot reports:

.tmp_kallsyms1.o: In function `kallsyms_relative_base':

Quoted 1 line

Quoted 1 line
(.rodata+0x8a18): undefined reference to `_text'

This is when using 'make alldefconfig'. Adding this _text symbol to mark the start of the kernel as in other architecture fixes this.

Signed-off-by Stafford Horne <[email protected]>

---
 arch/openrisc/kernel/vmlinux.lds.S | 2 ++
 1 file changed, 2 insertions(+)

arch/openrisc/kernel/vmlinux.lds.S +2 -0

index ef31fc2..5525446 100644
@@ -44,6 +44,8 @@ SECTIONS
         /* Read-only sections, merged into text segment: */
         . = LOAD_BASE ;
 
+	_text = .;
+
 	/* _s_kernel_ro must be page aligned */
 	. = ALIGN(PAGE_SIZE);
 	_s_kernel_ro = .;

Signature · 1 line

2.9.3

Jonas Bonn

maintainer Acked-by on v1 1/3

2016-12-31 14:11 UTC #2 lore raw

Re: [PATCH 1/3] openrisc: Add _text symbol to fix ksym build error

Quoted 8 lines · Stafford Horne

The build robot reports:
.tmp_kallsyms1.o: In function `kallsyms_relative_base':
Quoted 1 line
Quoted 1 line
(.rodata+0x8a18): undefined reference to `_text'
This is when using 'make alldefconfig'. Adding this _text symbol to mark the start of the kernel as in other architecture fixes this.
Signed-off-by Stafford Horne <[email protected]>

Acked-by Jonas Bonn <[email protected]>

Quoted 17 lines

---
  arch/openrisc/kernel/vmlinux.lds.S | 2 ++
  1 file changed, 2 insertions(+)

arch/openrisc/kernel/vmlinux.lds.S +2 -0

index ef31fc2..5525446 100644
@@ -44,6 +44,8 @@ SECTIONS
          /* Read-only sections, merged into text segment: */
          . = LOAD_BASE ;
 
+	_text = .;
+
  	/* _s_kernel_ro must be page aligned */
  	. = ALIGN(PAGE_SIZE);
  	_s_kernel_ro = .;

Stafford Horne

author maintainer

2016-12-31 11:52 UTC #3 lore raw

PATCH 2/3 openrisc: Add .gitignore

In reply to Stafford Horne

This helps to suppress the vmlinux.lds file.

Signed-off-by Stafford Horne <[email protected]>

---
 arch/openrisc/kernel/.gitignore | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 arch/openrisc/kernel/.gitignore

arch/openrisc/kernel/.gitignore new file +1 -0

new file mode 100644
index 0000000..c5f676c
@@ -0,0 +1 @@
+vmlinux.lds

Signature · 1 line

2.9.3

Stafford Horne

author maintainer

2016-12-31 11:52 UTC #4 lore raw

PATCH 3/3 MAINTAINERS: Add the openrisc official repository

In reply to Stafford Horne

The openrisc official repository and patch work happens currently on github. Add the repo for reference.

Signed-off-by Stafford Horne <[email protected]>

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

MAINTAINERS +1 -0

index cfff2c9..d6ebe38 100644
@@ -9161,6 +9161,7 @@ OPENRISC ARCHITECTURE
 M:	Jonas Bonn <[email protected]>
 M:	Stefan Kristiansson <[email protected]>
 M:	Stafford Horne <[email protected]>
+T:      git git://github.com/openrisc/linux.git
 L:	openrisc at lists.librecores.org
 W:	http://openrisc.io
 S:	Maintained

Signature · 1 line

2.9.3

Jonas Bonn

maintainer

2016-12-31 14:10 UTC #5 lore raw

In reply to Stafford Horne

Hi Stafford,

Quoted 8 lines · Stafford Horne

Hello,
These are a few small changes for openrisc I would like to include in 4.10. The main change is a fix for building with alldefconfig to properly setup then _text symbol. Others are trivial.
If no complaints I will push to 4.10 for inclusion and start working on 4.11 changes.

Post-merge window patches should be bug fixes, only. Patch 1/3 probably qualifies, but the others are far too trivial to be pushing now. Just put them on your 4.11 branch.

Quoted 2 lines

Let me know if these are too minor to even post for review.

Nothing is too minor to post for review!

/Jonas

Quoted 12 lines

Stafford Horne (3):
openrisc: Add _text symbol to fix ksym build error
openrisc: Add .gitignore
MAINTAINERS: Add the openrisc official repository
  MAINTAINERS                        | 1 +
  arch/openrisc/kernel/.gitignore    | 1 +
  arch/openrisc/kernel/vmlinux.lds.S | 2 ++
  3 files changed, 4 insertions(+)
create mode 100644 arch/openrisc/kernel/.gitignore

Stafford Horne

author maintainer

2016-12-31 22:50 UTC #6 lore raw

Hi Jonas,

Quoted 9 lines · Jonas Bonn

Hi Stafford,
Quoted 6 lines · Stafford Horne
Hello,
These are a few small changes for openrisc I would like to include in 4.10. The main change is a fix for building with alldefconfig to properly setup then _text symbol. Others are trivial.

Quoted 6 lines

Quoted 2 lines
If no complaints I will push to 4.10 for inclusion and start working on 4.11 changes.
Post-merge window patches should be bug fixes, only. Patch 1/3 probably qualifies, but the others are far too trivial to be pushing now. Just put them on your 4.11 branch.

Thanks, for some reason I thought minor changes like this were ok too. I will only push the one change in this case. The rest will go to my 4.11 queue, which I'll send for review in the next few days.

That brings up a question, Do you want to stay in the MAINTAINERS file? I noticed sometimes you dont get around to review, but often when you do the reviews are helpful like this one.

Quoted 2 lines

Quoted 1 line
Let me know if these are too minor to even post for review.
Nothing is too minor to post for review!

Good to know!

-Stafford

Quoted 13 lines

Quoted 12 lines
Stafford Horne (3):
openrisc: Add _text symbol to fix ksym build error
openrisc: Add .gitignore
MAINTAINERS: Add the openrisc official repository
  MAINTAINERS                        | 1 +
  arch/openrisc/kernel/.gitignore    | 1 +
  arch/openrisc/kernel/vmlinux.lds.S | 2 ++
  3 files changed, 4 insertions(+)
create mode 100644 arch/openrisc/kernel/.gitignore

Jonas Bonn

maintainer

2017-01-02 10:34 UTC #7 lore raw

Quoted 11 lines · Stafford Horne

Hi Jonas,
Quoted 5 lines · Jonas Bonn
Hi Stafford,
Post-merge window patches should be bug fixes, only. Patch 1/3 probably qualifies, but the others are far too trivial to be pushing now. Just put them on your 4.11 branch.
Thanks, for some reason I thought minor changes like this were ok too. I will only push the one change in this case. The rest will go to my 4.11 queue, which I'll send for review in the next few days.

Actually, it's not even bug-fixes, just fixes for regressions. Patch 1 fixes something which has never worked so it's not even a regression... just hold everything for 4.11. Get your 4.11 branch ready and pushed to -next now and then start working on stuff for 4.12.

Quoted 4 lines

That brings up a question, Do you want to stay in the MAINTAINERS file? I noticed sometimes you dont get around to review, but often when you do the reviews are helpful like this one.

Yes, keep me in the MAINTAINERS file.

Thanks,
Jonas

Richard Weinberger

2017-01-02 11:15 UTC #8 lore raw

Quoted 13 lines · Jonas Bonn

Quoted 12 lines · Stafford Horne
Hi Jonas,
Quoted 7 lines · Jonas Bonn
Hi Stafford,
Post-merge window patches should be bug fixes, only. Patch 1/3 probably qualifies, but the others are far too trivial to be pushing now. Just put
them on your 4.11 branch.

Quoted 5 lines

Quoted 3 lines
Thanks, for some reason I thought minor changes like this were ok too. I will only push the one change in this case. The rest will go to my 4.11 queue, which I'll send for review in the next few days.
Actually, it's not even bug-fixes, just fixes for regressions. Patch 1 fixes

Well, it is not that strict.
Fixes for real bugs are perfectly fine in early -rcX releases and don't have to wait for a merge window.

Signature · 2 lines

Thanks,
//richard