Skip to contentSkip to conversation

Add some missing pkgconfig inherits

PATCH New Jussi Kukkonen 1 participant 4 messages Feb 6, 2017

lore
Share & tools
lore
#0 lore raw

cover Add some missing pkgconfig inherits

Found based on Martins 'State of bitbake world'. These don't always come up because host pkg-config may give reasonable looking results.

Thanks,
Jussi

The following changes since commit c62908e6a3ecd4d3cde2576f226d669a8299298d:

gcc-6: Sync gcc stddef.h with musl stddef.h (2017-02-05 09:22:18 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib jku/missing-pkgconfigs
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/missing-pkgconfigs

Jussi Kukkonen (3):
pong-clock: Add missing 'inherit pkgconfig'
latencytop: Add missing 'inherit pkgconfig'
qemu: Add missing 'inherit pkgconfig'

 meta/recipes-devtools/qemu/qemu.inc                | 2 +-
 meta/recipes-graphics/pong-clock/pong-clock_1.0.bb | 2 +-
 meta/recipes-kernel/latencytop/latencytop_0.5.bb   | 2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/3 pong-clock: Add missing 'inherit pkgconfig'

The usage of pkg-config is sneakily hidden in do_compile()

---
 meta/recipes-graphics/pong-clock/pong-clock_1.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/pong-clock/pong-clock_1.0.bb +1 -1
index 6c3bcd8..cdfe38a 100644
@@ -2,7 +2,7 @@ SUMMARY = "A clock combined with a game of pong"
 LICENSE = "GPLv2+"
 DEPENDS = "virtual/libx11 xdmcp xau"
 
-inherit distro_features_check
+inherit distro_features_check pkgconfig
 # depends on virtual/libx11
 REQUIRED_DISTRO_FEATURES = "x11"
 
Signature · 1 line
2.1.4
#2 lore raw

PATCH 2/3 latencytop: Add missing 'inherit pkgconfig'

In reply to Jussi Kukkonen

The Makefile uses pkg-config.

---
 meta/recipes-kernel/latencytop/latencytop_0.5.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-kernel/latencytop/latencytop_0.5.bb +2 -0
index f31f1bb..c38a038 100644
@@ -4,6 +4,8 @@ HOMEPAGE = "http://www.latencytop.org/"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://latencytop.c;endline=23;md5=ee9ea9b1415356e5734adad4a87dc7fa"
 
+inherit pkgconfig
+
 DEPENDS = "virtual/libintl ncurses glib-2.0"
 
 PR = "r3"
Signature · 1 line
2.1.4
#3 lore raw

PATCH 3/3 qemu: Add missing 'inherit pkgconfig'

In reply to Jussi Kukkonen

The monster configure file does call pkg-config somewhere in there.

---
 meta/recipes-devtools/qemu/qemu.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/qemu/qemu.inc +1 -1
index e3af5c2..ef5d75c 100644
@@ -6,7 +6,7 @@ RDEPENDS_${PN}_class-target += "bash"
 RDEPENDS_${PN}-ptest = "bash make"
 
 require qemu-targets.inc
-inherit autotools ptest
+inherit autotools pkgconfig ptest
 BBCLASSEXTEND = "native nativesdk"
 
 # QEMU_TARGETS is overridable variable
Signature · 1 line
2.1.4