insane.bbclass: Add missing dependencies
v2 cover insane.bbclass: Add missing dependencies
From: Mariano Lopez <[email protected]>
Changes in v2:
- Add binutils as dependency too
The following changes since commit a624cf7f95c8cf4ff764cc997fd1db4601b97dcc:
oeqa/selftest/pkgdata: use m4 instead of bash (2017-02-07 14:50:10 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib mariano/insane_fix
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=mariano/insane_fix
Mariano Lopez (1):
insane.bbclass: Add missing dependencies
meta/classes/insane.bbclass | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.10.2
PATCH v2 1/1 insane.bbclass: Add missing dependencies
From: Mariano Lopez <[email protected]>
package_qa task requires some tools installed in sysroot; with the introduction of recipe specific sysroot this task won't have such tools installed if it's forced to run.
--- meta/classes/insane.bbclass | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
meta/classes/insane.bbclass +4 -1
@@ -1223,9 +1223,12 @@ python do_package_qa () { bb.note("DONE with PACKAGE QA") } +# binutils is used for most checks, so need to set as dependency +# POPULATESYSROOTDEPS is defined in staging class. +do_package_qa[depends] += "${POPULATESYSROOTDEPS}" do_package_qa[vardepsexclude] = "BB_TASKDEPDATA" do_package_qa[rdeptask] = "do_packagedata" -addtask do_package_qa after do_packagedata do_package before do_build +addtask do_package_qa after do_prepare_recipe_sysroot do_packagedata do_package before do_build SSTATETASKS += "do_package_qa" do_package_qa[sstate-inputdirs] = ""
Signature · 1 line
2.10.2
Quoted 23 lines · On Fri, 2017-02-10 at 14:19 -0600, [email protected] wrote:
From: Mariano Lopez <[email protected]>
package_qatask requires some tools installed in sysroot; with the introduction of recipe specific sysroot this task won't have such tools installed if it's forced to run.Signed-off-by Mariano Lopez <[email protected]>---
meta/classes/insane.bbclass | 5 ++++-1 file changed, 4 insertions(+), 1 deletion(-)meta/classes/insane.bbclass +0
-0@@ -1223,9 +1223,12 @@ python do_package_qa () { bb.note("DONE with PACKAGE QA") }meta/classes/insane.bbclass +3
-0+# binutils is used for most checks, so need to set as dependency +# POPULATESYSROOTDEPS is defined in staging class. +do_package_qa[depends] += "${POPULATESYSROOTDEPS}"
Quoted 6 lines
do_package_qa[vardepsexclude] = "
BB_TASKDEPDATA" do_package_qa[rdeptask] = "do_packagedata"
-addtaskdo_package_qaafterdo_packagedatado_packagebeforedo_build
+addtaskdo_package_qaafterdo_prepare_recipe_sysrootdo_packagedatado_packagebeforedo_build
This is close but I don't think you need this last addtask change, I think it should work just fine with the added [depends]?
Cheers,
Richard
Quoted 21 lines · Richard Purdie
Quoted 20 lines · On Fri, 2017-02-10 at 14:19 -0600, [email protected] wrote:
From: Mariano Lopez <[email protected]>
package_qatask requires some tools installed in sysroot; with the introduction of recipe specific sysroot this task won't have such tools installed if it's forced to run.Signed-off-by Mariano Lopez <[email protected]>--- meta/classes/insane.bbclass | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)meta/classes/insane.bbclass +0
-0@@ -1223,9 +1223,12 @@ python do_package_qa () { bb.note("DONE with PACKAGE QA") }
Quoted 11 lines
Quoted 9 lines
meta/classes/insane.bbclass +3
-1+# binutils is used for most checks, so need to set as dependency +# POPULATESYSROOTDEPS is defined in staging class. +do_package_qa[depends] += "${POPULATESYSROOTDEPS}" do_package_qa[vardepsexclude] = "BB_TASKDEPDATA" do_package_qa[rdeptask] = "do_packagedata" -addtask do_package_qa after do_packagedata do_package before
do_build
+addtaskdo_package_qaafterdo_prepare_recipe_sysrootdo_packagedatado_packagebeforedo_buildThis is close but I don't think you need this last addtask change, I think it should work just fine with the added [depends]?
Indeed, it works just with [depends]. Just sent v3 of this patch.
Mariano
Quoted 4 lines
Cheers,
Richard