prepare mac operations for multiple queues
Subsystems (5)
v4 cover prepare mac operations for multiple queues
As agreed with David Miller, this patch-set is the first of 3 to enable multiple queues in stmmac.
This first one concentrates on mac operations adding functionalities as:
a) Configuration through DT
b) RX and TX scheduling algorithms programming
b) TX queues weight programming (essential in weightes algorithms)
c) RX enable as DCB or AVB (preparing for future AVB support)
d) Mapping RX queue to DMA channel
e) IRQ treatment prepared for multiple queues
f) Debug dump prepared for multiple queues
g) CBS configuration
In v3 patch-set version I included a new patch to enable CBS configuration (Patch 9).
Yesterday I sent by mistake a pseudo-v4 that did not even entered patchwork. Please consider this v4 as the official one. Sorry for the inconvenience.
Joao Pinto (9):
net: stmicro: multiple queues dt configuration
net: stmicro: configure mtl rx and tx algorithms
net: stmicro: configure tx queue weight
net: stmicro: mtl rx queue enabled as dcb or avb
net: stmicro: mapping mtl rx to dma channel
net: stmicro: flow_ctrl functions adapted to mtl
net: stmicro: prepare irq_status for mtl
net: stmicro: mac debug prepared for multiple queues
net: stmicro: configuration of CBS in case of a TX AVB queue
Documentation/devicetree/bindings/net/stmmac.txt | 58 +++- drivers/net/ethernet/stmicro/stmmac/common.h | 22 +- .../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 6 +- .../net/ethernet/stmicro/stmmac/dwmac100_core.c | 3 +- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 59 +++- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 302 ++++++++++++++++----- .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 8 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 142 ++++++++-- .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 114 ++++++++ include/linux/stmmac.h | 36 +++ 10 files changed, 647 insertions(+), 103 deletions(-)
Signature · 1 line
2.9.3
PATCH v4 1/9 net: stmicro: multiple queues dt configuration
This patch adds the multiple queues configuration in the Device Tree. It was also created a set of structures to keep the RX and TX queues configurations to be used in the driver.
---
Changes v2->v4:
- Just to keep up with patch-set version
Changes v1->v2:
- RX and TX queues child nodes had bad handle
Documentation/devicetree/bindings/net/stmmac.txt | 40 ++++++++++ .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 91 ++++++++++++++++++++++ include/linux/stmmac.h | 30 +++++++ 3 files changed, 161 insertions(+)
Documentation/devicetree/bindings/net/stmmac.txt +40 -0
@@ -72,6 +72,27 @@ Optional properties: - snps,mb: mixed-burst - snps,rb: rebuild INCRx Burst - mdio: with compatible = "snps,dwmac-mdio", create and register mdio bus. +- Multiple RX Queues parameters: below the list of all the parameters to + configure the multiple RX queues: + - snps,rx-queues-to-use: number of RX queues to be used in the driver + - Choose one of these RX scheduling algorithms: + - snps,rx-sched-sp: Strict priority + - snps,rx-sched-wsp: Weighted Strict priority + - For each RX queue + - Choose one of these modes: + - snps,dcb-algorithm: Queue to be enabled as DCB + - snps,avb-algorithm: Queue to be enabled as AVB + - snps,map-to-dma-channel: Channel to map +- Multiple TX Queues parameters: below the list of all the parameters to + configure the multiple TX queues: + - snps,tx-queues-to-use: number of TX queues to be used in the driver + - Choose one of these TX scheduling algorithms: + - snps,tx-sched-wrr: Weighted Round Robin + - snps,tx-sched-wfq: Weighted Fair Queuing + - snps,tx-sched-dwrr: Deficit Weighted Round Robin + - snps,tx-sched-sp: Strict priority + - For each TX queue + - snps,weight: TX queue weight (if using a weighted algorithm) Examples:
@@ -81,6 +102,23 @@ Examples: snps,blen = <256 128 64 32 0 0 0>; }; + mtl_rx_setup: rx-queues-config { + snps,rx-queues-to-use = <1>; + snps,rx-sched-sp; + queue0 { + snps,dcb-algorithm; + snps,map-to-dma-channel = <0x0>; + }; + }; + + mtl_tx_setup: tx-queues-config { + snps,tx-queues-to-use = <1>; + snps,tx-sched-wrr; + queue0 { + snps,weight = <0x10>; + }; + }; + gmac0: ethernet@e0800000 { compatible = "st,spear600-gmac"; reg = <0xe0800000 0x8000>;
@@ -104,4 +142,6 @@ Examples: phy1: ethernet-phy@0 { }; }; + snps,mtl-rx-config = <&mtl_rx_setup>; + snps,mtl-tx-config = <&mtl_tx_setup>; };
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +91 -0
103 lines not on this page · raw message
include/linux/stmmac.h +30 -0
@@ -28,6 +28,9 @@#include <linux/platform_device.h> +#define MTL_MAX_RX_QUEUES 8 +#define MTL_MAX_TX_QUEUES 8 +#define STMMAC_RX_COE_NONE 0#define STMMAC_RX_COE_TYPE1 1#define STMMAC_RX_COE_TYPE2 2
@@ -44,6 +47,18 @@#define STMMAC_CSR_150_250M 0x4/* MDC = clk_scr_i/102 */ #define STMMAC_CSR_250_300M 0x5/* MDC = clk_scr_i/122 */ +/* MTL algorithms identifiers */ +#define MTL_TX_ALGORITHM_WRR 0x0 +#define MTL_TX_ALGORITHM_WFQ 0x1 +#define MTL_TX_ALGORITHM_DWRR 0x2 +#define MTL_TX_ALGORITHM_SP 0x3 +#define MTL_RX_ALGORITHM_SP 0x4 +#define MTL_RX_ALGORITHM_WSP 0x5 + +/* RX Queue Mode */ +#define MTL_RX_DCB 0x0 +#define MTL_RX_AVB 0x1 +/* The MDC clock could be set higher than the IEEE 802.3 * specified frequency limit 0f 2.5 MHz, by programming a clock divider * of value different than the above defined values. The resultant MDIO
@@ -109,6 +124,15 @@ struct stmmac_axi {bool axi_rb; }; +struct stmmac_rxq_cfg { +u8 mode_to_use; +u8 chan; +}; + +struct stmmac_txq_cfg { +u8 weight; +}; +struct plat_stmmacenet_data {int bus_id;int phy_addr;
@@ -133,6 +157,12 @@ struct plat_stmmacenet_data {int unicast_filter_entries;int tx_fifo_size;int rx_fifo_size; +u8 rx_queues_to_use; +u8 tx_queues_to_use; +u8 rx_sched_algorithm; +u8 tx_sched_algorithm; +struct stmmac_rxq_cfg rx_queues_cfg[MTL_MAX_RX_QUEUES ]; +struct stmmac_txq_cfg tx_queues_cfg[MTL_MAX_TX_QUEUES ];void (*fix_mac_speed)(void *priv,unsigned int speed);int (*init)(struct platform_device *pdev,void *priv);void (*exit)(struct platform_device *pdev,void *priv);
Signature · 1 line
2.9.3
PATCH v4 2/9 net: stmicro: configure mtl rx and tx algorithms
In reply to Joao PintoThis patch adds the RX and TX scheduling algorithms programming. It introduces the multiple queues configuration function (stmmac_mtl_configuration) in stmmac_main.
---
Changes v3->v4:
- Just to keep up with patch-set version
Changes v2->v3:
- Switch statements with a tab
Changes v1->v2:
- Just to keep up with patch-set version
drivers/net/ethernet/stmicro/stmmac/common.h | 4 ++ drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 10 +++++ drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 48 +++++++++++++++++++++++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 31 +++++++++++++-- 4 files changed, 90 insertions(+), 3 deletions(-)
drivers/net/ethernet/stmicro/stmmac/common.h +4 -0
@@ -455,6 +455,10 @@ struct stmmac_ops {int (*rx_ipc)(struct mac_device_info *hw);/* Enable RX Queues */ void (*rx_queue_enable)(struct mac_device_info *hw,u32 queue); +/* Program RX Algorithms */ +void (*prog_mtl_rx_algorithms)(struct mac_device_info *hw,u32 rx_alg); +/* Program TX Algorithms */ +void (*prog_mtl_tx_algorithms)(struct mac_device_info *hw,u32 tx_alg);/* Dump MAC registers */ void (*dump_regs)(struct mac_device_info *hw,u32 *reg_space);/* Handle extra events on specific interrupts hw dependent */
drivers/net/ethernet/stmicro/stmmac/dwmac4.h +10 -0
@@ -161,6 +161,16 @@ enum power_event {#define GMAC_HI_REG_AE BIT(31)/* MTL registers */ +#define MTL_OPERATION_MODE 0x00000c00 +#define MTL_OPERATION_SCHALG_MASK GENMASK(6, 5) +#define MTL_OPERATION_SCHALG_WRR (0x0 << 5) +#define MTL_OPERATION_SCHALG_WFQ (0x1 << 5) +#define MTL_OPERATION_SCHALG_DWRR (0x2 << 5) +#define MTL_OPERATION_SCHALG_SP (0x3 << 5) +#define MTL_OPERATION_RAA BIT(2) +#define MTL_OPERATION_RAA_SP (0x0 << 2) +#define MTL_OPERATION_RAA_WSP (0x1 << 2) +#define MTL_INT_STATUS 0x00000c20#define MTL_INT_Q0 BIT(0)
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +48 -0
60 lines not on this page · raw message
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +28 -3
@@ -1645,6 +1645,31 @@ static void stmmac_init_tx_coalesce(struct stmmac_priv *priv) }/** +* stmmac_mtl_configuration - Configure MTL +* @priv: driver private structure +* Description: It is used for configurring MTL +*/ +static void stmmac_mtl_configuration (struct stmmac_priv *priv) +{ +u32 rx_queues_count = priv->plat->rx_queues_to_use; +u32 tx_queues_count = priv->plat->tx_queues_to_use; + +/* Configure MTL RX algorithms */ +if (rx_queues_count >1 && priv->hw->mac->prog_mtl_rx_algorithms) + priv->hw->mac->prog_mtl_rx_algorithms (priv->hw, + priv->plat->rx_sched_algorithm); + +/* Configure MTL TX algorithms */ +if (tx_queues_count >1 && priv->hw->mac->prog_mtl_tx_algorithms) + priv->hw->mac->prog_mtl_tx_algorithms (priv->hw, + priv->plat->tx_sched_algorithm); + +/* Enable MAC RX Queues */ +if (rx_queues_count >1 && priv->hw->mac->rx_queue_enable) +stmmac_mac_enable_rx_queues (priv); +} + +/** * stmmac_hw_setup - setup mac in a usable state. * @dev : pointer to the device structure. * Description:
@@ -1688,9 +1713,9 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp)/* Initialize the MAC Core */ priv->hw->mac->core_init (priv->hw, dev->mtu); -/* Initialize MAC RX Queues */ -if (priv->hw->mac->rx_queue_enable) -stmmac_mac_enable_rx_queues (priv); +/* Initialize MTL*/ +if (priv->synopsys_id >=DWMAC_CORE_4_00 ) +stmmac_mtl_configuration (priv); ret = priv->hw->mac->rx_ipc (priv->hw);if (!ret) {
Signature · 1 line
2.9.3
PATCH v4 3/9 net: stmicro: configure tx queue weight
In reply to Joao PintoThis patch adds TX queues weight programming.
---
Changes v3->v4:
- variable init was simplified in some functions Changes v2->v3:
- local variable declarations from longest to shortest line Changes v1->v2:
- Just to keep up with patch-set version
drivers/net/ethernet/stmicro/stmmac/common.h | 3 +++ drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 7 +++++++ drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 12 ++++++++++++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 20 ++++++++++++++++++++ 4 files changed, 42 insertions(+)
drivers/net/ethernet/stmicro/stmmac/common.h +3 -0
@@ -459,6 +459,9 @@ struct stmmac_ops {void (*prog_mtl_rx_algorithms)(struct mac_device_info *hw,u32 rx_alg);/* Program TX Algorithms */ void (*prog_mtl_tx_algorithms)(struct mac_device_info *hw,u32 tx_alg); +/* Set MTL TX queues weight */ +void (*set_mtl_tx_queue_weight)(struct mac_device_info *hw, +u32 weight,u32 queue);/* Dump MAC registers */ void (*dump_regs)(struct mac_device_info *hw,u32 *reg_space);/* Handle extra events on specific interrupts hw dependent */
drivers/net/ethernet/stmicro/stmmac/dwmac4.h +7 -0
@@ -211,6 +211,13 @@ enum power_event {#define MTL_OP_MODE_RTC_96 (2 << MTL_OP_MODE_RTC_SHIFT)#define MTL_OP_MODE_RTC_128 (3 << MTL_OP_MODE_RTC_SHIFT) +/* MTL Queue Quantum Weight */ +#define MTL_TXQ_WEIGHT_BASE_ADDR 0x00000d18 +#define MTL_TXQ_WEIGHT_BASE_OFFSET 0x40 +#define MTL_TXQX_WEIGHT_BASE_ADDR (x) (MTL_TXQ_WEIGHT_BASE_ADDR + \ + ((x) * MTL_TXQ_WEIGHT_BASE_OFFSET)) +#define MTL_TXQ_WEIGHT_ISCQW_MASK GENMASK(20, 0) +/* MTL debug */ #define MTL_DEBUG_TXSTSFSTS BIT(5)#define MTL_DEBUG_TXFSTS BIT(4)
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +12 -0
@@ -116,6 +116,17 @@ static void dwmac4_prog_mtl_tx_algorithms(struct mac_device_info *hw, } } +static void dwmac4_set_mtl_tx_queue_weight (struct mac_device_info *hw, +u32 weight,u32 queue) +{ +void __iomem *ioaddr = hw->pcsr; +u32 value =readl (ioaddr +MTL_TXQX_WEIGHT_BASE_ADDR (queue)); + + value &= ~MTL_TXQ_WEIGHT_ISCQW_MASK ; + value |= weight &MTL_TXQ_WEIGHT_ISCQW_MASK ; +writel (value, ioaddr +MTL_TXQX_WEIGHT_BASE_ADDR (queue)); +} +static void dwmac4_dump_regs (struct mac_device_info *hw,u32 *reg_space) {void __iomem *ioaddr = hw->pcsr;
@@ -505,6 +516,7 @@ static const struct stmmac_ops dwmac4_ops = { .rx_queue_enable = dwmac4_rx_queue_enable, .prog_mtl_rx_algorithms = dwmac4_prog_mtl_rx_algorithms, .prog_mtl_tx_algorithms = dwmac4_prog_mtl_tx_algorithms, + .set_mtl_tx_queue_weight = dwmac4_set_mtl_tx_queue_weight, .dump_regs = dwmac4_dump_regs, .host_irq_status = dwmac4_irq_status, .flow_ctrl = dwmac4_flow_ctrl,
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +20 -0
@@ -1645,6 +1645,23 @@ static void stmmac_init_tx_coalesce(struct stmmac_priv *priv) }/** +* stmmac_set_tx_queue_weight - Set TX queue weight +* @priv: driver private structure +* Description: It is used for setting TX queues weight +*/ +static void stmmac_set_tx_queue_weight (struct stmmac_priv *priv) +{ +u32 tx_queues_count = priv->plat->tx_queues_to_use; +u32 weight; +u32 queue; + +for (queue =0 ; queue < tx_queues_count; queue++) { + weight = priv->plat->tx_queues_cfg[queue].weight; + priv->hw->mac->set_mtl_tx_queue_weight (priv->hw, weight, queue); + } +} + +/** * stmmac_mtl_configuration - Configure MTL * @priv: driver private structure * Description: It is used for configurring MTL
@@ -1654,6 +1671,9 @@ static void stmmac_mtl_configuration(struct stmmac_priv *priv)u32 rx_queues_count = priv->plat->rx_queues_to_use;u32 tx_queues_count = priv->plat->tx_queues_to_use; +if (tx_queues_count >1 && priv->hw->mac->set_mtl_tx_queue_weight) +stmmac_set_tx_queue_weight (priv); +/* Configure MTL RX algorithms */ if (rx_queues_count >1 && priv->hw->mac->prog_mtl_rx_algorithms) priv->hw->mac->prog_mtl_rx_algorithms(priv->hw,
Signature · 1 line
2.9.3
PATCH v4 4/9 net: stmicro: mtl rx queue enabled as dcb or avb
In reply to Joao PintoThis patch introduces the enabling of RX queues as DCB or as AVB based on configuration.
---
Changes v3->v4:
- variable init was simplified in some functions
Changes v1->v3:
- Just to keep up with patch-set version
drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 8 ++++++-- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 19 +++++++------------ 3 files changed, 14 insertions(+), 15 deletions(-)
drivers/net/ethernet/stmicro/stmmac/common.h +1 -1
@@ -454,7 +454,7 @@ struct stmmac_ops {/* Enable and verify that the IPC module is supported */ int (*rx_ipc)(struct mac_device_info *hw);/* Enable RX Queues */ -void (*rx_queue_enable)(struct mac_device_info *hw,u32 queue); +void (*rx_queue_enable)(struct mac_device_info *hw,u8 mode,u32 queue);/* Program RX Algorithms */ void (*prog_mtl_rx_algorithms)(struct mac_device_info *hw,u32 rx_alg);/* Program TX Algorithms */
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +6 -2
@@ -59,13 +59,17 @@ static void dwmac4_core_init(struct mac_device_info *hw, int mtu)writel (value, ioaddr +GMAC_INT_EN ); } -static void dwmac4_rx_queue_enable (struct mac_device_info *hw,u32 queue) +static void dwmac4_rx_queue_enable (struct mac_device_info *hw, +u8 mode,u32 queue) {void __iomem *ioaddr = hw->pcsr;u32 value =readl (ioaddr +GMAC_RXQ_CTRL0 ); value &=GMAC_RX_QUEUE_CLEAR (queue); - value |=GMAC_RX_AV_QUEUE_ENABLE (queue); +if (mode ==MTL_RX_AVB ) + value |=GMAC_RX_AV_QUEUE_ENABLE (queue); +else if (mode ==MTL_RX_DCB ) + value |=GMAC_RX_DCB_QUEUE_ENABLE (queue);writel (value, ioaddr +GMAC_RXQ_CTRL0 ); }
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +7 -12
@@ -1256,19 +1256,14 @@ static void free_dma_desc_resources(struct stmmac_priv *priv)*/ static void stmmac_mac_enable_rx_queues (struct stmmac_priv *priv) { -int rx_count = priv->dma_cap.number_rx_queues; -int queue =0 ; - -/* If GMAC does not have multiple queues, then this is not necessary*/ -if (rx_count ==1 ) -return ; +u32 rx_queues_count = priv->plat->rx_queues_to_use; +int queue; +u8 mode; -/** -* If the core is synthesized with multiple rx queues / multiple -* dma channels, then rx queues will be disabled by default. -* For now only rx queue 0 is enabled. -*/ - priv->hw->mac->rx_queue_enable (priv->hw, queue); +for (queue =0 ; queue < rx_queues_count; queue++) { + mode = priv->plat->rx_queues_cfg[queue].mode_to_use; + priv->hw->mac->rx_queue_enable (priv->hw, mode, queue); + } }/**
Signature · 1 line
2.9.3
PATCH v4 5/9 net: stmicro: mapping mtl rx to dma channel
In reply to Joao PintoThis patch adds the functionality of RX queue to dma channel mapping based on configuration.
---
changes v3->v4:
- variable init was simplified in some functions
changes v1->v3:
- Just to keep up with patch-set version
drivers/net/ethernet/stmicro/stmmac/common.h | 2 ++ drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 7 +++++++ drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 25 +++++++++++++++++++++++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 21 +++++++++++++++++++ 4 files changed, 55 insertions(+)
drivers/net/ethernet/stmicro/stmmac/common.h +2 -0
@@ -462,6 +462,8 @@ struct stmmac_ops {/* Set MTL TX queues weight */ void (*set_mtl_tx_queue_weight)(struct mac_device_info *hw,u32 weight,u32 queue); +/* RX MTL queue to RX dma mapping */ +void (*map_mtl_to_dma)(struct mac_device_info *hw,u32 queue,u32 chan);/* Dump MAC registers */ void (*dump_regs)(struct mac_device_info *hw,u32 *reg_space);/* Handle extra events on specific interrupts hw dependent */
drivers/net/ethernet/stmicro/stmmac/dwmac4.h +7 -0
@@ -174,6 +174,13 @@ enum power_event {#define MTL_INT_STATUS 0x00000c20#define MTL_INT_Q0 BIT(0) +#define MTL_RXQ_DMA_MAP0 0x00000c30/* queue 0 to 3 */ +#define MTL_RXQ_DMA_MAP1 0x00000c34/* queue 4 to 7 */ +#define MTL_RXQ_DMA_Q04MDMACH_MASK GENMASK(3, 0) +#define MTL_RXQ_DMA_Q04MDMACH (x) ((x) << 0) +#define MTL_RXQ_DMA_QXMDMACH_MASK (x) GENMASK(11 + (8 * ((x) - 1)), 8 * (x)) +#define MTL_RXQ_DMA_QXMDMACH (chan, q) ((chan) << (8 * (q))) +#define MTL_CHAN_BASE_ADDR 0x00000d00#define MTL_CHAN_BASE_OFFSET 0x40#define MTL_CHANX_BASE_ADDR (x) (MTL_CHAN_BASE_ADDR + \
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +25 -0
@@ -131,6 +131,30 @@ static void dwmac4_set_mtl_tx_queue_weight(struct mac_device_info *hw,writel (value, ioaddr +MTL_TXQX_WEIGHT_BASE_ADDR (queue)); } +static void dwmac4_map_mtl_dma (struct mac_device_info *hw,u32 queue,u32 chan) +{ +void __iomem *ioaddr = hw->pcsr; +u32 value; + +if (queue <4 ) + value =readl (ioaddr +MTL_RXQ_DMA_MAP0 ); +else + value =readl (ioaddr +MTL_RXQ_DMA_MAP1 ); + +if (queue ==0 || queue ==4 ) { + value &= ~MTL_RXQ_DMA_Q04MDMACH_MASK ; + value |=MTL_RXQ_DMA_Q04MDMACH (chan); + }else { + value &= ~MTL_RXQ_DMA_QXMDMACH_MASK (queue); + value |=MTL_RXQ_DMA_QXMDMACH (chan, queue); + } + +if (queue <4 ) +writel (value, ioaddr +MTL_RXQ_DMA_MAP0 ); +else +writel (value, ioaddr +MTL_RXQ_DMA_MAP1 ); +} +static void dwmac4_dump_regs (struct mac_device_info *hw,u32 *reg_space) {void __iomem *ioaddr = hw->pcsr;
@@ -521,6 +545,7 @@ static const struct stmmac_ops dwmac4_ops = { .prog_mtl_rx_algorithms = dwmac4_prog_mtl_rx_algorithms, .prog_mtl_tx_algorithms = dwmac4_prog_mtl_tx_algorithms, .set_mtl_tx_queue_weight = dwmac4_set_mtl_tx_queue_weight, + .map_mtl_to_dma = dwmac4_map_mtl_dma, .dump_regs = dwmac4_dump_regs, .host_irq_status = dwmac4_irq_status, .flow_ctrl = dwmac4_flow_ctrl,
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +21 -0
@@ -1657,6 +1657,23 @@ static void stmmac_set_tx_queue_weight(struct stmmac_priv *priv) }/** +* stmmac_rx_queue_dma_chan_map - Map RX queue to RX dma channel +* @priv: driver private structure +* Description: It is used for mapping RX queues to RX dma channels +*/ +static void stmmac_rx_queue_dma_chan_map (struct stmmac_priv *priv) +{ +u32 rx_queues_count = priv->plat->rx_queues_to_use; +u32 queue; +u32 chan; + +for (queue =0 ; queue < rx_queues_count; queue++) { + chan = priv->plat->rx_queues_cfg[queue].chan; + priv->hw->mac->map_mtl_to_dma (priv->hw, queue, chan); + } +} + +/** * stmmac_mtl_configuration - Configure MTL * @priv: driver private structure * Description: It is used for configurring MTL
@@ -1679,6 +1696,10 @@ static void stmmac_mtl_configuration(struct stmmac_priv *priv) priv->hw->mac->prog_mtl_tx_algorithms (priv->hw, priv->plat->tx_sched_algorithm); +/* Map RX MTL to DMA channels */ +if (rx_queues_count >1 && priv->hw->mac->map_mtl_to_dma) +stmmac_rx_queue_dma_chan_map (priv); +/* Enable MAC RX Queues */ if (rx_queues_count >1 && priv->hw->mac->rx_queue_enable)stmmac_mac_enable_rx_queues (priv);
Signature · 1 line
2.9.3
PATCH v4 6/9 net: stmicro: flow_ctrl functions adapted to mtl
In reply to Joao PintoThis patch adapts flow_ctrl function to prepare it for multiple queues.
---
Changes v3->v4:
- variable init simplified in some functions
Changes v1->v3:
- Just to keep up with patch-set version
drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 3 ++- drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c | 3 ++- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 20 +++++++++++++------- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 3 ++- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 17 ++++++++++++++--- 6 files changed, 34 insertions(+), 14 deletions(-)
drivers/net/ethernet/stmicro/stmmac/common.h +1 -1
@@ -473,7 +473,7 @@ struct stmmac_ops {void (*set_filter)(struct mac_device_info *hw,struct net_device *dev);/* Flow control setting */ void (*flow_ctrl)(struct mac_device_info *hw,unsigned int duplex, -unsigned int fc,unsigned int pause_time); +unsigned int fc,unsigned int pause_time,u32 tx_cnt);/* Set power management mode (e.g. magic frame) */ void (*pmt)(struct mac_device_info *hw,unsigned long mode);/* Set/Get Unicast MAC addresses */
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c +2 -1
@@ -216,7 +216,8 @@ static void dwmac1000_set_filter(struct mac_device_info *hw,static void dwmac1000_flow_ctrl (struct mac_device_info *hw,unsigned int duplex, -unsigned int fc,unsigned int pause_time) +unsigned int fc,unsigned int pause_time, +u32 tx_cnt) {void __iomem *ioaddr = hw->pcsr;/* Set flow such that DZPQ in Mac Register 6 is 0,
drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c +2 -1
@@ -131,7 +131,8 @@ static void dwmac100_set_filter(struct mac_device_info *hw, }static void dwmac100_flow_ctrl (struct mac_device_info *hw,unsigned int duplex, -unsigned int fc,unsigned int pause_time) +unsigned int fc,unsigned int pause_time, +u32 tx_cnt) {void __iomem *ioaddr = hw->pcsr;unsigned int flow =MAC_FLOW_CTRL_ENABLE ;
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +13 -7
@@ -336,11 +336,12 @@ static void dwmac4_set_filter(struct mac_device_info *hw, }static void dwmac4_flow_ctrl (struct mac_device_info *hw,unsigned int duplex, -unsigned int fc,unsigned int pause_time) +unsigned int fc,unsigned int pause_time, +u32 tx_cnt) {void __iomem *ioaddr = hw->pcsr; -u32 channel =STMMAC_CHAN0 ;/* FIXME */ unsigned int flow =0 ; +u32 queue;pr_debug ("GMAC Flow-Control:\n" );if (fc &FLOW_RX ) {
@@ -350,13 +351,18 @@ static void dwmac4_flow_ctrl(struct mac_device_info *hw, unsigned int duplex, }if (fc &FLOW_TX ) {pr_debug ("\tTransmit Flow-Control ON\n" ); - flow |=GMAC_TX_FLOW_CTRL_TFE ; -writel (flow, ioaddr +GMAC_QX_TX_FLOW_CTRL (channel)); -if (duplex) { +if (duplex)pr_debug ("\tduplex mode: PAUSE %d\n" , pause_time); - flow |= (pause_time <<GMAC_TX_FLOW_CTRL_PT_SHIFT ); -writel (flow, ioaddr +GMAC_QX_TX_FLOW_CTRL (channel)); + +for (queue =0 ; queue < tx_cnt; queue++) { + flow |=GMAC_TX_FLOW_CTRL_TFE ; + +if (duplex) + flow |= + (pause_time <<GMAC_TX_FLOW_CTRL_PT_SHIFT ); + +writel (flow, ioaddr +GMAC_QX_TX_FLOW_CTRL (queue)); } } }
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +2 -1
@@ -481,6 +481,7 @@ stmmac_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause) {struct stmmac_priv *priv =netdev_priv (netdev); +u32 tx_cnt = priv->plat->tx_queues_to_use;struct phy_device *phy = netdev->phydev;int new_pause =FLOW_OFF ;
@@ -511,7 +512,7 @@ stmmac_set_pauseparam(struct net_device *netdev, } priv->hw->mac->flow_ctrl (priv->hw, phy->duplex, priv->flow_ctrl, - priv->pause); + priv->pause, tx_cnt);return 0 ; }
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +14 -3
@@ -673,6 +673,19 @@ static void stmmac_release_ptp(struct stmmac_priv *priv) }/** +* stmmac_mac_flow_ctrl - Configure flow control in all queues +* @priv: driver private structure +* Description: It is used for configuring the flow control in all queues +*/ +static void stmmac_mac_flow_ctrl (struct stmmac_priv *priv,u32 duplex) +{ +u32 tx_cnt = priv->plat->tx_queues_to_use; + + priv->hw->mac->flow_ctrl (priv->hw, duplex, priv->flow_ctrl, + priv->pause, tx_cnt); +} + +/** * stmmac_adjust_link - adjusts the link parameters * @dev: net device structure * Description: this is the helper called by the physical abstraction layer
@@ -687,7 +700,6 @@ static void stmmac_adjust_link(struct net_device *dev)struct phy_device *phydev = dev->phydev;unsigned long flags;int new_state =0 ; -unsigned int fc = priv->flow_ctrl, pause_time = priv->pause;if (!phydev)return ;
@@ -709,8 +721,7 @@ static void stmmac_adjust_link(struct net_device *dev) }/* Flow Control operation */ if (phydev->pause) - priv->hw->mac->flow_ctrl (priv->hw, phydev->duplex, - fc, pause_time); +stmmac_mac_flow_ctrl (priv, phydev->duplex);if (phydev->speed != priv->speed) { new_state =1 ;
Signature · 1 line
2.9.3
PATCH v4 7/9 net: stmicro: prepare irq_status for mtl
In reply to Joao PintoThis patch prepares mac irq status treatment for multiple queues.
---
Changes v3->v4:
- Build error in dwmac4_irq_mtl_status()
- variable init simplified in some functions changes v2->v3:
- local variable declarations from longest to shortest line changes v1->v2:
- Just to keep up with patch-set version
drivers/net/ethernet/stmicro/stmmac/common.h | 2 ++ drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 40 ++++++++++++++--------- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +++ 4 files changed, 33 insertions(+), 16 deletions(-)
drivers/net/ethernet/stmicro/stmmac/common.h +2 -0
@@ -469,6 +469,8 @@ struct stmmac_ops {/* Handle extra events on specific interrupts hw dependent */ int (*host_irq_status)(struct mac_device_info *hw,struct stmmac_extra_stats *x); +/* Handle MTL interrupts */ +int (*host_mtl_irq_status)(struct mac_device_info *hw,u32 chan);/* Multicast filter setting */ void (*set_filter)(struct mac_device_info *hw,struct net_device *dev);/* Flow control setting */
drivers/net/ethernet/stmicro/stmmac/dwmac4.h +1 -1
@@ -172,7 +172,7 @@ enum power_event {#define MTL_OPERATION_RAA_WSP (0x1 << 2)#define MTL_INT_STATUS 0x00000c20 -#define MTL_INT_Q0 BIT(0) +#define MTL_INT_QX (x) BIT(x)#define MTL_RXQ_DMA_MAP0 0x00000c30/* queue 0 to 3 */ #define MTL_RXQ_DMA_MAP1 0x00000c34/* queue 4 to 7 */
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +25 -15
@@ -416,11 +416,34 @@ static void dwmac4_phystatus(void __iomem *ioaddr, struct stmmac_extra_stats *x) } } +static int dwmac4_irq_mtl_status (struct mac_device_info *hw,u32 chan) +{ +void __iomem *ioaddr = hw->pcsr; +u32 mtl_int_qx_status; +int ret =0 ; + + mtl_int_qx_status =readl (ioaddr +MTL_INT_STATUS ); + +/* Check MTL Interrupt */ +if (mtl_int_qx_status &MTL_INT_QX (chan)) { +/* read Queue x Interrupt status */ +u32 status =readl (ioaddr +MTL_CHAN_INT_CTRL (chan)); + +if (status &MTL_RX_OVERFLOW_INT ) { +/* clear Interrupt */ +writel (status |MTL_RX_OVERFLOW_INT , + ioaddr +MTL_CHAN_INT_CTRL (chan)); + ret =CORE_IRQ_MTL_RX_OVERFLOW ; + } + } + +return ret; +} +static int dwmac4_irq_status (struct mac_device_info *hw,struct stmmac_extra_stats *x) {void __iomem *ioaddr = hw->pcsr; -u32 mtl_int_qx_status;u32 intr_status;int ret =0 ;
@@ -439,20 +462,6 @@ static int dwmac4_irq_status(struct mac_device_info *hw, x->irq_receive_pmt_irq_n++; } - mtl_int_qx_status =readl (ioaddr +MTL_INT_STATUS ); -/* Check MTL Interrupt: Currently only one queue is used: Q0. */ -if (mtl_int_qx_status &MTL_INT_Q0 ) { -/* read Queue 0 Interrupt status */ -u32 status =readl (ioaddr +MTL_CHAN_INT_CTRL (STMMAC_CHAN0 )); - -if (status &MTL_RX_OVERFLOW_INT ) { -/* clear Interrupt */ -writel (status |MTL_RX_OVERFLOW_INT , - ioaddr +MTL_CHAN_INT_CTRL (STMMAC_CHAN0 )); - ret =CORE_IRQ_MTL_RX_OVERFLOW ; - } - } -dwmac_pcs_isr (ioaddr,GMAC_PCS_BASE , intr_status, x);if (intr_status &PCS_RGSMIIIS_IRQ )dwmac4_phystatus (ioaddr, x);
@@ -554,6 +563,7 @@ static const struct stmmac_ops dwmac4_ops = { .map_mtl_to_dma = dwmac4_map_mtl_dma, .dump_regs = dwmac4_dump_regs, .host_irq_status = dwmac4_irq_status, + .host_mtl_irq_status = dwmac4_irq_mtl_status, .flow_ctrl = dwmac4_flow_ctrl, .pmt = dwmac4_pmt, .set_umac_addr = dwmac4_set_umac_addr,
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +5 -0
@@ -2880,6 +2880,11 @@ static irqreturn_t stmmac_interrupt(int irq, void *dev_id)if ((priv->plat->has_gmac) || (priv->plat->has_gmac4)) {int status = priv->hw->mac->host_irq_status (priv->hw, &priv->xstats); + +if (priv->synopsys_id >=DWMAC_CORE_4_00 ) + status |= priv->hw->mac->host_mtl_irq_status (priv->hw, +STMMAC_CHAN0 ); +if (unlikely (status)) {/* For LPI we need to save the tx status */ if (status &CORE_IRQ_TX_PATH_IN_LPI_MODE )
Signature · 1 line
2.9.3
PATCH v4 8/9 net: stmicro: mac debug prepared for multiple queues
In reply to Joao PintoThis patch prepares mac debug dump for multiple queues.
---
Changes v3->v4:
- Debug function now gets all rx / tx queues data
Changes v1->v3:
- Just to keep up with patch-set version
drivers/net/ethernet/stmicro/stmmac/common.h | 3 +- .../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 3 +- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 107 +++++++++++---------- .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 5 +- 4 files changed, 64 insertions(+), 54 deletions(-)
drivers/net/ethernet/stmicro/stmmac/common.h +2 -1
@@ -488,7 +488,8 @@ struct stmmac_ops {void (*reset_eee_mode)(struct mac_device_info *hw);void (*set_eee_timer)(struct mac_device_info *hw,int ls,int tw);void (*set_eee_pls)(struct mac_device_info *hw,int link); -void (*debug)(void __iomem *ioaddr,struct stmmac_extra_stats *x); +void (*debug)(void __iomem *ioaddr,struct stmmac_extra_stats *x, +u32 rx_queues,u32 tx_queues);/* PCS calls */ void (*pcs_ctrl_ane)(void __iomem *ioaddr,bool ane,bool srgmi_ral,bool loopback);
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c +2 -1
@@ -413,7 +413,8 @@ static void dwmac1000_get_adv_lp(void __iomem *ioaddr, struct rgmii_adv *adv)dwmac_get_adv_lp (ioaddr,GMAC_PCS_BASE , adv); } -static void dwmac1000_debug (void __iomem *ioaddr,struct stmmac_extra_stats *x) +static void dwmac1000_debug (void __iomem *ioaddr,struct stmmac_extra_stats *x, +u32 rx_queues,u32 tx_queues) {u32 value =readl (ioaddr +GMAC_DEBUG );
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +56 -51
120 lines not on this page · raw message
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +4 -1
@@ -520,6 +520,8 @@ static void stmmac_get_ethtool_stats(struct net_device *dev, struct ethtool_stats *dummy, u64 *data) { struct stmmac_priv *priv = netdev_priv(dev); +u32 rx_queues_count = priv->plat->rx_queues_to_use; +u32 tx_queues_count = priv->plat->tx_queues_to_use;int i, j =0 ;/* Update the DMA HW counters for dwmac10/100 */
@@ -550,7 +552,8 @@ static void stmmac_get_ethtool_stats(struct net_device *dev,if ((priv->hw->mac->debug) && (priv->synopsys_id >=DWMAC_CORE_3_50 )) priv->hw->mac->debug (priv->ioaddr, - (void *)&priv->xstats); + (void *)&priv->xstats, + rx_queues_count, tx_queues_count); }for (i =0 ; i <STMMAC_STATS_LEN ; i++) {char *p = (char *)priv + stmmac_gstrings_stats[i].stat_offset;
Signature · 1 line
2.9.3
PATCH v4 9/9 net: stmicro: configuration of CBS in case of a TX AVB queue
In reply to Joao PintoThis patch adds the configuration of the AVB Credit-Based Shaper.
---
Changes v3->v4:
- variable init was simplified in some functions
Changes v1->v3:
- Added in v3
Documentation/devicetree/bindings/net/stmmac.txt | 22 +++++++++-- drivers/net/ethernet/stmicro/stmmac/common.h | 4 ++ drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 33 ++++++++++++++++ drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 46 +++++++++++++++++++++- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 29 ++++++++++++++ .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 29 ++++++++++++-- include/linux/stmmac.h | 12 ++++-- 7 files changed, 164 insertions(+), 11 deletions(-)
Documentation/devicetree/bindings/net/stmmac.txt +19 -3
@@ -92,8 +92,15 @@ Optional properties: - snps,tx-sched-dwrr: Deficit Weighted Round Robin - snps,tx-sched-sp: Strict priority - For each TX queue - - snps,weight: TX queue weight (if using a weighted algorithm) - + - snps,weight: TX queue weight (if using a DCB weight algorithm) + - Choose one of these modes: + - snps,dcb-algorithm: TX queue will be working in DCB + - snps,avb-algorithm: TX queue will be working in AVB + - Configure Credit Base Shaper (if AVB Mode selected): + - snps,send_slope: enable Low Power Interface + - snps,idle_slope: unlock on WoL + - snps,high_credit: max write outstanding req. limit + - snps,low_credit: max read outstanding req. limit Examples: stmmac_axi_setup: stmmac-axi-config {
@@ -112,10 +119,19 @@ Examples: }; mtl_tx_setup: tx-queues-config { - snps,tx-queues-to-use = <1>; + snps,tx-queues-to-use = <2>; snps,tx-sched-wrr; queue0 { snps,weight = <0x10>; + snps,dcb-algorithm; + }; + + queue1 { + snps,avb-algorithm; + snps,send_slope = <0x1000>; + snps,idle_slope = <0x1000>; + snps,high_credit = <0x3E800>; + snps,low_credit = <0xFFC18000>; }; };
drivers/net/ethernet/stmicro/stmmac/common.h +4 -0
@@ -464,6 +464,10 @@ struct stmmac_ops { u32 weight, u32 queue);/* RX MTL queue to RX dma mapping */ void (*map_mtl_to_dma)(struct mac_device_info *hw,u32 queue,u32 chan); +/* Configure AV Algorithm */ +void (*config_cbs)(struct mac_device_info *hw,u32 send_slope, +u32 idle_slope,u32 high_credit,u32 low_credit, +u32 queue);/* Dump MAC registers */ void (*dump_regs)(struct mac_device_info *hw,u32 *reg_space);/* Handle extra events on specific interrupts hw dependent */
drivers/net/ethernet/stmicro/stmmac/dwmac4.h +33 -0
@@ -218,6 +218,15 @@ enum power_event {#define MTL_OP_MODE_RTC_96 (2 << MTL_OP_MODE_RTC_SHIFT)#define MTL_OP_MODE_RTC_128 (3 << MTL_OP_MODE_RTC_SHIFT) +/* MTL ETS Control register */ +#define MTL_ETS_CTRL_BASE_ADDR 0x00000d10 +#define MTL_ETS_CTRL_BASE_OFFSET 0x40 +#define MTL_ETSX_CTRL_BASE_ADDR (x) (MTL_ETS_CTRL_BASE_ADDR + \ + ((x) * MTL_ETS_CTRL_BASE_OFFSET)) + +#define MTL_ETS_CTRL_CC BIT(3) +#define MTL_ETS_CTRL_AVALG BIT(2) +/* MTL Queue Quantum Weight */ #define MTL_TXQ_WEIGHT_BASE_ADDR 0x00000d18#define MTL_TXQ_WEIGHT_BASE_OFFSET 0x40
@@ -225,6 +234,30 @@ enum power_event { ((x) * MTL_TXQ_WEIGHT_BASE_OFFSET))#define MTL_TXQ_WEIGHT_ISCQW_MASK GENMASK(20, 0) +/* MTL sendSlopeCredit register */ +#define MTL_SEND_SLP_CRED_BASE_ADDR 0x00000d1c +#define MTL_SEND_SLP_CRED_OFFSET 0x40 +#define MTL_SEND_SLP_CREDX_BASE_ADDR (x) (MTL_SEND_SLP_CRED_BASE_ADDR + \ + ((x) * MTL_SEND_SLP_CRED_OFFSET)) + +#define MTL_SEND_SLP_CRED_SSC_MASK GENMASK(13, 0) + +/* MTL hiCredit register */ +#define MTL_HIGH_CRED_BASE_ADDR 0x00000d20 +#define MTL_HIGH_CRED_OFFSET 0x40 +#define MTL_HIGH_CREDX_BASE_ADDR (x) (MTL_HIGH_CRED_BASE_ADDR + \ + ((x) * MTL_HIGH_CRED_OFFSET)) + +#define MTL_HIGH_CRED_HC_MASK GENMASK(28, 0) + +/* MTL loCredit register */ +#define MTL_LOW_CRED_BASE_ADDR 0x00000d24 +#define MTL_LOW_CRED_OFFSET 0x40 +#define MTL_LOW_CREDX_BASE_ADDR (x) (MTL_LOW_CRED_BASE_ADDR + \ + ((x) * MTL_LOW_CRED_OFFSET)) + +#define MTL_HIGH_CRED_LC_MASK GENMASK(28, 0) +/* MTL debug */ #define MTL_DEBUG_TXSTSFSTS BIT(5)#define MTL_DEBUG_TXFSTS BIT(4)
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +44 -2
65 lines not on this page · raw message
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +29 -0
@@ -1668,6 +1668,31 @@ static void stmmac_set_tx_queue_weight(struct stmmac_priv *priv) }/** +* stmmac_configure_cbs - Configure CBS in TX queue +* @priv: driver private structure +* Description: It is used for configuring CBS in AVB TX queues +*/ +static void stmmac_configure_cbs (struct stmmac_priv *priv) +{ +u32 tx_queues_count = priv->plat->tx_queues_to_use; +u32 mode_to_use; +u32 queue; + +for (queue =0 ; queue < tx_queues_count; queue++) { + mode_to_use = priv->plat->tx_queues_cfg[queue].mode_to_use; +if (mode_to_use ==MTL_QUEUE_DCB ) +continue ; + + priv->hw->mac->config_cbs (priv->hw, + priv->plat->tx_queues_cfg[queue].send_slope, + priv->plat->tx_queues_cfg[queue].idle_slope, + priv->plat->tx_queues_cfg[queue].high_credit, + priv->plat->tx_queues_cfg[queue].low_credit, + queue); + } +} + +/** * stmmac_rx_queue_dma_chan_map - Map RX queue to RX dma channel * @priv: driver private structure * Description: It is used for mapping RX queues to RX dma channels
@@ -1707,6 +1732,10 @@ static void stmmac_mtl_configuration(struct stmmac_priv *priv) priv->hw->mac->prog_mtl_tx_algorithms (priv->hw, priv->plat->tx_sched_algorithm); +/* Configure CBS in AVB TX queues */ +if (tx_queues_count >1 && priv->hw->mac->config_cbs) +stmmac_configure_cbs (priv); +/* Map RX MTL to DMA channels */ if (rx_queues_count >1 && priv->hw->mac->map_mtl_to_dma)stmmac_rx_queue_dma_chan_map (priv);
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +26 -3
@@ -171,11 +171,11 @@ static void stmmac_mtl_setup(struct platform_device *pdev,break ;if (of_property_read_bool (q_node,"snps,dcb-algorithm" )) - plat->rx_queues_cfg[queue].mode_to_use =MTL_RX_DCB ; + plat->rx_queues_cfg[queue].mode_to_use =MTL_QUEUE_DCB ;else if (of_property_read_bool (q_node,"snps,avb-algorithm" )) - plat->rx_queues_cfg[queue].mode_to_use =MTL_RX_AVB ; + plat->rx_queues_cfg[queue].mode_to_use =MTL_QUEUE_AVB ;else - plat->rx_queues_cfg[queue].mode_to_use =MTL_RX_DCB ; + plat->rx_queues_cfg[queue].mode_to_use =MTL_QUEUE_DCB ;if (of_property_read_u8 (q_node,"snps,map-to-dma-channel" , &plat->rx_queues_cfg[queue].chan))
@@ -212,6 +212,29 @@ static void stmmac_mtl_setup(struct platform_device *pdev, &plat->tx_queues_cfg[queue].weight)) plat->tx_queues_cfg[queue].weight =0x10 + queue; +if (of_property_read_bool (q_node,"snps,dcb-algorithm" )) { + plat->tx_queues_cfg[queue].mode_to_use =MTL_QUEUE_DCB ; + }else if (of_property_read_bool (q_node, +"snps,avb-algorithm" )) { + plat->tx_queues_cfg[queue].mode_to_use =MTL_QUEUE_AVB ; + +/* Credit Base Shaper parameters used by AVB */ +if (of_property_read_u32 (q_node,"snps,send_slope" , + &plat->tx_queues_cfg[queue].send_slope)) + plat->tx_queues_cfg[queue].send_slope =0x0 ; +if (of_property_read_u32 (q_node,"snps,idle_slope" , + &plat->tx_queues_cfg[queue].idle_slope)) + plat->tx_queues_cfg[queue].idle_slope =0x0 ; +if (of_property_read_u32 (q_node,"snps,high_credit" , + &plat->tx_queues_cfg[queue].high_credit)) + plat->tx_queues_cfg[queue].high_credit =0x0 ; +if (of_property_read_u32 (q_node,"snps,low_credit" , + &plat->tx_queues_cfg[queue].low_credit)) + plat->tx_queues_cfg[queue].low_credit =0x0 ; + }else { + plat->tx_queues_cfg[queue].mode_to_use =MTL_QUEUE_DCB ; + } + queue++; }
include/linux/stmmac.h +9 -3
@@ -55,9 +55,9 @@#define MTL_RX_ALGORITHM_SP 0x4#define MTL_RX_ALGORITHM_WSP 0x5 -/* RX Queue Mode */ -#define MTL_RX_DCB 0x0 -#define MTL_RX_AVB 0x1 +/* RX/TX Queue Mode */ +#define MTL_QUEUE_DCB 0x0 +#define MTL_QUEUE_AVB 0x1/* The MDC clock could be set higher than the IEEE 802.3 * specified frequency limit 0f 2.5 MHz, by programming a clock divider
@@ -131,6 +131,12 @@ struct stmmac_rxq_cfg {struct stmmac_txq_cfg {u8 weight; +u8 mode_to_use; +/* Credit Base Shaper parameters */ +u32 send_slope; +u32 idle_slope; +u32 high_credit; +u32 low_credit; };struct plat_stmmacenet_data {
Signature · 1 line
2.9.3
David Miller
maintainerFrom: Joao Pinto <[email protected]>
Date: Fri, 10 Mar 2017 12:18:25 +0000
Quoted 2 lines
As agreed with David Miller, this patch-set is the first of 3 to enable multiple queues in stmmac.
I have one more request to make.
The name of the driver is "stmmac" therefore I'd like you to use "stmmac: " as the subsystem prefix in your Subject lines just as everyone else who works on this driver does. Please don't use "stmicro: " thank you.
Às 5:50 PM de 3/10/2017, David Miller escreveu:
Quoted 6 lines
From: Joao Pinto <[email protected]>
Date: Fri, 10 Mar 2017 12:18:25 +0000Quoted 2 lines
As agreed with David Miller, this patch-set is the first of 3 to enable multiple queues in stmmac.
Quoted 7 lines
I have one more request to make.
The name of the driver is "stmmac" therefore I'd like you to use "stmmac: " as the subsystem prefix in your Subject lines just as everyone else who works on this driver does. Please don't use "stmicro: " thank you.
Ok, I will do that. Thanks.