Skip to contentSkip to conversation

bitbake-diffsigs: fix traceback with no arguments

PATCH New Paul Eggleton 1 participant 2 messages Apr 10, 2017

lore
Share & tools
lore
#0 lore raw

cover bitbake-diffsigs: fix traceback with no arguments

The following changes since commit 04a023c8fdea1e1812fcdcaf00345aab59f9abe1:

bitbake-diffsigs: colourise output (2017-04-07 00:51:12 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib paule/bb-sigstuff-fix
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=paule/bb-sigstuff-fix

Paul Eggleton (1):
bitbake-diffsigs: fix traceback with no arguments

 bin/bitbake-diffsigs | 4 ++++
 1 file changed, 4 insertions(+)
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 bitbake-diffsigs: fix traceback with no arguments

In the move over to argparse we've made the two signature file arguments optional and thus if -t is not in use we need to explicitly check if at least one signature file has been specified - and if not, show an error and the command-line help.

---
 bin/bitbake-diffsigs | 4 ++++
 1 file changed, 4 insertions(+)
bin/bitbake-diffsigs +4 -0
index 884be1e..eb2f859 100755
@@ -147,6 +147,10 @@ else:
             output = bb.siggen.compare_sigfiles(options.sigdatafile1, options.sigdatafile2, color=color)
         elif options.sigdatafile1:
             output = bb.siggen.dump_sigfile(options.sigdatafile1)
+        else:
+            logger.error('Must specify signature file(s) or -t/--task')
+            parser.print_help()
+            sys.exit(1)
     except IOError as e:
         logger.error(str(e))
         sys.exit(1)
Signature · 1 line
2.9.3