sched: Minor cleanups
v2 cover sched: Minor cleanups
Hi,
Avoid reinitializing memory which is already set to zero.
V1->V2:
- Don't remove field initializers from 2nd and 3rd patch.
- Drop 4th patch (sched: core: drop useless expression from sched_init()).
--
viresh
Viresh Kumar (3):
sched: topology: drop memset() from init_rootdomain()
sched: cpudeadline: don't re-initialize struct cpudl
sched: cpupri: don't re-initialize struct cpupri
kernel/sched/cpudeadline.c | 1 - kernel/sched/cpupri.c | 2 -- kernel/sched/topology.c | 4 +--- 3 files changed, 1 insertion(+), 6 deletions(-)
Signature · 1 line
2.12.0.432.g71c3a4f4ba37
PATCH v2 1/3 sched: topology: drop memset() from init_rootdomain()
There are only two callers of init_rootdomain(). One of them passes a global to it and another one sends dynamically allocated root-domain.
There is no need to memset the root-domain in the first case as the structure is already reset.
Update alloc_rootdomain() to allocate the memory with kzalloc() and remove the memset() call from init_rootdomain().
--- kernel/sched/topology.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
kernel/sched/topology.c +1 -3
@@ -242,8 +242,6 @@ void rq_attach_root(struct rq *rq, struct root_domain *rd)static int init_rootdomain (struct root_domain *rd) { -memset (rd,0 ,sizeof (*rd)); -if (!zalloc_cpumask_var (&rd->span,GFP_KERNEL )) goto out;if (!zalloc_cpumask_var (&rd->online,GFP_KERNEL ))
@@ -292,7 +290,7 @@ static struct root_domain *alloc_rootdomain(void) {struct root_domain *rd; - rd =kmalloc (sizeof (*rd),GFP_KERNEL ); + rd =kzalloc (sizeof (*rd),GFP_KERNEL );if (!rd)return NULL ;
Signature · 1 line
2.12.0.432.g71c3a4f4ba37
tip-bot for Viresh Kumar
merge bot[tip:sched/core] sched/topology: Drop memset() from init_rootdomain()
sched/topology: Drop memset() from init_rootdomain()
Commit-ID: 4d13a06d54c415238325b0fe2c14f1052da4512f Gitweb: http://git.kernel.org/tip/4d13a06d54c415238325b0fe2c14f1052da4512f Author: Viresh Kumar <[email protected]> AuthorDate: Thu, 13 Apr 2017 14:45:48 +0530 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 10 Aug 2017 12:18:13 +0200
sched/topology: Drop memset() from init_rootdomain()
There are only two callers of init_rootdomain(). One of them passes a global to it and another one sends dynamically allocated root-domain.
There is no need to memset the root-domain in the first case as the structure is already reset.
Update alloc_rootdomain() to allocate the memory with kzalloc() and remove the memset() call from init_rootdomain().
--- kernel/sched/topology.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
kernel/sched/topology.c +1 -3
@@ -261,8 +261,6 @@ void rq_attach_root(struct rq *rq, struct root_domain *rd)static int init_rootdomain (struct root_domain *rd) { -memset (rd,0 ,sizeof (*rd)); -if (!zalloc_cpumask_var (&rd->span,GFP_KERNEL )) goto out;if (!zalloc_cpumask_var (&rd->online,GFP_KERNEL ))
@@ -311,7 +309,7 @@ static struct root_domain *alloc_rootdomain(void) {struct root_domain *rd; - rd =kmalloc (sizeof (*rd),GFP_KERNEL ); + rd =kzalloc (sizeof (*rd),GFP_KERNEL );if (!rd)return NULL ;
PATCH v2 2/3 sched: cpudeadline: don't re-initialize struct cpudl
In reply to Viresh KumarThe struct cpudl passed to cpudl_init() is already initialized to zero. Don't do that again.
--- kernel/sched/cpudeadline.c | 1 - 1 file changed, 1 deletion(-)
kernel/sched/cpudeadline.c +0 -1
@@ -246,7 +246,6 @@ int cpudl_init(struct cpudl *cp) {int i; -memset (cp,0 ,sizeof (*cp));raw_spin_lock_init (&cp->lock); cp->size =0 ;
Signature · 1 line
2.12.0.432.g71c3a4f4ba37
tip-bot for Viresh Kumar
merge bot[tip:sched/core] sched/deadline: Don't re-initialize 'struct cpudl'
sched/deadline: Don't re-initialize 'struct cpudl'
Commit-ID: 42d394d41ab90f4ed9d7a7403ed22e8f7590948a Gitweb: http://git.kernel.org/tip/42d394d41ab90f4ed9d7a7403ed22e8f7590948a Author: Viresh Kumar <[email protected]> AuthorDate: Thu, 13 Apr 2017 14:45:49 +0530 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 10 Aug 2017 12:18:13 +0200
sched/deadline: Don't re-initialize 'struct cpudl'
The 'struct cpudl' passed to cpudl_init() is already initialized to zero. Don't do that again.
--- kernel/sched/cpudeadline.c | 1 - 1 file changed, 1 deletion(-)
kernel/sched/cpudeadline.c +0 -1
@@ -246,7 +246,6 @@ int cpudl_init(struct cpudl *cp) {int i; -memset (cp,0 ,sizeof (*cp));raw_spin_lock_init (&cp->lock); cp->size =0 ;
PATCH v2 3/3 sched: cpupri: don't re-initialize struct cpupri
In reply to Viresh KumarThe struct cpupri passed to cpupri_init() is already initialized to zero. Don't do that again.
--- kernel/sched/cpupri.c | 2 -- 1 file changed, 2 deletions(-)
kernel/sched/cpupri.c +0 -2
@@ -209,8 +209,6 @@ int cpupri_init(struct cpupri *cp) {int i; -memset (cp,0 ,sizeof (*cp)); -for (i =0 ; i <CPUPRI_NR_PRIORITIES ; i++) {struct cpupri_vec *vec = &cp->pri_to_cpu[i];
Signature · 1 line
2.12.0.432.g71c3a4f4ba37
tip-bot for Viresh Kumar
merge bot[tip:sched/core] sched/cpupri: Don't re-initialize 'struct cpupri'
sched/cpupri: Don't re-initialize 'struct cpupri'
Commit-ID: 1c2a4861dbfca373fea1ff2cf9e9793933d024ce Gitweb: http://git.kernel.org/tip/1c2a4861dbfca373fea1ff2cf9e9793933d024ce Author: Viresh Kumar <[email protected]> AuthorDate: Thu, 13 Apr 2017 14:45:50 +0530 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 10 Aug 2017 12:18:14 +0200
sched/cpupri: Don't re-initialize 'struct cpupri'
The 'struct cpupri' passed to cpupri_init() is already initialized to zero. Don't do that again.
--- kernel/sched/cpupri.c | 2 -- 1 file changed, 2 deletions(-)
kernel/sched/cpupri.c +0 -2
@@ -209,8 +209,6 @@ int cpupri_init(struct cpupri *cp) {int i; -memset (cp,0 ,sizeof (*cp)); -for (i =0 ; i <CPUPRI_NR_PRIORITIES ; i++) {struct cpupri_vec *vec = &cp->pri_to_cpu[i];