staging: iio: meter: Replace symbolic permissions with octal permissions

PATCH Superseded Harinath Nampally 3 participants 14 messages May 9, 2017 – May 15, 2017 1 message not in the archive

Subsystems (4)

Staging IIO Analog Devices IIO drivers Staging - industrial io

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Harinath Nampally

author

2017-05-09 01:50 UTC #1 lore raw

cover coding style warnings fixes

This patchset is for fixes reported by checkpatch.pl

Please find the following patches:
[PATCH 1/3] staging: iio: meter: Add the comment for mutex definition [PATCH 2/3] staging: iio: meter: Fix the identations for proper
[PATCH 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions
-------------------------------------------------------------------------
Harinath Nampally (3):
staging: iio: meter: Add the comment for mutex definition in ade7753.c
staging: iio: meter: Fix the identations for proper alignments in

    ade7753.c

staging: iio: meter: Replace symbolic permissions with octal
permissions in ade7753.c

 drivers/staging/iio/meter/ade7753.c | 104 ++++++++++++++++++------------------
 1 file changed, 52 insertions(+), 52 deletions(-)

Signature · 1 line

2.7.4

Harinath Nampally

author

2017-05-09 01:50 UTC #2 lore raw

PATCH 1/3 staging: iio: meter: Add the comment for mutex definition

This patch fixes below checkpatch.pl warning:
CHECK: struct mutex definition without comment

Signed-off-by Harinath Nampally <[email protected]>

---
 drivers/staging/iio/meter/ade7753.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/staging/iio/meter/ade7753.c +2 -1

index b71fbd3..cffe6bf 100644
@@ -78,12 +78,13 @@
 /**
  * struct ade7753_state - device instance specific data
  * @us:         actual spi_device
+ * @buf_lock:       mutex to protect tx and rx
  * @tx:         transmit buffer
  * @rx:         receive buffer
- * @buf_lock:       mutex to protect tx and rx
  **/
 struct ade7753_state {
 	struct spi_device   *us;
+ /* mutex to protect tx and rx */
 	struct mutex        buf_lock;
 	u8          tx[ADE7753_MAX_TX] ____cacheline_aligned;
 	u8          rx[ADE7753_MAX_RX];

Signature · 1 line

2.7.4

Dan Carpenter

2017-05-09 07:47 UTC #3 lore raw

Re: [PATCH 1/3] staging: iio: meter: Add the comment for mutex definition

Quoted 14 lines · Harinath Nampally

This patch fixes below checkpatch.pl warning:
CHECK: struct mutex definition without comment
Signed-off-by Harinath Nampally <[email protected]>
---
 drivers/staging/iio/meter/ade7753.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/iio/meter/ade7753.c +0 -0
index b71fbd3..cffe6bf 100644
@@ -78,12 +78,13 @@
 /**

drivers/staging/iio/meter/ade7753.c line 87

Quoted 10 lines

drivers/staging/iio/meter/ade7753.c +2 -1

  * struct ade7753_state - device instance specific data
  * @us:         actual spi_device
+ * @buf_lock:       mutex to protect tx and rx
  * @tx:         transmit buffer
  * @rx:         receive buffer
- * @buf_lock:       mutex to protect tx and rx
  **/
 struct ade7753_state {
 	struct spi_device   *us;
+ /* mutex to protect tx and rx */

Not aligned. We don't need two duplicate comments anyway.

drivers/staging/iio/meter/ade7753.c line 88

Quoted 1 line

drivers/staging/iio/meter/ade7753.c +0 -0
 	struct mutex        buf_lock;

regards,
dan carpenter

Harinath Nampally

author

2017-05-09 23:41 UTC #4 lore raw

v2 cover coding style warnings fixes

This revised patchset is for improvement in [PATCH v2 1/3] as per the code review comment from Dan Carpenter.

Other two patches [PATCH v2 2/3] and [PATCH v2 3/3] are unchanged, so they are same as [PATCH 2/3] and [PATCH 3/3] respectively.

Please find the following related patches:
[PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition [PATCH v2 2/3] staging: iio: meter: Fix the identations for proper alignments [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions

Harinath Nampally (3):
staging: iio: meter: Add the comment for mutex definition
staging: iio: meter: Fix the identations for proper alignments
staging: iio: meter: Replace symbolic permissions with octal
permissions

 drivers/staging/iio/meter/ade7753.c | 104 ++++++++++++++++++------------------
 1 file changed, 51 insertions(+), 52 deletions(-)

Signature · 1 line

2.7.4

Harinath Nampally

author

2017-05-09 23:41 UTC #5 lore raw

PATCH v2 1/3 staging: iio: meter: Add the comment for mutex definition.

This patch fixes below checkpatch.pl warning:
CHECK: struct mutex definition without comment

Signed-off-by Harinath Nampally <[email protected]>

---
Changes in v2:
- Removed the extra comment for mutex in the struct.

 drivers/staging/iio/meter/ade7753.c | 3 ++-
 1 file changed, 1 insertions(+), 1 deletion(-)

drivers/staging/iio/meter/ade7753.c +1 -1

index b71fbd3..cffe6bf 100644
@@ -78,12 +78,13 @@
 /**
  * struct ade7753_state - device instance specific data
  * @us:         actual spi_device
+ * @buf_lock:       mutex to protect tx and rx
  * @tx:         transmit buffer
  * @rx:         receive buffer
- * @buf_lock:       mutex to protect tx and rx
  **/
 struct ade7753_state {
 	struct spi_device   *us;
 	struct mutex        buf_lock;
 	u8          tx[ADE7753_MAX_TX] ____cacheline_aligned;
 	u8          rx[ADE7753_MAX_RX];

Signature · 1 line

2.7.4

Jonathan Cameron

maintainer

2017-05-14 15:24 UTC #6 lore raw

Re: [PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition.

Quoted 4 lines · Harinath Nampally

This patch fixes below checkpatch.pl warning:
CHECK: struct mutex definition without comment
Signed-off-by Harinath Nampally <[email protected]>

They description is no longer correct. This moves a comment rather than adding one.

Quoted 26 lines

---
Changes in v2:
- Removed the extra comment for mutex in the struct.

  drivers/staging/iio/meter/ade7753.c | 3 ++-
  1 file changed, 1 insertions(+), 1 deletion(-)

drivers/staging/iio/meter/ade7753.c +1 -1

index b71fbd3..cffe6bf 100644
@@ -78,12 +78,13 @@
  /**
   * struct ade7753_state - device instance specific data
   * @us:         actual spi_device
+ * @buf_lock:       mutex to protect tx and rx
   * @tx:         transmit buffer
   * @rx:         receive buffer
- * @buf_lock:       mutex to protect tx and rx
   **/
  struct ade7753_state {
  	struct spi_device   *us;
  	struct mutex        buf_lock;
  	u8          tx[ADE7753_MAX_TX] ____cacheline_aligned;
  	u8          rx[ADE7753_MAX_RX];

Harinath Nampally

author

2017-05-09 23:41 UTC #7 lore raw

PATCH v2 2/3 staging: iio: meter: Fix the identations for proper alignments.

In reply to Harinath Nampally

This patch fixes below checkpatch.pl kind of warnings:
CHECK: Alignment should match open parenthesis

Signed-off-by Harinath Nampally <[email protected]>

---
Changes in v2:
- None because only [PATCH v2 1/3] has improvement

 drivers/staging/iio/meter/ade7753.c | 55 ++++++++++++++++++-------------------
 1 file changed, 27 insertions(+), 28 deletions(-)

drivers/staging/iio/meter/ade7753.c +27 ~~-28~~

index cffe6bf..5d45a68 100644
@@ -108,9 +108,8 @@ static int ade7753_spi_write_reg_8(struct device *dev,
 	return ret;
 }
 
-static int ade7753_spi_write_reg_16(struct device *dev,
-		u8 reg_address,
-		u16 value)
+static int ade7753_spi_write_reg_16(struct device *dev, u8 reg_address,
+				    u16 value)
 {
 	int ret;
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);

@@ -127,8 +126,8 @@ static int ade7753_spi_write_reg_16(struct device *dev,
 }
 
 static int ade7753_spi_read_reg_8(struct device *dev,
-		u8 reg_address,
-		u8 *val)
+				  u8 reg_address,
+				  u8 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);

@@ -137,7 +136,7 @@ static int ade7753_spi_read_reg_8(struct device *dev,
 	ret = spi_w8r8(st->us, ADE7753_READ_REG(reg_address));
 	if (ret < 0) {
 		dev_err(&st->us->dev, "problem when reading 8 bit register 0x%02X",
-				reg_address);
+			reg_address);
 		return ret;
 	}
 	*val = ret;

@@ -146,8 +145,8 @@ static int ade7753_spi_read_reg_8(struct device *dev,
 }
 
 static int ade7753_spi_read_reg_16(struct device *dev,
-		u8 reg_address,
-		u16 *val)
+				   u8 reg_address,
+				   u16 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);

@@ -166,8 +165,8 @@ static int ade7753_spi_read_reg_16(struct device *dev,
 }
 
 static int ade7753_spi_read_reg_24(struct device *dev,
-		u8 reg_address,
-		u32 *val)
+				   u8 reg_address,
+				   u32 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);

@@ -190,7 +189,7 @@ static int ade7753_spi_read_reg_24(struct device *dev,
 	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
 	if (ret) {
 		dev_err(&st->us->dev, "problem when reading 24 bit register 0x%02X",
-				reg_address);
+			reg_address);
 		goto error_ret;
 	}
 	*val = (st->rx[0] << 16) | (st->rx[1] << 8) | st->rx[2];

@@ -201,8 +200,8 @@ static int ade7753_spi_read_reg_24(struct device *dev,
 }
 
 static ssize_t ade7753_read_8bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				 struct device_attribute *attr,
+				 char *buf)
 {
 	int ret;
 	u8 val;

@@ -216,8 +215,8 @@ static ssize_t ade7753_read_8bit(struct device *dev,
 }
 
 static ssize_t ade7753_read_16bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				  struct device_attribute *attr,
+				  char *buf)
 {
 	int ret;
 	u16 val;

@@ -231,8 +230,8 @@ static ssize_t ade7753_read_16bit(struct device *dev,
 }
 
 static ssize_t ade7753_read_24bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				  struct device_attribute *attr,
+				  char *buf)
 {
 	int ret;
 	u32 val;

@@ -246,9 +245,9 @@ static ssize_t ade7753_read_24bit(struct device *dev,
 }
 
 static ssize_t ade7753_write_8bit(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				  struct device_attribute *attr,
+				  const char *buf,
+				  size_t len)
 {
 	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
 	int ret;

@@ -264,9 +263,9 @@ static ssize_t ade7753_write_8bit(struct device *dev,
 }
 
 static ssize_t ade7753_write_16bit(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				   struct device_attribute *attr,
+				   const char *buf,
+				   size_t len)
 {
 	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
 	int ret;

@@ -451,8 +450,8 @@ static int ade7753_initial_setup(struct iio_dev *indio_dev)
 }
 
 static ssize_t ade7753_read_frequency(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				      struct device_attribute *attr,
+				      char *buf)
 {
 	int ret;
 	u16 t;

@@ -469,9 +468,9 @@ static ssize_t ade7753_read_frequency(struct device *dev,
 }
 
 static ssize_t ade7753_write_frequency(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				       struct device_attribute *attr,
+				       const char *buf,
+				       size_t len)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);

Signature · 1 line

2.7.4

Jonathan Cameron

maintainer

2017-05-14 15:26 UTC #8 lore raw

Re: [PATCH v2 2/3] staging: iio: meter: Fix the identations for proper alignments.

Quoted 4 lines · Harinath Nampally

This patch fixes below checkpatch.pl kind of warnings:
CHECK: Alignment should match open parenthesis
Signed-off-by Harinath Nampally <[email protected]>

Good patch and well described.

Applied this one (without patch 1) to the togreg branch of
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/
which is initially pushed out as testing for the autobuilders to see if we've missed anything.

Thanks,

Jonathan

Quoted 158 lines

---
Changes in v2:
- None because only [PATCH v2 1/3] has improvement

  drivers/staging/iio/meter/ade7753.c | 55 ++++++++++++++++++-------------------
  1 file changed, 27 insertions(+), 28 deletions(-)

drivers/staging/iio/meter/ade7753.c +27 ~~-28~~

index cffe6bf..5d45a68 100644
@@ -108,9 +108,8 @@ static int ade7753_spi_write_reg_8(struct device *dev,
  	return ret;
  }
 
-static int ade7753_spi_write_reg_16(struct device *dev,
-		u8 reg_address,
-		u16 value)
+static int ade7753_spi_write_reg_16(struct device *dev, u8 reg_address,
+				    u16 value)
  {
  	int ret;
  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);

@@ -127,8 +126,8 @@ static int ade7753_spi_write_reg_16(struct device *dev,
  }
 
  static int ade7753_spi_read_reg_8(struct device *dev,
-		u8 reg_address,
-		u8 *val)
+				  u8 reg_address,
+				  u8 *val)
  {
  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
  	struct ade7753_state *st = iio_priv(indio_dev);

@@ -137,7 +136,7 @@ static int ade7753_spi_read_reg_8(struct device *dev,
  	ret = spi_w8r8(st->us, ADE7753_READ_REG(reg_address));
  	if (ret < 0) {
  		dev_err(&st->us->dev, "problem when reading 8 bit register 0x%02X",
-				reg_address);
+			reg_address);
  		return ret;
  	}
  	*val = ret;

@@ -146,8 +145,8 @@ static int ade7753_spi_read_reg_8(struct device *dev,
  }
 
  static int ade7753_spi_read_reg_16(struct device *dev,
-		u8 reg_address,
-		u16 *val)
+				   u8 reg_address,
+				   u16 *val)
  {
  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
  	struct ade7753_state *st = iio_priv(indio_dev);

@@ -166,8 +165,8 @@ static int ade7753_spi_read_reg_16(struct device *dev,
  }
 
  static int ade7753_spi_read_reg_24(struct device *dev,
-		u8 reg_address,
-		u32 *val)
+				   u8 reg_address,
+				   u32 *val)
  {
  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
  	struct ade7753_state *st = iio_priv(indio_dev);

@@ -190,7 +189,7 @@ static int ade7753_spi_read_reg_24(struct device *dev,
  	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
  	if (ret) {
  		dev_err(&st->us->dev, "problem when reading 24 bit register 0x%02X",
-				reg_address);
+			reg_address);
  		goto error_ret;
  	}
  	*val = (st->rx[0] << 16) | (st->rx[1] << 8) | st->rx[2];

@@ -201,8 +200,8 @@ static int ade7753_spi_read_reg_24(struct device *dev,
  }
 
  static ssize_t ade7753_read_8bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				 struct device_attribute *attr,
+				 char *buf)
  {
  	int ret;
  	u8 val;

@@ -216,8 +215,8 @@ static ssize_t ade7753_read_8bit(struct device *dev,
  }
 
  static ssize_t ade7753_read_16bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				  struct device_attribute *attr,
+				  char *buf)
  {
  	int ret;
  	u16 val;

@@ -231,8 +230,8 @@ static ssize_t ade7753_read_16bit(struct device *dev,
  }
 
  static ssize_t ade7753_read_24bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				  struct device_attribute *attr,
+				  char *buf)
  {
  	int ret;
  	u32 val;

@@ -246,9 +245,9 @@ static ssize_t ade7753_read_24bit(struct device *dev,
  }
 
  static ssize_t ade7753_write_8bit(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				  struct device_attribute *attr,
+				  const char *buf,
+				  size_t len)
  {
  	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
  	int ret;

@@ -264,9 +263,9 @@ static ssize_t ade7753_write_8bit(struct device *dev,
  }
 
  static ssize_t ade7753_write_16bit(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				   struct device_attribute *attr,
+				   const char *buf,
+				   size_t len)
  {
  	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
  	int ret;

@@ -451,8 +450,8 @@ static int ade7753_initial_setup(struct iio_dev *indio_dev)
  }
 
  static ssize_t ade7753_read_frequency(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				      struct device_attribute *attr,
+				      char *buf)
  {
  	int ret;
  	u16 t;

@@ -469,9 +468,9 @@ static ssize_t ade7753_read_frequency(struct device *dev,
  }
 
  static ssize_t ade7753_write_frequency(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				       struct device_attribute *attr,
+				       const char *buf,
+				       size_t len)
  {
  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
  	struct ade7753_state *st = iio_priv(indio_dev);

Harinath Nampally

author

2017-05-09 23:42 UTC #9 lore raw

PATCH v2 3/3 staging: iio: meter: Replace symbolic permissions with octal permissions.

In reply to Harinath Nampally

This patch fixes below kind of warnings:
WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred.

Below errors are false positives:
ade7753.c:382: ERROR: Use 4 digit octal (0777) not decimal permissions ade7753.c:386: ERROR: Use 4 digit octal (0777) not decimal permissions

Signed-off-by Harinath Nampally <[email protected]>

---
Changes in v2:
- None because only [PATCH v2 1/3] has improvement

 drivers/staging/iio/meter/ade7753.c | 46 ++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

drivers/staging/iio/meter/ade7753.c +23 ~~-23~~

index 5d45a68..2534bd0 100644
@@ -298,92 +298,92 @@ static IIO_DEV_ATTR_AENERGY(ade7753_read_24bit, ADE7753_AENERGY);
 static IIO_DEV_ATTR_LAENERGY(ade7753_read_24bit, ADE7753_LAENERGY);
 static IIO_DEV_ATTR_VAENERGY(ade7753_read_24bit, ADE7753_VAENERGY);
 static IIO_DEV_ATTR_LVAENERGY(ade7753_read_24bit, ADE7753_LVAENERGY);
-static IIO_DEV_ATTR_CFDEN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CFDEN(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_CFDEN);
-static IIO_DEV_ATTR_CFNUM(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CFNUM(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_CFNUM);
 static IIO_DEV_ATTR_CHKSUM(ade7753_read_8bit, ADE7753_CHKSUM);
-static IIO_DEV_ATTR_PHCAL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_PHCAL(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_PHCAL);
-static IIO_DEV_ATTR_APOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_APOS(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_APOS);
-static IIO_DEV_ATTR_SAGCYC(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAGCYC(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_SAGCYC);
-static IIO_DEV_ATTR_SAGLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAGLVL(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_SAGLVL);
-static IIO_DEV_ATTR_LINECYC(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_LINECYC(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_LINECYC);
-static IIO_DEV_ATTR_WDIV(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_WDIV(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_WDIV);
-static IIO_DEV_ATTR_IRMS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IRMS(0644,
 		ade7753_read_24bit,
 		NULL,
 		ADE7753_IRMS);
-static IIO_DEV_ATTR_VRMS(S_IRUGO,
+static IIO_DEV_ATTR_VRMS(0444,
 		ade7753_read_24bit,
 		NULL,
 		ADE7753_VRMS);
-static IIO_DEV_ATTR_IRMSOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IRMSOS(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_IRMSOS);
-static IIO_DEV_ATTR_VRMSOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VRMSOS(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_VRMSOS);
-static IIO_DEV_ATTR_WGAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_WGAIN(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_WGAIN);
-static IIO_DEV_ATTR_VAGAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VAGAIN(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_VAGAIN);
-static IIO_DEV_ATTR_PGA_GAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_PGA_GAIN(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_GAIN);
-static IIO_DEV_ATTR_IPKLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IPKLVL(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_IPKLVL);
-static IIO_DEV_ATTR_VPKLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VPKLVL(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_VPKLVL);
-static IIO_DEV_ATTR_IPEAK(S_IRUGO,
+static IIO_DEV_ATTR_IPEAK(0444,
 		ade7753_read_24bit,
 		NULL,
 		ADE7753_IPEAK);
-static IIO_DEV_ATTR_VPEAK(S_IRUGO,
+static IIO_DEV_ATTR_VPEAK(0444,
 		ade7753_read_24bit,
 		NULL,
 		ADE7753_VPEAK);
-static IIO_DEV_ATTR_VPERIOD(S_IRUGO,
+static IIO_DEV_ATTR_VPERIOD(0444,
 		ade7753_read_16bit,
 		NULL,
 		ADE7753_PERIOD);
-static IIO_DEV_ATTR_CH_OFF(1, S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CH_OFF(1, 0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_CH1OS);
-static IIO_DEV_ATTR_CH_OFF(2, S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CH_OFF(2, 0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_CH2OS);

@@ -514,7 +514,7 @@ static IIO_DEV_ATTR_TEMP_RAW(ade7753_read_8bit);
 static IIO_CONST_ATTR(in_temp_offset, "-25 C");
 static IIO_CONST_ATTR(in_temp_scale, "0.67 C");
 
-static IIO_DEV_ATTR_SAMP_FREQ(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAMP_FREQ(0644,
 		ade7753_read_frequency,
 		ade7753_write_frequency);

Signature · 1 line

2.7.4

Jonathan Cameron

maintainer

2017-05-14 15:29 UTC #10 lore raw

Re: [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions.

Quoted 8 lines · Harinath Nampally

This patch fixes below kind of warnings:
WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred.
Below errors are false positives:
ade7753.c:382: ERROR: Use 4 digit octal (0777) not decimal permissions ade7753.c:386: ERROR: Use 4 digit octal (0777) not decimal permissions
Signed-off-by Harinath Nampally <[email protected]>

I've already taken a patch for this.

For IIO patches (including for drivers in staging) please also check the iio.git tree and in particularly base the on the togreg branch of that unless you know something you need is in the testing branch (usually more recent) in which case use that. This stuff all gets batched up every few weeks and sent as a pull request to Greg. Right now we have just ended a merge window so it's the longest gap that typically occurs in these going to Greg.

Thanks,

Jonathan

Quoted 136 lines

---
Changes in v2:
- None because only [PATCH v2 1/3] has improvement

  drivers/staging/iio/meter/ade7753.c | 46 ++++++++++++++++++-------------------
  1 file changed, 23 insertions(+), 23 deletions(-)

drivers/staging/iio/meter/ade7753.c +23 ~~-23~~

index 5d45a68..2534bd0 100644
@@ -298,92 +298,92 @@ static IIO_DEV_ATTR_AENERGY(ade7753_read_24bit, ADE7753_AENERGY);
  static IIO_DEV_ATTR_LAENERGY(ade7753_read_24bit, ADE7753_LAENERGY);
  static IIO_DEV_ATTR_VAENERGY(ade7753_read_24bit, ADE7753_VAENERGY);
  static IIO_DEV_ATTR_LVAENERGY(ade7753_read_24bit, ADE7753_LVAENERGY);
-static IIO_DEV_ATTR_CFDEN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CFDEN(0644,
  		ade7753_read_16bit,
  		ade7753_write_16bit,
  		ADE7753_CFDEN);
-static IIO_DEV_ATTR_CFNUM(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CFNUM(0644,
  		ade7753_read_8bit,
  		ade7753_write_8bit,
  		ADE7753_CFNUM);
  static IIO_DEV_ATTR_CHKSUM(ade7753_read_8bit, ADE7753_CHKSUM);
-static IIO_DEV_ATTR_PHCAL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_PHCAL(0644,
  		ade7753_read_16bit,
  		ade7753_write_16bit,
  		ADE7753_PHCAL);
-static IIO_DEV_ATTR_APOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_APOS(0644,
  		ade7753_read_16bit,
  		ade7753_write_16bit,
  		ADE7753_APOS);
-static IIO_DEV_ATTR_SAGCYC(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAGCYC(0644,
  		ade7753_read_8bit,
  		ade7753_write_8bit,
  		ADE7753_SAGCYC);
-static IIO_DEV_ATTR_SAGLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAGLVL(0644,
  		ade7753_read_8bit,
  		ade7753_write_8bit,
  		ADE7753_SAGLVL);
-static IIO_DEV_ATTR_LINECYC(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_LINECYC(0644,
  		ade7753_read_8bit,
  		ade7753_write_8bit,
  		ADE7753_LINECYC);
-static IIO_DEV_ATTR_WDIV(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_WDIV(0644,
  		ade7753_read_8bit,
  		ade7753_write_8bit,
  		ADE7753_WDIV);
-static IIO_DEV_ATTR_IRMS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IRMS(0644,
  		ade7753_read_24bit,
  		NULL,
  		ADE7753_IRMS);
-static IIO_DEV_ATTR_VRMS(S_IRUGO,
+static IIO_DEV_ATTR_VRMS(0444,
  		ade7753_read_24bit,
  		NULL,
  		ADE7753_VRMS);
-static IIO_DEV_ATTR_IRMSOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IRMSOS(0644,
  		ade7753_read_16bit,
  		ade7753_write_16bit,
  		ADE7753_IRMSOS);
-static IIO_DEV_ATTR_VRMSOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VRMSOS(0644,
  		ade7753_read_16bit,
  		ade7753_write_16bit,
  		ADE7753_VRMSOS);
-static IIO_DEV_ATTR_WGAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_WGAIN(0644,
  		ade7753_read_16bit,
  		ade7753_write_16bit,
  		ADE7753_WGAIN);
-static IIO_DEV_ATTR_VAGAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VAGAIN(0644,
  		ade7753_read_16bit,
  		ade7753_write_16bit,
  		ADE7753_VAGAIN);
-static IIO_DEV_ATTR_PGA_GAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_PGA_GAIN(0644,
  		ade7753_read_16bit,
  		ade7753_write_16bit,
  		ADE7753_GAIN);
-static IIO_DEV_ATTR_IPKLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IPKLVL(0644,
  		ade7753_read_8bit,
  		ade7753_write_8bit,
  		ADE7753_IPKLVL);
-static IIO_DEV_ATTR_VPKLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VPKLVL(0644,
  		ade7753_read_8bit,
  		ade7753_write_8bit,
  		ADE7753_VPKLVL);
-static IIO_DEV_ATTR_IPEAK(S_IRUGO,
+static IIO_DEV_ATTR_IPEAK(0444,
  		ade7753_read_24bit,
  		NULL,
  		ADE7753_IPEAK);
-static IIO_DEV_ATTR_VPEAK(S_IRUGO,
+static IIO_DEV_ATTR_VPEAK(0444,
  		ade7753_read_24bit,
  		NULL,
  		ADE7753_VPEAK);
-static IIO_DEV_ATTR_VPERIOD(S_IRUGO,
+static IIO_DEV_ATTR_VPERIOD(0444,
  		ade7753_read_16bit,
  		NULL,
  		ADE7753_PERIOD);
-static IIO_DEV_ATTR_CH_OFF(1, S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CH_OFF(1, 0644,
  		ade7753_read_8bit,
  		ade7753_write_8bit,
  		ADE7753_CH1OS);
-static IIO_DEV_ATTR_CH_OFF(2, S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CH_OFF(2, 0644,
  		ade7753_read_8bit,
  		ade7753_write_8bit,
  		ADE7753_CH2OS);

@@ -514,7 +514,7 @@ static IIO_DEV_ATTR_TEMP_RAW(ade7753_read_8bit);
  static IIO_CONST_ATTR(in_temp_offset, "-25 C");
  static IIO_CONST_ATTR(in_temp_scale, "0.67 C");
 
-static IIO_DEV_ATTR_SAMP_FREQ(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAMP_FREQ(0644,
  		ade7753_read_frequency,
  		ade7753_write_frequency);

harinath Nampally

author

2017-05-15 03:10 UTC #11 lore raw

Re: [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions.

Jonathan,

Thank you for letting me know. In future I will work on 'togreg' branch of iio.git tree to send my patches.

Thanks,
Harinath

Quoted 164 lines · Jonathan Cameron

Quoted 9 lines · Harinath Nampally

This patch fixes below kind of warnings:
WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred.
Below errors are false positives:
ade7753.c:382: ERROR: Use 4 digit octal (0777) not decimal permissions ade7753.c:386: ERROR: Use 4 digit octal (0777) not decimal permissions
Signed-off-by Harinath Nampally <[email protected]>

I've already taken a patch for this.

Thanks,

Jonathan

Quoted 137 lines

---
Changes in v2:
- None because only [PATCH v2 1/3] has improvement

  drivers/staging/iio/meter/ade7753.c | 46
++++++++++++++++++-------------------
  1 file changed, 23 insertions(+), 23 deletions(-)

drivers/staging/iio/meter/ade7753.c +22 ~~-22~~

index 5d45a68..2534bd0 100644
@@ -298,92 +298,92 @@ static IIO_DEV_ATTR_AENERGY(ade7753_read_24bit,
 ADE7753_AENERGY);
  static IIO_DEV_ATTR_LAENERGY(ade7753_read_24bit, ADE7753_LAENERGY);
  static IIO_DEV_ATTR_VAENERGY(ade7753_read_24bit, ADE7753_VAENERGY);
  static IIO_DEV_ATTR_LVAENERGY(ade7753_read_24bit, ADE7753_LVAENERGY);
-static IIO_DEV_ATTR_CFDEN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CFDEN(0644,
                ade7753_read_16bit,
                ade7753_write_16bit,
                ADE7753_CFDEN);
-static IIO_DEV_ATTR_CFNUM(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CFNUM(0644,
                ade7753_read_8bit,
                ade7753_write_8bit,
                ADE7753_CFNUM);
  static IIO_DEV_ATTR_CHKSUM(ade7753_read_8bit, ADE7753_CHKSUM);
-static IIO_DEV_ATTR_PHCAL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_PHCAL(0644,
                ade7753_read_16bit,
                ade7753_write_16bit,
                ADE7753_PHCAL);
-static IIO_DEV_ATTR_APOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_APOS(0644,
                ade7753_read_16bit,
                ade7753_write_16bit,
                ADE7753_APOS);
-static IIO_DEV_ATTR_SAGCYC(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAGCYC(0644,
                ade7753_read_8bit,
                ade7753_write_8bit,
                ADE7753_SAGCYC);
-static IIO_DEV_ATTR_SAGLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAGLVL(0644,
                ade7753_read_8bit,
                ade7753_write_8bit,
                ADE7753_SAGLVL);
-static IIO_DEV_ATTR_LINECYC(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_LINECYC(0644,
                ade7753_read_8bit,
                ade7753_write_8bit,
                ADE7753_LINECYC);
-static IIO_DEV_ATTR_WDIV(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_WDIV(0644,
                ade7753_read_8bit,
                ade7753_write_8bit,
                ADE7753_WDIV);
-static IIO_DEV_ATTR_IRMS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IRMS(0644,
                ade7753_read_24bit,
                NULL,
                ADE7753_IRMS);
-static IIO_DEV_ATTR_VRMS(S_IRUGO,
+static IIO_DEV_ATTR_VRMS(0444,
                ade7753_read_24bit,
                NULL,
                ADE7753_VRMS);
-static IIO_DEV_ATTR_IRMSOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IRMSOS(0644,
                ade7753_read_16bit,
                ade7753_write_16bit,
                ADE7753_IRMSOS);
-static IIO_DEV_ATTR_VRMSOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VRMSOS(0644,
                ade7753_read_16bit,
                ade7753_write_16bit,
                ADE7753_VRMSOS);
-static IIO_DEV_ATTR_WGAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_WGAIN(0644,
                ade7753_read_16bit,
                ade7753_write_16bit,
                ADE7753_WGAIN);
-static IIO_DEV_ATTR_VAGAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VAGAIN(0644,
                ade7753_read_16bit,
                ade7753_write_16bit,
                ADE7753_VAGAIN);
-static IIO_DEV_ATTR_PGA_GAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_PGA_GAIN(0644,
                ade7753_read_16bit,
                ade7753_write_16bit,
                ADE7753_GAIN);
-static IIO_DEV_ATTR_IPKLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IPKLVL(0644,
                ade7753_read_8bit,
                ade7753_write_8bit,
                ADE7753_IPKLVL);
-static IIO_DEV_ATTR_VPKLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VPKLVL(0644,
                ade7753_read_8bit,
                ade7753_write_8bit,
                ADE7753_VPKLVL);
-static IIO_DEV_ATTR_IPEAK(S_IRUGO,
+static IIO_DEV_ATTR_IPEAK(0444,
                ade7753_read_24bit,
                NULL,
                ADE7753_IPEAK);
-static IIO_DEV_ATTR_VPEAK(S_IRUGO,
+static IIO_DEV_ATTR_VPEAK(0444,
                ade7753_read_24bit,
                NULL,
                ADE7753_VPEAK);
-static IIO_DEV_ATTR_VPERIOD(S_IRUGO,
+static IIO_DEV_ATTR_VPERIOD(0444,
                ade7753_read_16bit,
                NULL,
                ADE7753_PERIOD);
-static IIO_DEV_ATTR_CH_OFF(1, S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CH_OFF(1, 0644,
                ade7753_read_8bit,
                ade7753_write_8bit,
                ADE7753_CH1OS);
-static IIO_DEV_ATTR_CH_OFF(2, S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CH_OFF(2, 0644,
                ade7753_read_8bit,
                ade7753_write_8bit,

                ADE7753_CH2OS);

drivers/staging/iio/meter/ade7753.c +1 -0

@@ -514,7 +514,7 @@ static IIO_DEV_ATTR_TEMP_RAW(ade7753_read_8bit);
  static IIO_CONST_ATTR(in_temp_offset, "-25 C");
  static IIO_CONST_ATTR(in_temp_scale, "0.67 C");
  -static IIO_DEV_ATTR_SAMP_FREQ(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAMP_FREQ(0644,
                ade7753_read_frequency,
                ade7753_write_frequency);

Signature · 3 lines

Thanks,
Harinath
+1 312 560 8565

Jonathan Cameron

maintainer

2017-05-14 15:24 UTC #12 lore raw

Re: [PATCH v2 0/3] coding style warnings fixes

In reply to Harinath Nampally

Quoted 11 lines · Harinath Nampally

This revised patchset is for improvement in [PATCH v2 1/3] as per the code review comment from Dan Carpenter.
Other two patches [PATCH v2 2/3] and [PATCH v2 3/3] are unchanged, so they are same as [PATCH 2/3] and [PATCH 3/3] respectively.
Please find the following related patches:
[PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition [PATCH v2 2/3] staging: iio: meter: Fix the identations for proper alignments [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions

Quoted 8 lines

Harinath Nampally (3):
staging: iio: meter: Add the comment for mutex definition
staging: iio: meter: Fix the identations for proper alignments
staging: iio: meter: Replace symbolic permissions with octal
permissions
  drivers/staging/iio/meter/ade7753.c | 104 ++++++++++++++++++------------------
  1 file changed, 51 insertions(+), 52 deletions(-)

Please don't post new versions of a patch series as a reply to earlier versions. It very rapidly leads to deep and unmanageable threads!

Jonathan

Quoted 1 line

Harinath Nampally

author

2017-05-09 01:49 UTC #13 lore raw

PATCH 2/3 staging: iio: meter: Fix the identations for proper alignments

In reply to Harinath Nampally

This patch fixes below checkpatch.pl kind of warnings:
CHECK: Alignment should match open parenthesis

Signed-off-by Harinath Nampally <[email protected]>

---
 drivers/staging/iio/meter/ade7753.c | 55 ++++++++++++++++++-------------------
 1 file changed, 27 insertions(+), 28 deletions(-)

drivers/staging/iio/meter/ade7753.c +27 ~~-28~~

index cffe6bf..5d45a68 100644
@@ -108,9 +108,8 @@ static int ade7753_spi_write_reg_8(struct device *dev,
 	return ret;
 }
 
-static int ade7753_spi_write_reg_16(struct device *dev,
-		u8 reg_address,
-		u16 value)
+static int ade7753_spi_write_reg_16(struct device *dev, u8 reg_address,
+				    u16 value)
 {
 	int ret;
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);

@@ -127,8 +126,8 @@ static int ade7753_spi_write_reg_16(struct device *dev,
 }
 
 static int ade7753_spi_read_reg_8(struct device *dev,
-		u8 reg_address,
-		u8 *val)
+				  u8 reg_address,
+				  u8 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);

@@ -137,7 +136,7 @@ static int ade7753_spi_read_reg_8(struct device *dev,
 	ret = spi_w8r8(st->us, ADE7753_READ_REG(reg_address));
 	if (ret < 0) {
 		dev_err(&st->us->dev, "problem when reading 8 bit register 0x%02X",
-				reg_address);
+			reg_address);
 		return ret;
 	}
 	*val = ret;

@@ -146,8 +145,8 @@ static int ade7753_spi_read_reg_8(struct device *dev,
 }
 
 static int ade7753_spi_read_reg_16(struct device *dev,
-		u8 reg_address,
-		u16 *val)
+				   u8 reg_address,
+				   u16 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);

@@ -166,8 +165,8 @@ static int ade7753_spi_read_reg_16(struct device *dev,
 }
 
 static int ade7753_spi_read_reg_24(struct device *dev,
-		u8 reg_address,
-		u32 *val)
+				   u8 reg_address,
+				   u32 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);

@@ -190,7 +189,7 @@ static int ade7753_spi_read_reg_24(struct device *dev,
 	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
 	if (ret) {
 		dev_err(&st->us->dev, "problem when reading 24 bit register 0x%02X",
-				reg_address);
+			reg_address);
 		goto error_ret;
 	}
 	*val = (st->rx[0] << 16) | (st->rx[1] << 8) | st->rx[2];

@@ -201,8 +200,8 @@ static int ade7753_spi_read_reg_24(struct device *dev,
 }
 
 static ssize_t ade7753_read_8bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				 struct device_attribute *attr,
+				 char *buf)
 {
 	int ret;
 	u8 val;

@@ -216,8 +215,8 @@ static ssize_t ade7753_read_8bit(struct device *dev,
 }
 
 static ssize_t ade7753_read_16bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				  struct device_attribute *attr,
+				  char *buf)
 {
 	int ret;
 	u16 val;

@@ -231,8 +230,8 @@ static ssize_t ade7753_read_16bit(struct device *dev,
 }
 
 static ssize_t ade7753_read_24bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				  struct device_attribute *attr,
+				  char *buf)
 {
 	int ret;
 	u32 val;

@@ -246,9 +245,9 @@ static ssize_t ade7753_read_24bit(struct device *dev,
 }
 
 static ssize_t ade7753_write_8bit(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				  struct device_attribute *attr,
+				  const char *buf,
+				  size_t len)
 {
 	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
 	int ret;

@@ -264,9 +263,9 @@ static ssize_t ade7753_write_8bit(struct device *dev,
 }
 
 static ssize_t ade7753_write_16bit(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				   struct device_attribute *attr,
+				   const char *buf,
+				   size_t len)
 {
 	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
 	int ret;

@@ -451,8 +450,8 @@ static int ade7753_initial_setup(struct iio_dev *indio_dev)
 }
 
 static ssize_t ade7753_read_frequency(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				      struct device_attribute *attr,
+				      char *buf)
 {
 	int ret;
 	u16 t;

@@ -469,9 +468,9 @@ static ssize_t ade7753_read_frequency(struct device *dev,
 }
 
 static ssize_t ade7753_write_frequency(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				       struct device_attribute *attr,
+				       const char *buf,
+				       size_t len)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);

Signature · 1 line

2.7.4

Harinath Nampally

author

2017-05-09 01:49 UTC #14 lore raw

PATCH 3/3 staging: iio: meter: Replace symbolic permissions with octal permissions

In reply to Harinath Nampally

This patch fixes below kind of warnings:
WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred.

Below errors are false positives:
ade7753.c:382: ERROR: Use 4 digit octal (0777) not decimal permissions ade7753.c:386: ERROR: Use 4 digit octal (0777) not decimal permissions

Signed-off-by Harinath Nampally <[email protected]>

---
 drivers/staging/iio/meter/ade7753.c | 46 ++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

drivers/staging/iio/meter/ade7753.c +23 ~~-23~~

index 5d45a68..2534bd0 100644
@@ -298,92 +298,92 @@ static IIO_DEV_ATTR_AENERGY(ade7753_read_24bit, ADE7753_AENERGY);
 static IIO_DEV_ATTR_LAENERGY(ade7753_read_24bit, ADE7753_LAENERGY);
 static IIO_DEV_ATTR_VAENERGY(ade7753_read_24bit, ADE7753_VAENERGY);
 static IIO_DEV_ATTR_LVAENERGY(ade7753_read_24bit, ADE7753_LVAENERGY);
-static IIO_DEV_ATTR_CFDEN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CFDEN(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_CFDEN);
-static IIO_DEV_ATTR_CFNUM(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CFNUM(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_CFNUM);
 static IIO_DEV_ATTR_CHKSUM(ade7753_read_8bit, ADE7753_CHKSUM);
-static IIO_DEV_ATTR_PHCAL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_PHCAL(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_PHCAL);
-static IIO_DEV_ATTR_APOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_APOS(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_APOS);
-static IIO_DEV_ATTR_SAGCYC(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAGCYC(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_SAGCYC);
-static IIO_DEV_ATTR_SAGLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAGLVL(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_SAGLVL);
-static IIO_DEV_ATTR_LINECYC(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_LINECYC(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_LINECYC);
-static IIO_DEV_ATTR_WDIV(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_WDIV(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_WDIV);
-static IIO_DEV_ATTR_IRMS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IRMS(0644,
 		ade7753_read_24bit,
 		NULL,
 		ADE7753_IRMS);
-static IIO_DEV_ATTR_VRMS(S_IRUGO,
+static IIO_DEV_ATTR_VRMS(0444,
 		ade7753_read_24bit,
 		NULL,
 		ADE7753_VRMS);
-static IIO_DEV_ATTR_IRMSOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IRMSOS(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_IRMSOS);
-static IIO_DEV_ATTR_VRMSOS(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VRMSOS(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_VRMSOS);
-static IIO_DEV_ATTR_WGAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_WGAIN(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_WGAIN);
-static IIO_DEV_ATTR_VAGAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VAGAIN(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_VAGAIN);
-static IIO_DEV_ATTR_PGA_GAIN(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_PGA_GAIN(0644,
 		ade7753_read_16bit,
 		ade7753_write_16bit,
 		ADE7753_GAIN);
-static IIO_DEV_ATTR_IPKLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_IPKLVL(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_IPKLVL);
-static IIO_DEV_ATTR_VPKLVL(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_VPKLVL(0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_VPKLVL);
-static IIO_DEV_ATTR_IPEAK(S_IRUGO,
+static IIO_DEV_ATTR_IPEAK(0444,
 		ade7753_read_24bit,
 		NULL,
 		ADE7753_IPEAK);
-static IIO_DEV_ATTR_VPEAK(S_IRUGO,
+static IIO_DEV_ATTR_VPEAK(0444,
 		ade7753_read_24bit,
 		NULL,
 		ADE7753_VPEAK);
-static IIO_DEV_ATTR_VPERIOD(S_IRUGO,
+static IIO_DEV_ATTR_VPERIOD(0444,
 		ade7753_read_16bit,
 		NULL,
 		ADE7753_PERIOD);
-static IIO_DEV_ATTR_CH_OFF(1, S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CH_OFF(1, 0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_CH1OS);
-static IIO_DEV_ATTR_CH_OFF(2, S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_CH_OFF(2, 0644,
 		ade7753_read_8bit,
 		ade7753_write_8bit,
 		ADE7753_CH2OS);

@@ -514,7 +514,7 @@ static IIO_DEV_ATTR_TEMP_RAW(ade7753_read_8bit);
 static IIO_CONST_ATTR(in_temp_offset, "-25 C");
 static IIO_CONST_ATTR(in_temp_scale, "0.67 C");
 
-static IIO_DEV_ATTR_SAMP_FREQ(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAMP_FREQ(0644,
 		ade7753_read_frequency,
 		ade7753_write_frequency);

Signature · 1 line

2.7.4