Enable DSM pass thru for root functions

include/uapi/linux/ndctl.h static inline const char *nvdimm_bus_cmd_name(unsigned cmd) · line 225

Quoted 10 lines · Jerry Hoemann

include/uapi/linux/ndctl.h +4 -0

@@ -179,6 +217,10 @@ static inline const char *nvdimm_bus_cmd_name(unsigned cmd)
              [ND_CMD_ARS_START] = "ars_start",
              [ND_CMD_ARS_STATUS] = "ars_status",
              [ND_CMD_CLEAR_ERROR] = "clear_error",
+             [5] = "trans_spa",
+             [7] = "ars_err_inj",
+             [8] = "ars_err_inj_clr",
+             [9] = "ars_err_inj_stat",
              [ND_CMD_CALL] = "cmd_call",
      };

Can you please add the new values to the enum in uapi/ndctl.h? I don't really like the magic numbers here.

Quoted 14 lines · Johannes Thumshirn

include/uapi/linux/ndctl.h static inline const char *nvdimm_bus_cmd_name(unsigned cmd) · line 225

Quoted 10 lines · Jerry Hoemann

include/uapi/linux/ndctl.h +4 -0

@@ -179,6 +217,10 @@ static inline const char *nvdimm_bus_cmd_name(unsigned cmd)
              [ND_CMD_ARS_START] = "ars_start",
              [ND_CMD_ARS_STATUS] = "ars_status",
              [ND_CMD_CLEAR_ERROR] = "clear_error",
+             [5] = "trans_spa",
+             [7] = "ars_err_inj",
+             [8] = "ars_err_inj_clr",
+             [9] = "ars_err_inj_stat",
              [ND_CMD_CALL] = "cmd_call",
      };

Can you please add the new values to the enum in uapi/ndctl.h? I don't really like the magic numbers here.

I think the reason Jerry didn't add them is due to symmetry. All the current ND_CMD_ definitions have corresponding ND_IOCTL_ definitions. These new commands we're only adding function number support and using ND_CMD_CALL for the ioctl transport.

We can still add definitions for
them, but perhaps with an ACPI_NFIT_DSM_ prefix? The only consumer in the kernel of this is debug output code. I think perhaps we should just delete them here and either print raw numbers or enable acpi_nfit_ctl() to the decode and not rely on nvdimm_bus_cmd_name() which is meant to represent NVDIMM bus type generic command numbers.

Quoted 16 lines · Dan Williams

Quoted 14 lines · Johannes Thumshirn

include/uapi/linux/ndctl.h static inline const char *nvdimm_bus_cmd_name(unsigned cmd) · line 225

Quoted 10 lines · Jerry Hoemann

include/uapi/linux/ndctl.h +4 -0

@@ -179,6 +217,10 @@ static inline const char *nvdimm_bus_cmd_name(unsigned cmd)
              [ND_CMD_ARS_START] = "ars_start",
              [ND_CMD_ARS_STATUS] = "ars_status",
              [ND_CMD_CLEAR_ERROR] = "clear_error",
+             [5] = "trans_spa",
+             [7] = "ars_err_inj",
+             [8] = "ars_err_inj_clr",
+             [9] = "ars_err_inj_stat",
              [ND_CMD_CALL] = "cmd_call",
      };

Can you please add the new values to the enum in uapi/ndctl.h? I don't really like the magic numbers here.

Quoted 4 lines

I think the reason Jerry didn't add them is due to symmetry. All the current ND_CMD_ definitions have corresponding ND_IOCTL_ definitions. These new commands we're only adding function number support and using ND_CMD_CALL for the ioctl transport.

Yes, this is correct.

Quoted 6 lines

We can still add definitions for
them, but perhaps with an ACPI_NFIT_DSM_ prefix? The only consumer in the kernel of this is debug output code. I think perhaps we should just delete them here and either print raw numbers or enable acpi_nfit_ctl() to the decode and not rely on nvdimm_bus_cmd_name() which is meant to represent NVDIMM bus type generic command numbers.

This also comes into play when doing:

cat /sys/class/nd/ndctl0/device/nd/ndctl0/device/commands

Without change here the new functions would show up as "unknown unknown unknown unknown."

Dan, are you suggesting I change the above to:

               [ND_CMD_CLEAR_ERROR] = "clear_error",
 +             [5] = "5",
 +             [7] = "7",
 +             [8] = "8",
 +             [9] = "9",
               [ND_CMD_CALL] = "cmd_call",

Note, "6" is currently reserved by ACPI. I could add that also.