Skip to contentSkip to conversation

Small fixes

PATCH In review Jussi Kukkonen 3 participants 6 messages Jun 9, 2017 – Jun 12, 2017

lore
Share & tools
lore
#0 lore raw

cover Small fixes

A host path leak fix for diff and a build optimization for numpy.

Cheers,
Jussi

The following changes since commit 4a7612c7a12b9a381fb8343ba9586272b889fc15:

buildhistory: skip tests if GitPython module is missing (2017-06-07 16:00:49 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib numpy-parallel
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=numpy-parallel

Jussi Kukkonen (2):
Enable parallel compilation for python3-numpy
diffutils: prevent host path leaks, set pr path

 meta/recipes-devtools/python-numpy/python3-numpy_1.11.2.bb | 2 ++
 meta/recipes-extended/diffutils/diffutils_3.5.bb           | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/2 Enable parallel compilation for python3-numpy

Support for "-j N" does not seem like a generic distutils thing but numpy supports it.

This improves compile time by 2 minutes (real time).

---
 meta/recipes-devtools/python-numpy/python3-numpy_1.11.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/python-numpy/python3-numpy_1.11.2.bb +2 -0
index d5fe50c..9a9c4cf 100644
@@ -69,6 +69,8 @@ CONFIGFILESURI_mipsarchn32el = " \
 
 S = "${WORKDIR}/numpy-${PV}"
 
+DISTUTILS_BUILD_ARGS += "${PARALLEL_MAKE}"
+
 inherit setuptools3
 
 # Make the build fail and replace *config.h with proper one
Signature · 1 line
2.1.4
#3 lore raw

Re: [PATCH 1/2] Enable parallel compilation for python3-numpy

On 12 June 2017 at 13:06, Richard Purdie <[email protected]

Quoted 6 lines

wrote:

Quoted 3 lines · Jussi Kukkonen

Support for "-j N" does not seem like a generic distutils thing but numpy supports it.

Quoted 9 lines
Quoted 1 line

This improves compile time by 2 minutes (real time).

Sorry:

https://autobuilder.yocto.io/builders/nightly-musl/builds/
298/steps/BuildImages/logs/stdio

Appears to have races?

Indeed, thanks. I'll have a look but could be that there will be no v2 (I couldn't reproduce earlier and distutils isn't really my cup of tea).

Jussi

#4 lore raw

PATCH 2/2 diffutils: prevent host path leaks, set pr path

In reply to Jussi Kukkonen

Note that this just removes a host path leakage: diffutils still doesn't depend on coreutils so 'pr' might not actually be there on image (this only breaks "diff -l" so no big deal).

---
 meta/recipes-extended/diffutils/diffutils_3.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-extended/diffutils/diffutils_3.5.bb +1 -1
index 354a6e8..a4fc27b 100644
@@ -11,7 +11,7 @@ SRC_URI = "${GNU_MIRROR}/diffutils/diffutils-${PV}.tar.xz \
 SRC_URI[md5sum] = "569354697ff1cfc9a9de3781361015fa"
 SRC_URI[sha256sum] = "dad398ccd5b9faca6b0ab219a036453f62a602a56203ac659b43e889bec35533"
 
-EXTRA_OECONF += "--without-libsigsegv-prefix"
+EXTRA_OECONF += "ac_cv_path_PR_PROGRAM=${bindir}/pr --without-libsigsegv-prefix"
 
 # Fix "Argument list too long" error when len(TMPDIR) = 410
 acpaths = "-I ./m4"
Signature · 1 line
2.1.4
#5 lore raw

✗ patchtest: failure for Small fixes

In reply to Jussi Kukkonen

== Series Details ==

Series: Small fixes
Revision: 1
URL : https://patchwork.openembedded.org/series/7157/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Patch            [1/2] Enable parallel compilation for python3-numpy
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe