Skip to contentSkip to conversation

oe-init-build-env-memres: swap parameter order

PATCH New Paul Eggleton 1 participant 2 messages Jun 21, 2017

lore
Share & tools
lore
#0 lore raw

cover oe-init-build-env-memres: swap parameter order

The following changes since commit 1d9a88f635549e68562de681e297b9270ad02d4e:

ovmf: fix secureboot PACKAGECONFIG + OpenSSL update (2017-06-16 10:58:19 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib paule/memres-init-param-order
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=paule/memres-init-param-order

Paul Eggleton (1):
oe-init-build-env-memres: swap parameter order

 oe-init-build-env-memres | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Signature · 1 line
2.9.4
#1 lore raw

PATCH 1/1 oe-init-build-env-memres: swap parameter order

This script expected the port number to be specified first, which is somewhat counter-intuitive especially if you're used to oe-init-build-env; besides, in local usage you are unlikely to need to specify a custom port. Given that few people are using this yet (based on the issues I have recently fixed), switch the arguments around so that the two scripts behave consistently.

---
 oe-init-build-env-memres | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
oe-init-build-env-memres +6 -6
index 9e1425e..3f0d239 100755
@@ -19,18 +19,18 @@
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
 #
-# Normally this is called as '. ./oe-init-build-env-memres <portnumber> <builddir>'
+# Normally this is called as '. ./oe-init-build-env-memres <builddir> [portnumber]'
 #
 # This works in most shells (not dash), but not all of them pass the arguments
-# when being sourced.  To workaround the shell limitation use "set <portnumber>
-# <builddir>" prior to sourcing this script.
+# when being sourced.  To workaround the shell limitation use "set <builddir>
+# [portnumber]" prior to sourcing this script.
 #
-if [ -z "$1" ]; then
+if [ -z "$2" ]; then
     echo "No port specified, using dynamically selected port"
     port=-1
 else
-    port=$1
-    shift
+    port=$2
+    set -- "$1" "$3" "$4" "$5" "$6"
 fi
 
 if [ -n "$BASH_SOURCE" ]; then
Signature · 1 line
2.9.4