Skip to contentSkip to conversation

fix ls-remote help message

PATCH In review Silvio Fricke 2 participants 4 messages Jun 27, 2017 – Jun 28, 2017

lore
Share & tools
lore

Silvio Fricke

author
#0 lore raw

cover fix ls-remote help message

Hi,

a small patch about a wrong help text. Please include when okay.

Best Regards,
Silvio

Silvio Fricke (1):
ls-remote: remove "-h" from help text

 builtin/ls-remote.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.13.2
author
#1 lore raw

PATCH 1/1 ls-remote: remove "-h" from help text

This regression was fixed in 91a640ffb6d9 ("ls-remote: a lone "-h" is asking for help") and the wrong help text was introduced in ba5f28bf79ea ("ls-remote: use parse-options api").
This patch removes the "-h" on the help text.

Signed-off-by Silvio Fricke <[email protected]>
---
 builtin/ls-remote.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
builtin/ls-remote.c +1 -1
index b2d7d5ce6..cd54f7e98 100644
@@ -56,7 +56,7 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
 			   N_("path of git-upload-pack on the remote host"),
 			   PARSE_OPT_HIDDEN },
 		OPT_BIT('t', "tags", &flags, N_("limit to tags"), REF_TAGS),
-		OPT_BIT('h', "heads", &flags, N_("limit to heads"), REF_HEADS),
+		OPT_BIT(0, "heads", &flags, N_("limit to heads"), REF_HEADS),
 		OPT_BIT(0, "refs", &flags, N_("do not show peeled tags"), REF_NORMAL),
 		OPT_BOOL(0, "get-url", &get_url,
 			 N_("take url.<base>.insteadOf into account")),
Signature · 1 line
2.13.2
#2 lore raw

Re: [PATCH 1/1] ls-remote: remove "-h" from help text

Hi,

Quoted 9 lines · Silvio Fricke

This regression was fixed in 91a640ffb6d9 ("ls-remote: a lone "-h" is asking for help") and the wrong help text was introduced in ba5f28bf79ea ("ls-remote: use parse-options api").
This patch removes the "-h" on the help text.

Signed-off-by Silvio Fricke <[email protected]>
---
 builtin/ls-remote.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Without this patch, I'm able to run

git ls-remote -h .

This patch removes that support. Intended?

Thanks and hope that helps,
Jonathan

author
#3 lore raw

Re: [PATCH 1/1] ls-remote: remove "-h" from help text

Hi Jonathan,

Quoted 8 lines
Quoted 2 lines

This regression was fixed in 91a640ffb6d9 ("ls-remote: a lone "-h" is [...]

Without this patch, I'm able to run

git ls-remote -h .

This patch removes that support. Intended?

*hihi* okay it was to counter-intuitive for me. "91a640ffb6d" talks about this issue.

Thanks for enlightenment :-)
Silvio

Signature · 4 lines
-- S. Fricke ---------------------------------------- [email protected] --
   Diplom-Informatiker (FH)
   Linux-Development                         Matrix: @silvio:port1024.net   
----------------------------------------------------------------------------