Skip to contentSkip to conversation

serial: 8250: add support for MediaTek BTIF controller

PATCH In review [email protected] 3 participants 5 messages Aug 20, 2017 – Aug 23, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v3 cover serial: 8250: add support for MediaTek BTIF controller

From: Sean Wang <[email protected]>

Since v3:
- enhancing the definition of the compatible strings in dt-bindings

Since v2:
- reusing 8250_of since the original driver has almost the same logic

This patchset introduces the support for MediaTek BTIF controller.

MediaTek BTIF controller is the serial interface similar to UART but it works only as the digital device which is mainly used to communicate with the connectivity module also called CONNSYS inside the SoC which could be mostly found on those MediaTek SoCs with Bluetooth feature.

And the controller is made as being compatible with the 8250 register layout so it tends to be integrated with existing 8250 core driver and have no requirement for the modem configuration additionally such as the baud rate calculation and assignment.

Sean Wang (2):
dt-bindings: serial: 8250: Add MediaTek BTIF controller bindings
serial: 8250: of: Add new port type for MediaTek BTIF controller on

    MT7622/23 SoC
 Documentation/devicetree/bindings/serial/8250.txt | 2 ++
 drivers/tty/serial/8250/8250_of.c                 | 2 ++
 drivers/tty/serial/8250/8250_port.c               | 8 ++++++++
 include/uapi/linux/serial_core.h                  | 3 +++
 4 files changed, 15 insertions(+)
Signature · 1 line
2.7.4
#1 lore raw

PATCH v3 1/2 dt-bindings: serial: 8250: Add MediaTek BTIF controller bindings

From: Sean Wang <[email protected]>

Document the devicetree bindings in 8250.txt for MediaTek BTIF controller which could be found on MT7622 and MT7623 SoC.

---
 Documentation/devicetree/bindings/serial/8250.txt | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/serial/8250.txt +2 -0
index 419ff6c..dad3b2e 100644
@@ -14,6 +14,8 @@ Required properties:
 	  tegra132, or tegra210.
 	- "nxp,lpc3220-uart"
 	- "ralink,rt2880-uart"
+	- For MediaTek BTIF, must contain '"mediatek,<chip>-btif",
+	  "mediatek,mtk-btif"' where <chip> is mt7622, mt7623.
 	- "altr,16550-FIFO32"
 	- "altr,16550-FIFO64"
 	- "altr,16550-FIFO128"
Signature · 1 line
2.7.4
maintainer Acked-by on v3 1/2
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: serial: 8250: Add MediaTek BTIF controller bindings

Quoted 9 lines · sean.wang at mediatek.com

From: Sean Wang <[email protected]>

Document the devicetree bindings in 8250.txt for MediaTek BTIF controller which could be found on MT7622 and MT7623 SoC.

---
 Documentation/devicetree/bindings/serial/8250.txt | 2 ++
 1 file changed, 2 insertions(+)
#3 lore raw

PATCH v3 2/2 serial: 8250: of: Add new port type for MediaTek BTIF controller on MT7622/23 SoC

In reply to [email protected]

From: Sean Wang <[email protected]>

MediaTek BTIF controller is the serial interface similar to UART but it works only as the digital device which is mainly used to communicate with the connectivity module called CONNSYS inside the SoC which could be mostly found on those MediaTek SoCs with Bluetooth feature such as MT7622 and MT7623 SoCs.

And the controller is made as being compatible with the 8250 register layout with extra registers such as DMA enablement so it tends to be integrated with reusing 8250 OF driver. However, DMA mode is not being supported yet in the current driver.

---
 drivers/tty/serial/8250/8250_of.c   | 2 ++
 drivers/tty/serial/8250/8250_port.c | 8 ++++++++
 include/uapi/linux/serial_core.h    | 3 +++
 3 files changed, 13 insertions(+)
drivers/tty/serial/8250/8250_of.c +2 -0
index 6c5a8ca..be1c5e75 100644
@@ -300,6 +300,8 @@ static const struct of_device_id of_platform_serial_table[] = {
 		.data = (void *)PORT_ALTR_16550_F64, },
 	{ .compatible = "altr,16550-FIFO128",
 		.data = (void *)PORT_ALTR_16550_F128, },
+	{ .compatible = "mediatek,mtk-btif",
+		.data = (void *)PORT_MTK_BTIF, },
 	{ .compatible = "mrvl,mmp-uart",
 		.data = (void *)PORT_XSCALE, },
 	{ .compatible = "ti,da830-uart", .data = (void *)PORT_DA830, },
drivers/tty/serial/8250/8250_port.c +8 -0
index 25aae66..053bb38 100644
@@ -289,6 +289,14 @@ static const struct serial8250_config uart_config[] = {
 		.rxtrig_bytes	= {1, 4, 8, 14},
 		.flags		= UART_CAP_FIFO | UART_CAP_AFE,
 	},
+	[PORT_MTK_BTIF] = {
+		.name		= "MediaTek BTIF",
+		.fifo_size	= 16,
+		.tx_loadsz	= 16,
+		.fcr		= UART_FCR_ENABLE_FIFO |
+				  UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT,
+		.flags		= UART_CAP_FIFO,
+	},
 };
 
 /* Uart divisor latch read */
include/uapi/linux/serial_core.h +3 -0
index 38bea32..cfc07a5 100644
@@ -272,4 +272,7 @@
 /* MPS2 UART */
 #define PORT_MPS2UART	116
 
+/* MediaTek BTIF */
+#define PORT_MTK_BTIF	117
+
 #endif /* _UAPILINUX_SERIAL_CORE_H */
Signature · 1 line
2.7.4
Acked-by on v3 2/2
#4 lore raw

Re: [PATCH v3 2/2] serial: 8250: of: Add new port type for MediaTek BTIF controller on MT7622/23 SoC

Quoted 8 lines · On Sun, Aug 20, 2017 at 7:17 PM, <[email protected]> wrote:

From: Sean Wang <[email protected]>

MediaTek BTIF controller is the serial interface similar to UART but it works only as the digital device which is mainly used to communicate with the connectivity module called CONNSYS inside the SoC which could be mostly found on those MediaTek SoCs with Bluetooth feature such as MT7622 and MT7623 SoCs.

Quoted 7 lines

And the controller is made as being compatible with the 8250 register layout with extra registers such as DMA enablement so it tends to be integrated with reusing 8250 OF driver. However, DMA mode is not being supported yet in the current driver.