Skip to contentSkip to conversation

ovmf: fix do_compile error when len(tmp)=410

PATCH Superseded Dengke Du 2 participants 4 messages Sep 11, 2017 – Sep 12, 2017

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Dengke Du

author
#0 lore raw

cover ovmf: fix do_compile error when len(tmp)=410

The following changes since commit 8b4f16a9cbbaf521461f699b7264fac2ac872581:

mesa-gl: Fix build after recent mesa PACKAGECONFIG changes (2017-09-05 15:01:02 +0100)

are available in the git repository at:

https://github.com/DengkeDu/openembedded-core.git dengke/fix-ovmf-do-compile-error-when-enable-long-file-path
https://github.com//tree/dengke/fix-ovmf-do-compile-error-when-enable-long-file-path

Dengke Du (1):
ovmf: fix do_compile error when len(tmp)=410

 .../ovmf/0004-ovmf-enable-long-path-file.patch     | 28 ++++++++++++++++++++++
 meta/recipes-core/ovmf/ovmf_git.bb                 |  3 ++-
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-file.patch
Signature · 1 line
2.8.1
author
#1 lore raw

PATCH 1/1 ovmf: fix do_compile error when len(tmp)=410

[YOCTO #11354]

Signed-off-by Dengke Du <[email protected]>
---
 .../ovmf/0004-ovmf-enable-long-path-file.patch     | 28 ++++++++++++++++++++++
 meta/recipes-core/ovmf/ovmf_git.bb                 |  3 ++-
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-file.patch
meta/recipes-core/ovmf/ovmf/0004-ovmf-enable-long-path-file.patch new file +28 -0
new file mode 100644
index 0000000..fbb95ed
@@ -0,0 +1,28 @@
+From a07eef024089de6bc1cfe4effa4f04cc765d00eb Mon Sep 17 00:00:00 2001
+From: Dengke Du <[email protected]>
+Date: Mon, 11 Sep 2017 02:21:55 -0400
+Subject: [PATCH] ovmf: enable long path file
+
+Upstream-Status: Pending
+
+Signed-off-by: Dengke Du <[email protected]>
+---
+ BaseTools/Source/C/Common/CommonLib.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/BaseTools/Source/C/Common/CommonLib.h b/BaseTools/Source/C/Common/CommonLib.h
+index 2041b89..279cf59 100644
+--- a/BaseTools/Source/C/Common/CommonLib.h
++++ b/BaseTools/Source/C/Common/CommonLib.h
+@@ -19,7 +19,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+ #include <Common/BuildVersion.h>
+ #define PRINTED_GUID_BUFFER_SIZE  37  // including null-termination
+ 
+-#define MAX_LONG_FILE_PATH 500
++#define MAX_LONG_FILE_PATH 800
+ 
+ #ifdef __cplusplus
+ extern "C" {
+-- 
+2.8.1
+
meta/recipes-core/ovmf/ovmf_git.bb +2 -1
index 1872c95..50c01aa 100644
@@ -11,10 +11,11 @@ PACKAGECONFIG ??= ""
 PACKAGECONFIG[secureboot] = ",,,"
 
 SRC_URI = "git://github.com/tianocore/edk2.git;branch=master \
+	file://0001-ia32-Dont-use-pie.patch \
 	file://0002-ovmf-update-path-to-native-BaseTools.patch \
 	file://0003-BaseTools-makefile-adjust-to-build-in-under-bitbake.patch \
+	file://0004-ovmf-enable-long-path-file.patch \
 	file://VfrCompile-increase-path-length-limit.patch \
-	file://0001-ia32-Dont-use-pie.patch \
 	file://no-stack-protector-all-archs.patch \
         "
 UPSTREAM_VERSION_UNKNOWN = "1"
Signature · 1 line
2.8.1
#2 lore raw
Quoted 3 lines · Dengke Du

+-#define MAX_LONG_FILE_PATH 500
++#define MAX_LONG_FILE_PATH 800

Making this limit a little bigger seems like a great way to hit it with a slightly longer path. The other patch (VfrCompile-increase-path-length-limit.patch)
increases it to 1023 which seems to be a more future-proof solution (and consistent).

Ross

author
#3 lore raw

Ok, I will resend it with 1023.

Quoted 9 lines · Ross

On 11 September 2017 at 08:29, Dengke Du <[email protected] <mailto:[email protected]>> wrote:

    +-#define MAX_LONG_FILE_PATH 500
    ++#define MAX_LONG_FILE_PATH 800

Making this limit a little bigger seems like a great way to hit it with a slightly longer path. The other patch (VfrCompile-increase-path-length-limit.patch) increases it to 1023 which seems to be a more future-proof solution (and consistent).

Ross