fix code styling warnings in llite files
cover fix code styling warnings in llite files
These patches fix various checkpatch.pl warnings in llite files.
---------------------------------------------------------------------------
Aastha Gupta (4):
staging: lustre: llite: fix lines over 80 characters in llite files
staging: lustre: llite: fix identation in dir
staging: lustre: lllite: fix multi line comments alignment in file
staging: lustre: llite: fix multi line comments style
drivers/staging/lustre/lustre/llite/dcache.c | 9 +++-- drivers/staging/lustre/lustre/llite/dir.c | 24 +++++++----- drivers/staging/lustre/lustre/llite/file.c | 16 +++++--- .../staging/lustre/lustre/llite/llite_internal.h | 25 ++++++++---- drivers/staging/lustre/lustre/llite/llite_lib.c | 45 ++++++++++++++-------- drivers/staging/lustre/lustre/llite/llite_mmap.c | 3 +- drivers/staging/lustre/lustre/llite/llite_nfs.c | 3 +- drivers/staging/lustre/lustre/llite/namei.c | 24 ++++++++---- drivers/staging/lustre/lustre/llite/rw.c | 15 +++++--- drivers/staging/lustre/lustre/llite/rw26.c | 3 +- drivers/staging/lustre/lustre/llite/statahead.c | 18 +++++---- drivers/staging/lustre/lustre/llite/super25.c | 3 +- drivers/staging/lustre/lustre/llite/xattr_cache.c | 3 +- 13 files changed, 124 insertions(+), 67 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/4 staging: lustre: llite: fix lines over 80 characters in llite files
This fixes checkpatch.pl warning:
WARNING: line over 80 characters
--- drivers/staging/lustre/lustre/llite/dcache.c | 9 +++-- drivers/staging/lustre/lustre/llite/dir.c | 20 ++++++---- drivers/staging/lustre/lustre/llite/file.c | 12 ++++-- .../staging/lustre/lustre/llite/llite_internal.h | 20 +++++++--- drivers/staging/lustre/lustre/llite/llite_lib.c | 45 ++++++++++++++-------- drivers/staging/lustre/lustre/llite/llite_mmap.c | 3 +- drivers/staging/lustre/lustre/llite/llite_nfs.c | 3 +- drivers/staging/lustre/lustre/llite/namei.c | 24 ++++++++---- drivers/staging/lustre/lustre/llite/rw.c | 12 ++++-- drivers/staging/lustre/lustre/llite/rw26.c | 3 +- drivers/staging/lustre/lustre/llite/statahead.c | 18 +++++---- drivers/staging/lustre/lustre/llite/super25.c | 3 +- drivers/staging/lustre/lustre/llite/xattr_cache.c | 3 +- 13 files changed, 115 insertions(+), 60 deletions(-)
drivers/staging/lustre/lustre/llite/dcache.c +6 -3
@@ -141,7 +141,8 @@ void ll_intent_drop_lock(struct lookup_intent *it) handle.cookie = it->it_lock_handle; -CDEBUG (D_DLMTRACE ,"releasing lock with cookie %#llx from it %p\n" , +CDEBUG (D_DLMTRACE , +"releasing lock with cookie %#llx from it %p\n" , handle.cookie, it);ldlm_lock_decref (&handle, it->it_lock_mode);
@@ -152,7 +153,8 @@ void ll_intent_drop_lock(struct lookup_intent *it)if (it->it_remote_lock_mode !=0 ) { handle.cookie = it->it_remote_lock_handle; -CDEBUG (D_DLMTRACE ,"releasing remote lock with cookie%#llx from it %p\n" , +CDEBUG (D_DLMTRACE , +"releasing remote lock with cookie%#llx from it %p\n" , handle.cookie, it);ldlm_lock_decref (&handle, it->it_remote_lock_mode);
@@ -185,7 +187,8 @@ void ll_invalidate_aliases(struct inode *inode)spin_lock (&inode->i_lock);hlist_for_each_entry (dentry, &inode->i_dentry, d_u.d_alias) { -CDEBUG (D_DENTRY ,"dentry in drop %pd (%p) parent %p inode %p flags %d\n" , +CDEBUG (D_DENTRY , +"dentry in drop %pd (%p) parent %p inode %p flags %d\n" , dentry, dentry, dentry->d_parent,d_inode (dentry), dentry->d_flags);
drivers/staging/lustre/lustre/llite/dir.c +13 -7
@@ -303,7 +303,8 @@ static int ll_readdir(struct file *filp, struct dir_context *ctx)struct md_op_data *op_data;int rc; -CDEBUG (D_VFSTRACE ,"VFS Op:inode=" DFID "(%p) pos/size %lu/%llu 32bit_api %d\n" , +CDEBUG (D_VFSTRACE , +"VFS Op:inode=" DFID "(%p) pos/size %lu/%llu 32bit_api %d\n" ,PFID (ll_inode2fid (inode)), inode, (unsigned long )pos,i_size_read (inode), api32);
@@ -419,7 +420,8 @@ static int ll_dir_setdirstripe(struct inode *parent, struct lmv_user_md *lump,if (unlikely (lump->lum_magic !=LMV_USER_MAGIC ))return -EINVAL ; -CDEBUG (D_VFSTRACE ,"VFS Op:inode=" DFID "(%p) name %s stripe_offset %d, stripe_count: %u\n" , +CDEBUG (D_VFSTRACE ,"VFS Op:inode=" DFID +"(%p) name %s stripe_offset %d, stripe_count: %u\n" ,PFID (ll_inode2fid (parent)), parent, dirname, (int )lump->lum_stripe_offset, lump->lum_stripe_count);
@@ -502,7 +504,8 @@ int ll_dir_setstripe(struct inode *inode, struct lov_user_md *lump,break ; }default : { -CDEBUG (D_IOCTL ,"bad userland LOV MAGIC: %#08x != %#08x nor %#08x\n" , +CDEBUG (D_IOCTL , +"bad userland LOV MAGIC: %#08x != %#08x nor %#08x\n" , lump->lmm_magic,LOV_USER_MAGIC_V1 ,LOV_USER_MAGIC_V3 );return -EINVAL ;
@@ -732,8 +735,9 @@ static int ll_ioc_copy_start(struct super_block *sb, struct hsm_copy *copy) rc =ll_data_version (inode, &data_version,LL_DV_RD_FLUSH );iput (inode);if (rc !=0 ) { -CDEBUG (D_HSM ,"Could not read file data version of " -DFID " (rc = %d). Archive request (%#llx) could not be done.\n" , +CDEBUG (D_HSM , +"Could not read file data version of " DFID +" (rc = %d). Archive request (%#llx) could not be done.\n" ,PFID (©->hc_hai.hai_fid), rc, copy->hc_hai.hai_cookie); hpk.hpk_flags |=HP_FLAG_RETRY ;
@@ -816,7 +820,8 @@ static int ll_ioc_copy_end(struct super_block *sb, struct hsm_copy *copy) rc =ll_data_version (inode, &data_version,LL_DV_RD_FLUSH );iput (inode);if (rc) { -CDEBUG (D_HSM ,"Could not read file data version. Request could not be confirmed.\n" ); +CDEBUG (D_HSM , +"Could not read file data version. Request could not be confirmed.\n" );if (hpk.hpk_errval ==0 ) hpk.hpk_errval = -rc; goto progress;
@@ -832,7 +837,8 @@ static int ll_ioc_copy_end(struct super_block *sb, struct hsm_copy *copy)*/ if ((copy->hc_hai.hai_action ==HSMA_ARCHIVE ) && (copy->hc_data_version != data_version)) { -CDEBUG (D_HSM ,"File data version mismatched. File content was changed during archiving. " +CDEBUG (D_HSM , +"File data version mismatched. File content was changed during archiving. " DFID ", start:%#llx current:%#llx\n" ,PFID (©->hc_hai.hai_fid), copy->hc_data_version, data_version);
drivers/staging/lustre/lustre/llite/file.c +8 -4
@@ -605,7 +605,8 @@ int ll_file_open(struct inode *inode, struct file *file)* to get file with different fid. */ it->it_flags |=MDS_OPEN_LOCK |MDS_OPEN_BY_FID ; - rc =ll_intent_file_open (file->f_path.dentry,NULL ,0 , it); + rc =ll_intent_file_open (file->f_path.dentry, +NULL ,0 , it);if (rc) goto out_openerr;
@@ -1119,7 +1120,8 @@ ll_file_io_generic(const struct lu_env *env, struct vvp_io_args *args,cl_io_fini (env, io);if ((!rc || rc == -ENODATA ) && count >0 && io->ci_need_restart) { -CDEBUG (D_VFSTRACE ,"%s: restart %s from %lld, count:%zu, result: %zd\n" , +CDEBUG (D_VFSTRACE , +"%s: restart %s from %lld, count:%zu, result: %zd\n" ,file_dentry (file)->d_name.name, iot ==CIT_READ ?"read" :"write" , *ppos, count, result);
@@ -2507,7 +2509,8 @@ ll_file_flock(struct file *file, int cmd, struct file_lock *file_lock)if (IS_ERR (op_data))return PTR_ERR (op_data); -CDEBUG (D_DLMTRACE ,"inode=" DFID ", pid=%u, flags=%#llx, mode=%u, start=%llu, end=%llu\n" , +CDEBUG (D_DLMTRACE ,"inode=" DFID +", pid=%u, flags=%#llx, mode=%u, start=%llu, end=%llu\n" ,PFID (ll_inode2fid (inode)), flock.l_flock.pid, flags, einfo.ei_mode, flock.l_flock.start, flock.l_flock.end);
@@ -3455,7 +3458,8 @@ static int ll_layout_lock_set(struct lustre_handle *lockh, enum ldlm_mode mode,if (rc ==0 ) rc = -EAGAIN ; -CDEBUG (D_INODE ,"%s: file=" DFID " waiting layout return: %d.\n" , +CDEBUG (D_INODE , +"%s: file=" DFID " waiting layout return: %d.\n" ,ll_get_fsname (inode->i_sb,NULL ,0 ),PFID (&lli->lli_fid), rc); }
drivers/staging/lustre/lustre/llite/llite_internal.h +14 -6
@@ -84,7 +84,9 @@ struct ll_dentry_data {struct ll_getname_data {struct dir_context ctx; -char *lgd_name;/* points to a buffer with NAME_MAX+1 size */ +char *lgd_name;/* points to a buffer with +* NAME_MAX+1 size +*/ struct lu_fid lgd_fid;/* target fid we are looking for */ int lgd_found;/* inode matched? */ };
@@ -637,7 +639,8 @@ static inline int ll_need_32bit_api(struct ll_sb_info *sbi)#if BITS_PER_LONG ==32 return 1 ;#elif defined(CONFIG_COMPAT ) -return unlikely (in_compat_syscall () || (sbi->ll_flags &LL_SBI_32BIT_API )); +return unlikely (in_compat_syscall () || + (sbi->ll_flags &LL_SBI_32BIT_API ));#else return unlikely (sbi->ll_flags &LL_SBI_32BIT_API );#endif
@@ -1065,7 +1068,9 @@ struct ll_statahead_info {* hidden entries */ sai_agl_valid:1 ,/* AGL is valid for the dir */ - sai_in_readpage:1;/* statahead is in readdir() */ + sai_in_readpage:1;/* statahead is in +* readdir() +*/ wait_queue_head_t sai_waitq;/* stat-ahead wait queue */ struct ptlrpc_thread sai_thread;/* stat-ahead thread */ struct ptlrpc_thread sai_agl_thread;/* AGL thread */
@@ -1253,7 +1258,8 @@ static inline void ll_set_lock_data(struct obd_export *exp, struct inode *inode,*/ if (it->it_remote_lock_mode) { handle.cookie = it->it_remote_lock_handle; -CDEBUG (D_DLMTRACE ,"setting l_data to inode " DFID "%p for remote lock %#llx\n" , +CDEBUG (D_DLMTRACE ,"setting l_data to inode " +DFID "%p for remote lock %#llx\n" ,PFID (ll_inode2fid (inode)), inode, handle.cookie);md_set_lock_data (exp, &handle, inode,NULL );
@@ -1261,7 +1267,8 @@ static inline void ll_set_lock_data(struct obd_export *exp, struct inode *inode, handle.cookie = it->it_lock_handle; -CDEBUG (D_DLMTRACE ,"setting l_data to inode " DFID "%p for lock %#llx\n" , +CDEBUG (D_DLMTRACE , +"setting l_data to inode " DFID "%p for lock %#llx\n" ,PFID (ll_inode2fid (inode)), inode, handle.cookie);md_set_lock_data (exp, &handle, inode, &it->it_lock_bits);
@@ -1284,7 +1291,8 @@ static inline int d_lustre_invalid(const struct dentry *dentry)*/ static inline void d_lustre_invalidate (struct dentry *dentry,int nested) { -CDEBUG (D_DENTRY ,"invalidate dentry %pd (%p) parent %p inode %p refc %d\n" , +CDEBUG (D_DENTRY , +"invalidate dentry %pd (%p) parent %p inode %p refc %d\n" , dentry, dentry, dentry->d_parent,d_inode (dentry),d_count (dentry));
drivers/staging/lustre/lustre/llite/llite_lib.c +29 -16
129 lines not on this page · raw message
drivers/staging/lustre/lustre/llite/llite_mmap.c +2 -1
@@ -208,7 +208,8 @@ static int ll_page_mkwrite0(struct vm_area_struct *vma, struct page *vmpage,*/ unlock_page (vmpage); -CDEBUG (D_MMAP ,"Race on page_mkwrite %p/%lu, page has been written out, retry.\n" , +CDEBUG (D_MMAP , +"Race on page_mkwrite %p/%lu, page has been written out, retry.\n" , vmpage, vmpage->index); *retry = true;
drivers/staging/lustre/lustre/llite/llite_nfs.c +2 -1
@@ -127,7 +127,8 @@ struct lustre_nfs_fid { };static struct dentry * -ll_iget_for_nfs (struct super_block *sb,struct lu_fid *fid,struct lu_fid *parent) +ll_iget_for_nfs (struct super_block *sb, +struct lu_fid *fid,struct lu_fid *parent) {struct inode *inode;struct dentry *result;
drivers/staging/lustre/lustre/llite/namei.c +16 -8
@@ -204,7 +204,8 @@ int ll_md_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,if (!fid_res_name_eq (ll_inode2fid (inode), &lock->l_resource->lr_name)) { -LDLM_ERROR (lock,"data mismatch with object " DFID "(%p)" , +LDLM_ERROR (lock, +"data mismatch with object " DFID "(%p)" ,PFID (ll_inode2fid (inode)), inode);LBUG (); }
@@ -273,7 +274,8 @@ int ll_md_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,if ((bits &MDS_INODELOCK_UPDATE ) &&S_ISDIR (inode->i_mode)) {struct ll_inode_info *lli =ll_i2info (inode); -CDEBUG (D_INODE ,"invalidating inode " DFID " lli = %p, pfid = " DFID "\n" , +CDEBUG (D_INODE ,"invalidating inode " DFID +" lli = %p, pfid = " DFID "\n" ,PFID (ll_inode2fid (inode)), lli,PFID (&lli->lli_pfid));
@@ -289,7 +291,8 @@ int ll_md_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,* we have to invalidate the negative children * on master inode */ -CDEBUG (D_INODE ,"Invalidate s" DFID " m" DFID "\n" , +CDEBUG (D_INODE , +"Invalidate s" DFID " m" DFID "\n" ,PFID (ll_inode2fid (inode)),PFID (&lli->lli_pfid));
@@ -684,7 +687,8 @@ static int ll_atomic_open(struct inode *dir, struct dentry *dentry,struct dentry *de;int rc =0 ; -CDEBUG (D_VFSTRACE ,"VFS Op:name=%pd, dir=" DFID "(%p),file %p,open_flags %x,mode %x opened %d\n" , +CDEBUG (D_VFSTRACE ,"VFS Op:name=%pd, dir=" DFID +"(%p),file %p,open_flags %x,mode %x opened %d\n" , dentry,PFID (ll_inode2fid (dir)), dir, file, open_flags, mode, *opened);
@@ -737,7 +741,8 @@ static int ll_atomic_open(struct inode *dir, struct dentry *dentry, *opened |=FILE_CREATED ; } -if (d_really_is_positive (dentry) &&it_disposition (it,DISP_OPEN_OPEN )) { +if (d_really_is_positive (dentry) && +it_disposition (it,DISP_OPEN_OPEN )) {/* Open dentry. */ if (S_ISFIFO (d_inode (dentry)->i_mode)) {/* We cannot call open here as it might
@@ -981,7 +986,8 @@ static int ll_create_nd(struct inode *dir, struct dentry *dentry, {int rc; -CDEBUG (D_VFSTRACE ,"VFS Op:name=%pd, dir=" DFID "(%p), flags=%u, excl=%d\n" , +CDEBUG (D_VFSTRACE , +"VFS Op:name=%pd, dir=" DFID "(%p), flags=%u, excl=%d\n" , dentry,PFID (ll_inode2fid (dir)), dir, mode, want_excl); rc =ll_mknod (dir, dentry, mode,0 );
@@ -1102,7 +1108,8 @@ static int ll_link(struct dentry *old_dentry, struct inode *dir,struct md_op_data *op_data;int err; -CDEBUG (D_VFSTRACE ,"VFS Op: inode=" DFID "(%p), dir=" DFID "(%p), target=%pd\n" , +CDEBUG (D_VFSTRACE , +"VFS Op: inode=" DFID "(%p), dir=" DFID "(%p), target=%pd\n" ,PFID (ll_inode2fid (src)), src,PFID (ll_inode2fid (dir)), dir, new_dentry);
@@ -1137,7 +1144,8 @@ static int ll_rename(struct inode *src, struct dentry *src_dchild,return -EINVAL ;CDEBUG (D_VFSTRACE , -"VFS Op:oldname=%pd, src_dir=" DFID "(%p), newname=%pd, tgt_dir=" DFID "(%p)\n" , +"VFS Op:oldname=%pd, src_dir=" DFID +"(%p), newname=%pd, tgt_dir=" DFID "(%p)\n" , src_dchild,PFID (ll_inode2fid (src)), src, tgt_dchild,PFID (ll_inode2fid (tgt)), tgt);
drivers/staging/lustre/lustre/llite/rw.c +8 -4
@@ -297,7 +297,8 @@ stride_pg_count(pgoff_t st_off, unsigned long st_len, unsigned long st_pgs,else pg_count = start_left + st_pgs * (end - start -1 ) + end_left; -CDEBUG (D_READA ,"st_off %lu, st_len %lu st_pgs %lu off %lu length %lu pgcount %lu\n" , +CDEBUG (D_READA , +"st_off %lu, st_len %lu st_pgs %lu off %lu length %lu pgcount %lu\n" , st_off, st_len, st_pgs, off, length, pg_count);return pg_count;
@@ -404,7 +405,8 @@ ll_read_ahead_pages(const struct lu_env *env, struct cl_io *io,* forward read-ahead, it will be fixed when backward * read-ahead is implemented */ -LASSERTF (page_idx >= ria->ria_stoff,"Invalid page_idx %lu rs %lu re %lu ro %lu rl %lu rp %lu\n" , +LASSERTF (page_idx >= ria->ria_stoff, +"Invalid page_idx %lu rs %lu re %lu ro %lu rl %lu rp %lu\n" , page_idx, ria->ria_start, ria->ria_end, ria->ria_stoff, ria->ria_length, ria->ria_pages);
@@ -670,7 +672,8 @@ static void ras_stride_increase_window(struct ll_readahead_state *ras,LASSERT (ras->ras_stride_length >0 );LASSERTF (ras->ras_window_start + ras->ras_window_len - >= ras->ras_stride_offset,"window_start %lu, window_len %lu stride_offset %lu\n" , + >= ras->ras_stride_offset, +"window_start %lu, window_len %lu stride_offset %lu\n" , ras->ras_window_start, ras->ras_window_len, ras->ras_stride_offset);
@@ -766,7 +769,8 @@ static void ras_update(struct ll_sb_info *sbi, struct inode *inode,PAGE_SHIFT ;CDEBUG (D_READA ,"kmsp %llu mwp %lu mp %lu\n" , kms_pages, - ra->ra_max_read_ahead_whole_pages, ra->ra_max_pages_per_file); + ra->ra_max_read_ahead_whole_pages, + ra->ra_max_pages_per_file);if (kms_pages && kms_pages <= ra->ra_max_read_ahead_whole_pages) {
drivers/staging/lustre/lustre/llite/rw26.c +2 -1
@@ -327,7 +327,8 @@ static ssize_t ll_direct_IO_26(struct kiocb *iocb, struct iov_iter *iter)if ((file_offset & ~PAGE_MASK ) || (count & ~PAGE_MASK ))return -EINVAL ; -CDEBUG (D_VFSTRACE ,"VFS Op:inode=" DFID "(%p), size=%zd (max %lu), offset=%lld=%llx, pages %zd (max %lu)\n" , +CDEBUG (D_VFSTRACE ,"VFS Op:inode=" DFID +"(%p), size=%zd (max %lu), offset=%lld=%llx, pages %zd (max %lu)\n" ,PFID (ll_inode2fid (inode)), inode, count,MAX_DIO_SIZE , file_offset, file_offset, count >>PAGE_SHIFT ,MAX_DIO_SIZE >>PAGE_SHIFT );
drivers/staging/lustre/lustre/llite/statahead.c +11 -7
@@ -1008,7 +1008,8 @@ static int ll_statahead_thread(void *arg) sai->sai_in_readpage =0 ;if (IS_ERR (page)) { rc =PTR_ERR (page); -CDEBUG (D_READA ,"error reading dir " DFID " at %llu/%llu: opendir_pid = %u: rc = %d\n" , +CDEBUG (D_READA ,"error reading dir " DFID +" at %llu/%llu: opendir_pid = %u: rc = %d\n" ,PFID (ll_inode2fid (dir)), pos, sai->sai_index, lli->lli_opendir_pid, rc);break ;
@@ -1082,7 +1083,8 @@ static int ll_statahead_thread(void *arg)struct ll_inode_info *clli; clli =list_entry (sai->sai_agls.next, - struct ll_inode_info, lli_agl_list); + struct ll_inode_info, + lli_agl_list);list_del_init (&clli->lli_agl_list);spin_unlock (&lli->lli_agl_lock);
@@ -1105,7 +1107,8 @@ static int ll_statahead_thread(void *arg)if (sa_low_hit (sai)) { rc = -EFAULT ;atomic_inc (&sbi->ll_sa_wrong); -CDEBUG (D_READA ,"Statahead for dir " DFID " hit ratio too low: hit/miss %llu/%llu, sent/replied %llu/%llu, stopping statahead thread: pid %d\n" , +CDEBUG (D_READA ,"Statahead for dir " DFID +" hit ratio too low: hit/miss %llu/%llu, sent/replied %llu/%llu, stopping statahead thread: pid %d\n" ,PFID (&lli->lli_fid), sai->sai_hit, sai->sai_miss, sai->sai_sent, sai->sai_replied,current_pid ());
@@ -1274,7 +1277,8 @@ static int is_first_dirent(struct inode *dir, struct dentry *dentry)struct ll_inode_info *lli =ll_i2info (dir); rc =PTR_ERR (page); -CERROR ("%s: error reading dir " DFID " at %llu: opendir_pid = %u : rc = %d\n" , +CERROR ("%s: error reading dir " DFID +" at %llu: opendir_pid = %u : rc = %d\n" ,ll_get_fsname (dir->i_sb,NULL ,0 ),PFID (ll_inode2fid (dir)), pos, lli->lli_opendir_pid, rc);
@@ -1447,7 +1451,7 @@ static int revalidate_statahead_dentry(struct inode *dir,if (entry->se_state ==SA_ENTRY_SUCC && entry->se_inode) {struct inode *inode = entry->se_inode;struct lookup_intent it = { .it_op =IT_GETATTR , - .it_lock_handle = entry->se_handle }; + .it_lock_handle = entry->se_handle};__u64 bits; rc = md_revalidate_lock(ll_i2mdexp(dir), &it,
@@ -1470,8 +1474,8 @@ static int revalidate_statahead_dentry(struct inode *dir, entry->se_inode =NULL ; }else if ((*dentryp)->d_inode != inode) {/* revalidate, but inode is recreated */ - CDEBUG(D_READA, - "%s: stale dentry %pd inode " DFID ", statahead inode " DFID "\n", + CDEBUG(D_READA, "%s: stale dentry %pd inode " + DFID ", statahead inode " DFID "\n", ll_get_fsname((*dentryp)->d_inode->i_sb, NULL, 0), *dentryp,
drivers/staging/lustre/lustre/llite/super25.c +2 -1
@@ -88,7 +88,8 @@ static int __init lustre_init(void)struct timespec64 ts;int i, rc, seed[2 ]; -BUILD_BUG_ON (sizeof (LUSTRE_VOLATILE_HDR ) !=LUSTRE_VOLATILE_HDR_LEN +1 ); +BUILD_BUG_ON (sizeof (LUSTRE_VOLATILE_HDR ) != +LUSTRE_VOLATILE_HDR_LEN +1 );/* print an address of _any_ initialized kernel symbol from this * module, to allow debugging with gdb that doesn't support data
drivers/staging/lustre/lustre/llite/xattr_cache.c +2 -1
@@ -364,7 +364,8 @@ static int ll_xattr_cache_refill(struct inode *inode, struct lookup_intent *oit) }if (oit->it_status <0 ) { -CDEBUG (D_CACHE ,"getxattr intent returned %d for fid " DFID "\n" , +CDEBUG (D_CACHE , +"getxattr intent returned %d for fid " DFID "\n" , oit->it_status,PFID (ll_inode2fid (inode))); rc = oit->it_status;/* xattr data is so large that we don't want to cache it */
Signature · 1 line
2.7.4
PATCH 2/4 staging: lustre: llite: fix identation in dir
In reply to Aastha GuptaThis patch fixes identation issue caused by one of the fixes in this patch.
Have the trailing line of a function call line up with the starting '('.
--- drivers/staging/lustre/lustre/llite/dir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/lustre/lustre/llite/dir.c +2 -2
@@ -738,8 +738,8 @@ static int ll_ioc_copy_start(struct super_block *sb, struct hsm_copy *copy)CDEBUG (D_HSM ,"Could not read file data version of " DFID " (rc = %d). Archive request (%#llx) could not be done.\n" , -PFID (©->hc_hai.hai_fid), rc, - copy->hc_hai.hai_cookie); +PFID (©->hc_hai.hai_fid), rc, + copy->hc_hai.hai_cookie); hpk.hpk_flags |=HP_FLAG_RETRY ;/* hpk_errval must be >= 0 */ hpk.hpk_errval = -rc;
Signature · 1 line
2.7.4
PATCH 3/4 staging: lustre: lllite: fix multi line comments alignment in file
In reply to Aastha GuptaThis patch fixes checkpatch.pl warning:
WARNING: Block comments should align the * on each line
--- drivers/staging/lustre/lustre/llite/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/lustre/lustre/llite/file.c +2 -2
@@ -386,8 +386,8 @@ static int ll_intent_file_open(struct dentry *de, void *lmm, int lmmsize,ll_finish_md_op_data (op_data);if (rc == -ESTALE ) {/* reason for keep own exit path - don`t flood log -* with messages with -ESTALE errors. -*/ +* with messages with -ESTALE errors. +*/ if (!it_disposition (itp,DISP_OPEN_OPEN ) ||it_open_error (DISP_OPEN_OPEN , itp)) goto out;
Signature · 1 line
2.7.4
PATCH 4/4 staging: lustre: llite: fix multi line comments style
In reply to Aastha GuptaThis patch fixes checkpatch.pl warning:
WARNING: Block comments use a trailing */ on a separate line
--- drivers/staging/lustre/lustre/llite/llite_internal.h | 5 +++-- drivers/staging/lustre/lustre/llite/rw.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-)
drivers/staging/lustre/lustre/llite/llite_internal.h +3 -2
@@ -394,7 +394,8 @@ enum stats_track_type {#define LL_SBI_XATTR_CACHE 0x80000/* support for xattr cache */ #define LL_SBI_NOROOTSQUASH 0x100000/* do not apply root squash */ #define LL_SBI_ALWAYS_PING 0x200000/* always ping even if server -* suppress_pings */ +* suppress_pings +*/ #define LL_SBI_FLAGS { \ "nolck", \
@@ -1203,7 +1204,7 @@ typedef enum llioc_iter (*llioc_callback_t)(struct inode *inode,* Return value: * A magic pointer will be returned if success; * otherwise, NULL will be returned. -* */ +*/ void *ll_iocontrol_register (llioc_callback_t cb,int count,unsigned int *cmd);void ll_iocontrol_unregister (void *magic);
drivers/staging/lustre/lustre/llite/rw.c +2 -1
@@ -888,7 +888,8 @@ static void ras_update(struct ll_sb_info *sbi, struct inode *inode,/* The initial ras_window_len is set to the request size. To avoid * uselessly reading and discarding pages for random IO the window is -* only increased once per consecutive request received. */ +* only increased once per consecutive request received. +*/ if ((ras->ras_consecutive_requests >1 || stride_detect) && !ras->ras_request_index)ras_increase_window (inode, ras, ra);
Signature · 1 line
2.7.4