arm64 defconfig: enable additional led triggers
Subsystems (4)
cover arm64 defconfig: enable additional led triggers
This patchset enables the kernel panic and disk-activity trigger for LEDs and then enables the panic trigger for three 96Boards - DB410c, Hikey and Hikey960.
DB410c and Hikey panic behaviour has been tested by triggering a panic through /proc/sysrq-trigger, while Hikey960 is only compile-tested.
Amit Kucheria (4):
arm64: defconfig: enable new trigger modes for leds
arm64: dts: qcom: apq8016-sbc: Allow USR4 LED to notify kernel panic
arm64: dts: hisilicon: hi6220-hikey: Allow USR1 LED to notify kernel
panic
arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify
kernel panic
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 + arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 1 + arch/arm64/configs/defconfig | 2 ++ 4 files changed, 5 insertions(+)
Signature · 1 line
2.7.4
PATCH 1/4 arm64: defconfig: enable new trigger modes for leds
Enable panic and disk activity triggers to tie to LED activity
--- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/configs/defconfig +2 -0
@@ -460,6 +460,8 @@ CONFIG_LEDS_SYSCON=y CONFIG_LEDS_TRIGGER_HEARTBEAT=y CONFIG_LEDS_TRIGGER_CPU=y CONFIG_LEDS_TRIGGER_DEFAULT_ON=y +CONFIG_LEDS_TRIGGER_PANIC=y +CONFIG_LEDS_TRIGGER_DISK=y CONFIG_EDAC=y CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_MAX77686=y
Signature · 1 line
2.7.4
Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds
Quoted 1 line · Amit Kucheria
Enable panic and disk activity triggers to tie to LED activity
Could you provide some explanation as to why we want this enabled for ARM64? I don't have a problem with the change itself, but I think patch descriptions for defconfig changes should include justifications.
Signature · 3 lines
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds
Quoted 8 lines · Timur Tabi
Quoted 2 lines · Amit Kucheria
Enable panic and disk activity triggers to tie to LED activity
Could you provide some explanation as to why we want this enabled for ARM64? I don't have a problem with the change itself, but I think patch descriptions for defconfig changes should include justifications.
Indeed.
The blurb should be modified as follows:
"Most development boards and devices have one or more LEDs. It is useful during debugging if they can be wired to show different behaviours such as disk or cpu activity or a load-average dependent heartbeat. Enable panic and disk activity triggers so they can be tied to LED activity during debugging as well."
If this blurb works, I'll send out another version.
Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds
Quoted 6 lines · Amit Kucheria
"Most development boards and devices have one or more LEDs. It is useful during debugging if they can be wired to show different behaviours such as disk or cpu activity or a load-average dependent heartbeat. Enable panic and disk activity triggers so they can be tied to LED activity during debugging as well."
This is great, thanks.
Signature · 3 lines
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds
Quoted 11 lines · Timur Tabi
Quoted 7 lines · Amit Kucheria
"Most development boards and devices have one or more LEDs. It is useful during debugging if they can be wired to show different behaviours such as disk or cpu activity or a load-average dependent heartbeat. Enable panic and disk activity triggers so they can be tied to LED activity during debugging as well."
This is great, thanks.
Can I take this as an ACK?
Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds
Quoted 2 lines · Amit Kucheria
Quoted 1 line
This is great, thanks.
Can I take this as an ACK?
Sure, but I'm not a maintainer for the defconfig, so it's just my personal opinion.
Signature · 3 lines
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds
In reply to Amit KucheriaQuoted 3 lines · Amit Kucheria
Enable panic and disk activity triggers to tie to LED activity
Signed-off-by Amit Kucheria <[email protected]>
Regards,
Mani
Quoted 20 lines
--- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/configs/defconfig +2
-1@@ -460,6 +460,8 @@ CONFIG_LEDS_SYSCON=y CONFIG_LEDS_TRIGGER_HEARTBEAT=y CONFIG_LEDS_TRIGGER_CPU=y CONFIG_LEDS_TRIGGER_DEFAULT_ON=y +CONFIG_LEDS_TRIGGER_PANIC=y +CONFIG_LEDS_TRIGGER_DISK=y CONFIG_EDAC=y CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_MAX77686=y --2.7.4
PATCH 2/4 arm64: dts: qcom: apq8016-sbc: Allow USR4 LED to notify kernel panic
In reply to Amit KucheriaBlink the LED on a kernel panic.
--- arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi +1 -0
@@ -174,6 +174,7 @@ label = "apq8016-sbc:green:user4"; gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>; linux,default-trigger = "none"; + panic-indicator; default-state = "off"; };
Signature · 1 line
2.7.4
PATCH 3/4 arm64: dts: hisilicon: hi6220-hikey: Allow USR1 LED to notify kernel panic
In reply to Amit KucheriaBlink the LED on a kernel panic.
--- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts +1 -0
@@ -358,6 +358,7 @@ user_led1 { label = "user_led1"; gpios = <&gpio4 3 0>; /* <&gpio_user_led_4>; */ + panic-indicator; linux,default-trigger = "cpu0"; };
Signature · 1 line
2.7.4
PATCH 4/4 arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify kernel panic
In reply to Amit KucheriaBlink the LED on a kernel panic.
--- arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +1 -0
@@ -108,6 +108,7 @@ label = "user_led4"; /* gpio_190_user_led4 */ gpios = <&gpio23 6 0>; + panic-indicator; linux,default-trigger = "cpu0"; };
Signature · 1 line
2.7.4
A message that is not in the archive (sent off-list or not yet received): CAFGCpxy3v6Z5kTqDEF=mqEpSm2+7pn6jSrotx=sHVBmC=VH3Bw@mail.gmail.com
Re: [PATCH 4/4] arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify kernel panic
Quoted 12 lines · Guodong Xu
Quoted 8 lines · Amit Kucheria
Blink the LED on a kernel panic.
Signed-off-by Amit Kucheria <[email protected]>--- arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 + 1 file changed, 1 insertion(+)
Quoted 13 lines
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts line 111
Quoted 10 lines
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +1
-0@@ -108,6 +108,7 @@ label = "user_led4"; /* gpio_190_user_led4 */ gpios = <&gpio23 6 0>; + panic-indicator;Looks good to me.
Can I take that as an Ack? How about the Hikey960 patch?
Quoted 10 lines
Quoted 9 lines
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +0
-1linux,default-trigger = "cpu0"; }; --2.7.4
Guodong Xu
Acked-byRe: [PATCH 4/4] arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify kernel panic
Quoted 27 lines · Amit Kucheria
Quoted 12 lines · Guodong Xu
Quoted 8 lines · Amit Kucheria
Blink the LED on a kernel panic.
Signed-off-by Amit Kucheria <[email protected]>--- arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 + 1 file changed, 1 insertion(+)Quoted 13 lines
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts line 111
Quoted 10 lines
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +1
-0@@ -108,6 +108,7 @@ label = "user_led4"; /* gpio_190_user_led4 */ gpios = <&gpio23 6 0>; + panic-indicator;Looks good to me.
Quoted 2 lines
Can I take that as an Ack? How about the Hikey960 patch?
-Guodong
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +0
-1linux,default-trigger = "cpu0"; }; --2.7.4