Skip to contentSkip to conversation

mark expected switch fall-throughs

PATCH In review Gustavo A. R. Silva 3 participants 16 messages Nov 8, 2017 – Nov 23, 2017

Subsystems (5)
Sound ASoC Wolfson microelectronics drivers Qualcomm audio (ASoC) drivers +1 more subsystems
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

cover mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, this patchset aims to mark switch cases where we are expecting to fall through.

Thanks!

Gustavo A. R. Silva (7):
ASoC: msm8916-wcd-analog: mark expected switch fall-through
ASoC: tlv320aic23: mark expected switch fall-through
ASoC: tlv320dac31xx: mark expected switch fall-through
ASoC: tpa6130a2: mark expected switch fall-through
ASoC: wm8753: mark expected switch fall-throughs
ASoC: wm8993: mark expected switch fall-throughs
ASoC: wm8994: mark expected switch fall-throughs

 sound/soc/codecs/msm8916-wcd-analog.c | 1 +
 sound/soc/codecs/tlv320aic23.c        | 1 +
 sound/soc/codecs/tlv320aic31xx.c      | 2 +-
 sound/soc/codecs/tpa6130a2.c          | 1 +
 sound/soc/codecs/wm8753.c             | 4 ++--
 sound/soc/codecs/wm8993.c             | 2 ++
 sound/soc/codecs/wm8994.c             | 2 ++
 7 files changed, 10 insertions(+), 3 deletions(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/7 ASoC: msm8916-wcd-analog: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1397957

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 sound/soc/codecs/msm8916-wcd-analog.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/msm8916-wcd-analog.c +1 -0
index 7ff42ef..5f3c42c 100644
@@ -621,6 +621,7 @@ static int pm8916_wcd_analog_enable_adc(struct snd_soc_dapm_widget *w,
 		case CDC_A_TX_2_EN:
 			snd_soc_update_bits(codec, CDC_A_MICB_1_CTL,
 					    MICB_1_CTL_CFILT_REF_SEL_MASK, 0);
+			/* fall through */
 		case CDC_A_TX_3_EN:
 			snd_soc_update_bits(codec, CDC_D_CDC_CONN_TX2_CTL,
 					    CONN_TX2_SERIAL_TX2_MUX,
Signature · 1 line
2.7.4
maintainer
#2 lore raw

Applied "ASoC: msm8916-wcd-analog: mark expected switch fall-through" to the asoc tree

The patch

ASoC: msm8916-wcd-analog: mark expected switch fall-through

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From dc10622bb32f08383cf5a9942a91042d8f38bf3d Mon Sep 17 00:00:00 2001

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 8 Nov 2017 14:04:09 -0600
Subject: [PATCH] ASoC: msm8916-wcd-analog: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1397957

Signed-off-by Gustavo A. R. Silva <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/msm8916-wcd-analog.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/msm8916-wcd-analog.c +1 -0
index 549c269acc7d..518fa2a4ac78 100644
@@ -614,6 +614,7 @@ static int pm8916_wcd_analog_enable_adc(struct snd_soc_dapm_widget *w,
 		case CDC_A_TX_2_EN:
 			snd_soc_update_bits(codec, CDC_A_MICB_1_CTL,
 					    MICB_1_CTL_CFILT_REF_SEL_MASK, 0);
+			/* fall through */
 		case CDC_A_TX_3_EN:
 			snd_soc_update_bits(codec, CDC_D_CDC_CONN_TX2_CTL,
 					    CONN_TX2_SERIAL_TX2_MUX,
Signature · 1 line
2.15.0
author
#3 lore raw

PATCH 2/7 ASoC: tlv320aic23: mark expected switch fall-through

In reply to Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 146566

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 sound/soc/codecs/tlv320aic23.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/tlv320aic23.c +1 -0
index 3d42138..7490921 100644
@@ -454,6 +454,7 @@ static int tlv320aic23_set_dai_fmt(struct snd_soc_dai *codec_dai,
 		break;
 	case SND_SOC_DAIFMT_DSP_A:
 		iface_reg |= TLV320AIC23_LRP_ON;
+		/* fall through */
 	case SND_SOC_DAIFMT_DSP_B:
 		iface_reg |= TLV320AIC23_FOR_DSP;
 		break;
Signature · 1 line
2.7.4
maintainer
#4 lore raw

Applied "ASoC: tlv320aic23: mark expected switch fall-through" to the asoc tree

The patch

ASoC: tlv320aic23: mark expected switch fall-through

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From a47043ec35d4198b3858cb1eb4c38d712154ae99 Mon Sep 17 00:00:00 2001

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 8 Nov 2017 14:04:12 -0600
Subject: [PATCH] ASoC: tlv320aic23: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 146566

Signed-off-by Gustavo A. R. Silva <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/tlv320aic23.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/tlv320aic23.c +1 -0
index 3d42138a7974..74909211c608 100644
@@ -454,6 +454,7 @@ static int tlv320aic23_set_dai_fmt(struct snd_soc_dai *codec_dai,
 		break;
 	case SND_SOC_DAIFMT_DSP_A:
 		iface_reg |= TLV320AIC23_LRP_ON;
+		/* fall through */
 	case SND_SOC_DAIFMT_DSP_B:
 		iface_reg |= TLV320AIC23_FOR_DSP;
 		break;
Signature · 1 line
2.15.0
author
#5 lore raw

PATCH 3/7 ASoC: tlv320dac31xx: mark expected switch fall-through

In reply to Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1195220

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 sound/soc/codecs/tlv320aic31xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tlv320aic31xx.c +1 -1
index 54a87a9..e286237 100644
@@ -929,7 +929,7 @@ static int aic31xx_set_dai_fmt(struct snd_soc_dai *codec_dai,
 	case SND_SOC_DAIFMT_I2S:
 		break;
 	case SND_SOC_DAIFMT_DSP_A:
-		dsp_a_val = 0x1;
+		dsp_a_val = 0x1; /* fall through */
 	case SND_SOC_DAIFMT_DSP_B:
 		/* NOTE: BCLKINV bit value 1 equas NB and 0 equals IB */
 		switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
Signature · 1 line
2.7.4
maintainer
#6 lore raw

Applied "ASoC: tlv320dac31xx: mark expected switch fall-through" to the asoc tree

The patch

ASoC: tlv320dac31xx: mark expected switch fall-through

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 09fc38c1af4cb888255e9ecf267bf9757c12885d Mon Sep 17 00:00:00 2001

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 8 Nov 2017 14:04:17 -0600
Subject: [PATCH] ASoC: tlv320dac31xx: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1195220

Signed-off-by Gustavo A. R. Silva <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/tlv320aic31xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tlv320aic31xx.c +1 -1
index 54a87a905eb6..e2862372c26e 100644
@@ -929,7 +929,7 @@ static int aic31xx_set_dai_fmt(struct snd_soc_dai *codec_dai,
 	case SND_SOC_DAIFMT_I2S:
 		break;
 	case SND_SOC_DAIFMT_DSP_A:
-		dsp_a_val = 0x1;
+		dsp_a_val = 0x1; /* fall through */
 	case SND_SOC_DAIFMT_DSP_B:
 		/* NOTE: BCLKINV bit value 1 equas NB and 0 equals IB */
 		switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
Signature · 1 line
2.15.0
author
#7 lore raw

PATCH 4/7 ASoC: tpa6130a2: mark expected switch fall-through

In reply to Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 115164

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 sound/soc/codecs/tpa6130a2.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/tpa6130a2.c +1 -0
index 2e014c8..616cd4b 100644
@@ -274,6 +274,7 @@ static int tpa6130a2_probe(struct i2c_client *client,
 	default:
 		dev_warn(dev, "Unknown TPA model (%d). Assuming 6130A2\n",
 			 data->id);
+		/* fall through */
 	case TPA6130A2:
 		regulator = "Vdd";
 		break;
Signature · 1 line
2.7.4
maintainer
#8 lore raw

Applied "ASoC: tpa6130a2: mark expected switch fall-through" to the asoc tree

The patch

ASoC: tpa6130a2: mark expected switch fall-through

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 402954f8e573e4b610da6858b8431d4edfd754c8 Mon Sep 17 00:00:00 2001

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 8 Nov 2017 14:04:22 -0600
Subject: [PATCH] ASoC: tpa6130a2: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 115164

Signed-off-by Gustavo A. R. Silva <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/tpa6130a2.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/tpa6130a2.c +1 -0
index 2e014c80d113..616cd4bebd01 100644
@@ -274,6 +274,7 @@ static int tpa6130a2_probe(struct i2c_client *client,
 	default:
 		dev_warn(dev, "Unknown TPA model (%d). Assuming 6130A2\n",
 			 data->id);
+		/* fall through */
 	case TPA6130A2:
 		regulator = "Vdd";
 		break;
Signature · 1 line
2.15.0
author
#9 lore raw

PATCH 5/7 ASoC: wm8753: mark expected switch fall-throughs

In reply to Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 146568
Addresses-Coverity-ID: 146569

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 sound/soc/codecs/wm8753.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/wm8753.c +2 -2
index d05d76e..0271a52 100644
@@ -971,7 +971,7 @@ static int wm8753_pcm_set_dai_fmt(struct snd_soc_codec *codec,
 	case SND_SOC_DAIFMT_CBS_CFS:
 		break;
 	case SND_SOC_DAIFMT_CBM_CFM:
-		ioctl |= 0x2;
+		ioctl |= 0x2; /* fall through */
 	case SND_SOC_DAIFMT_CBM_CFS:
 		voice |= 0x0040;
 		break;

@@ -1096,7 +1096,7 @@ static int wm8753_i2s_set_dai_fmt(struct snd_soc_codec *codec,
 	case SND_SOC_DAIFMT_CBS_CFS:
 		break;
 	case SND_SOC_DAIFMT_CBM_CFM:
-		ioctl |= 0x1;
+		ioctl |= 0x1; /* fall through */
 	case SND_SOC_DAIFMT_CBM_CFS:
 		hifi |= 0x0040;
 		break;
Signature · 1 line
2.7.4
maintainer
#10 lore raw

Applied "ASoC: wm8753: mark expected switch fall-throughs" to the asoc tree

The patch

ASoC: wm8753: mark expected switch fall-throughs

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From b0e92b515e2cbcad923ee1211f59c4b62e94ee37 Mon Sep 17 00:00:00 2001

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 8 Nov 2017 14:04:31 -0600
Subject: [PATCH] ASoC: wm8753: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 146568
Addresses-Coverity-ID: 146569

Signed-off-by Gustavo A. R. Silva <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/wm8753.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/wm8753.c +2 -2
index d05d76e79c70..0271a5253bd3 100644
@@ -971,7 +971,7 @@ static int wm8753_pcm_set_dai_fmt(struct snd_soc_codec *codec,
 	case SND_SOC_DAIFMT_CBS_CFS:
 		break;
 	case SND_SOC_DAIFMT_CBM_CFM:
-		ioctl |= 0x2;
+		ioctl |= 0x2; /* fall through */
 	case SND_SOC_DAIFMT_CBM_CFS:
 		voice |= 0x0040;
 		break;

@@ -1096,7 +1096,7 @@ static int wm8753_i2s_set_dai_fmt(struct snd_soc_codec *codec,
 	case SND_SOC_DAIFMT_CBS_CFS:
 		break;
 	case SND_SOC_DAIFMT_CBM_CFM:
-		ioctl |= 0x1;
+		ioctl |= 0x1; /* fall through */
 	case SND_SOC_DAIFMT_CBM_CFS:
 		hifi |= 0x0040;
 		break;
Signature · 1 line
2.15.0
author
#11 lore raw

PATCH 6/7 ASoC: wm8993: mark expected switch fall-throughs

In reply to Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 115168

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 sound/soc/codecs/wm8993.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/wm8993.c +2 -0
index 195f7bf..830ffd80 100644
@@ -1076,6 +1076,7 @@ static int wm8993_set_sysclk(struct snd_soc_dai *codec_dai,
 	switch (clk_id) {
 	case WM8993_SYSCLK_MCLK:
 		wm8993->mclk_rate = freq;
+		/* fall through */
 	case WM8993_SYSCLK_FLL:
 		wm8993->sysclk_source = clk_id;
 		break;

@@ -1123,6 +1124,7 @@ static int wm8993_set_dai_fmt(struct snd_soc_dai *dai,
 	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
 	case SND_SOC_DAIFMT_DSP_B:
 		aif1 |= WM8993_AIF_LRCLK_INV;
+		/* fall through */
 	case SND_SOC_DAIFMT_DSP_A:
 		aif1 |= 0x18;
 		break;
Signature · 1 line
2.7.4
maintainer
#12 lore raw

Applied "ASoC: wm8993: mark expected switch fall-throughs" to the asoc tree

The patch

ASoC: wm8993: mark expected switch fall-throughs

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From cdf45e49adb2ba39e6e270717b86fe844e4c59c8 Mon Sep 17 00:00:00 2001

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 8 Nov 2017 14:04:38 -0600
Subject: [PATCH] ASoC: wm8993: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 115168

Signed-off-by Gustavo A. R. Silva <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/wm8993.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/wm8993.c +2 -0
index 195f7bf6eb22..830ffd80de4a 100644
@@ -1076,6 +1076,7 @@ static int wm8993_set_sysclk(struct snd_soc_dai *codec_dai,
 	switch (clk_id) {
 	case WM8993_SYSCLK_MCLK:
 		wm8993->mclk_rate = freq;
+		/* fall through */
 	case WM8993_SYSCLK_FLL:
 		wm8993->sysclk_source = clk_id;
 		break;

@@ -1123,6 +1124,7 @@ static int wm8993_set_dai_fmt(struct snd_soc_dai *dai,
 	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
 	case SND_SOC_DAIFMT_DSP_B:
 		aif1 |= WM8993_AIF_LRCLK_INV;
+		/* fall through */
 	case SND_SOC_DAIFMT_DSP_A:
 		aif1 |= 0x18;
 		break;
Signature · 1 line
2.15.0
author
#13 lore raw

PATCH 7/7 ASoC: wm8994: mark expected switch fall-throughs

In reply to Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 402005

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 sound/soc/codecs/wm8994.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/wm8994.c +2 -0
index 3896523..f91b49e 100644
@@ -860,6 +860,7 @@ static void vmid_reference(struct snd_soc_codec *codec)
 		switch (wm8994->vmid_mode) {
 		default:
 			WARN_ON(NULL == "Invalid VMID mode");
+			/* fall through */
 		case WM8994_VMID_NORMAL:
 			/* Startup bias, VMID ramp & buffer */
 			snd_soc_update_bits(codec, WM8994_ANTIPOP_2,

@@ -2654,6 +2655,7 @@ static int wm8994_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 	case SND_SOC_DAIFMT_DSP_B:
 		aif1 |= WM8994_AIF1_LRCLK_INV;
 		lrclk |= WM8958_AIF1_LRCLK_INV;
+		/* fall through */
 	case SND_SOC_DAIFMT_DSP_A:
 		aif1 |= 0x18;
 		break;
Signature · 1 line
2.7.4
maintainer
#14 lore raw

Applied "ASoC: wm8994: mark expected switch fall-throughs" to the asoc tree

The patch

ASoC: wm8994: mark expected switch fall-throughs

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 9d94305a7df4ce6af5070baa92cc784786b748b9 Mon Sep 17 00:00:00 2001

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 8 Nov 2017 14:04:43 -0600
Subject: [PATCH] ASoC: wm8994: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 402005

Signed-off-by Gustavo A. R. Silva <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/wm8994.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/wm8994.c +2 -0
index 3896523b71e9..f91b49e1ece3 100644
@@ -860,6 +860,7 @@ static void vmid_reference(struct snd_soc_codec *codec)
 		switch (wm8994->vmid_mode) {
 		default:
 			WARN_ON(NULL == "Invalid VMID mode");
+			/* fall through */
 		case WM8994_VMID_NORMAL:
 			/* Startup bias, VMID ramp & buffer */
 			snd_soc_update_bits(codec, WM8994_ANTIPOP_2,

@@ -2654,6 +2655,7 @@ static int wm8994_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 	case SND_SOC_DAIFMT_DSP_B:
 		aif1 |= WM8994_AIF1_LRCLK_INV;
 		lrclk |= WM8958_AIF1_LRCLK_INV;
+		/* fall through */
 	case SND_SOC_DAIFMT_DSP_A:
 		aif1 |= 0x18;
 		break;
Signature · 1 line
2.15.0