Skip to contentSkip to conversation

irqchip: pr_err() strings should end with newlines

PATCH In review Arvind Yadav 2 participants 5 messages Nov 13, 2017

Subsystems (4)
Arm Samsung Exynos irqchip drivers Arm generic interrupt controller drivers MIPS core drivers
lore
Share & tools
lore

Arvind Yadav

author
#0 lore raw

cover irqchip: pr_err() strings should end with newlines

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Arvind Yadav (3):
[PATCH 1/3] irqchip/mips-gic: pr_err() strings should end with newlines [PATCH 2/3] irqchip/s3c24xx: pr_err() strings should end with newlines [PATCH 3/3] irqchip/gic-v3: pr_err() strings should end with newlines

 drivers/irqchip/irq-gic-v3.c   | 2 +-
 drivers/irqchip/irq-mips-gic.c | 4 ++--
 drivers/irqchip/irq-s3c24xx.c  | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/3 irqchip/mips-gic: pr_err() strings should end with newlines

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/irqchip/irq-mips-gic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-mips-gic.c +2 -2
index c90976d..e87d33b 100644
@@ -737,7 +737,7 @@ static int __init gic_of_init(struct device_node *node,
 					       gic_shared_intrs, 0,
 					       &gic_irq_domain_ops, NULL);
 	if (!gic_irq_domain) {
-		pr_err("Failed to add GIC IRQ domain");
+		pr_err("Failed to add GIC IRQ domain\n");
 		return -ENXIO;
 	}
 

@@ -746,7 +746,7 @@ static int __init gic_of_init(struct device_node *node,
 						  GIC_NUM_LOCAL_INTRS + gic_shared_intrs,
 						  node, &gic_ipi_domain_ops, NULL);
 	if (!gic_ipi_domain) {
-		pr_err("Failed to add GIC IPI domain");
+		pr_err("Failed to add GIC IPI domain\n");
 		return -ENXIO;
 	}
Signature · 1 line
1.9.1
#2 lore raw

Re: [PATCH 1/3] irqchip/mips-gic: pr_err() strings should end with newlines

Quoted 23 lines · Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/irqchip/irq-mips-gic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-mips-gic.c +1 -1
index c90976d..e87d33b 100644
@@ -737,7 +737,7 @@ static int __init gic_of_init(struct device_node *node,
 					       gic_shared_intrs, 0,
 					       &gic_irq_domain_ops, NULL);
 	if (!gic_irq_domain) {
-		pr_err("Failed to add GIC IRQ domain");
+		pr_err("Failed to add GIC IRQ domain\n");
 		return -ENXIO;
 	}

drivers/irqchip/irq-mips-gic.c static int __init gic_of_init(struct device_node *node, · line 752

Quoted 8 lines
drivers/irqchip/irq-mips-gic.c +1 -1
@@ -746,7 +746,7 @@ static int __init gic_of_init(struct device_node *node,
 						  GIC_NUM_LOCAL_INTRS + gic_shared_intrs,
 						  node, &gic_ipi_domain_ops, NULL);
 	if (!gic_ipi_domain) {
-		pr_err("Failed to add GIC IPI domain");
+		pr_err("Failed to add GIC IPI domain\n");
 		return -ENXIO;
 	}

This patch doesn't apply to the current state of the irqchip tree, nor of tip/irq/core. Please verify that it applies and resubmit if required.

I've applied patches 2 and 3.

Thanks,

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...
author
#3 lore raw

PATCH 2/3 irqchip/s3c24xx: pr_err() strings should end with newlines

In reply to Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/irqchip/irq-s3c24xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-s3c24xx.c +2 -2
index c25ce5a..ec0e6a8 100644
@@ -156,7 +156,7 @@ static int s3c_irq_type(struct irq_data *data, unsigned int type)
 		irq_set_handler(data->irq, handle_level_irq);
 		break;
 	default:
-		pr_err("No such irq type %d", type);
+		pr_err("No such irq type %d\n", type);
 		return -EINVAL;
 	}
 

@@ -204,7 +204,7 @@ static int s3c_irqext_type_set(void __iomem *gpcon_reg,
 			break;
 
 		default:
-			pr_err("No such irq type %d", type);
+			pr_err("No such irq type %d\n", type);
 			return -EINVAL;
 	}
Signature · 1 line
1.9.1
author
#4 lore raw

PATCH 3/3 irqchip/gic-v3: pr_err() strings should end with newlines

In reply to Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/irqchip/irq-gic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-gic-v3.c +1 -1
index b5df99c..252fb0c 100644
@@ -1489,7 +1489,7 @@ static void __init gic_acpi_setup_kvm_info(void)
 
 	err = gic_validate_dist_version(acpi_data.dist_base);
 	if (err) {
-		pr_err("No distributor detected at @%p, giving up",
+		pr_err("No distributor detected at @%p, giving up\n",
 		       acpi_data.dist_base);
 		goto out_dist_unmap;
 	}
Signature · 1 line
1.9.1