olpc_dcon: Fix style issues
v2 cover olpc_dcon: Fix style issues
From: Zebulon McCorkle <[email protected]>
checkpatch.pl was complaining about style issues in the olpc_dcon driver.
I've split this into two patches at the request of Greg Kroah-Hartman's patch-bot.
Zebulon McCorkle (2):
olpc_dcon: Change bitshifts to BIT macro
olpc_dcon: Line up parentheses in func calls and defs
drivers/staging/olpc_dcon/olpc_dcon.c | 30 ++++++++++++++++++++---------- drivers/staging/olpc_dcon/olpc_dcon.h | 30 +++++++++++++++--------------- drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 2 +- 3 files changed, 36 insertions(+), 26 deletions(-)
Signature · 1 line
2.11.0
PATCH v2 1/2 olpc_dcon: Change bitshifts to BIT macro
From: Zebulon McCorkle <[email protected]>
checkpatch.pl reported the bitshifts (1<<x) as a style violation, so change them to the BIT macro (BIT(x)).
--- drivers/staging/olpc_dcon/olpc_dcon.h | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-)
drivers/staging/olpc_dcon/olpc_dcon.h +15 -15
@@ -10,18 +10,18 @@#define DCON_REG_ID 0#define DCON_REG_MODE 1 -#define MODE_PASSTHRU (1<<0) -#define MODE_SLEEP (1<<1) -#define MODE_SLEEP_AUTO (1<<2) -#define MODE_BL_ENABLE (1<<3) -#define MODE_BLANK (1<<4) -#define MODE_CSWIZZLE (1<<5) -#define MODE_COL_AA (1<<6) -#define MODE_MONO_LUMA (1<<7) -#define MODE_SCAN_INT (1<<8) -#define MODE_CLOCKDIV (1<<9) -#define MODE_DEBUG (1<<14) -#define MODE_SELFTEST (1<<15) +#define MODE_PASSTHRU BIT(0) +#define MODE_SLEEP BIT(1) +#define MODE_SLEEP_AUTO BIT(2) +#define MODE_BL_ENABLE BIT(3) +#define MODE_BLANK BIT(4) +#define MODE_CSWIZZLE BIT(5) +#define MODE_COL_AA BIT(6) +#define MODE_MONO_LUMA BIT(7) +#define MODE_SCAN_INT BIT(8) +#define MODE_CLOCKDIV BIT(9) +#define MODE_DEBUG BIT(14) +#define MODE_SELFTEST BIT(15)#define DCON_REG_HRES 0x2#define DCON_REG_HTOTAL 0x3
@@ -36,11 +36,11 @@#define DCON_REG_MEM_OPT_B 0x42/* Load Delay Locked Loop (DLL) settings for clock delay */ -#define MEM_DLL_CLOCK_DELAY (1<<0) +#define MEM_DLL_CLOCK_DELAY BIT(0)/* Memory controller power down function */ -#define MEM_POWER_DOWN (1<<8) +#define MEM_POWER_DOWN BIT(8)/* Memory controller software reset */ -#define MEM_SOFT_RESET (1<<0) +#define MEM_SOFT_RESET BIT(0)/* Status values */
Signature · 1 line
2.11.0
PATCH v2 2/2 olpc_dcon: Line up parentheses in func calls and defs
In reply to [email protected]From: Zebulon McCorkle <[email protected]>
Line up arguments to opening parentheses and ensure lines stay under 80 columns, since checkpatch.pl was complaining about incorrect indentation in function calls and definitions.
--- drivers/staging/olpc_dcon/olpc_dcon.c | 30 ++++++++++++++++++++---------- drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 2 +- 2 files changed, 21 insertions(+), 11 deletions(-)
drivers/staging/olpc_dcon/olpc_dcon.c +20 -10
@@ -393,7 +393,8 @@ static void dcon_set_source_sync(struct dcon_priv *dcon, int arg) }static ssize_t dcon_mode_show (struct device *dev, -struct device_attribute *attr,char *buf) +struct device_attribute *attr, +char *buf) {struct dcon_priv *dcon =dev_get_drvdata (dev);
@@ -401,7 +402,8 @@ static ssize_t dcon_mode_show(struct device *dev, }static ssize_t dcon_sleep_show (struct device *dev, -struct device_attribute *attr,char *buf) +struct device_attribute *attr, +char *buf) {struct dcon_priv *dcon =dev_get_drvdata (dev);
@@ -409,7 +411,8 @@ static ssize_t dcon_sleep_show(struct device *dev, }static ssize_t dcon_freeze_show (struct device *dev, -struct device_attribute *attr,char *buf) +struct device_attribute *attr, +char *buf) {struct dcon_priv *dcon =dev_get_drvdata (dev);
@@ -417,7 +420,8 @@ static ssize_t dcon_freeze_show(struct device *dev, }static ssize_t dcon_mono_show (struct device *dev, -struct device_attribute *attr,char *buf) +struct device_attribute *attr, +char *buf) {struct dcon_priv *dcon =dev_get_drvdata (dev);
@@ -425,13 +429,15 @@ static ssize_t dcon_mono_show(struct device *dev, }static ssize_t dcon_resumeline_show (struct device *dev, -struct device_attribute *attr,char *buf) +struct device_attribute *attr, +char *buf) {return sprintf (buf,"%d\n" , resumeline); }static ssize_t dcon_mono_store (struct device *dev, -struct device_attribute *attr,const char *buf,size_t count) +struct device_attribute *attr, +const char *buf,size_t count) {unsigned long enable_mono;int rc;
@@ -446,7 +452,8 @@ static ssize_t dcon_mono_store(struct device *dev, }static ssize_t dcon_freeze_store (struct device *dev, -struct device_attribute *attr,const char *buf,size_t count) +struct device_attribute *attr, +const char *buf,size_t count) {struct dcon_priv *dcon =dev_get_drvdata (dev);unsigned long output;
@@ -474,7 +481,8 @@ static ssize_t dcon_freeze_store(struct device *dev, }static ssize_t dcon_resumeline_store (struct device *dev, -struct device_attribute *attr,const char *buf,size_t count) +struct device_attribute *attr, +const char *buf,size_t count) {unsigned short rl;int rc;
@@ -490,7 +498,8 @@ static ssize_t dcon_resumeline_store(struct device *dev, }static ssize_t dcon_sleep_store (struct device *dev, -struct device_attribute *attr,const char *buf,size_t count) +struct device_attribute *attr, +const char *buf,size_t count) {unsigned long output;int ret;
@@ -641,7 +650,8 @@ static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id)/* Add the backlight device for the DCON */ dcon_bl_props.brightness = dcon->bl_val; dcon->bl_dev =backlight_device_register ("dcon-bl" , &dcon_device->dev, - dcon, &dcon_bl_ops, &dcon_bl_props); + dcon, &dcon_bl_ops, + &dcon_bl_props);if (IS_ERR (dcon->bl_dev)) {dev_err (&client->dev,"cannot register backlight dev (%ld)\n" ,PTR_ERR (dcon->bl_dev));
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c +1 -1
@@ -69,7 +69,7 @@ static int dcon_init_xo_1(struct dcon_priv *dcon)gpio_direction_input (OLPC_GPIO_DCON_IRQ );gpio_direction_input (OLPC_GPIO_DCON_BLANK );gpio_direction_output (OLPC_GPIO_DCON_LOAD , - dcon->curr_src ==DCON_SOURCE_CPU ); + dcon->curr_src ==DCON_SOURCE_CPU );/* Set up the interrupt mappings */
Signature · 1 line
2.11.0