Skip to contentSkip to conversation

package/asterisk: fix parallel build/install

PATCH New Yann E. MORIN 2 participants 4 messages Nov 27, 2017

lore
Share & tools
lore
#0 lore raw

cover package/asterisk: fix parallel build/install

Hello All!

This series adds a patch to asterisk to fix an autobuild issue in highly-parallel install.

It also adds me to DEVELOPPERS for the recent packages I've introduced to support asterisk.

Regards,
Yann E. MORIN.

The following changes since commit c8f0a823efdb3f195c475194dc7b3341502819c0

linux-headers: bump 3.2.x series (2017-11-27 09:25:46 +0100)

are available in the git repository at:

git://git.buildroot.org/~ymorin/git/buildroot.git

for you to fetch changes up to 77a465b5afe27dd09b5b3ec5a4e9069b24f00a5e

package/asterisk: fix parallel build/install (2017-11-27 13:09:42 +0100)

----------------------------------------------------------------
Yann E. MORIN (2):
DEVELOPERS: adopt the packages I recently added package/asterisk: fix parallel build/install

 DEVELOPERS                                         |  5 ++++
 ...nsure-target-directory-for-modules-exists.patch | 32 ++++++++++++++++++++++
 2 files changed, 37 insertions(+)
 create mode 100644 package/asterisk/0005-build-ensure-target-directory-for-modules-exists.patch
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#1 lore raw

PATCH 1/2 DEVELOPERS: adopt the packages I recently added

---
 DEVELOPERS | 5 +++++
 1 file changed, 5 insertions(+)
DEVELOPERS +5 -0
index 7621f969a0..20fe70253d 100644
@@ -1743,8 +1743,11 @@ F:	package/fwup/
 
 N:	Yann E. MORIN <[email protected]>
 F:	fs/squashfs/
+F:	package/asterisk/
 F:	package/cegui06/
 F:	package/celt051/
+F:	package/dahdi-linux/
+F:	package/dahdi-tools/
 F:	package/dtc/
 F:	package/dtv-scan-tables/
 F:	package/dvb-apps/
@@ -1755,7 +1758,9 @@ F:	package/libedit/
 F:	package/libgsm/
 F:	package/libinput/
 F:	package/libiscsi/
+F:	package/libpri/
 F:	package/libseccomp/
+F:	package/libss7/
 F:	package/linux-tools/
 F:	package/mesa3d-headers/
 F:	package/nbd/
Signature · 1 line
2.11.0
#2 lore raw

PATCH 2/2 package/asterisk: fix parallel build/install

In reply to Yann E. MORIN

Fixes:

    http://autobuild.buildroot.org/results/7c9892b9425aff6e54b8c8942dbdcb0b26e58572
---
 ...nsure-target-directory-for-modules-exists.patch | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 package/asterisk/0005-build-ensure-target-directory-for-modules-exists.patch
package/asterisk/0005-build-ensure-target-directory-for-modules-exists.patch new file +32 -0
new file mode 100644
index 0000000000..92ff296a38
@@ -0,0 +1,32 @@
+From 933b2554a40f932571bdbdbb5217cda3e35fd61f Mon Sep 17 00:00:00 2001
+From: "Yann E. MORIN" <[email protected]>
+Date: Mon, 27 Nov 2017 12:52:52 +0100
+Subject: [PATCH] build: ensure target directory for modules exists
+
+Currently, in highly-parallel builds, it is possible that installing
+modules fails because the target direcotry does not exist yet.
+
+We fix that by instructing $(INSTALL) to create the destination directory
+first.
+
+Signed-off-by: "Yann E. MORIN" <[email protected]>
+---
+ Makefile.moddir_rules | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.moddir_rules b/Makefile.moddir_rules
+index 59190bece9..b73153a9a5 100644
+--- a/Makefile.moddir_rules
++++ b/Makefile.moddir_rules
+@@ -110,7 +110,7 @@ clean::
+ 
+ install:: all
+ 	@echo "Installing modules from `basename $(CURDIR)`..."
+-	@for x in $(LOADABLE_MODS:%=%.so); do $(INSTALL) -m 755 $$x "$(DESTDIR)$(ASTMODDIR)" ; done
++	@for x in $(LOADABLE_MODS:%=%.so); do $(INSTALL) -D -m 755 $$x "$(DESTDIR)$(ASTMODDIR)" ; done
+ ifneq ($(findstring :,$(XMLSTARLET)$(BASH)),:)
+ 	@if [ -f .moduleinfo ] ; then \
+ 		declare -A DISABLED_MODS ;\
+-- 
+2.11.0
+
Signature · 1 line
2.11.0
#3 lore raw

cover package/asterisk: fix parallel build/install

In reply to Yann E. MORIN

Hello,

Quoted 3 lines · Yann E. MORIN

Yann E. MORIN (2):
DEVELOPERS: adopt the packages I recently added package/asterisk: fix parallel build/install

Both applied to master. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com