Skip to contentSkip to conversation

systemd: fix PACKAGECONFIG for lz4

PATCH In review Robert Yang 3 participants 5 messages Dec 21, 2017 – Dec 22, 2017

lore
Share & tools
lore

Robert Yang

author
#0 lore raw

cover systemd: fix PACKAGECONFIG for lz4

The following changes since commit 978472c58629d1448399207873bbead96b27102e:

image.bbclass: Add additional bb.debug to help track 12304 (2017-12-18 18:02:12 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/systemd_lz4
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/systemd_lz4

Robert Yang (1):
systemd: fix PACKAGECONFIG for lz4

 meta/recipes-core/systemd/systemd_234.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/1 systemd: fix PACKAGECONFIG for lz4

Fixed:
MACHINE = "qemux86-64" PACKAGECONFIG_append_pn-systemd = "lz4" DISTRO_FEATURES_append = " systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit" VIRTUAL-RUNTIME_init_manager = "systemd" VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"

$ bitbake core-image-minimal
$ runqemu tmp/deploy/images/qemux86-64/ nographic
/sbin/init: error while loading shared libraries: liblz4.so.1: cannot open shared object file: No such file or directory

Add lz4 to RDEPENDS to fix the problem.

Signed-off-by Robert Yang <[email protected]>
---
 meta/recipes-core/systemd/systemd_234.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/systemd/systemd_234.bb +1 -1
index 778b868..ed82c33 100644
@@ -122,7 +122,7 @@ PACKAGECONFIG[ldconfig] = "--enable-ldconfig,--disable-ldconfig"
 PACKAGECONFIG[libidn] = "--enable-libidn,--disable-libidn,libidn"
 PACKAGECONFIG[localed] = "--enable-localed,--disable-localed"
 PACKAGECONFIG[logind] = "--enable-logind,--disable-logind"
-PACKAGECONFIG[lz4] = "--enable-lz4,--disable-lz4,lz4"
+PACKAGECONFIG[lz4] = "--enable-lz4,--disable-lz4,lz4,lz4"
 PACKAGECONFIG[machined] = "--enable-machined,--disable-machined"
 PACKAGECONFIG[manpages] = "--enable-manpages,--disable-manpages,libxslt-native xmlto-native docbook-xml-dtd4-native docbook-xsl-stylesheets-native"
 PACKAGECONFIG[microhttpd] = "--enable-microhttpd,--disable-microhttpd,libmicrohttpd"
Signature · 1 line
2.7.4
#2 lore raw

The problem seems to be that the lz4 packaging problem. lz4-ptest is packages as liblz4 and is installed instead of the lz4 package.

Best Regards,
Chen Qi

Quoted 32 lines · Robert Yang

Fixed:
MACHINE = "qemux86-64" PACKAGECONFIG_append_pn-systemd = "lz4" DISTRO_FEATURES_append = " systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit" VIRTUAL-RUNTIME_init_manager = "systemd" VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"

$ bitbake core-image-minimal
$ runqemu tmp/deploy/images/qemux86-64/ nographic
/sbin/init: error while loading shared libraries: liblz4.so.1: cannot open shared object file: No such file or directory

Add lz4 to RDEPENDS to fix the problem.

Signed-off-by Robert Yang <[email protected]>
---
  meta/recipes-core/systemd/systemd_234.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/systemd/systemd_234.bb +1 -1
index 778b868..ed82c33 100644
@@ -122,7 +122,7 @@ PACKAGECONFIG[ldconfig] = "--enable-ldconfig,--disable-ldconfig"
  PACKAGECONFIG[libidn] = "--enable-libidn,--disable-libidn,libidn"
  PACKAGECONFIG[localed] = "--enable-localed,--disable-localed"
  PACKAGECONFIG[logind] = "--enable-logind,--disable-logind"
-PACKAGECONFIG[lz4] = "--enable-lz4,--disable-lz4,lz4"
+PACKAGECONFIG[lz4] = "--enable-lz4,--disable-lz4,lz4,lz4"
  PACKAGECONFIG[machined] = "--enable-machined,--disable-machined"
  PACKAGECONFIG[manpages] = "--enable-manpages,--disable-manpages,libxslt-native xmlto-native docbook-xml-dtd4-native docbook-xsl-stylesheets-native"
  PACKAGECONFIG[microhttpd] = "--enable-microhttpd,--disable-microhttpd,libmicrohttpd"
#3 lore raw
Quoted 4 lines · ChenQi

The problem seems to be that the lz4 packaging problem. lz4-ptest is packages as liblz4 and is installed instead of the lz4 package.

So that's because lz4-ptest ships a copy of the build tree (so has a liblz5.so.*) and is before lz4 in PACKAGES.

I've got a patch here to remove the ptest bits from lz4 as shipping an entire build tree isn't a good idea, and will look at fixing debian.bbclass so it doesn't consider libraries outside of $libdir et al.

Ross

author
#4 lore raw

Hi Ross,

Quoted 9 lines · Ross

On 21 December 2017 at 05:55, ChenQi <[email protected] <mailto:[email protected]>> wrote:

The problem seems to be that the lz4 packaging problem. lz4-ptest is packages as liblz4 and is installed instead of the lz4 package.

So that's because lz4-ptest ships a copy of the build tree (so has a liblz5.so.*) and is before lz4 in PACKAGES.

I've got a patch here to remove the ptest bits from lz4 as shipping an entire build tree isn't a good idea, and will look at fixing debian.bbclass so it doesn't consider libraries outside of $libdir et al.

Thank you very much.

// Robert

Quoted 2 lines

Ross