arm: Fix zynq DTS file with mainline Linux kernel

PATCH New Michal Simek 1 participant 7 messages Mar 28, 2018

Subsystems (2)

Arm (32-bit) Arm/Zynq architecture

lore

Share & tools

lore

Michal Simek

author

2018-03-28 14:22 UTC #0 lore raw

cover arm: Fix zynq DTS file with mainline Linux kernel

Hi,

with reviewing new Xilinx platforms for Linux kernel some issues were found which should be fixed.
Also Kernel adopted SPDX that's why position has changed. Based on my talk with Tom it is not a problem to adopt Linux kernel style and keep these dts in sync.

Thanks,
Michal

Javier Martinez Canillas (1):
ARM: dts: zynq: Add generic compatible string for I2C EEPROM

Michal Simek (5):
arm: zynq: Remove 0x prefixes from cc108
arm: zynq: Sync up licenses with mainline kernel
arm: zynq: Use i2c-mux instead of i2cswitch for pca9548
arm: zynq: Fix eeprom dt nodes
arm: zynq: Use fixed partitions for spi flash for zc770 xm010

 arch/arm/dts/zynq-cc108.dts       | 15 +++++++--------
 arch/arm/dts/zynq-zc702.dts       |  9 +++------
 arch/arm/dts/zynq-zc706.dts       |  9 +++------
 arch/arm/dts/zynq-zc770-xm010.dts | 24 +++++++++++++-----------
 arch/arm/dts/zynq-zc770-xm011.dts |  9 ++++-----
 arch/arm/dts/zynq-zc770-xm012.dts | 13 ++++++-------
 arch/arm/dts/zynq-zc770-xm013.dts |  5 ++---
 arch/arm/dts/zynq-zed.dts         |  5 +----
 arch/arm/dts/zynq-zybo.dts        |  5 +----
 9 files changed, 40 insertions(+), 54 deletions(-)

Signature · 1 line

1.9.1

Michal Simek

author

2018-03-28 14:22 UTC #1 lore raw

PATCH 1/6 arm: zynq: Remove 0x prefixes from cc108

The patch fixing issues reported by DTC:
zynq-cc108.dtb: Warning (unit_address_format): Node
/amba/spi at e000d000/flash at 0/partition at 0x400000 unit name should not have leading "0x"
zynq-cc108.dtb: Warning (unit_address_format): Node
/amba/spi at e000d000/flash at 0/partition at 0x800000 unit name should not have leading "0x"
zynq-cc108.dtb: Warning (unit_address_format): Node
/amba/spi at e000d000/flash at 0/partition at 0xc00000 unit name should not have leading "0x"
zynq-cc108.dtb: Warning (unit_address_format): Node
/amba/spi at e000d000/flash at 0/partition at 0xd00000 unit name should not have leading "0x"
zynq-cc108.dtb: Warning (unit_address_format): Node
/amba/spi at e000d000/flash at 0/partition at 0xf00000 unit name should not have leading "0x"

Signed-off-by Michal Simek <[email protected]>

---

 arch/arm/dts/zynq-cc108.dts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

arch/arm/dts/zynq-cc108.dts +5 -5

index 4804da5235dd..b9cc000a33e9 100644
@@ -70,23 +70,23 @@
 			label = "qspi-fsbl-uboot-bs";
 			reg = <0x0 0x400000>; /* 4MB */
 		};
-		partition at 0x400000 {
+		partition at 400000 {
 			label = "qspi-linux";
 			reg = <0x400000 0x400000>; /* 4MB */
 		};
-		partition at 0x800000 {
+		partition at 800000 {
 			label = "qspi-rootfs";
 			reg = <0x800000 0x400000>; /* 4MB */
 		};
-		partition at 0xc00000 {
+		partition at c00000 {
 			label = "qspi-devicetree";
 			reg = <0xc00000 0x100000>; /* 1MB */
 		};
-		partition at 0xd00000 {
+		partition at d00000 {
 			label = "qspi-scratch";
 			reg = <0xd00000 0x200000>; /* 2MB */
 		};
-		partition at 0xf00000 {
+		partition at f00000 {
 			label = "qspi-uboot-env";
 			reg = <0xf00000 0x100000>; /* 1MB */
 		};

Signature · 1 line

1.9.1

Michal Simek

author

2018-03-28 14:22 UTC #2 lore raw

PATCH 2/6 arm: zynq: Sync up licenses with mainline kernel

In reply to Michal Simek

Use different location for SPDX line. Also update dates for new mainline DTS files.

Signed-off-by Michal Simek <[email protected]>

---

 arch/arm/dts/zynq-cc108.dts       | 5 ++---
 arch/arm/dts/zynq-zc702.dts       | 5 +----
 arch/arm/dts/zynq-zc706.dts       | 5 +----
 arch/arm/dts/zynq-zc770-xm010.dts | 5 ++---
 arch/arm/dts/zynq-zc770-xm011.dts | 5 ++---
 arch/arm/dts/zynq-zc770-xm012.dts | 5 ++---
 arch/arm/dts/zynq-zc770-xm013.dts | 3 +--
 arch/arm/dts/zynq-zed.dts         | 5 +----
 arch/arm/dts/zynq-zybo.dts        | 5 +----
 9 files changed, 13 insertions(+), 30 deletions(-)

arch/arm/dts/zynq-cc108.dts +2 -3

index b9cc000a33e9..5f8a0d255529 100644
@@ -1,13 +1,12 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Xilinx CC108 board DTS
  *
- * (C) Copyright 2007-2013 Xilinx, Inc.
+ * (C) Copyright 2007-2018 Xilinx, Inc.
  * (C) Copyright 2007-2013 Michal Simek
  * (C) Copyright 2007-2012 PetaLogix Qld Pty Ltd
  *
  * Michal SIMEK <[email protected]>
- *
- * SPDX-License-Identifier:	GPL-2.0+
  */
 /dts-v1/;
 /include/ "zynq-7000.dtsi"

arch/arm/dts/zynq-zc702.dts +1 -4

index da698a19ccd1..b95c1608d220 100644
@@ -1,10 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
- * Xilinx ZC702 board DTS
- *
  *  Copyright (C) 2011 - 2015 Xilinx
  *  Copyright (C) 2012 National Instruments Corp.
- *
- * SPDX-License-Identifier:	GPL-2.0+
  */
 /dts-v1/;
 #include "zynq-7000.dtsi"

arch/arm/dts/zynq-zc706.dts +1 -4

index a88a83c16650..dbb57445ca7c 100644
@@ -1,10 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
- * Xilinx ZC706 board DTS
- *
  *  Copyright (C) 2011 - 2015 Xilinx
  *  Copyright (C) 2012 National Instruments Corp.
- *
- * SPDX-License-Identifier:	GPL-2.0+
  */
 /dts-v1/;
 #include "zynq-7000.dtsi"

arch/arm/dts/zynq-zc770-xm010.dts +2 -3

index cc5ba98d6bd9..0c364dfcc14f 100644
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Xilinx ZC770 XM010 board DTS
  *
- * Copyright (C) 2013 - 2015 Xilinx, Inc.
- *
- * SPDX-License-Identifier:	GPL-2.0+
+ * Copyright (C) 2013-2018 Xilinx, Inc.
  */
 /dts-v1/;
 #include "zynq-7000.dtsi"

arch/arm/dts/zynq-zc770-xm011.dts +2 -3

index 7f08961491a6..f711675dd88e 100644
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Xilinx ZC770 XM013 board DTS
  *
- * Copyright (C) 2013 Xilinx, Inc.
- *
- * SPDX-License-Identifier:	GPL-2.0+
+ * Copyright (C) 2013-2018 Xilinx, Inc.
  */
 /dts-v1/;
 #include "zynq-7000.dtsi"

arch/arm/dts/zynq-zc770-xm012.dts +2 -3

index 699cd2c0fb1c..ee6809d51bcf 100644
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Xilinx ZC770 XM012 board DTS
  *
- * Copyright (C) 2013 - 2015 Xilinx, Inc.
- *
- * SPDX-License-Identifier:	GPL-2.0+
+ * Copyright (C) 2013-2018 Xilinx, Inc.
  */
 /dts-v1/;
 #include "zynq-7000.dtsi"

arch/arm/dts/zynq-zc770-xm013.dts +1 -2

index 81a6aa562a94..88a7ef068219 100644
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Xilinx ZC770 XM013 board DTS
  *
  * Copyright (C) 2013 Xilinx, Inc.
- *
- * SPDX-License-Identifier:	GPL-2.0+
  */
 /dts-v1/;
 #include "zynq-7000.dtsi"

arch/arm/dts/zynq-zed.dts +1 -4

index a9ff0e6fa814..24eccf1633d8 100644
@@ -1,10 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
- * Xilinx ZED board DTS
- *
  *  Copyright (C) 2011 - 2015 Xilinx
  *  Copyright (C) 2012 National Instruments Corp.
- *
- * SPDX-License-Identifier:	GPL-2.0+
  */
 /dts-v1/;
 #include "zynq-7000.dtsi"

arch/arm/dts/zynq-zybo.dts +1 -4

index 52ec5a45667a..38448223055c 100644
@@ -1,10 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
- * Digilent ZYBO board DTS
- *
  *  Copyright (C) 2011 - 2015 Xilinx
  *  Copyright (C) 2012 National Instruments Corp.
- *
- * SPDX-License-Identifier:	GPL-2.0+
  */
 /dts-v1/;
 #include "zynq-7000.dtsi"

Signature · 1 line

1.9.1

Michal Simek

author

2018-03-28 14:23 UTC #3 lore raw

PATCH 3/6 arm: zynq: Use i2c-mux instead of i2cswitch for pca9548

In reply to Michal Simek

i2c muxes should described like this.

Signed-off-by Michal Simek <[email protected]>

---

 arch/arm/dts/zynq-zc702.dts | 2 +-
 arch/arm/dts/zynq-zc706.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/dts/zynq-zc702.dts +1 -1

index b95c1608d220..1410c4d7b6bd 100644
@@ -111,7 +111,7 @@
 	scl-gpios = <&gpio0 50 0>;
 	sda-gpios = <&gpio0 51 0>;
 
-	i2cswitch at 74 {
+	i2c-mux at 74 {
 		compatible = "nxp,pca9548";
 		#address-cells = <1>;
 		#size-cells = <0>;

arch/arm/dts/zynq-zc706.dts +1 -1

index dbb57445ca7c..c782064a8036 100644
@@ -62,7 +62,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_i2c0_default>;
 
-	i2cswitch at 74 {
+	i2c-mux at 74 {
 		compatible = "nxp,pca9548";
 		#address-cells = <1>;
 		#size-cells = <0>;

Signature · 1 line

1.9.1

Michal Simek

author

2018-03-28 14:23 UTC #4 lore raw

PATCH 4/6 ARM: dts: zynq: Add generic compatible string for I2C EEPROM

In reply to Michal Simek

From: Javier Martinez Canillas <[email protected]>

The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries.

But when matching using an OF table, both the vendor and device has to be taken into account so the driver defines only a set of compatible strings using the "atmel" vendor as a generic fallback for compatible I2C devices.

So add this generic fallback to the device node compatible string to make the device to match the driver using the OF device ID table.

Signed-off-by Javier Martinez Canillas <[email protected]>

Signed-off-by Michal Simek <[email protected]>

---

 arch/arm/dts/zynq-zc702.dts | 2 +-
 arch/arm/dts/zynq-zc706.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/dts/zynq-zc702.dts +1 -1

index 1410c4d7b6bd..bb224662bb77 100644
@@ -151,7 +151,7 @@
 			#size-cells = <0>;
 			reg = <2>;
 			eeprom at 54 {
-				compatible = "at,24c08";
+				compatible = "atmel,24c08";
 				reg = <0x54>;
 			};
 		};

arch/arm/dts/zynq-zc706.dts +1 -1

index c782064a8036..f24364b3853a 100644
@@ -102,7 +102,7 @@
 			#size-cells = <0>;
 			reg = <2>;
 			eeprom at 54 {
-				compatible = "at,24c08";
+				compatible = "atmel,24c08";
 				reg = <0x54>;
 			};
 		};

Signature · 1 line

1.9.1

Michal Simek

author

2018-03-28 14:23 UTC #5 lore raw

PATCH 5/6 arm: zynq: Fix eeprom dt nodes

In reply to Michal Simek

- Use eeprom for node name
- Use atmel compatible string instead of at.
- Add missing labels

Signed-off-by Michal Simek <[email protected]>

---

 arch/arm/dts/zynq-zc770-xm010.dts | 4 ++--
 arch/arm/dts/zynq-zc770-xm011.dts | 4 ++--
 arch/arm/dts/zynq-zc770-xm012.dts | 8 ++++----
 arch/arm/dts/zynq-zc770-xm013.dts | 2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

arch/arm/dts/zynq-zc770-xm010.dts +2 -2

index 0c364dfcc14f..2c594b7ecc6c 100644
@@ -54,8 +54,8 @@
 	status = "okay";
 	clock-frequency = <400000>;
 
-	m24c02_eeprom at 52 {
-		compatible = "at,24c02";
+	eeprom: eeprom at 52 {
+		compatible = "atmel,24c02";
 		reg = <0x52>;
 	};

arch/arm/dts/zynq-zc770-xm011.dts +2 -2

index f711675dd88e..3fe6eb559ea7 100644
@@ -41,8 +41,8 @@
 	status = "okay";
 	clock-frequency = <400000>;
 
-	m24c02_eeprom at 52 {
-		compatible = "at,24c02";
+	eeprom: eeprom at 52 {
+		compatible = "atmel,24c02";
 		reg = <0x52>;
 	};
 };

arch/arm/dts/zynq-zc770-xm012.dts +4 -4

index ee6809d51bcf..19d5b275ae06 100644
@@ -37,8 +37,8 @@
 	status = "okay";
 	clock-frequency = <400000>;
 
-	m24c02_eeprom at 52 {
-		compatible = "at,24c02";
+	eeprom0: eeprom at 52 {
+		compatible = "atmel,24c02";
 		reg = <0x52>;
 	};
 };

@@ -47,8 +47,8 @@
 	status = "okay";
 	clock-frequency = <400000>;
 
-	m24c02_eeprom at 52 {
-		compatible = "at,24c02";
+	eeprom1: eeprom at 52 {
+		compatible = "atmel,24c02";
 		reg = <0x52>;
 	};
 };

arch/arm/dts/zynq-zc770-xm013.dts +1 -1

index 88a7ef068219..efd0833eab91 100644
@@ -67,7 +67,7 @@
 	status = "okay";
 	num-cs = <4>;
 	is-decoded-cs = <0>;
-	eeprom: at25 at 0 {
+	eeprom: eeprom at 0 {
 		at25,byte-len = <8192>;
 		at25,addr-mode = <2>;
 		at25,page-size = <32>;

Signature · 1 line

1.9.1

Michal Simek

author

2018-03-28 14:23 UTC #6 lore raw

PATCH 6/6 arm: zynq: Use fixed partitions for spi flash for zc770 xm010

In reply to Michal Simek

Sync with mainline.

Signed-off-by Michal Simek <[email protected]>

---

 arch/arm/dts/zynq-zc770-xm010.dts | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

arch/arm/dts/zynq-zc770-xm010.dts +9 -6

index 2c594b7ecc6c..a779672f3add 100644
@@ -74,14 +74,17 @@
 	num-cs = <4>;
 	is-decoded-cs = <0>;
 	flash at 0 {
-		compatible = "sst25wf080";
+		compatible = "sst25wf080", "jedec,spi-nor";
 		reg = <1>;
 		spi-max-frequency = <1000000>;
-		#address-cells = <1>;
-		#size-cells = <1>;
-		partition at test {
-			label = "spi-flash";
-			reg = <0x0 0x100000>;
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			partition at 0 {
+				label = "data";
+				reg = <0x0 0x100000>;
+			};
 		};
 	};
 };

Signature · 1 line

1.9.1