Add Designated Reviewer (R:) to MAINTAINERS (plus a test case)

cover

 MAINTAINERS               |  4 ++++
 scripts/get_maintainer.pl | 24 +++++++++++-------------
 2 files changed, 15 insertions(+), 13 deletions(-)
2.13.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
index bbda4b9f43..e539fac71f 100644
@@ -142,12 +142,14 @@ F:	tools/libacpi/
 
 AMD IOMMU
 M:	Suravee Suthikulpanit <[email protected]>
+R:	Brian Woods <[email protected]>
 S:	Maintained
 F:	xen/drivers/passthrough/amd/
 
 AMD SVM
 M:	Boris Ostrovsky <[email protected]>
 M:	Suravee Suthikulpanit <[email protected]>
+R:	Brian Woods <[email protected]>
 S:	Supported
 F:	xen/arch/x86/hvm/svm/
 F:	xen/arch/x86/cpu/vpmu_amd.c

2.13.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
---
 MAINTAINERS               |  2 ++
 scripts/get_maintainer.pl | 24 +++++++++++-------------
 2 files changed, 13 insertions(+), 13 deletions(-)
index e539fac71f..fab76b0af4 100644
@@ -60,6 +60,8 @@ appropriate branch.
 Descriptions of section entries:
 
 	M: Mail patches to: FullName <address@domain>
+	R: Designated reviewer: FullName <address@domain>
+	   These reviewers should be CCed on patches.
 	L: Mailing list that is relevant to this area
 	W: Web-page with status/info
 	T: SCM tree type and location.  Type is one of: git, hg, quilt, stgit.

index 3fb1ad4b69..d528da738c 100755
@@ -21,6 +21,7 @@ my $xen_path = "./";
 my $email = 1;
 my $email_usename = 1;
 my $email_maintainer = 1;
+my $email_reviewer = 1;
 my $email_list = 1;
 my $email_subscriber_list = 0;
 my $email_git_penguin_chiefs = 0;

@@ -199,6 +200,7 @@ if (!GetOptions(
 		'mailmap!' => \$email_use_mailmap,
 		'drop_the_rest_supporter!' => \$email_drop_the_rest_supporter_if_supporter_found,
 		'm!' => \$email_maintainer,
+		'r!' => \$email_reviewer,
 		'n!' => \$email_usename,
 		'l!' => \$email_list,
 		's!' => \$email_subscriber_list,

@@ -257,7 +259,8 @@ if ($sections) {
 }
 
 if ($email &&
-    ($email_maintainer + $email_list + $email_subscriber_list +
+    ($email_maintainer + $email_reviewer +
+     $email_list + $email_subscriber_list +
      $email_git + $email_git_penguin_chiefs + $email_git_blame) == 0) {
     die "$P: Please select at least 1 email option\n";
 }

@@ -791,6 +794,7 @@ MAINTAINER field selection options:
     --hg-since => hg history to use (default: $email_hg_since)
     --interactive => display a menu (mostly useful if used with the --git option)
     --m => include maintainer(s) if any
+    --r => include reviewer(s) if any
     --n => include name 'Full Name <addr\@domain.tld>'
     --l => include list(s) if any
     --s => include subscriber only list(s) if any

@@ -817,7 +821,7 @@ Other options:
   --help => show this help information
 
 Default options:
-  [--email --nogit --git-fallback --m --n --l --multiline -pattern-depth=0
+  [--email --nogit --git-fallback --m --r --n --l --multiline -pattern-depth=0
    --remove-duplicates --rolestats]
 
 Notes:

@@ -1080,21 +1084,15 @@ sub add_categories {
 		}
 	    } elsif ($ptype eq "M") {
 		my ($name, $address) = parse_email($pvalue);
-		if ($name eq "") {
-		    if ($i > 0) {
-			my $tv = $typevalue[$i - 1];
-			if ($tv =~ m/^([A-Z]):\s*(.*)/) {
-			    if ($1 eq "P") {
-				$name = $2;
-				$pvalue = format_email($name, $address, $email_usename);
-			    }
-			}
-		    }
-		}
 		if ($email_maintainer) {
 		    my $role = get_maintainer_role($i);
 		    push_email_addresses($pvalue, $role);
 		}
+	    } elsif ($ptype eq "R") {
+		my ($name, $address) = parse_email($pvalue);
+		if ($email_reviewer) {
+		    push_email_addresses($pvalue, 'reviewer');
+		}
 	    } elsif ($ptype eq "T") {
 		push(@scm, $pvalue);
 	    } elsif ($ptype eq "W") {

2.13.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
  +        Reviewers should be CCed on patches.  However, they do not
  +        have a formal governance role, and are listed here
  +        simply because of their own request.
  +        Reviewers should be CCed on patches.  However, they do not
  +        have a formal governance role, and are listed here
  +        simply because of their own request.
  +        Reviewers should be CCed on patches.  However, they do not
  +        have a formal governance role, and are listed here
  +        simply because of their own request.

Add Designated Reviewer (R:) to MAINTAINERS (plus a test case)

Lars Kurth

Lars Kurth

Lars Kurth

Jan Beulich

Lars Kurth

Jan Beulich

Ian Jackson

Lars Kurth

Jan Beulich

Ian Jackson

Jan Beulich

George Dunlap

Lars Kurth

Ian Jackson

George Dunlap